zenstruck / foundry

src/FactoryCollection.php

<?php

namespace Zenstruck\Foundry;

/**
 * @template TObject of object
 *
 * @author Kevin Bond <kevinbond@gmail.com>
 */
final class FactoryCollection
{
    /** @var Factory<TObject> */
    private $factory;

    /** @var int */
    private $min;

    /** @var int */
    private $max;

    /**
     * @param int|null $max If set, when created, the collection will be a random size between $min and $max
     *
     * @psalm-param Factory<TObject> $factory
     */
    public function __construct(Factory $factory, int $min, ?int $max = null)
    {
        if ($max && $min > $max) {

The expression $max of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            throw new \InvalidArgumentException('Min must be less than max.');
        }

        $this->factory = $factory;
        $this->min = $min;
        $this->max = $max ?? $min;
    }

    /**
     * @param array|callable $attributes
     *
     * @return list<TObject&Proxy<TObject>>

The type Zenstruck\Foundry\list was not found. Maybe you did not declare it correctly or list all dependencies?

     *
     * @psalm-suppress InvalidReturnType
     * @psalm-return list<Proxy<TObject>>
     */
    public function create($attributes = []): array
    {
        return \array_map(

The expression return array_map(function(...) { /* ... */ }, $this->all()) returns the type array which is incompatible with the documented return type Zenstruck\Foundry\list.

            static function(Factory $factory) use ($attributes) {
                return $factory->create($attributes);
            },
            $this->all()
        );
    }

    /**
     * @return Factory[]
     *
     * @psalm-return list<Factory<TObject>>
     */
    public function all(): array
    {
        /** @psalm-suppress TooManyArguments */
        return \array_map(
            function() {
                return clone $this->factory;
            },
            \array_fill(0, \random_int($this->min, $this->max), null)
        );
    }

    public function factory(): Factory
    {
        return $this->factory;
    }
}