FactoryCollection::factory() - Code Metrics - zenstruck/foundry - Measure and Improve Code Quality continuously with Scrutinizer

FactoryCollection::factory() A
last analyzed 2022-04-03 12:21 UTC

↳ Parent: FactoryCollection

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
eloc	1
c	1
b	0
f	1
dl	0
loc	3
rs	10
ccs	2
cts	2
cp	1
cc	1
nc	1
nop	0
crap	1

<?php

namespace Zenstruck\Foundry;

/**
 * @template TObject of object
 *
 * @author Kevin Bond <[email protected]>
 */
final class FactoryCollection
{
    /** @var Factory<TObject> */
    private $factory;

    /** @var int */
    private $min;

    /** @var int */
    private $max;

    /**
     * @param int|null $max If set, when created, the collection will be a random size between $min and $max
     *
     * @psalm-param Factory<TObject> $factory
     */
    public function __construct(Factory $factory, int $min, ?int $max = null)
    {
        if ($max && $min > $max) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            throw new \InvalidArgumentException('Min must be less than max.');
        }

        $this->factory = $factory;
        $this->min = $min;
        $this->max = $max ?? $min;
    }

    /**
     * @param array|callable $attributes
     *
     * @return list<TObject&Proxy<TObject>>
filter:
    dependency_paths: ["lib/*"]
     *
     * @psalm-suppress InvalidReturnType
     * @psalm-return list<Proxy<TObject>>
     */
    public function create($attributes = []): array
    {
        return \array_map(

            static function(Factory $factory) use ($attributes) {
                return $factory->create($attributes);
            },
            $this->all()
        );
    }

    /**
     * @return Factory[]
     *
     * @psalm-return list<Factory<TObject>>
     */
    public function all(): array
    {
        /** @psalm-suppress TooManyArguments */
        return \array_map(
            function() {
                return clone $this->factory;
            },
            \array_fill(0, \random_int($this->min, $this->max), null)
        );
    }

    public function factory(): Factory
    {
        return $this->factory;
    }
}


1		<?php
2
3		namespace Zenstruck\Foundry;
4
5		/**
6		* @template TObject of object
7		*
8		* @author Kevin Bond <[email protected]>
9		*/
10		final class FactoryCollection
11		{
12		/** @var Factory<TObject> */
13		private $factory;
14
15		/** @var int */
16		private $min;
17
18		/** @var int */
19		private $max;
20
21		/**
22		* @param int\|null $max If set, when created, the collection will be a random size between $min and $max
23		*
24		* @psalm-param Factory<TObject> $factory
25		*/
26	270	public function __construct(Factory $factory, int $min, ?int $max = null)
27		{
28	270	if ($max && $min > $max) {
		0 ignored issues – show Bug Best Practice introduced 2020-09-28 20:02 UTC by Report Bug Copy Issue Report The expression `$max` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
29	10	throw new \InvalidArgumentException('Min must be less than max.');
30		}
31
32	260	$this->factory = $factory;
33	260	$this->min = $min;
34	260	$this->max = $max ?? $min;
35	260	}
36
37		/**
38		* @param array\|callable $attributes
39		*
40		* @return list<TObject&Proxy<TObject>>
		0 ignored issues – show Bug introduced 2021-08-20 21:12 UTC by Report Bug Copy Issue Report The type `Zenstruck\Foundry\list` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
41		*
42		* @psalm-suppress InvalidReturnType
43		* @psalm-return list<Proxy<TObject>>
44		*/
45	220	public function create($attributes = []): array
46		{
47	220	return \array_map(
		0 ignored issues – show Bug Best Practice introduced 2021-08-20 21:12 UTC by Report Bug Copy Issue Report The expression `return array_map(functio...... */ }, $this->all())` returns the type `array` which is incompatible with the documented return type `Zenstruck\Foundry\list`. Loading history...
48		static function(Factory $factory) use ($attributes) {
49	220	return $factory->create($attributes);
50	220	},
51	220	$this->all()
52		);
53		}
54
55		/**
56		* @return Factory[]
57		*
58		* @psalm-return list<Factory<TObject>>
59		*/
60	260	public function all(): array
61		{
62		/** @psalm-suppress TooManyArguments */
63	260	return \array_map(
64		function() {
65	260	return clone $this->factory;
66	260	},
67	260	\array_fill(0, \random_int($this->min, $this->max), null)
68		);
69		}
70
71	50	public function factory(): Factory
72		{
73	50	return $this->factory;
74		}
75		}
76

zenstruck / foundry

FactoryCollection::factory() A last analyzed 2022-04-03 12:21 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

FactoryCollection::factory() A
last analyzed 2022-04-03 12:21 UTC