Completed
Pull Request — master (#2802)
by lingfeng
02:31
created
src/Form/Builder.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
     /**
56 56
      * Returns builder is $mode.
57 57
      *
58
-     * @param $mode
58
+     * @param string $mode
59 59
      *
60 60
      * @return bool
61 61
      */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
      */
250 250
     public function field($name)
251 251
     {
252
-        return $this->fields()->first(function (Field $field) use ($name) {
252
+        return $this->fields()->first(function(Field $field) use ($name) {
253 253
             return $field->column() == $name;
254 254
         });
255 255
     }
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
             $this->form->model()->getUpdatedAtColumn(),
491 491
         ];
492 492
 
493
-        $this->fields = $this->fields()->reject(function (Field $field) use ($reservedColumns) {
493
+        $this->fields = $this->fields()->reject(function(Field $field) use ($reservedColumns) {
494 494
             return in_array($field->column(), $reservedColumns);
495 495
         });
496 496
     }
Please login to merge, or discard this patch.
src/Grid/Filter/Between.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 
55 55
         $this->value = array_get($inputs, $this->column);
56 56
 
57
-        $value = array_filter($this->value, function ($val) {
57
+        $value = array_filter($this->value, function($val) {
58 58
             return $val !== '';
59 59
         });
60 60
 
Please login to merge, or discard this patch.
src/Grid/Filter/AbstractFilter.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
 
159 159
         list($relation, $args[0]) = explode('.', $this->column);
160 160
 
161
-        return ['whereHas' => [$relation, function ($relation) use ($args) {
161
+        return ['whereHas' => [$relation, function($relation) use ($args) {
162 162
             call_user_func_array([$relation, $this->query], $args);
163 163
         }]];
164 164
     }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -331,7 +331,7 @@
 block discarded – undo
331 331
      *
332 332
      * @param Presenter $presenter
333 333
      *
334
-     * @return mixed
334
+     * @return Presenter
335 335
      */
336 336
     protected function setPresenter(Presenter $presenter)
337 337
     {
Please login to merge, or discard this patch.
src/Grid/Row.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
     public function style($style)
135 135
     {
136 136
         if (is_array($style)) {
137
-            $style = implode('', array_map(function ($key, $val) {
137
+            $style = implode('', array_map(function($key, $val) {
138 138
                 return "$key:$val";
139 139
             }, array_keys($style), array_values($style)));
140 140
         }
Please login to merge, or discard this patch.
src/Widgets/Box.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
             return $this->style([$styles]);
65 65
         }
66 66
 
67
-        $styles = array_map(function ($style) {
67
+        $styles = array_map(function($style) {
68 68
             return 'box-'.$style;
69 69
         }, $styles);
70 70
 
Please login to merge, or discard this patch.
src/Auth/Permission.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
      *
13 13
      * @param $permission
14 14
      *
15
-     * @return true
15
+     * @return boolean|null
16 16
      */
17 17
     public static function check($permission)
18 18
     {
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
      *
31 31
      * @param $roles
32 32
      *
33
-     * @return true
33
+     * @return boolean|null
34 34
      */
35 35
     public static function allow($roles)
36 36
     {
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
      *
49 49
      * @param $roles
50 50
      *
51
-     * @return true
51
+     * @return boolean|null
52 52
      */
53 53
     public static function deny($roles)
54 54
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
         }
23 23
 
24 24
         if (is_array($permission)) {
25
-            collect($permission)->each(function ($permission) {
25
+            collect($permission)->each(function($permission) {
26 26
                 call_user_func([Permission::class, 'check'], $permission);
27 27
             });
28 28
 
Please login to merge, or discard this patch.
src/Widgets/Form.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -117,7 +117,7 @@
 block discarded – undo
117 117
     /**
118 118
      * Add form attributes.
119 119
      *
120
-     * @param string|array $attr
120
+     * @param string $attr
121 121
      * @param string       $value
122 122
      *
123 123
      * @return $this
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -162,7 +162,7 @@
 block discarded – undo
162 162
      */
163 163
     public function setWidth($fieldWidth = 8, $labelWidth = 2)
164 164
     {
165
-        collect($this->fields)->each(function ($field) use ($fieldWidth, $labelWidth) {
165
+        collect($this->fields)->each(function($field) use ($fieldWidth, $labelWidth) {
166 166
             /* @var Field $field  */
167 167
             $field->setWidth($fieldWidth, $labelWidth);
168 168
         });
Please login to merge, or discard this patch.
src/Console/MakeCommand.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
     /**
26 26
      * Execute the console command.
27 27
      *
28
-     * @return void
28
+     * @return false|null
29 29
      */
30 30
     public function handle()
31 31
     {
Please login to merge, or discard this patch.
src/Controllers/PermissionController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@
 block discarded – undo
131 131
     /**
132 132
      * Get options of HTTP methods select field.
133 133
      *
134
-     * @return array
134
+     * @return callable
135 135
      */
136 136
     protected function getHttpMethodsOptions()
137 137
     {
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -86,8 +86,8 @@  discard block
 block discarded – undo
86 86
         $grid->slug(trans('admin.slug'));
87 87
         $grid->name(trans('admin.name'));
88 88
 
89
-        $grid->http_path(trans('admin.route'))->display(function ($path) {
90
-            return collect(explode("\r\n", $path))->map(function ($path) {
89
+        $grid->http_path(trans('admin.route'))->display(function($path) {
90
+            return collect(explode("\r\n", $path))->map(function($path) {
91 91
                 $method = $this->http_method ?: ['ANY'];
92 92
 
93 93
                 if (Str::contains($path, ':')) {
@@ -95,9 +95,9 @@  discard block
 block discarded – undo
95 95
                     $method = explode(',', $method);
96 96
                 }
97 97
 
98
-                $method = collect($method)->map(function ($name) {
98
+                $method = collect($method)->map(function($name) {
99 99
                     return strtoupper($name);
100
-                })->map(function ($name) {
100
+                })->map(function($name) {
101 101
                     return "<span class='label label-primary'>{$name}</span>";
102 102
                 })->implode('&nbsp;');
103 103
 
@@ -110,8 +110,8 @@  discard block
 block discarded – undo
110 110
         $grid->created_at(trans('admin.created_at'));
111 111
         $grid->updated_at(trans('admin.updated_at'));
112 112
 
113
-        $grid->tools(function (Grid\Tools $tools) {
114
-            $tools->batch(function (Grid\Tools\BatchActions $actions) {
113
+        $grid->tools(function(Grid\Tools $tools) {
114
+            $tools->batch(function(Grid\Tools\BatchActions $actions) {
115 115
                 $actions->disableDelete();
116 116
             });
117 117
         });
@@ -133,8 +133,8 @@  discard block
 block discarded – undo
133 133
         $show->slug(trans('admin.slug'));
134 134
         $show->name(trans('admin.name'));
135 135
 
136
-        $show->http_path(trans('admin.route'))->as(function ($path) {
137
-            return collect(explode("\r\n", $path))->map(function ($path) {
136
+        $show->http_path(trans('admin.route'))->as(function($path) {
137
+            return collect(explode("\r\n", $path))->map(function($path) {
138 138
                 $method = $this->http_method ?: ['ANY'];
139 139
 
140 140
                 if (Str::contains($path, ':')) {
@@ -142,9 +142,9 @@  discard block
 block discarded – undo
142 142
                     $method = explode(',', $method);
143 143
                 }
144 144
 
145
-                $method = collect($method)->map(function ($name) {
145
+                $method = collect($method)->map(function($name) {
146 146
                     return strtoupper($name);
147
-                })->map(function ($name) {
147
+                })->map(function($name) {
148 148
                     return "<span class='label label-primary'>{$name}</span>";
149 149
                 })->implode('&nbsp;');
150 150
 
Please login to merge, or discard this patch.