Completed
Pull Request — master (#14100)
by Robert
15:59 queued 04:44
created
build/controllers/PhpDocController.php 1 patch
Doc Comments   +24 added lines, -2 removed lines patch added patch discarded remove patch
@@ -113,6 +113,9 @@  discard block
 block discarded – undo
113 113
         return array_merge(parent::options($actionID), ['updateFiles', 'skipFrameworkRequirements']);
114 114
     }
115 115
 
116
+    /**
117
+     * @param string|null $root
118
+     */
116 119
     protected function findFiles($root, $needsInclude = true)
117 120
     {
118 121
         $except = [];
@@ -233,6 +236,9 @@  discard block
 block discarded – undo
233 236
         return FileHelper::findFiles($root, $options);
234 237
     }
235 238
 
239
+    /**
240
+     * @param string $extensionPath
241
+     */
236 242
     private function setUpExtensionAliases($extensionPath)
237 243
     {
238 244
         foreach (scandir($extensionPath) as $extension) {
@@ -340,6 +346,9 @@  discard block
 block discarded – undo
340 346
         }
341 347
     }
342 348
 
349
+    /**
350
+     * @param string $line
351
+     */
343 352
     protected function fixParamTypes($line)
344 353
     {
345 354
         return preg_replace_callback('~@(param|return) ([\w\\|]+)~i', function ($matches) {
@@ -473,6 +482,10 @@  discard block
 block discarded – undo
473 482
         // TODO
474 483
     }
475 484
 
485
+    /**
486
+     * @param null|string $className
487
+     * @param string $propertyDoc
488
+     */
476 489
     protected function updateClassPropertyDocs($file, $className, $propertyDoc)
477 490
     {
478 491
         try {
@@ -553,7 +566,7 @@  discard block
 block discarded – undo
553 566
     /**
554 567
      * remove multi empty lines and trim trailing whitespace
555 568
      *
556
-     * @param $doc
569
+     * @param string $doc
557 570
      * @return string
558 571
      */
559 572
     protected function cleanDocComment($doc)
@@ -572,7 +585,7 @@  discard block
 block discarded – undo
572 585
 
573 586
     /**
574 587
      * Replace property annotations in doc comment
575
-     * @param $doc
588
+     * @param string $doc
576 589
      * @param $properties
577 590
      * @return string
578 591
      */
@@ -739,6 +752,9 @@  discard block
 block discarded – undo
739 752
         return [$className, $phpdoc];
740 753
     }
741 754
 
755
+    /**
756
+     * @param string $pattern
757
+     */
742 758
     protected function match($pattern, $subject, $split = false)
743 759
     {
744 760
         $sets = [];
@@ -762,6 +778,9 @@  discard block
 block discarded – undo
762 778
         return $sets;
763 779
     }
764 780
 
781
+    /**
782
+     * @param string $str
783
+     */
765 784
     protected function fixSentence($str)
766 785
     {
767 786
         // TODO fix word wrap
@@ -771,6 +790,9 @@  discard block
 block discarded – undo
771 790
         return strtoupper(substr($str, 0, 1)) . substr($str, 1) . ($str[strlen($str) - 1] != '.' ? '.' : '');
772 791
     }
773 792
 
793
+    /**
794
+     * @param string $param
795
+     */
774 796
     protected function getPropParam($prop, $param)
775 797
     {
776 798
         return isset($prop['property']) ? $prop['property'][$param] : (isset($prop['get']) ? $prop['get'][$param] : $prop['set'][$param]);
Please login to merge, or discard this patch.
build/controllers/ReleaseController.php 1 patch
Doc Comments   +20 added lines, -1 removed lines patch added patch discarded remove patch
@@ -366,7 +366,7 @@  discard block
 block discarded – undo
366 366
 
367 367
     /**
368 368
      * @param array $what list of items
369
-     * @param array $limit list of things to allow, or empty to allow any, can be `app`, `framework`, `extension`
369
+     * @param string[] $limit list of things to allow, or empty to allow any, can be `app`, `framework`, `extension`
370 370
      * @throws \yii\base\Exception
371 371
      */
372 372
     protected function validateWhat(array $what, $limit = [], $ensureGitClean = true)
@@ -545,6 +545,10 @@  discard block
 block discarded – undo
545 545
         $this->stdout("\n");
546 546
     }
547 547
 
548
+    /**
549
+     * @param string $name
550
+     * @param string $path
551
+     */
548 552
     protected function releaseApplication($name, $path, $version)
549 553
     {
550 554
         $this->stdout("\n");
@@ -647,6 +651,9 @@  discard block
 block discarded – undo
647 651
         Yii::setAlias('@app', $this->_oldAlias);
648 652
     }
649 653
 
654
+    /**
655
+     * @param string $name
656
+     */
650 657
     protected function packageApplication($name, $version, $packagePath)
651 658
     {
652 659
         FileHelper::createDirectory($packagePath);
@@ -808,6 +815,9 @@  discard block
 block discarded – undo
808 815
     }
809 816
 
810 817
 
818
+    /**
819
+     * @param string[] $what
820
+     */
811 821
     protected function closeChangelogs($what, $version)
812 822
     {
813 823
         $v = str_replace('\\-', '[\\- ]', preg_quote($version, '/'));
@@ -819,6 +829,9 @@  discard block
 block discarded – undo
819 829
         );
820 830
     }
821 831
 
832
+    /**
833
+     * @param string[] $what
834
+     */
822 835
     protected function openChangelogs($what, $version)
823 836
     {
824 837
         $headline = "\n$version under development\n";
@@ -975,6 +988,9 @@  discard block
 block discarded – undo
975 988
             $frameworkPath . '/BaseYii.php');
976 989
     }
977 990
 
991
+    /**
992
+     * @param string $pattern
993
+     */
978 994
     protected function sed($pattern, $replace, $files)
979 995
     {
980 996
         foreach ((array) $files as $file) {
@@ -1007,6 +1023,9 @@  discard block
 block discarded – undo
1007 1023
     const MINOR = 'minor';
1008 1024
     const PATCH = 'patch';
1009 1025
 
1026
+    /**
1027
+     * @param string $type
1028
+     */
1010 1029
     protected function getNextVersions(array $versions, $type)
1011 1030
     {
1012 1031
         foreach ($versions as $k => $v) {
Please login to merge, or discard this patch.
framework/console/controllers/BaseMigrateController.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 use yii\console\Exception;
14 14
 use yii\helpers\Console;
15 15
 use yii\helpers\FileHelper;
16
-use yii\helpers\StringHelper;
17 16
 
18 17
 /**
19 18
  * BaseMigrateController is the base class for migrate controllers.
Please login to merge, or discard this patch.