Yiisoft\Validator\Tests\Rule\Base\WhenTestTrait::testWhenInternal()

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    private function testWhenInternal(WhenInterface $ruleWithoutWhen, WhenInterface $ruleWithWhen): void
    {
        $this->assertNull($ruleWithoutWhen->getWhen());

It seems like assertNull() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $when = static fn (mixed $value): bool => $value !== null;
        $new = $ruleWithoutWhen->when($when);
        $this->assertNull($ruleWithoutWhen->getWhen());
        $this->assertInstanceOf(Closure::class, $new->getWhen());

It seems like assertInstanceOf() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->assertNotSame($ruleWithoutWhen, $new);

It seems like assertNotSame() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->assertInstanceOf(Closure::class, $ruleWithWhen->getWhen());

        $new = $ruleWithWhen->when(null);
        $this->assertInstanceOf(Closure::class, $ruleWithWhen->getWhen());
        $this->assertNull($new->getWhen());
        $this->assertNotSame($ruleWithWhen, $new);
    }