Yiisoft\Validator\Tests\Rule\Base\WhenTestTrait

Complexity

Total Complexity

1

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	testWhenInternal()	0	16	1

<?php

declare(strict_types=1);

namespace Yiisoft\Validator\Tests\Rule\Base;

use Closure;
use Yiisoft\Validator\WhenInterface;

trait WhenTestTrait
{
    abstract public function testWhen(): void;

    private function testWhenInternal(WhenInterface $ruleWithoutWhen, WhenInterface $ruleWithWhen): void
    {
        $this->assertNull($ruleWithoutWhen->getWhen());

It seems like assertNull() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $when = static fn (mixed $value): bool => $value !== null;
        $new = $ruleWithoutWhen->when($when);
        $this->assertNull($ruleWithoutWhen->getWhen());
        $this->assertInstanceOf(Closure::class, $new->getWhen());

It seems like assertInstanceOf() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->assertNotSame($ruleWithoutWhen, $new);

It seems like assertNotSame() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->assertInstanceOf(Closure::class, $ruleWithWhen->getWhen());

        $new = $ruleWithWhen->when(null);
        $this->assertInstanceOf(Closure::class, $ruleWithWhen->getWhen());
        $this->assertNull($new->getWhen());
        $this->assertNotSame($ruleWithWhen, $new);
    }
}