Inspection of "add page - account info" - yii2mod/base - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 53489f...89bc16 )

by Igor

created 2016-03-25 15:37 UTC

Status

Spacing +38 added lines, -38 removed lines patch added patch discarded remove patch

@@ -22,14 +22,14 @@  discard block
 block discarded – undo
         //Create user table
         $this->createTable('{{%User}}', [
             'id' => Schema::TYPE_PK,
-            'username' => Schema::TYPE_STRING . ' NOT NULL',
-            'authKey' => Schema::TYPE_STRING . '(32) NOT NULL',
-            'passwordHash' => Schema::TYPE_STRING . ' NOT NULL',
+            'username' => Schema::TYPE_STRING.' NOT NULL',
+            'authKey' => Schema::TYPE_STRING.'(32) NOT NULL',
+            'passwordHash' => Schema::TYPE_STRING.' NOT NULL',
             'passwordResetToken' => Schema::TYPE_STRING,
-            'email' => Schema::TYPE_STRING . ' NOT NULL',
-            'status' => Schema::TYPE_SMALLINT . ' NOT NULL DEFAULT 10',
-            'createdAt' => Schema::TYPE_INTEGER . ' NOT NULL',
-            'updatedAt' => Schema::TYPE_INTEGER . ' NOT NULL',
+            'email' => Schema::TYPE_STRING.' NOT NULL',
+            'status' => Schema::TYPE_SMALLINT.' NOT NULL DEFAULT 10',
+            'createdAt' => Schema::TYPE_INTEGER.' NOT NULL',
+            'updatedAt' => Schema::TYPE_INTEGER.' NOT NULL',
             'lastLogin' => Schema::TYPE_INTEGER,
         ], $tableOptions);
 
@@ -42,32 +42,32 @@  discard block
 block discarded – undo
         //Create Cms table
         $this->createTable('{{%Cms}}', [
             'id' => Schema::TYPE_PK,
-            'url' => Schema::TYPE_STRING . '(255)',
-            'title' => Schema::TYPE_STRING . '(255)',
+            'url' => Schema::TYPE_STRING.'(255)',
+            'title' => Schema::TYPE_STRING.'(255)',
             'content' => Schema::TYPE_TEXT,
             'status' => Schema::TYPE_SMALLINT,
             'commentAvailable' => 'TINYINT(1) DEFAULT 0',
             'metaTitle' => Schema::TYPE_TEXT,
             'metaDescription' => Schema::TYPE_TEXT,
             'metaKeywords' => Schema::TYPE_TEXT,
-            'createdAt' => Schema::TYPE_INTEGER . ' NOT NULL',
-            'updatedAt' => Schema::TYPE_INTEGER . ' NOT NULL',
+            'createdAt' => Schema::TYPE_INTEGER.' NOT NULL',
+            'updatedAt' => Schema::TYPE_INTEGER.' NOT NULL',
         ], $tableOptions);
 
         //Create Comment table
         $this->createTable('{{%Comment}}', [
             'id' => Schema::TYPE_PK,
             'entity' => 'CHAR(10) NOT NULL',
-            'entityId' => Schema::TYPE_INTEGER . ' NOT NULL',
-            'content' => Schema::TYPE_TEXT . ' NOT NULL',
-            'parentId' => Schema::TYPE_INTEGER . ' DEFAULT NULL',
+            'entityId' => Schema::TYPE_INTEGER.' NOT NULL',
+            'content' => Schema::TYPE_TEXT.' NOT NULL',
+            'parentId' => Schema::TYPE_INTEGER.' DEFAULT NULL',
             'level' => 'TINYINT(3) NOT NULL DEFAULT 1',
-            'createdBy' => Schema::TYPE_INTEGER . ' NOT NULL',
-            'updatedBy' => Schema::TYPE_INTEGER . ' NOT NULL',
+            'createdBy' => Schema::TYPE_INTEGER.' NOT NULL',
+            'updatedBy' => Schema::TYPE_INTEGER.' NOT NULL',
             'relatedTo' => $this->string(500)->notNull(),
             'status' => 'TINYINT(2) NOT NULL DEFAULT 1',
-            'createdAt' => Schema::TYPE_INTEGER . ' NOT NULL',
-            'updatedAt' => Schema::TYPE_INTEGER . ' NOT NULL',
+            'createdAt' => Schema::TYPE_INTEGER.' NOT NULL',
+            'updatedAt' => Schema::TYPE_INTEGER.' NOT NULL',
         ], $tableOptions);
 
         //Insert pages in CMS table
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
         ]);
 
         $this->createTable('{{%AuthRule}}', [
-            'name' => Schema::TYPE_STRING . '(64) NOT NULL',
+            'name' => Schema::TYPE_STRING.'(64) NOT NULL',
             'data' => Schema::TYPE_TEXT,
             'created_at' => Schema::TYPE_INTEGER,
             'updated_at' => Schema::TYPE_INTEGER,
@@ -123,45 +123,45 @@  discard block
 block discarded – undo
         ], $tableOptions);
 
         $this->createTable('{{%AuthItem}}', [
-            'name' => Schema::TYPE_STRING . '(64) NOT NULL',
-            'type' => Schema::TYPE_INTEGER . ' NOT NULL',
+            'name' => Schema::TYPE_STRING.'(64) NOT NULL',
+            'type' => Schema::TYPE_INTEGER.' NOT NULL',
             'description' => Schema::TYPE_TEXT,
-            'rule_name' => Schema::TYPE_STRING . '(64)',
+            'rule_name' => Schema::TYPE_STRING.'(64)',
             'data' => Schema::TYPE_TEXT,
             'created_at' => Schema::TYPE_INTEGER,
             'updated_at' => Schema::TYPE_INTEGER,
             'PRIMARY KEY (name)',
-            'FOREIGN KEY (rule_name) REFERENCES ' . '{{%AuthRule}}' . ' (name) ON DELETE SET NULL ON UPDATE CASCADE',
+            'FOREIGN KEY (rule_name) REFERENCES '.'{{%AuthRule}}'.' (name) ON DELETE SET NULL ON UPDATE CASCADE',
         ], $tableOptions);
 
         $this->createIndex('idx-auth_item-type', '{{%AuthItem}}', 'type');
 
         $this->createTable('{{%AuthItemChild}}', [
-            'parent' => Schema::TYPE_STRING . '(64) NOT NULL',
-            'child' => Schema::TYPE_STRING . '(64) NOT NULL',
+            'parent' => Schema::TYPE_STRING.'(64) NOT NULL',
+            'child' => Schema::TYPE_STRING.'(64) NOT NULL',
             'PRIMARY KEY (parent, child)',
-            'FOREIGN KEY (parent) REFERENCES ' . '{{%AuthItem}}' . ' (name) ON DELETE CASCADE ON UPDATE CASCADE',
-            'FOREIGN KEY (child) REFERENCES ' . '{{%AuthItem}}' . ' (name) ON DELETE CASCADE ON UPDATE CASCADE',
+            'FOREIGN KEY (parent) REFERENCES '.'{{%AuthItem}}'.' (name) ON DELETE CASCADE ON UPDATE CASCADE',
+            'FOREIGN KEY (child) REFERENCES '.'{{%AuthItem}}'.' (name) ON DELETE CASCADE ON UPDATE CASCADE',
         ], $tableOptions);
 
         $this->createTable('{{%AuthAssignment}}', [
-            'item_name' => Schema::TYPE_STRING . '(64) NOT NULL',
-            'user_id' => Schema::TYPE_INTEGER . ' NOT NULL',
+            'item_name' => Schema::TYPE_STRING.'(64) NOT NULL',
+            'user_id' => Schema::TYPE_INTEGER.' NOT NULL',
             'created_at' => Schema::TYPE_INTEGER,
             'PRIMARY KEY (item_name, user_id)',
-            'FOREIGN KEY (item_name) REFERENCES ' . '{{%AuthItem}}' . ' (name) ON DELETE CASCADE ON UPDATE CASCADE',
+            'FOREIGN KEY (item_name) REFERENCES '.'{{%AuthItem}}'.' (name) ON DELETE CASCADE ON UPDATE CASCADE',
         ], $tableOptions);
 
         // Create Cron Shedule table
-        $this->createTable('{{%CronSchedule}}',[
+        $this->createTable('{{%CronSchedule}}', [
             'id' => Schema::TYPE_PK,
-            'jobCode' => Schema::TYPE_STRING . '(255) NULL DEFAULT NULL',
-            'status' => Schema::TYPE_SMALLINT . ' NOT NULL',
-            'messages' => Schema::TYPE_TEXT . ' NULL',
-            'dateCreated' => Schema::TYPE_TIMESTAMP . ' NULL DEFAULT NULL',
-            'dateScheduled' => Schema::TYPE_TIMESTAMP . ' NULL DEFAULT NULL',
-            'dateExecuted' => Schema::TYPE_TIMESTAMP . ' NULL DEFAULT NULL',
-            'dateFinished' => Schema::TYPE_TIMESTAMP . ' NULL DEFAULT NULL',
+            'jobCode' => Schema::TYPE_STRING.'(255) NULL DEFAULT NULL',
+            'status' => Schema::TYPE_SMALLINT.' NOT NULL',
+            'messages' => Schema::TYPE_TEXT.' NULL',
+            'dateCreated' => Schema::TYPE_TIMESTAMP.' NULL DEFAULT NULL',
+            'dateScheduled' => Schema::TYPE_TIMESTAMP.' NULL DEFAULT NULL',
+            'dateExecuted' => Schema::TYPE_TIMESTAMP.' NULL DEFAULT NULL',
+            'dateFinished' => Schema::TYPE_TIMESTAMP.' NULL DEFAULT NULL',
         ],
             $tableOptions
         );

Please login to merge, or discard this patch.

		@@ -22,14 +22,14 @@ discard block
		block discarded – undo
22	22	//Create user table
23	23	$this->createTable('{{%User}}', [
24	24	'id' => Schema::TYPE_PK,
25		- 'username' => Schema::TYPE_STRING . ' NOT NULL',
26		- 'authKey' => Schema::TYPE_STRING . '(32) NOT NULL',
27		- 'passwordHash' => Schema::TYPE_STRING . ' NOT NULL',
	25	+ 'username' => Schema::TYPE_STRING.' NOT NULL',
	26	+ 'authKey' => Schema::TYPE_STRING.'(32) NOT NULL',
	27	+ 'passwordHash' => Schema::TYPE_STRING.' NOT NULL',
28	28	'passwordResetToken' => Schema::TYPE_STRING,
29		- 'email' => Schema::TYPE_STRING . ' NOT NULL',
30		- 'status' => Schema::TYPE_SMALLINT . ' NOT NULL DEFAULT 10',
31		- 'createdAt' => Schema::TYPE_INTEGER . ' NOT NULL',
32		- 'updatedAt' => Schema::TYPE_INTEGER . ' NOT NULL',
	29	+ 'email' => Schema::TYPE_STRING.' NOT NULL',
	30	+ 'status' => Schema::TYPE_SMALLINT.' NOT NULL DEFAULT 10',
	31	+ 'createdAt' => Schema::TYPE_INTEGER.' NOT NULL',
	32	+ 'updatedAt' => Schema::TYPE_INTEGER.' NOT NULL',
33	33	'lastLogin' => Schema::TYPE_INTEGER,
34	34	], $tableOptions);
35	35
		@@ -42,32 +42,32 @@ discard block
		block discarded – undo
42	42	//Create Cms table
43	43	$this->createTable('{{%Cms}}', [
44	44	'id' => Schema::TYPE_PK,
45		- 'url' => Schema::TYPE_STRING . '(255)',
46		- 'title' => Schema::TYPE_STRING . '(255)',
	45	+ 'url' => Schema::TYPE_STRING.'(255)',
	46	+ 'title' => Schema::TYPE_STRING.'(255)',
47	47	'content' => Schema::TYPE_TEXT,
48	48	'status' => Schema::TYPE_SMALLINT,
49	49	'commentAvailable' => 'TINYINT(1) DEFAULT 0',
50	50	'metaTitle' => Schema::TYPE_TEXT,
51	51	'metaDescription' => Schema::TYPE_TEXT,
52	52	'metaKeywords' => Schema::TYPE_TEXT,
53		- 'createdAt' => Schema::TYPE_INTEGER . ' NOT NULL',
54		- 'updatedAt' => Schema::TYPE_INTEGER . ' NOT NULL',
	53	+ 'createdAt' => Schema::TYPE_INTEGER.' NOT NULL',
	54	+ 'updatedAt' => Schema::TYPE_INTEGER.' NOT NULL',
55	55	], $tableOptions);
56	56
57	57	//Create Comment table
58	58	$this->createTable('{{%Comment}}', [
59	59	'id' => Schema::TYPE_PK,
60	60	'entity' => 'CHAR(10) NOT NULL',
61		- 'entityId' => Schema::TYPE_INTEGER . ' NOT NULL',
62		- 'content' => Schema::TYPE_TEXT . ' NOT NULL',
63		- 'parentId' => Schema::TYPE_INTEGER . ' DEFAULT NULL',
	61	+ 'entityId' => Schema::TYPE_INTEGER.' NOT NULL',
	62	+ 'content' => Schema::TYPE_TEXT.' NOT NULL',
	63	+ 'parentId' => Schema::TYPE_INTEGER.' DEFAULT NULL',
64	64	'level' => 'TINYINT(3) NOT NULL DEFAULT 1',
65		- 'createdBy' => Schema::TYPE_INTEGER . ' NOT NULL',
66		- 'updatedBy' => Schema::TYPE_INTEGER . ' NOT NULL',
	65	+ 'createdBy' => Schema::TYPE_INTEGER.' NOT NULL',
	66	+ 'updatedBy' => Schema::TYPE_INTEGER.' NOT NULL',
67	67	'relatedTo' => $this->string(500)->notNull(),
68	68	'status' => 'TINYINT(2) NOT NULL DEFAULT 1',
69		- 'createdAt' => Schema::TYPE_INTEGER . ' NOT NULL',
70		- 'updatedAt' => Schema::TYPE_INTEGER . ' NOT NULL',
	69	+ 'createdAt' => Schema::TYPE_INTEGER.' NOT NULL',
	70	+ 'updatedAt' => Schema::TYPE_INTEGER.' NOT NULL',
71	71	], $tableOptions);
72	72
73	73	//Insert pages in CMS table
		@@ -115,7 +115,7 @@ discard block
		block discarded – undo
115	115	]);
116	116
117	117	$this->createTable('{{%AuthRule}}', [
118		- 'name' => Schema::TYPE_STRING . '(64) NOT NULL',
	118	+ 'name' => Schema::TYPE_STRING.'(64) NOT NULL',
119	119	'data' => Schema::TYPE_TEXT,
120	120	'created_at' => Schema::TYPE_INTEGER,
121	121	'updated_at' => Schema::TYPE_INTEGER,
		@@ -123,45 +123,45 @@ discard block
		block discarded – undo
123	123	], $tableOptions);
124	124
125	125	$this->createTable('{{%AuthItem}}', [
126		- 'name' => Schema::TYPE_STRING . '(64) NOT NULL',
127		- 'type' => Schema::TYPE_INTEGER . ' NOT NULL',
	126	+ 'name' => Schema::TYPE_STRING.'(64) NOT NULL',
	127	+ 'type' => Schema::TYPE_INTEGER.' NOT NULL',
128	128	'description' => Schema::TYPE_TEXT,
129		- 'rule_name' => Schema::TYPE_STRING . '(64)',
	129	+ 'rule_name' => Schema::TYPE_STRING.'(64)',
130	130	'data' => Schema::TYPE_TEXT,
131	131	'created_at' => Schema::TYPE_INTEGER,
132	132	'updated_at' => Schema::TYPE_INTEGER,
133	133	'PRIMARY KEY (name)',
134		- 'FOREIGN KEY (rule_name) REFERENCES ' . '{{%AuthRule}}' . ' (name) ON DELETE SET NULL ON UPDATE CASCADE',
	134	+ 'FOREIGN KEY (rule_name) REFERENCES '.'{{%AuthRule}}'.' (name) ON DELETE SET NULL ON UPDATE CASCADE',
135	135	], $tableOptions);
136	136
137	137	$this->createIndex('idx-auth_item-type', '{{%AuthItem}}', 'type');
138	138
139	139	$this->createTable('{{%AuthItemChild}}', [
140		- 'parent' => Schema::TYPE_STRING . '(64) NOT NULL',
141		- 'child' => Schema::TYPE_STRING . '(64) NOT NULL',
	140	+ 'parent' => Schema::TYPE_STRING.'(64) NOT NULL',
	141	+ 'child' => Schema::TYPE_STRING.'(64) NOT NULL',
142	142	'PRIMARY KEY (parent, child)',
143		- 'FOREIGN KEY (parent) REFERENCES ' . '{{%AuthItem}}' . ' (name) ON DELETE CASCADE ON UPDATE CASCADE',
144		- 'FOREIGN KEY (child) REFERENCES ' . '{{%AuthItem}}' . ' (name) ON DELETE CASCADE ON UPDATE CASCADE',
	143	+ 'FOREIGN KEY (parent) REFERENCES '.'{{%AuthItem}}'.' (name) ON DELETE CASCADE ON UPDATE CASCADE',
	144	+ 'FOREIGN KEY (child) REFERENCES '.'{{%AuthItem}}'.' (name) ON DELETE CASCADE ON UPDATE CASCADE',
145	145	], $tableOptions);
146	146
147	147	$this->createTable('{{%AuthAssignment}}', [
148		- 'item_name' => Schema::TYPE_STRING . '(64) NOT NULL',
149		- 'user_id' => Schema::TYPE_INTEGER . ' NOT NULL',
	148	+ 'item_name' => Schema::TYPE_STRING.'(64) NOT NULL',
	149	+ 'user_id' => Schema::TYPE_INTEGER.' NOT NULL',
150	150	'created_at' => Schema::TYPE_INTEGER,
151	151	'PRIMARY KEY (item_name, user_id)',
152		- 'FOREIGN KEY (item_name) REFERENCES ' . '{{%AuthItem}}' . ' (name) ON DELETE CASCADE ON UPDATE CASCADE',
	152	+ 'FOREIGN KEY (item_name) REFERENCES '.'{{%AuthItem}}'.' (name) ON DELETE CASCADE ON UPDATE CASCADE',
153	153	], $tableOptions);
154	154
155	155	// Create Cron Shedule table
156		- $this->createTable('{{%CronSchedule}}',[
	156	+ $this->createTable('{{%CronSchedule}}', [
157	157	'id' => Schema::TYPE_PK,
158		- 'jobCode' => Schema::TYPE_STRING . '(255) NULL DEFAULT NULL',
159		- 'status' => Schema::TYPE_SMALLINT . ' NOT NULL',
160		- 'messages' => Schema::TYPE_TEXT . ' NULL',
161		- 'dateCreated' => Schema::TYPE_TIMESTAMP . ' NULL DEFAULT NULL',
162		- 'dateScheduled' => Schema::TYPE_TIMESTAMP . ' NULL DEFAULT NULL',
163		- 'dateExecuted' => Schema::TYPE_TIMESTAMP . ' NULL DEFAULT NULL',
164		- 'dateFinished' => Schema::TYPE_TIMESTAMP . ' NULL DEFAULT NULL',
	158	+ 'jobCode' => Schema::TYPE_STRING.'(255) NULL DEFAULT NULL',
	159	+ 'status' => Schema::TYPE_SMALLINT.' NOT NULL',
	160	+ 'messages' => Schema::TYPE_TEXT.' NULL',
	161	+ 'dateCreated' => Schema::TYPE_TIMESTAMP.' NULL DEFAULT NULL',
	162	+ 'dateScheduled' => Schema::TYPE_TIMESTAMP.' NULL DEFAULT NULL',
	163	+ 'dateExecuted' => Schema::TYPE_TIMESTAMP.' NULL DEFAULT NULL',
	164	+ 'dateFinished' => Schema::TYPE_TIMESTAMP.' NULL DEFAULT NULL',
165	165	],
166	166	$tableOptions
167	167	);

yii2mod / base

Push — master ( 53489f...89bc16 )

Status

Category

Spacing +38 added lines, -38 removed lines patch added patch discarded remove patch