Completed
Pull Request — master (#275)
by
unknown
03:00 queued 41s
created
src/yajra/Datatables/Engines/CollectionEngine.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,6 @@
 block discarded – undo
17 17
 use Illuminate\Support\Str;
18 18
 use yajra\Datatables\Contracts\DataTableEngine;
19 19
 use yajra\Datatables\Request;
20
-use yajra\Datatables\Helper;
21 20
 
22 21
 class CollectionEngine extends BaseEngine implements DataTableEngine
23 22
 {
Please login to merge, or discard this patch.
src/yajra/Datatables/Engines/QueryBuilderEngine.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -256,7 +256,9 @@
 block discarded – undo
256 256
                  * which causes a query exception
257 257
                  * The temporary fix is modify `*` column to `id` column 
258 258
                  */
259
-                if ($column === '*') $column = 'id';
259
+                if ($column === '*') {
260
+                    $column = 'id';
261
+                }
260 262
                 $this->getQueryBuilder()->orderBy($column, $orderable['direction']);
261 263
             }
262 264
         }
Please login to merge, or discard this patch.