WidgetsController::publish() - Code Metrics - yajra/cms-core - Measure and Improve Code Quality continuously with Scrutinizer

WidgetsController::publish() A
last analyzed 2017-02-08 14:31 UTC

↳ Parent: WidgetsController

Complexity

Conditions	2
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	1
nop	1
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0

<?php

namespace Yajra\CMS\Http\Controllers;

use Yajra\CMS\DataTables\WidgetsDataTable;
use Yajra\CMS\Entities\Extension;
use Yajra\CMS\Entities\Widget;
use Yajra\CMS\Http\Requests\WidgetFormRequest;
use Yajra\CMS\Repositories\Extension\Repository;

class WidgetsController extends Controller
{
    /**
     * Controller specific permission ability map.
     *
     * @var array
     */
    protected $customPermissionMap = [
        'publish' => 'update',
    ];

    /**
     * @var \Yajra\CMS\Repositories\Extension\Repository
     */
    protected $repository;

    /**
     * WidgetsController constructor.
     *
     * @param \Yajra\CMS\Repositories\Extension\Repository $repository
     */
    public function __construct(Repository $repository)
    {
        $this->authorizePermissionResource('widget');
        $this->repository = $repository;
    }

    /**
     * Display list of widgets.
     *
     * @param \Yajra\CMS\DataTables\WidgetsDataTable $dataTable
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(WidgetsDataTable $dataTable)
    {
        return $dataTable->render('administrator.widgets.index');
    }

    /**
     * Show widget form.
     *
     * @param \Yajra\CMS\Entities\Widget $widget
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function create(Widget $widget)
    {
        $widget->extension_id = old('extension_id', Extension::WIDGET_WYSIWYG);
        $widget->template     = old('template', 'widgets.wysiwyg.raw');
        $widget->published    = old('published', true);

        return view('administrator.widgets.create', compact('widget'));
    }

    /**
     * Store a newly created widget.
     *
     * @param \Yajra\CMS\Http\Requests\WidgetFormRequest $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(WidgetFormRequest $request)

    {
        $widget = new Widget;
        $widget->fill($request->all());
        $widget->published     = $request->get('published', false);
        $widget->authenticated = $request->get('authenticated', false);
        $widget->show_title    = $request->get('show_title', false);
        $widget->save();

        $widget->syncPermissions($request->get('permissions', []));
        $widget->syncMenuAssignment($request->get('menu', []), $request->get('assignment', Widget::ALL_PAGES));

        flash()->success(trans('cms::widget.store.success'));


        return redirect()->route('administrator.widgets.index');
    }

    /**
     * Show and edit selected widget.
     *
     * @param \Yajra\CMS\Entities\Widget $widget
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function edit(Widget $widget)
    {
        $widget->type     = old('type', $widget->type);
        $widget->template = old('template', $widget->template);

        return view('administrator.widgets.edit', compact('widget'));
    }

    /**
     * Update selected widget.
     *
     * @param \Yajra\CMS\Entities\Widget $widget
     * @param \Yajra\CMS\Http\Requests\WidgetFormRequest $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Widget $widget, WidgetFormRequest $request)

    {
        $widget->fill($request->all());
        $widget->published     = $request->get('published', false);
        $widget->authenticated = $request->get('authenticated', false);
        $widget->show_title    = $request->get('show_title', false);
        $widget->save();

        $widget->syncPermissions($request->get('permissions', []));
        $widget->syncMenuAssignment($request->get('menu', []), $request->get('assignment', Widget::ALL_PAGES));

        flash()->success(trans('cms::widget.update.success'));


        return redirect()->route('administrator.widgets.index');
    }

    /**
     * Remove selected widget.
     *
     * @param \Yajra\CMS\Entities\Widget $widget
     * @return \Illuminate\Http\JsonResponse
     * @throws \Exception
     */
    public function destroy(Widget $widget)
    {
        $widget->delete();

        return $this->notifySuccess(trans('cms::widget.destroy.success'));
    }

    /**
     * Publish/Unpublish a widget.
     *
     * @param \Yajra\CMS\Entities\Widget $widget
     * @return \Illuminate\Http\JsonResponse
     */
    public function publish(Widget $widget)
    {
        $widget->published = ! $widget->published;
        $widget->save();

        return $this->notifySuccess(trans('cms::widget.update.publish', [
                'task' => $widget->published ? 'published' : 'unpublished',
            ])
        );
    }

    /**
     * Get all widget types.
     *
     * @param string $type
     * @return string
     */
    public function templates($type)
    {
        $data      = [];
        $extension = $this->repository->findOrFail($type);
        foreach ($extension->param('templates') as $template) {
            $data[] = ['key' => $template['path'], 'value' => $template['description']];
        }

        return response()->json([
            'template' => $data[0]['key'],
            'selected' => $type,
            'data'     => $data,
        ], 200);
    }

    /**
     * Get widget custom parameter form if any.
     *
     * @param int $id
     * @param int $widget
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View|string
     */
    public function parameters($id, $widget)
    {
        $widget    = Widget::withoutGlobalScope('menu_assignment')->findOrNew($widget);
        $extension = $this->repository->findOrFail($id);
        $formView  = $extension->param('form');

        if (view()->exists($formView)) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            return view($formView, compact('widget'));
        }

        return view('widgets.partials.none');
    }
}


1		<?php
2
3		namespace Yajra\CMS\Http\Controllers;
4
5		use Yajra\CMS\DataTables\WidgetsDataTable;
6		use Yajra\CMS\Entities\Extension;
7		use Yajra\CMS\Entities\Widget;
8		use Yajra\CMS\Http\Requests\WidgetFormRequest;
9		use Yajra\CMS\Repositories\Extension\Repository;
10
11		class WidgetsController extends Controller
12		{
13		/**
14		* Controller specific permission ability map.
15		*
16		* @var array
17		*/
18		protected $customPermissionMap = [
19		'publish' => 'update',
20		];
21
22		/**
23		* @var \Yajra\CMS\Repositories\Extension\Repository
24		*/
25		protected $repository;
26
27		/**
28		* WidgetsController constructor.
29		*
30		* @param \Yajra\CMS\Repositories\Extension\Repository $repository
31		*/
32		public function __construct(Repository $repository)
33		{
34		$this->authorizePermissionResource('widget');
35		$this->repository = $repository;
36		}
37
38		/**
39		* Display list of widgets.
40		*
41		* @param \Yajra\CMS\DataTables\WidgetsDataTable $dataTable
42		* @return \Illuminate\Http\JsonResponse\|\Illuminate\View\View
43		*/
44		public function index(WidgetsDataTable $dataTable)
45		{
46		return $dataTable->render('administrator.widgets.index');
47		}
48
49		/**
50		* Show widget form.
51		*
52		* @param \Yajra\CMS\Entities\Widget $widget
53		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
54		*/
55		public function create(Widget $widget)
56		{
57		$widget->extension_id = old('extension_id', Extension::WIDGET_WYSIWYG);
58		$widget->template = old('template', 'widgets.wysiwyg.raw');
59		$widget->published = old('published', true);
60
61		return view('administrator.widgets.create', compact('widget'));
62		}
63
64		/**
65		* Store a newly created widget.
66		*
67		* @param \Yajra\CMS\Http\Requests\WidgetFormRequest $request
68		* @return \Illuminate\Http\RedirectResponse
69		*/
70	View Code Duplication	public function store(WidgetFormRequest $request)
		0 ignored issues – show Duplication introduced 2016-06-13 15:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		{
72		$widget = new Widget;
73		$widget->fill($request->all());
74		$widget->published = $request->get('published', false);
75		$widget->authenticated = $request->get('authenticated', false);
76		$widget->show_title = $request->get('show_title', false);
77		$widget->save();
78
79		$widget->syncPermissions($request->get('permissions', []));
80		$widget->syncMenuAssignment($request->get('menu', []), $request->get('assignment', Widget::ALL_PAGES));
81
82		flash()->success(trans('cms::widget.store.success'));
		0 ignored issues – show Bug introduced 2017-02-08 14:31 UTC by Report Bug Copy Issue Report It seems like `trans('cms::widget.store.success')` targeting `trans()` can also be of type `object<Illuminate\Contra...Translation\Translator>`; however, `Laracasts\Flash\FlashNotifier::success()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
83
84		return redirect()->route('administrator.widgets.index');
85		}
86
87		/**
88		* Show and edit selected widget.
89		*
90		* @param \Yajra\CMS\Entities\Widget $widget
91		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
92		*/
93		public function edit(Widget $widget)
94		{
95		$widget->type = old('type', $widget->type);
96		$widget->template = old('template', $widget->template);
97
98		return view('administrator.widgets.edit', compact('widget'));
99		}
100
101		/**
102		* Update selected widget.
103		*
104		* @param \Yajra\CMS\Entities\Widget $widget
105		* @param \Yajra\CMS\Http\Requests\WidgetFormRequest $request
106		* @return \Illuminate\Http\RedirectResponse
107		*/
108	View Code Duplication	public function update(Widget $widget, WidgetFormRequest $request)
		0 ignored issues – show Duplication introduced 2016-06-13 15:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
109		{
110		$widget->fill($request->all());
111		$widget->published = $request->get('published', false);
112		$widget->authenticated = $request->get('authenticated', false);
113		$widget->show_title = $request->get('show_title', false);
114		$widget->save();
115
116		$widget->syncPermissions($request->get('permissions', []));
117		$widget->syncMenuAssignment($request->get('menu', []), $request->get('assignment', Widget::ALL_PAGES));
118
119		flash()->success(trans('cms::widget.update.success'));
		0 ignored issues – show Bug introduced 2017-02-08 14:31 UTC by Report Bug Copy Issue Report It seems like `trans('cms::widget.update.success')` targeting `trans()` can also be of type `object<Illuminate\Contra...Translation\Translator>`; however, `Laracasts\Flash\FlashNotifier::success()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
120
121		return redirect()->route('administrator.widgets.index');
122		}
123
124		/**
125		* Remove selected widget.
126		*
127		* @param \Yajra\CMS\Entities\Widget $widget
128		* @return \Illuminate\Http\JsonResponse
129		* @throws \Exception
130		*/
131		public function destroy(Widget $widget)
132		{
133		$widget->delete();
134
135		return $this->notifySuccess(trans('cms::widget.destroy.success'));
136		}
137
138		/**
139		* Publish/Unpublish a widget.
140		*
141		* @param \Yajra\CMS\Entities\Widget $widget
142		* @return \Illuminate\Http\JsonResponse
143		*/
144		public function publish(Widget $widget)
145		{
146		$widget->published = ! $widget->published;
147		$widget->save();
148
149		return $this->notifySuccess(trans('cms::widget.update.publish', [
150		'task' => $widget->published ? 'published' : 'unpublished',
151		])
152		);
153		}
154
155		/**
156		* Get all widget types.
157		*
158		* @param string $type
159		* @return string
160		*/
161		public function templates($type)
162		{
163		$data = [];
164		$extension = $this->repository->findOrFail($type);
165		foreach ($extension->param('templates') as $template) {
166		$data[] = ['key' => $template['path'], 'value' => $template['description']];
167		}
168
169		return response()->json([
170		'template' => $data[0]['key'],
171		'selected' => $type,
172		'data' => $data,
173		], 200);
174		}
175
176		/**
177		* Get widget custom parameter form if any.
178		*
179		* @param int $id
180		* @param int $widget
181		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View\|string
182		*/
183		public function parameters($id, $widget)
184		{
185		$widget = Widget::withoutGlobalScope('menu_assignment')->findOrNew($widget);
186		$extension = $this->repository->findOrFail($id);
187		$formView = $extension->param('form');
188
189		if (view()->exists($formView)) {
		0 ignored issues – show Bug introduced 2016-06-20 06:35 UTC by Report Bug Copy Issue Report The method `exists` does only exist in `Illuminate\Contracts\View\Factory`, but not in `Illuminate\View\View`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
190		return view($formView, compact('widget'));
191		}
192
193		return view('widgets.partials.none');
194		}
195		}
196

yajra / cms-core

WidgetsController::publish() A last analyzed 2017-02-08 14:31 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

WidgetsController::publish() A
last analyzed 2017-02-08 14:31 UTC