Yajra\CMS\Http\Controllers\WidgetsController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	185
Duplicated Lines	16.76 %

Coupling/Cohesion

Components	2
Dependencies	9

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	4	1
A	__construct()	0	5	1
A	store()	16	16	1
A	edit()	0	7	1
A	update()	15	15	1
A	destroy()	0	6	1
A	publish()	0	10	2
A	templates()	0	14	2
A	parameters()	0	12	2
A	create()	0	8	1

<?php

namespace Yajra\CMS\Http\Controllers;

use Yajra\CMS\DataTables\WidgetsDataTable;
use Yajra\CMS\Entities\Extension;
use Yajra\CMS\Entities\Widget;
use Yajra\CMS\Http\Requests\WidgetFormRequest;
use Yajra\CMS\Repositories\Extension\Repository;

class WidgetsController extends Controller
{
    /**
     * Controller specific permission ability map.
     *
     * @var array
     */
    protected $customPermissionMap = [
        'publish' => 'update',
    ];

    /**
     * @var \Yajra\CMS\Repositories\Extension\Repository
     */
    protected $repository;

    /**
     * WidgetsController constructor.
     *
     * @param \Yajra\CMS\Repositories\Extension\Repository $repository
     */
    public function __construct(Repository $repository)
    {
        $this->authorizePermissionResource('widget');
        $this->repository = $repository;
    }

    /**
     * Display list of widgets.
     *
     * @param \Yajra\CMS\DataTables\WidgetsDataTable $dataTable
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(WidgetsDataTable $dataTable)
    {
        return $dataTable->render('administrator.widgets.index');
    }

    /**
     * Show widget form.
     *
     * @param \Yajra\CMS\Entities\Widget $widget
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function create(Widget $widget)
    {
        $widget->extension_id = old('extension_id', Extension::WIDGET_WYSIWYG);
        $widget->template     = old('template', 'widgets.wysiwyg.raw');
        $widget->published    = old('published', true);

        return view('administrator.widgets.create', compact('widget'));
    }

    /**
     * Store a newly created widget.
     *
     * @param \Yajra\CMS\Http\Requests\WidgetFormRequest $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(WidgetFormRequest $request)

This method seems to be duplicated in your project.

    {
        $widget = new Widget;
        $widget->fill($request->all());
        $widget->published     = $request->get('published', false);
        $widget->authenticated = $request->get('authenticated', false);
        $widget->show_title    = $request->get('show_title', false);
        $widget->save();

        $widget->syncPermissions($request->get('permissions', []));
        $widget->syncMenuAssignment($request->get('menu', []), $request->get('assignment', Widget::ALL_PAGES));

        flash()->success(trans('cms::widget.store.success'));

It seems like trans('cms::widget.store.success') targeting trans() can also be of type object<Illuminate\Contracts\Translation\Translator>; however, Laracasts\Flash\FlashNotifier::success() does only seem to accept string, maybe add an additional type check?

        return redirect()->route('administrator.widgets.index');
    }

    /**
     * Show and edit selected widget.
     *
     * @param \Yajra\CMS\Entities\Widget $widget
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function edit(Widget $widget)
    {
        $widget->type     = old('type', $widget->type);
        $widget->template = old('template', $widget->template);

        return view('administrator.widgets.edit', compact('widget'));
    }

    /**
     * Update selected widget.
     *
     * @param \Yajra\CMS\Entities\Widget $widget
     * @param \Yajra\CMS\Http\Requests\WidgetFormRequest $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Widget $widget, WidgetFormRequest $request)

This method seems to be duplicated in your project.

    {
        $widget->fill($request->all());
        $widget->published     = $request->get('published', false);
        $widget->authenticated = $request->get('authenticated', false);
        $widget->show_title    = $request->get('show_title', false);
        $widget->save();

        $widget->syncPermissions($request->get('permissions', []));
        $widget->syncMenuAssignment($request->get('menu', []), $request->get('assignment', Widget::ALL_PAGES));

        flash()->success(trans('cms::widget.update.success'));

It seems like trans('cms::widget.update.success') targeting trans() can also be of type object<Illuminate\Contracts\Translation\Translator>; however, Laracasts\Flash\FlashNotifier::success() does only seem to accept string, maybe add an additional type check?

        return redirect()->route('administrator.widgets.index');
    }

    /**
     * Remove selected widget.
     *
     * @param \Yajra\CMS\Entities\Widget $widget
     * @return \Illuminate\Http\JsonResponse
     * @throws \Exception
     */
    public function destroy(Widget $widget)
    {
        $widget->delete();

        return $this->notifySuccess(trans('cms::widget.destroy.success'));
    }

    /**
     * Publish/Unpublish a widget.
     *
     * @param \Yajra\CMS\Entities\Widget $widget
     * @return \Illuminate\Http\JsonResponse
     */
    public function publish(Widget $widget)
    {
        $widget->published = ! $widget->published;
        $widget->save();

        return $this->notifySuccess(trans('cms::widget.update.publish', [
                'task' => $widget->published ? 'published' : 'unpublished',
            ])
        );
    }

    /**
     * Get all widget types.
     *
     * @param string $type
     * @return string
     */
    public function templates($type)
    {
        $data      = [];
        $extension = $this->repository->findOrFail($type);
        foreach ($extension->param('templates') as $template) {
            $data[] = ['key' => $template['path'], 'value' => $template['description']];
        }

        return response()->json([
            'template' => $data[0]['key'],
            'selected' => $type,
            'data'     => $data,
        ], 200);
    }

    /**
     * Get widget custom parameter form if any.
     *
     * @param int $id
     * @param int $widget
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View|string
     */
    public function parameters($id, $widget)
    {
        $widget    = Widget::withoutGlobalScope('menu_assignment')->findOrNew($widget);
        $extension = $this->repository->findOrFail($id);
        $formView  = $extension->param('form');

        if (view()->exists($formView)) {

The method exists does only exist in Illuminate\Contracts\View\Factory, but not in Illuminate\View\View.

            return view($formView, compact('widget'));
        }

        return view('widgets.partials.none');
    }
}