RolesController::edit() - Code Metrics - yajra/cms-core - Measure and Improve Code Quality continuously with Scrutinizer

RolesController::edit() A
last analyzed 2017-02-08 14:31 UTC

↳ Parent: RolesController

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

namespace Yajra\CMS\Http\Controllers;

use Yajra\CMS\DataTables\RolesDataTable;
use Illuminate\Database\QueryException;
use Illuminate\Http\Request;
use Yajra\Acl\Models\Permission;
use Yajra\Acl\Models\Role;

class RolesController extends Controller
{
    /**
     * @var \Illuminate\Http\Request
     */
    protected $request;

    /**
     * RolesController constructor.
     *
     * @param \Illuminate\Http\Request $request
     */
    public function __construct(Request $request)

    {
        $this->request = $request;
        $this->authorizePermissionResource('role');
    }

    /**
     * Display list of roles.
     *
     * @param \Yajra\CMS\DataTables\RolesDataTable $dataTable
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(RolesDataTable $dataTable)
    {
        return $dataTable->render('administrator.roles.index');
    }

    /**
     * Show role form.
     *
     * @return \Illuminate\View\View
     */
    public function create()
    {
        $role                = new Role;
        $permissions         = Permission::all();
        $selectedPermissions = $this->request->old('permissions', []);

        return view('administrator.roles.create', compact('role', 'permissions', 'selectedPermissions'));
    }

    /**
     * Store a newly created role.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store()

    {
        $this->validate($this->request, [
            'name' => 'required',
            'slug' => 'required|unique:roles,slug',
        ]);

        $role = Role::create($this->request->all());
        $role->syncPermissions($this->request->get('permissions', []));
        flash()->success('Role ' . $role->name . ' successfully created!');

        return redirect()->route('administrator.roles.index');
    }

    /**
     * Show and edit selected role.
     *
     * @param \Yajra\Acl\Models\Role $role
     * @return \Illuminate\View\View
     */
    public function edit(Role $role)
    {
        $permissions = Permission::all();

        return view('administrator.roles.edit', compact('role', 'permissions'));
    }

    /**
     * Update role permission.
     *
     * @param \Yajra\Acl\Models\Role $role
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Role $role)
    {
        $this->validate($this->request, [
            'name'        => 'required',
            'slug'        => 'required|unique:roles,slug,' . $role->id,
            'permissions' => 'required',
        ]);

        $role->update($this->request->all());
        $role->syncPermissions($this->request->get('permissions', []));
        flash()->success('Role ' . $role->name . ' successfully updated!');

        return redirect()->route('administrator.roles.index');
    }

    /**
     * Remove selected role.
     *
     * @param \Yajra\Acl\Models\Role $role
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy(Role $role)

    {
        if (! $role->system) {
            try {
                $role->delete();

                return $this->notifySuccess('Role successfully deleted!');
            } catch (QueryException $e) {
                return $this->notifyError($e->getMessage());
            }
        }

        return $this->notifyError('Role is protected and cannot be deleted!');
    }
}


1		<?php
2
3		namespace Yajra\CMS\Http\Controllers;
4
5		use Yajra\CMS\DataTables\RolesDataTable;
6		use Illuminate\Database\QueryException;
7		use Illuminate\Http\Request;
8		use Yajra\Acl\Models\Permission;
9		use Yajra\Acl\Models\Role;
10
11		class RolesController extends Controller
12		{
13		/**
14		* @var \Illuminate\Http\Request
15		*/
16		protected $request;
17
18		/**
19		* RolesController constructor.
20		*
21		* @param \Illuminate\Http\Request $request
22		*/
23		public function __construct(Request $request)
		0 ignored issues – show Bug introduced 2016-06-13 15:10 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
24		{
25		$this->request = $request;
26		$this->authorizePermissionResource('role');
27		}
28
29		/**
30		* Display list of roles.
31		*
32		* @param \Yajra\CMS\DataTables\RolesDataTable $dataTable
33		* @return \Illuminate\Http\JsonResponse\|\Illuminate\View\View
34		*/
35		public function index(RolesDataTable $dataTable)
36		{
37		return $dataTable->render('administrator.roles.index');
38		}
39
40		/**
41		* Show role form.
42		*
43		* @return \Illuminate\View\View
44		*/
45		public function create()
46		{
47		$role = new Role;
48		$permissions = Permission::all();
49		$selectedPermissions = $this->request->old('permissions', []);
50
51		return view('administrator.roles.create', compact('role', 'permissions', 'selectedPermissions'));
52		}
53
54		/**
55		* Store a newly created role.
56		*
57		* @return \Illuminate\Http\RedirectResponse
58		*/
59	View Code Duplication	public function store()
		0 ignored issues – show Duplication introduced 2016-06-13 15:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		{
61		$this->validate($this->request, [
62		'name' => 'required',
63		'slug' => 'required\|unique:roles,slug',
64		]);
65
66		$role = Role::create($this->request->all());
67		$role->syncPermissions($this->request->get('permissions', []));
68		flash()->success('Role ' . $role->name . ' successfully created!');
69
70		return redirect()->route('administrator.roles.index');
71		}
72
73		/**
74		* Show and edit selected role.
75		*
76		* @param \Yajra\Acl\Models\Role $role
77		* @return \Illuminate\View\View
78		*/
79		public function edit(Role $role)
80		{
81		$permissions = Permission::all();
82
83		return view('administrator.roles.edit', compact('role', 'permissions'));
84		}
85
86		/**
87		* Update role permission.
88		*
89		* @param \Yajra\Acl\Models\Role $role
90		* @return \Illuminate\Http\RedirectResponse
91		*/
92		public function update(Role $role)
93		{
94		$this->validate($this->request, [
95		'name' => 'required',
96		'slug' => 'required\|unique:roles,slug,' . $role->id,
97		'permissions' => 'required',
98		]);
99
100		$role->update($this->request->all());
101		$role->syncPermissions($this->request->get('permissions', []));
102		flash()->success('Role ' . $role->name . ' successfully updated!');
103
104		return redirect()->route('administrator.roles.index');
105		}
106
107		/**
108		* Remove selected role.
109		*
110		* @param \Yajra\Acl\Models\Role $role
111		* @return \Illuminate\Http\RedirectResponse
112		*/
113	View Code Duplication	public function destroy(Role $role)
		0 ignored issues – show Duplication introduced 2016-06-13 15:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
114		{
115		if (! $role->system) {
116		try {
117		$role->delete();
118
119		return $this->notifySuccess('Role successfully deleted!');
120		} catch (QueryException $e) {
121		return $this->notifyError($e->getMessage());
122		}
123		}
124
125		return $this->notifyError('Role is protected and cannot be deleted!');
126		}
127		}
128

yajra / cms-core

RolesController::edit() A last analyzed 2017-02-08 14:31 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RolesController::edit() A
last analyzed 2017-02-08 14:31 UTC