Yajra\CMS\Http\Controllers\RolesController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	117
Duplicated Lines	23.08 %

Coupling/Cohesion

Components	2
Dependencies	8

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	index()	0	4	1
A	create()	0	8	1
A	edit()	0	6	1
A	update()	0	14	1
A	destroy()	14	14	3
A	store()	13	13	1

<?php

namespace Yajra\CMS\Http\Controllers;

use Yajra\CMS\DataTables\RolesDataTable;
use Illuminate\Database\QueryException;
use Illuminate\Http\Request;
use Yajra\Acl\Models\Permission;
use Yajra\Acl\Models\Role;

class RolesController extends Controller
{
    /**
     * @var \Illuminate\Http\Request
     */
    protected $request;

    /**
     * RolesController constructor.
     *
     * @param \Illuminate\Http\Request $request
     */
    public function __construct(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
        $this->authorizePermissionResource('role');
    }

    /**
     * Display list of roles.
     *
     * @param \Yajra\CMS\DataTables\RolesDataTable $dataTable
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(RolesDataTable $dataTable)
    {
        return $dataTable->render('administrator.roles.index');
    }

    /**
     * Show role form.
     *
     * @return \Illuminate\View\View
     */
    public function create()
    {
        $role                = new Role;
        $permissions         = Permission::all();
        $selectedPermissions = $this->request->old('permissions', []);

        return view('administrator.roles.create', compact('role', 'permissions', 'selectedPermissions'));
    }

    /**
     * Store a newly created role.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store()

This method seems to be duplicated in your project.

    {
        $this->validate($this->request, [
            'name' => 'required',
            'slug' => 'required|unique:roles,slug',
        ]);

        $role = Role::create($this->request->all());
        $role->syncPermissions($this->request->get('permissions', []));
        flash()->success('Role ' . $role->name . ' successfully created!');

        return redirect()->route('administrator.roles.index');
    }

    /**
     * Show and edit selected role.
     *
     * @param \Yajra\Acl\Models\Role $role
     * @return \Illuminate\View\View
     */
    public function edit(Role $role)
    {
        $permissions = Permission::all();

        return view('administrator.roles.edit', compact('role', 'permissions'));
    }

    /**
     * Update role permission.
     *
     * @param \Yajra\Acl\Models\Role $role
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Role $role)
    {
        $this->validate($this->request, [
            'name'        => 'required',
            'slug'        => 'required|unique:roles,slug,' . $role->id,
            'permissions' => 'required',
        ]);

        $role->update($this->request->all());
        $role->syncPermissions($this->request->get('permissions', []));
        flash()->success('Role ' . $role->name . ' successfully updated!');

        return redirect()->route('administrator.roles.index');
    }

    /**
     * Remove selected role.
     *
     * @param \Yajra\Acl\Models\Role $role
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy(Role $role)

This method seems to be duplicated in your project.

    {
        if (! $role->system) {
            try {
                $role->delete();

                return $this->notifySuccess('Role successfully deleted!');
            } catch (QueryException $e) {
                return $this->notifyError($e->getMessage());
            }
        }

        return $this->notifyError('Role is protected and cannot be deleted!');
    }
}