xoco70 / laravel-tournaments

src/TreeGen/CreateDirectEliminationTree.php

Doc Comments +2 added lines, -2 removed lines

@@ -192,7 +192,7 @@ 
     }
 
     /**
-     * @param $numRound
+     * @param integer $numRound
      */
     private function assignFightersToBracket($numRound, $hasPreliminary)
     {
@@ -218,7 +218,7 @@ 
     /**
      * @param $selected
      * @param $fighter
-     * @param $html
+     * @param string $html
      * @return string
      */
     private function addOptionToSelect($selected, $fighter, $html): string

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
         $this->groupsByRound = $groupsByRound;
         $this->hasPreliminary = $hasPreliminary;
 
-        $this->firstRoundName = $groupsByRound->first()->map(function ($item) use ($championship) {
+        $this->firstRoundName = $groupsByRound->first()->map(function($item) use ($championship) {
             $fighters = $item->getFightersWithBye();
             $fighter1 = $fighters->get(0);
             $fighter2 = $fighters->get(1);

src/models/Fight.php

Braces +12 added lines, -4 removed lines

@@ -44,7 +44,9 @@ 
      */
     protected static function getFightersWithByes(FightersGroup $group)
     {
-        if ($group == null) return null;
+        if ($group == null) {
+            return null;
+        }
         $fighters = $group->getFightersWithBye();
         $fighterType = $group->getFighterType();
         if (sizeof($fighters) == 0) {
@@ -127,8 +129,12 @@ 
      */
     public function shouldBeInFightList()
     {
-        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) return false;
-        if ($this->has2Fighters()) return true;
+        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) {
+            return false;
+        }
+        if ($this->has2Fighters()) {
+            return true;
+        }
         // We aint in the first round, and there is 1 or 0 competitor
         // We check children, and see :
         // if there is 2  - 2 fighters -> undetermine, we cannot add it to fight list
@@ -157,7 +163,9 @@ 
     private function belongsToFirstRound()
     {
         $firstRoundFights = $this->group->championship->firstRoundFights->pluck('id')->toArray();
-        if (in_array($this->id, $firstRoundFights)) return true;
+        if (in_array($this->id, $firstRoundFights)) {
+            return true;
+        }
         return false;
     }
 

resources/views/partials/tree/directElimination.blade.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
 foreach ($championship->fightersGroups as $group) {
     $group->fixTree();
 }
-$directEliminationTree = $championship->fightersGroups->where('round', '>=', $hasPreliminary +1 )->groupBy('round');
+$directEliminationTree = $championship->fightersGroups->where('round', '>=', $hasPreliminary + 1)->groupBy('round');
 
 $treeGen = new CreateDirectEliminationTree($directEliminationTree, $championship, $hasPreliminary);
 $treeGen->build();