xoco70 / laravel-tournaments

src/Models/Fighter.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 
     public function getFullNameAttribute()
     {
-        if ($this instanceof Competitor){
+        if ($this instanceof Competitor) {
             return $this->getFullName();
         }
         return $this->name;

database/factories/TeamFactory.php

Spacing +1 added lines, -1 removed lines

@@ -1,7 +1,7 @@
 <?php
 
 use Xoco70\KendoTournaments\Models\Team;
-$factory->define(Team::class, function (Faker\Generator $faker) {
+$factory->define(Team::class, function(Faker\Generator $faker) {
 
     return [
         'name' => $faker->name,

database/migrations/2014_10_12_000010_create_users_table.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
      */
     public function up()
     {
-        Schema::create('users', function (Blueprint $table) {
+        Schema::create('users', function(Blueprint $table) {
             $table->increments('id');
             $table->string('name');
             $table->string('firstname');

src/Models/DirectEliminationFight.php

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 
 namespace Xoco70\KendoTournaments\Models;
 
-use Illuminate\Database\Eloquent\Model;
-use Illuminate\Support\Collection;
-
 class DirectEliminationFight extends Fight
 {
     public function __construct(Fight $fight = null)

Spacing +6 added lines, -6 removed lines

@@ -9,12 +9,12 @@
 {
     public function __construct(Fight $fight = null)
     {
-        if ($fight!=null){
-            $this->id= $fight->id;
-            $this->short_id= $fight->short_id;
-            $this->fighters_group_id= $fight->fighters_group_id;
-            $this->c1= $fight->c1;
-            $this->c2= $fight->c2;
+        if ($fight != null) {
+            $this->id = $fight->id;
+            $this->short_id = $fight->short_id;
+            $this->fighters_group_id = $fight->fighters_group_id;
+            $this->c1 = $fight->c1;
+            $this->c2 = $fight->c2;
         }
     }
     /**

src/Models/PreliminaryFight.php

Spacing +6 added lines, -6 removed lines

@@ -9,12 +9,12 @@
 
     public function __construct(Fight $fight = null)
     {
-        if ($fight!=null){
-            $this->id= $fight->id;
-            $this->short_id= $fight->short_id;
-            $this->fighters_group_id= $fight->fighters_group_id;
-            $this->c1= $fight->c1;
-            $this->c2= $fight->c2;
+        if ($fight != null) {
+            $this->id = $fight->id;
+            $this->short_id = $fight->short_id;
+            $this->fighters_group_id = $fight->fighters_group_id;
+            $this->c1 = $fight->c1;
+            $this->c2 = $fight->c2;
         }
     }
 

src/models/FightersGroup.php

Spacing +1 added lines, -1 removed lines

@@ -180,7 +180,7 @@
     public function hasDeterminedParent()
     {
         // There is more than 1 fight, should be Preliminary
-        if (sizeof($this->fighters()) > 1){
+        if (sizeof($this->fighters()) > 1) {
             return false;
         }
         foreach ($this->children as $child) {

Braces +3 added lines, -1 removed lines

@@ -184,7 +184,9 @@
             return false;
         }
         foreach ($this->children as $child) {
-            if (sizeof($child->fighters()) > 1) return false;
+            if (sizeof($child->fighters()) > 1) {
+                return false;
+            }
         }
         return true;
 

src/TreeGen/DirectEliminationTreeGen.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Illuminate\Support\Facades\App;
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\DirectEliminationFight;
-use Xoco70\KendoTournaments\Models\Fight;
 
 abstract class DirectEliminationTreeGen extends TreeGen
 {

src/TreeGen/PlayOffTreeGen.php

Doc Comments +1 added lines, -2 removed lines

@@ -15,7 +15,6 @@ 
 
     /**
      * Calculate the Byes need to fill the Championship Tree.
-     * @param Championship $championship
      * @param $fighters
      * @return Collection
      */
@@ -65,7 +64,7 @@ 
      * Chunk Fighters into groups for fighting, and optionnaly shuffle
      * @param $round
      * @param $fightersByEntity
-     * @return mixed
+     * @return Collection
      */
     protected function chunkAndShuffle($round, Collection $fightersByEntity)
     {

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Illuminate\Support\Facades\App;
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\DirectEliminationFight;
-use Xoco70\KendoTournaments\Models\Fight;
 use Xoco70\KendoTournaments\Models\PreliminaryFight;
 
 abstract class PlayOffTreeGen extends TreeGen

src/TreeGen/CreateDirectEliminationTree.php

Doc Comments +2 added lines, -2 removed lines

@@ -192,7 +192,7 @@ 
     }
 
     /**
-     * @param $numRound
+     * @param integer $numRound
      */
     private function assignFightersToBracket($numRound, $hasPreliminary)
     {
@@ -218,7 +218,7 @@ 
     /**
      * @param $selected
      * @param $fighter
-     * @param $html
+     * @param string $html
      * @return string
      */
     private function addOptionToSelect($selected, $fighter, $html): string

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
         $this->groupsByRound = $groupsByRound;
         $this->hasPreliminary = $hasPreliminary;
 
-        $this->firstRoundName = $groupsByRound->first()->map(function ($item) use ($championship) {
+        $this->firstRoundName = $groupsByRound->first()->map(function($item) use ($championship) {
             $fighters = $item->getFightersWithBye();
             $fighter1 = $fighters->get(0);
             $fighter2 = $fighters->get(1);