xoco70 / laravel-tournaments

database/seeds/TournamentSeeder.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 
-use Illuminate\Database\QueryException;
 use Illuminate\Database\Seeder;
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\Venue;

src/models/Tree.php

Doc Comments +1 added lines, -1 removed lines

@@ -218,7 +218,7 @@
 
     /**
      * @param Collection $tree
-     * @param $settings
+     * @param ChampionshipSettings $settings
      */
     public static function generateFights(Collection $tree, $settings, Championship $championship = null)
     {

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Collection;
-use Illuminate\Support\Facades\Config;
 use Xoco70\KendoTournaments\TreeGen\TreeGen;
 
 class Tree extends Model

Spacing +4 added lines, -4 removed lines

@@ -41,15 +41,15 @@ 
      */
     public static function getTournament($request)
     {
-        $tournament = Tournament::whereHas('championships', function ($query) use ($request) {
+        $tournament = Tournament::whereHas('championships', function($query) use ($request) {
             return $query->where('id', $request->championshipId);
         })
-            ->with(['championships' => function ($query) use ($request) {
+            ->with(['championships' => function($query) use ($request) {
                 $query->where('id', '=', $request->championshipId)
                     ->with([
                         'settings',
                         'category',
-                        'tree' => function ($query) {
+                        'tree' => function($query) {
                             return $query->with('user1', 'user2', 'user3', 'user4', 'user5');
                         }]);
             }])
@@ -225,7 +225,7 @@ 
 
         // Delete previous fight for this championship
 
-        $arrayTreeId = $tree->map(function ($value, $key) {
+        $arrayTreeId = $tree->map(function($value, $key) {
             return $value->id;
         })->toArray();
         Fight::destroy($arrayTreeId);

src/TreeGen/TreeGen.php

Doc Comments +4 added lines, -1 removed lines

@@ -20,6 +20,9 @@ 
     public $championship, $settings;
 
 
+    /**
+     * @param \Xoco70\KendoTournaments\Models\ChampionshipSettings $settings
+     */
     public function __construct(Championship $championship, $groupBy, $settings)
     {
         $this->championship = $championship;
@@ -257,7 +260,7 @@ 
 
     /**
      * @param $userGroups
-     * @param $max
+     * @param integer $max
      * @return Collection
      */
     private function repart($userGroups, $max)

Spacing +2 added lines, -2 removed lines

@@ -69,7 +69,7 @@ 
 
             } else if ($this->championship->isDirectEliminationType()) {
                 $roundRobinGroups = $users->chunk(2)->shuffle();
-            }else{
+            } else {
                 $roundRobinGroups = new Collection();
 
                 // Not so good, Round Robin has no trees
@@ -223,7 +223,7 @@ 
     private function getTreeSize($userCount, $groupSize)
     {
         $square = collect([1, 2, 4, 8, 16, 32, 64]);
-        $squareMultiplied = $square->map(function ($item, $key) use ($groupSize) {
+        $squareMultiplied = $square->map(function($item, $key) use ($groupSize) {
             return $item * $groupSize;
         });
 

Braces +16 added lines, -6 removed lines

@@ -69,7 +69,7 @@ 
 
             } else if ($this->championship->isDirectEliminationType()) {
                 $roundRobinGroups = $users->chunk(2)->shuffle();
-            }else{
+            } else{
                 $roundRobinGroups = new Collection();
 
                 // Not so good, Round Robin has no trees
@@ -106,11 +106,21 @@ 
                 $c4 = $robinGroup->get(3);
                 $c5 = $robinGroup->get(4);
 
-                if (isset($c1)) $pt->c1 = $c1->id;
-                if (isset($c2)) $pt->c2 = $c2->id;
-                if (isset($c3)) $pt->c3 = $c3->id;
-                if (isset($c4)) $pt->c4 = $c4->id;
-                if (isset($c5)) $pt->c5 = $c5->id;
+                if (isset($c1)) {
+                    $pt->c1 = $c1->id;
+                }
+                if (isset($c2)) {
+                    $pt->c2 = $c2->id;
+                }
+                if (isset($c3)) {
+                    $pt->c3 = $c3->id;
+                }
+                if (isset($c4)) {
+                    $pt->c4 = $c4->id;
+                }
+                if (isset($c5)) {
+                    $pt->c5 = $c5->id;
+                }
                 $pt->save();
                 $trees->push($pt);
                 $order++;

resources/views/partials/tree/directElimination.blade.php

Spacing +3 added lines, -3 removed lines

@@ -1,10 +1,10 @@
 <?php
-$directEliminationTree = $championship->tree->map(function ($item, $key) use ($championship) {
-    if ($championship->category->isTeam()){
+$directEliminationTree = $championship->tree->map(function($item, $key) use ($championship) {
+    if ($championship->category->isTeam()) {
 
         $user1 = $item->team1 != null ? $item->team1->name : "Bye";
         $user2 = $item->team2 != null ? $item->team2->name : "Bye";
-    }else{
+    } else {
         $user1 = $item->user1 != null ? $item->user1->name : "Bye";
         $user2 = $item->user2 != null ? $item->user2->name : "Bye";
     }

Braces +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
 
         $user1 = $item->team1 != null ? $item->team1->name : "Bye";
         $user2 = $item->team2 != null ? $item->team2->name : "Bye";
-    }else{
+    } else{
         $user1 = $item->user1 != null ? $item->user1->name : "Bye";
         $user2 = $item->user2 != null ? $item->user2->name : "Bye";
     }

src/TreeController.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
 //            'championships.users'
             )->first();
 
-        $championship = Championship::with('teams','users','category','settings')->find($championship->id);
+        $championship = Championship::with('teams', 'users', 'category', 'settings')->find($championship->id);
 
         $settings = ChampionshipSettings::createOrUpdate($request, $championship);
 

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Xoco70\KendoTournaments;
 
 use App\Http\Controllers\Controller;
-use Illuminate\Auth\Access\AuthorizationException;
 use Illuminate\Http\Request;
 use Xoco70\KendoTournaments\Exceptions\TreeGenerationException;
 use Xoco70\KendoTournaments\Models\Championship;

src/models/Championship.php

Spacing +2 added lines, -2 removed lines

@@ -22,11 +22,11 @@
     {
         parent::boot();
 
-        static::deleting(function ($championship) {
+        static::deleting(function($championship) {
             $championship->competitors()->delete();
             $championship->settings()->delete();
         });
-        static::restoring(function ($championship) {
+        static::restoring(function($championship) {
             $championship->competitors()->restore();
             $championship->settings()->restore();
 

src/models/Category.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
         'gradeMax',
     ];
 
-    public function getAliasString(){
+    public function getAliasString() {
         return $this->alias;
     }
 

src/models/Tournament.php

Spacing +2 added lines, -2 removed lines

@@ -59,14 +59,14 @@
     protected static function boot()
     {
         parent::boot();
-        static::deleting(function ($tournament) {
+        static::deleting(function($tournament) {
             foreach ($tournament->championships as $ct) {
                 $ct->delete();
             }
             $tournament->invites()->delete();
 
         });
-        static::restoring(function ($tournament) {
+        static::restoring(function($tournament) {
 
             foreach ($tournament->championships()->withTrashed()->get() as $ct) {
                 $ct->restore();

src/models/Fight.php

Spacing +1 added lines, -1 removed lines

@@ -174,7 +174,7 @@
             $round = [];
             $fighters = self::getActorsToFights($championship, $treeGroup);
 
-            $away = $fighters->splice(sizeof($fighters) / 2);  // 2
+            $away = $fighters->splice(sizeof($fighters) / 2); // 2
 
             $home = $fighters; // 1
 

Braces +30 added lines, -10 removed lines

@@ -43,17 +43,37 @@
         } else {
             $fighters = new Collection;
             if ($championship->category->isTeam) {
-                if ($treeGroup->c1 != null) $fighters->push($treeGroup->team1);
-                if ($treeGroup->c2 != null) $fighters->push($treeGroup->team2);
-                if ($treeGroup->c3 != null) $fighters->push($treeGroup->team3);
-                if ($treeGroup->c4 != null) $fighters->push($treeGroup->team4);
-                if ($treeGroup->c5 != null) $fighters->push($treeGroup->team5);
+                if ($treeGroup->c1 != null) {
+                    $fighters->push($treeGroup->team1);
+                }
+                if ($treeGroup->c2 != null) {
+                    $fighters->push($treeGroup->team2);
+                }
+                if ($treeGroup->c3 != null) {
+                    $fighters->push($treeGroup->team3);
+                }
+                if ($treeGroup->c4 != null) {
+                    $fighters->push($treeGroup->team4);
+                }
+                if ($treeGroup->c5 != null) {
+                    $fighters->push($treeGroup->team5);
+                }
             } else {
-                if ($treeGroup->c1 != null) $fighters->push($treeGroup->user1);
-                if ($treeGroup->c2 != null) $fighters->push($treeGroup->user2);
-                if ($treeGroup->c3 != null) $fighters->push($treeGroup->user3);
-                if ($treeGroup->c4 != null) $fighters->push($treeGroup->user4);
-                if ($treeGroup->c5 != null) $fighters->push($treeGroup->user5);
+                if ($treeGroup->c1 != null) {
+                    $fighters->push($treeGroup->user1);
+                }
+                if ($treeGroup->c2 != null) {
+                    $fighters->push($treeGroup->user2);
+                }
+                if ($treeGroup->c3 != null) {
+                    $fighters->push($treeGroup->user3);
+                }
+                if ($treeGroup->c4 != null) {
+                    $fighters->push($treeGroup->user4);
+                }
+                if ($treeGroup->c5 != null) {
+                    $fighters->push($treeGroup->user5);
+                }
             }
         }
         if ($championship->category->isTeam) {

Doc Comments +4 added lines, -1 removed lines

@@ -106,7 +106,7 @@ 
 
     /**
      * Save a Fight.
-     * @param $tree
+     * @param Collection $tree
      * @param int $numRound
      */
     public static function saveFightRound($tree, $numRound = 1)
@@ -166,6 +166,9 @@ 
 //        }
 //    }
 
+    /**
+     * @param Collection $tree
+     */
     public static function saveRoundRobinFights(Championship $championship, $tree)
     {