@@ -47,7 +47,7 @@ discard block |
||
| 47 | 47 | |
| 48 | 48 | /** |
| 49 | 49 | * Get the biggest entity group |
| 50 | - * @param $userGroups |
|
| 50 | + * @param Collection $userGroups |
|
| 51 | 51 | * |
| 52 | 52 | * @return int |
| 53 | 53 | */ |
@@ -104,7 +104,7 @@ discard block |
||
| 104 | 104 | |
| 105 | 105 | /** |
| 106 | 106 | * Repart BYE in the tree, |
| 107 | - * @param $fighterGroups |
|
| 107 | + * @param Collection $fighterGroups |
|
| 108 | 108 | * @param int $max |
| 109 | 109 | * |
| 110 | 110 | * @return Collection |
@@ -185,9 +185,9 @@ discard block |
||
| 185 | 185 | } |
| 186 | 186 | |
| 187 | 187 | /** |
| 188 | - * @param $area |
|
| 189 | - * @param $order |
|
| 190 | - * @param $round |
|
| 188 | + * @param integer $area |
|
| 189 | + * @param integer $order |
|
| 190 | + * @param integer $round |
|
| 191 | 191 | * @param $parent |
| 192 | 192 | * @return FightersGroup |
| 193 | 193 | */ |
@@ -276,10 +276,14 @@ |
||
| 276 | 276 | function hasDeterminedParent() |
| 277 | 277 | { |
| 278 | 278 | |
| 279 | - if ($this->c1 != null && $this->c2 != null) return true; |
|
| 279 | + if ($this->c1 != null && $this->c2 != null) { |
|
| 280 | + return true; |
|
| 281 | + } |
|
| 280 | 282 | foreach ($this->group->children as $child) { |
| 281 | 283 | $fight = $child->fights->get(0); |
| 282 | - if ($fight->c1 != null && $fight->c2 != null) return false; |
|
| 284 | + if ($fight->c1 != null && $fight->c2 != null) { |
|
| 285 | + return false; |
|
| 286 | + } |
|
| 283 | 287 | } |
| 284 | 288 | return true; |
| 285 | 289 | } |
@@ -203,7 +203,9 @@ |
||
| 203 | 203 | foreach ($fightsByRound as $fight) { |
| 204 | 204 | |
| 205 | 205 | $parentGroup = $fight->group->parent; |
| 206 | - if ($parentGroup == null) break; |
|
| 206 | + if ($parentGroup == null) { |
|
| 207 | + break; |
|
| 208 | + } |
|
| 207 | 209 | $parentFight = $parentGroup->fights->get(0); //TODO This Might change when extending to Preliminary |
| 208 | 210 | |
| 209 | 211 | // IN this $fight, is c1 or c2 has the info? |
@@ -63,7 +63,7 @@ |
||
| 63 | 63 | ); |
| 64 | 64 | } |
| 65 | 65 | |
| 66 | - $championship->settings = ChampionshipSettings::createOrUpdate($request, $championship); |
|
| 66 | + $championship->settings = ChampionshipSettings::createOrUpdate($request, $championship); |
|
| 67 | 67 | $generation = $championship->chooseGenerationStrategy(); |
| 68 | 68 | |
| 69 | 69 | try { |