Completed
Push — master ( f65102...332511 )
by Julien
02:46
created
src/TreeGen/DirectEliminationTreeGen.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -86,7 +86,9 @@  discard block
 block discarded – undo
86 86
     {
87 87
         foreach ($fightsByRound as $fight) {
88 88
             $parentGroup = $fight->group->parent;
89
-            if ($parentGroup == null) break;
89
+            if ($parentGroup == null) {
90
+                break;
91
+            }
90 92
             $parentFight = $parentGroup->fights->get(0); //TODO This Might change when extending to Preliminary
91 93
 
92 94
             // IN this $fight, is c1 or c2 has the info?
@@ -160,10 +162,14 @@  discard block
 block discarded – undo
160 162
      */
161 163
     public function hasDeterminedParent()
162 164
     {
163
-        if ($this->group->has2Fighters()) return true;
165
+        if ($this->group->has2Fighters()) {
166
+            return true;
167
+        }
164 168
         foreach ($this->group->children as $child) {
165 169
             $fight = $child->fights->get(0);
166
-            if ($fight->has2Fighters()) return false;
170
+            if ($fight->has2Fighters()) {
171
+                return false;
172
+            }
167 173
         }
168 174
         return true;
169 175
     }
Please login to merge, or discard this patch.
src/models/Fight.php 1 patch
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -46,7 +46,9 @@  discard block
 block discarded – undo
46 46
      */
47 47
     protected static function getFightersWithByes(FightersGroup $group)
48 48
     {
49
-        if ($group == null) return null;
49
+        if ($group == null) {
50
+            return null;
51
+        }
50 52
         $fighters = $group->getFighters();
51 53
         $fighterType = $group->getFighterType();
52 54
         if (sizeof($fighters) == 0) {
@@ -167,18 +169,26 @@  discard block
 block discarded – undo
167 169
      */
168 170
     public function hasDeterminedParent()
169 171
     {
170
-        if ($this->has2Fighters()) return true;
172
+        if ($this->has2Fighters()) {
173
+            return true;
174
+        }
171 175
         foreach ($this->group->children as $child) {
172 176
             $fight = $child->fights->get(0);
173
-            if ($fight->has2Fighters()) return false;
177
+            if ($fight->has2Fighters()) {
178
+                return false;
179
+            }
174 180
         }
175 181
         return true;
176 182
     }
177 183
 
178 184
     public function shouldBeInFightList()
179 185
     {
180
-        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) return false;
181
-        if ($this->has2Fighters()) return true;
186
+        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) {
187
+            return false;
188
+        }
189
+        if ($this->has2Fighters()) {
190
+            return true;
191
+        }
182 192
         // We aint in the first round, and there is 1 or 0 competitor
183 193
         // We check children, and see :
184 194
         // if there is 2  - 2 fighters -> undetermine, we cannot add it to fight list
@@ -204,7 +214,9 @@  discard block
 block discarded – undo
204 214
     private function belongsToFirstRound()
205 215
     {
206 216
         $firstRoundFights = $this->group->championship->firstRoundFights->pluck('id')->toArray();
207
-        if (in_array($this->id, $firstRoundFights)) return true;
217
+        if (in_array($this->id, $firstRoundFights)) {
218
+            return true;
219
+        }
208 220
         return false;
209 221
     }
210 222
 
Please login to merge, or discard this patch.