xoco70 / laravel-tournaments

src/TreeGen/TreeGen.php

Doc Comments +9 added lines, -9 removed lines

@@ -48,7 +48,7 @@ 
 
     /**
      * Get the biggest entity group
-     * @param $userGroups
+     * @param Collection $userGroups
      *
      * @return int
      */
@@ -107,7 +107,7 @@ 
 
     /**
      * Repart BYE in the tree,
-     * @param $fighterGroups
+     * @param Collection $fighterGroups
      * @param int $max
      *
      * @return Collection
@@ -175,9 +175,9 @@ 
     }
 
     /**
-     * @param $area
-     * @param $order
-     * @param $round
+     * @param integer $area
+     * @param integer $order
+     * @param integer $round
      * @param $parent
      * @return FightersGroup
      */
@@ -338,8 +338,8 @@ 
 
     /**
      * @param Collection $fighters
-     * @param $frequency
-     * @param $sizeGroupBy
+     * @param integer $frequency
+     * @param integer $sizeGroupBy
      * @param $bye
      * @return Collection
      */
@@ -362,8 +362,8 @@ 
     /**
      * @param $frequency
      * @param $sizeGroupBy
-     * @param $count
-     * @param $byeCount
+     * @param integer $count
+     * @param integer $byeCount
      * @return bool
      */
     private function shouldInsertBye($frequency, $sizeGroupBy, $count, $byeCount): bool

src/TreeController.php

Unused Use Statements -2 removed lines

@@ -10,8 +10,6 @@
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\ChampionshipSettings;
 use Xoco70\KendoTournaments\Models\Competitor;
-use Xoco70\KendoTournaments\Models\Fight;
-use Xoco70\KendoTournaments\Models\FightersGroup;
 use Xoco70\KendoTournaments\Models\Tournament;
 
 class TreeController extends Controller

src/TreeGen/DirectEliminationTreeGen.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Illuminate\Support\Facades\App;
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\DirectEliminationFight;
-use Xoco70\KendoTournaments\Models\Fight;
 
 class DirectEliminationTreeGen extends TreeGen
 {

Braces +9 added lines, -3 removed lines

@@ -86,7 +86,9 @@ 
     {
         foreach ($fightsByRound as $fight) {
             $parentGroup = $fight->group->parent;
-            if ($parentGroup == null) break;
+            if ($parentGroup == null) {
+                break;
+            }
             $parentFight = $parentGroup->fights->get(0); //TODO This Might change when extending to Preliminary
 
             // IN this $fight, is c1 or c2 has the info?
@@ -160,10 +162,14 @@ 
      */
     public function hasDeterminedParent()
     {
-        if ($this->group->has2Fighters()) return true;
+        if ($this->group->has2Fighters()) {
+            return true;
+        }
         foreach ($this->group->children as $child) {
             $fight = $child->fights->get(0);
-            if ($fight->has2Fighters()) return false;
+            if ($fight->has2Fighters()) {
+                return false;
+            }
         }
         return true;
     }

src/TreeGen/PlayOffTreeGen.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\App;
 use Xoco70\KendoTournaments\Models\Championship;
-use Xoco70\KendoTournaments\Models\Fight;
 use Xoco70\KendoTournaments\Models\PreliminaryFight;
 
 class PlayOffTreeGen extends TreeGen

src/models/Fight.php

Braces +18 added lines, -6 removed lines

@@ -46,7 +46,9 @@ 
      */
     protected static function getFightersWithByes(FightersGroup $group)
     {
-        if ($group == null) return null;
+        if ($group == null) {
+            return null;
+        }
         $fighters = $group->getFighters();
         $fighterType = $group->getFighterType();
         if (sizeof($fighters) == 0) {
@@ -167,18 +169,26 @@ 
      */
     public function hasDeterminedParent()
     {
-        if ($this->has2Fighters()) return true;
+        if ($this->has2Fighters()) {
+            return true;
+        }
         foreach ($this->group->children as $child) {
             $fight = $child->fights->get(0);
-            if ($fight->has2Fighters()) return false;
+            if ($fight->has2Fighters()) {
+                return false;
+            }
         }
         return true;
     }
 
     public function shouldBeInFightList()
     {
-        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) return false;
-        if ($this->has2Fighters()) return true;
+        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) {
+            return false;
+        }
+        if ($this->has2Fighters()) {
+            return true;
+        }
         // We aint in the first round, and there is 1 or 0 competitor
         // We check children, and see :
         // if there is 2  - 2 fighters -> undetermine, we cannot add it to fight list
@@ -204,7 +214,9 @@ 
     private function belongsToFirstRound()
     {
         $firstRoundFights = $this->group->championship->firstRoundFights->pluck('id')->toArray();
-        if (in_array($this->id, $firstRoundFights)) return true;
+        if (in_array($this->id, $firstRoundFights)) {
+            return true;
+        }
         return false;
     }