DirectEliminationTreeGen - Code Metrics - Inspection of "refactor Seconds steps into differents generation" - xoco70/laravel-tournaments - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f65102...332511 )

by Julien

created 2017-05-25 04:45 UTC

DirectEliminationTreeGen A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	160
Duplicated Lines	23.75 %

Coupling/Cohesion

Components	3
Dependencies	3

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
dl	38
loc	160
c	2
b	1
f	0
wmc	28
lcom	3
cbo	3
rs	10

10 Methods

Rating	Name	Duplication	Size	Complexity
A	getByeGroup()	0	8	1
A	pushEmptyGroupsToTree()	0	6	1
A	chunkAndShuffle()	0	10	2
A	generateFights()	0	6	1
A	generateNextRoundsFights()	0	10	2
A	updateParentFight()	0	14	4
A	chooseAndUpdateParentFight()	0	10	3
B	getParentFighterToUpdate()	16	16	5
B	getValueToUpdate()	13	13	5
A	hasDeterminedParent()	9	9	4

How to fix Duplicated Code

<?php

namespace Xoco70\KendoTournaments\TreeGen;

use Illuminate\Support\Collection;
use Illuminate\Support\Facades\App;
use Xoco70\KendoTournaments\Models\Championship;
use Xoco70\KendoTournaments\Models\DirectEliminationFight;
use Xoco70\KendoTournaments\Models\Fight;

class DirectEliminationTreeGen extends TreeGen
{

    /**
     * Calculate the Byes need to fill the Championship Tree.
     * @param Championship $championship
     * @param $fighters
     * @return Collection
     */
    protected function getByeGroup(Championship $championship, $fighters)

    {
        $fighterCount = $fighters->count();
        $treeSize = $this->getTreeSize($fighterCount, 2);
        $byeCount = $treeSize - $fighterCount;

        return $this->createNullsGroup($byeCount);
    }


    /**
     * Create empty groups for direct Elimination Tree
     * @param $numFightersElim
     */
    public function pushEmptyGroupsToTree($numFightersElim)
    {
        // We calculate how much rounds we will have
        $numRounds = intval(log($numFightersElim, 2));
        $this->pushGroups($numRounds, $numFightersElim);
    }

    /**
     * Chunk Fighters into groups for fighting, and optionnaly shuffle
     * @param $fightersByEntity
     * @return Collection|null
     */
    protected function chunkAndShuffle($round = null, $fightersByEntity)

    {
        $fightersGroup = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $fightersGroup = $fightersByEntity->chunk(2);
        if (!App::runningUnitTests()) {
            $fightersGroup = $fightersGroup->shuffle();
        }
        return $fightersGroup;
    }


    /**
     * Generate First Round Fights
     */
    public function generateFights()
    {
        parent::destroyPreviousFights($this->championship);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        // Very specific case to common case : Preliminary with 3 fighters
        DirectEliminationFight::saveFights($this->championship);
    }
    /**
     *
     */
    public function generateNextRoundsFights()
    {
        $championship = $this->championship->withCount('teams', 'competitors')->first();
        $fightersCount = $championship->competitors_count + $championship->teams_count;
        $maxRounds = intval(ceil(log($fightersCount, 2)));
        for ($numRound = 1; $numRound < $maxRounds; $numRound++) {
            $fightsByRound = $championship->fightsByRound($numRound)->with('group.parent', 'group.children')->get();
            $this->updateParentFight($championship, $fightsByRound);
        }
    }

    /**
     * @param Championship $championship
     * @param $fightsByRound
     */
    private function updateParentFight(Championship $championship, $fightsByRound)
    {
        foreach ($fightsByRound as $fight) {
            $parentGroup = $fight->group->parent;
            if ($parentGroup == null) break;
            $parentFight = $parentGroup->fights->get(0); //TODO This Might change when extending to Preliminary

            // IN this $fight, is c1 or c2 has the info?
            if ($championship->isDirectEliminationType()) {
                // determine whether c1 or c2 must be updated
                $this->chooseAndUpdateParentFight($fight, $parentFight);
            }
        }
    }

    /**
     * @param $fight
     * @param $parentFight
     */
    private function chooseAndUpdateParentFight($fight, $parentFight)
    {
        $fighterToUpdate = $fight->getParentFighterToUpdate();
        $valueToUpdate = $fight->getValueToUpdate();
        // we need to know if the child has empty fighters, is this BYE or undetermined
        if ($fight->hasDeterminedParent() && $valueToUpdate != null) {
            $parentFight->$fighterToUpdate = $fight->$valueToUpdate;
            $parentFight->save();
        }
    }


    /**
     * Returns the parent field that need to be updated
     * @return null|string
     */
    public function getParentFighterToUpdate()

    {
        $childrenGroup = $this->group->parent->children;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        foreach ($childrenGroup as $key => $children) {
            $childFight = $children->fights->get(0);
            if ($childFight->id == $this->id) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
                if ($key % 2 == 0) {
                    return "c1";
                }
                if ($key % 2 == 1) {
                    return "c2";
                }
            }
        }
        return null;
    }

    /**
     * In the original fight ( child ) return the field that contains data to copy to parent
     * @return null|string
     */
    public function getValueToUpdate()

    {
        if ($this->c1 != null && $this->c2 != null) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return null;
        }
        if ($this->c1 != null) {
            return "c1";
        }
        if ($this->c2 != null) {
            return "c2";
        }
        return null;
    }

    /**
     * Check if we are able to fill the parent fight or not
     * If one of the children has c1 x c2, then we must wait to fill parent
     *
     * @return bool
     */
    public function hasDeterminedParent()

    {
        if ($this->group->has2Fighters()) return true;
        foreach ($this->group->children as $child) {
            $fight = $child->fights->get(0);
            if ($fight->has2Fighters()) return false;
        }
        return true;
    }
}


1		<?php
2
3		namespace Xoco70\KendoTournaments\TreeGen;
4
5		use Illuminate\Support\Collection;
6		use Illuminate\Support\Facades\App;
7		use Xoco70\KendoTournaments\Models\Championship;
8		use Xoco70\KendoTournaments\Models\DirectEliminationFight;
9		use Xoco70\KendoTournaments\Models\Fight;
10
11		class DirectEliminationTreeGen extends TreeGen
12		{
13
14		/**
15		* Calculate the Byes need to fill the Championship Tree.
16		* @param Championship $championship
17		* @param $fighters
18		* @return Collection
19		*/
20		protected function getByeGroup(Championship $championship, $fighters)
		0 ignored issues – show Unused Code introduced 2017-05-11 23:03 UTC by Report Bug Copy Issue Report The parameter `$championship` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
21		{
22		$fighterCount = $fighters->count();
23		$treeSize = $this->getTreeSize($fighterCount, 2);
24		$byeCount = $treeSize - $fighterCount;
25
26		return $this->createNullsGroup($byeCount);
27		}
28
29
30		/**
31		* Create empty groups for direct Elimination Tree
32		* @param $numFightersElim
33		*/
34		public function pushEmptyGroupsToTree($numFightersElim)
35		{
36		// We calculate how much rounds we will have
37		$numRounds = intval(log($numFightersElim, 2));
38		$this->pushGroups($numRounds, $numFightersElim);
39		}
40
41		/**
42		* Chunk Fighters into groups for fighting, and optionnaly shuffle
43		* @param $fightersByEntity
44		* @return Collection\|null
45		*/
46		protected function chunkAndShuffle($round = null, $fightersByEntity)
		0 ignored issues – show Unused Code introduced 2017-05-19 22:49 UTC by Report Bug Copy Issue Report The parameter `$round` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
47		{
48		$fightersGroup = null;
		0 ignored issues – show Unused Code introduced 2017-05-12 01:03 UTC by Report Bug Copy Issue Report `$fightersGroup` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
49
50		$fightersGroup = $fightersByEntity->chunk(2);
51		if (!App::runningUnitTests()) {
52		$fightersGroup = $fightersGroup->shuffle();
53		}
54		return $fightersGroup;
55		}
56
57
58		/**
59		* Generate First Round Fights
60		*/
61		public function generateFights()
62		{
63		parent::destroyPreviousFights($this->championship);
		0 ignored issues – show Comprehensibility Bug introduced 2017-05-25 04:48 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`destroyPreviousFights()` instead of `generateFights()`). Are you sure this is correct? If so, you might want to change this to `$this->destroyPreviousFights()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
64		// Very specific case to common case : Preliminary with 3 fighters
65		DirectEliminationFight::saveFights($this->championship);
66		}
67		/**
68		*
69		*/
70		public function generateNextRoundsFights()
71		{
72		$championship = $this->championship->withCount('teams', 'competitors')->first();
73		$fightersCount = $championship->competitors_count + $championship->teams_count;
74		$maxRounds = intval(ceil(log($fightersCount, 2)));
75		for ($numRound = 1; $numRound < $maxRounds; $numRound++) {
76		$fightsByRound = $championship->fightsByRound($numRound)->with('group.parent', 'group.children')->get();
77		$this->updateParentFight($championship, $fightsByRound);
78		}
79		}
80
81		/**
82		* @param Championship $championship
83		* @param $fightsByRound
84		*/
85		private function updateParentFight(Championship $championship, $fightsByRound)
86		{
87		foreach ($fightsByRound as $fight) {
88		$parentGroup = $fight->group->parent;
89		if ($parentGroup == null) break;
90		$parentFight = $parentGroup->fights->get(0); //TODO This Might change when extending to Preliminary
91
92		// IN this $fight, is c1 or c2 has the info?
93		if ($championship->isDirectEliminationType()) {
94		// determine whether c1 or c2 must be updated
95		$this->chooseAndUpdateParentFight($fight, $parentFight);
96		}
97		}
98		}
99
100		/**
101		* @param $fight
102		* @param $parentFight
103		*/
104		private function chooseAndUpdateParentFight($fight, $parentFight)
105		{
106		$fighterToUpdate = $fight->getParentFighterToUpdate();
107		$valueToUpdate = $fight->getValueToUpdate();
108		// we need to know if the child has empty fighters, is this BYE or undetermined
109		if ($fight->hasDeterminedParent() && $valueToUpdate != null) {
110		$parentFight->$fighterToUpdate = $fight->$valueToUpdate;
111		$parentFight->save();
112		}
113		}
114
115
116		/**
117		* Returns the parent field that need to be updated
118		* @return null\|string
119		*/
120	View Code Duplication	public function getParentFighterToUpdate()
		0 ignored issues – show Duplication introduced 2017-05-25 04:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121		{
122		$childrenGroup = $this->group->parent->children;
		0 ignored issues – show Bug introduced 2017-05-25 04:48 UTC by Report Bug Copy Issue Report The property `group` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
123		foreach ($childrenGroup as $key => $children) {
124		$childFight = $children->fights->get(0);
125		if ($childFight->id == $this->id) {
		0 ignored issues – show Bug introduced 2017-05-25 04:48 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
126		if ($key % 2 == 0) {
127		return "c1";
128		}
129		if ($key % 2 == 1) {
130		return "c2";
131		}
132		}
133		}
134		return null;
135		}
136
137		/**
138		* In the original fight ( child ) return the field that contains data to copy to parent
139		* @return null\|string
140		*/
141	View Code Duplication	public function getValueToUpdate()
		0 ignored issues – show Duplication introduced 2017-05-25 04:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
142		{
143		if ($this->c1 != null && $this->c2 != null) {
		0 ignored issues – show Bug introduced 2017-05-25 04:48 UTC by Report Bug Copy Issue Report The property `c1` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-05-25 04:48 UTC by Report Bug Copy Issue Report The property `c2` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
144		return null;
145		}
146		if ($this->c1 != null) {
147		return "c1";
148		}
149		if ($this->c2 != null) {
150		return "c2";
151		}
152		return null;
153		}
154
155		/**
156		* Check if we are able to fill the parent fight or not
157		* If one of the children has c1 x c2, then we must wait to fill parent
158		*
159		* @return bool
160		*/
161	View Code Duplication	public function hasDeterminedParent()
		0 ignored issues – show Duplication introduced 2017-05-25 04:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
162		{
163		if ($this->group->has2Fighters()) return true;
164		foreach ($this->group->children as $child) {
165		$fight = $child->fights->get(0);
166		if ($fight->has2Fighters()) return false;
167		}
168		return true;
169		}
170		}
171

xoco70 / laravel-tournaments

Push — master ( f65102...332511 )

DirectEliminationTreeGen A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like