@@ -58,7 +58,7 @@ |
||
58 | 58 | /** |
59 | 59 | * Save a Fight. |
60 | 60 | * |
61 | - * @param Collection $group |
|
61 | + * @param FightersGroup $group |
|
62 | 62 | * @param int $numGroup |
63 | 63 | * @param int $order |
64 | 64 | */ |
@@ -29,7 +29,7 @@ discard block |
||
29 | 29 | * |
30 | 30 | * @param $fightersByEntity |
31 | 31 | * |
32 | - * @return mixed |
|
32 | + * @return Collection |
|
33 | 33 | */ |
34 | 34 | protected function chunk(Collection $fightersByEntity) |
35 | 35 | { |
@@ -103,6 +103,9 @@ discard block |
||
103 | 103 | $this->generateGroupsForRound($fighters, 1); |
104 | 104 | } |
105 | 105 | |
106 | + /** |
|
107 | + * @param integer $round |
|
108 | + */ |
|
106 | 109 | protected function generateGroupsForRound(Collection $fightersByArea, $round) |
107 | 110 | { |
108 | 111 | $fightersId = $fightersByArea->pluck('id'); |
@@ -59,7 +59,7 @@ discard block |
||
59 | 59 | /** |
60 | 60 | * Create empty groups after round 1. |
61 | 61 | * |
62 | - * @param $numFighters |
|
62 | + * @param integer $numFighters |
|
63 | 63 | */ |
64 | 64 | protected function pushEmptyGroupsToTree($numFighters) |
65 | 65 | { |
@@ -162,7 +162,7 @@ discard block |
||
162 | 162 | |
163 | 163 | /** |
164 | 164 | * @param Collection $usersByArea |
165 | - * @param $round |
|
165 | + * @param integer $round |
|
166 | 166 | */ |
167 | 167 | public function generateGroupsForRound(Collection $usersByArea, $round) |
168 | 168 | { |
@@ -249,10 +249,11 @@ discard block |
||
249 | 249 | } |
250 | 250 | |
251 | 251 | /** |
252 | - * @param $frequency |
|
252 | + * @param integer $frequency |
|
253 | 253 | * @param $groupSize |
254 | - * @param $count |
|
255 | - * @param $byeCount |
|
254 | + * @param integer $count |
|
255 | + * @param integer $byeCount |
|
256 | + * @param integer $numByeTotal |
|
256 | 257 | * |
257 | 258 | * @return bool |
258 | 259 | */ |
@@ -293,7 +294,7 @@ discard block |
||
293 | 294 | /** |
294 | 295 | * Get the biggest entity group. |
295 | 296 | * |
296 | - * @param $userGroups |
|
297 | + * @param Collection $userGroups |
|
297 | 298 | * |
298 | 299 | * @return int |
299 | 300 | */ |
@@ -311,7 +312,7 @@ discard block |
||
311 | 312 | /** |
312 | 313 | * Repart BYE in the tree,. |
313 | 314 | * |
314 | - * @param $fighterGroups |
|
315 | + * @param Collection $fighterGroups |
|
315 | 316 | * @param int $max |
316 | 317 | * |
317 | 318 | * @return Collection |
@@ -301,7 +301,7 @@ |
||
301 | 301 | function getMaxFightersByEntity($userGroups): int |
302 | 302 | { |
303 | 303 | return $userGroups |
304 | - ->sortByDesc(function ($group) { |
|
304 | + ->sortByDesc(function($group) { |
|
305 | 305 | return $group->count(); |
306 | 306 | }) |
307 | 307 | ->first() |
@@ -21,6 +21,9 @@ discard block |
||
21 | 21 | |
22 | 22 | abstract protected function generateFights(); |
23 | 23 | |
24 | + /** |
|
25 | + * @param string|null $fighterToUpdate |
|
26 | + */ |
|
24 | 27 | abstract protected function addFighterToGroup(FightersGroup $group, $fighter, $fighterToUpdate); |
25 | 28 | |
26 | 29 | abstract protected function getByeGroup($fighters); |
@@ -84,7 +87,7 @@ discard block |
||
84 | 87 | * Get the size the first round will have. |
85 | 88 | * |
86 | 89 | * @param $fighterCount |
87 | - * @param $groupSize |
|
90 | + * @param integer $groupSize |
|
88 | 91 | * |
89 | 92 | * @return int |
90 | 93 | */ |
@@ -206,7 +209,7 @@ discard block |
||
206 | 209 | /** |
207 | 210 | * Logically build the tree ( attach a parent to every child for nestedSet Navigation ) |
208 | 211 | * |
209 | - * @param $numFighters |
|
212 | + * @param integer $numFighters |
|
210 | 213 | */ |
211 | 214 | protected function addParentToChildren($numFighters) |
212 | 215 | { |
@@ -91,7 +91,7 @@ discard block |
||
91 | 91 | protected function getTreeSize($fighterCount, $groupSize) |
92 | 92 | { |
93 | 93 | $squareMultiplied = collect([1, 2, 4, 8, 16, 32, 64]) |
94 | - ->map(function ($item) use ($groupSize) { |
|
94 | + ->map(function($item) use ($groupSize) { |
|
95 | 95 | return $item * $groupSize; |
96 | 96 | }); // [4, 8, 16, 32, 64,...] |
97 | 97 | |
@@ -197,10 +197,10 @@ discard block |
||
197 | 197 | protected function getFightersByArea() |
198 | 198 | { |
199 | 199 | $areas = $this->settings->fightingAreas; |
200 | - $fighters = $this->getFighters(); // Get Competitor or Team Objects |
|
201 | - $fighterByEntity = $this->getFightersByEntity($fighters); // Chunk it by entities (Fede, Assoc, Club,...) |
|
202 | - $fightersWithBye = $this->adjustFightersGroupWithByes($fighters, $fighterByEntity); // Fill with Byes |
|
203 | - return $fightersWithBye->chunk(count($fightersWithBye) / $areas); // Chunk user by areas |
|
200 | + $fighters = $this->getFighters(); // Get Competitor or Team Objects |
|
201 | + $fighterByEntity = $this->getFightersByEntity($fighters); // Chunk it by entities (Fede, Assoc, Club,...) |
|
202 | + $fightersWithBye = $this->adjustFightersGroupWithByes($fighters, $fighterByEntity); // Fill with Byes |
|
203 | + return $fightersWithBye->chunk(count($fightersWithBye) / $areas); // Chunk user by areas |
|
204 | 204 | } |
205 | 205 | |
206 | 206 | /** |