xoco70 / laravel-tournaments

src/TreeController.php

Unused Use Statements -2 removed lines

@@ -10,8 +10,6 @@
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\ChampionshipSettings;
 use Xoco70\KendoTournaments\Models\Competitor;
-use Xoco70\KendoTournaments\Models\Fight;
-use Xoco70\KendoTournaments\Models\FightersGroup;
 use Xoco70\KendoTournaments\Models\Team;
 use Xoco70\KendoTournaments\Models\Tournament;
 

src/TreeGen/CreateDirectEliminationTree.php

Doc Comments +2 added lines, -2 removed lines

@@ -233,7 +233,7 @@ 
     }
 
     /**
-     * @param $roundNumber
+     * @param integer $roundNumber
      */
     private function assignFightersToBracket($roundNumber)
     {
@@ -258,7 +258,7 @@ 
     /**
      * @param $selected
      * @param $fighter
-     * @param $html
+     * @param string $html
      * @return string
      */
     private function addOptionToSelect($selected, $fighter, $html): string

Spacing +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@ 
         $this->championship = $championship;
         $this->names = $names;
 
-        $this->firstRoundName = $names->first()->map(function ($item) use ($championship) {
+        $this->firstRoundName = $names->first()->map(function($item) use ($championship) {
             $fighters = $item->getFighters();
             $fighter1 = $fighters->get(0);
             $fighter2 = $fighters->get(1);
@@ -240,7 +240,7 @@ 
         for ($roundNumber = 1; $roundNumber <= $this->noRounds; $roundNumber++) {
             $groupsByRound = $this->names->get($roundNumber);
             for ($matchNumber = 1; $matchNumber <= ($this->noTeams / pow(2, $roundNumber)); $matchNumber++) {
-                $fight = $groupsByRound[$matchNumber-1]->fights[0];
+                $fight = $groupsByRound[$matchNumber - 1]->fights[0];
 
                 if ($this->championship->category->isTeam()) {
                     $fighter1 = $fight->team1;

src/TreeGen/PlayOffTreeGen.php

Doc Comments -1 removed lines

@@ -14,7 +14,6 @@
 
     /**
      * Calculate the Byes need to fill the Championship Tree.
-     * @param Championship $championship
      * @param $fighters
      * @return Collection
      */

src/TreeGen/DirectEliminationTreeGen.php

Spacing +2 added lines, -2 removed lines

@@ -68,9 +68,9 @@
      */
     public function generateNextRoundsFights()
     {
-        if ($this->championship->category->isTeam){
+        if ($this->championship->category->isTeam) {
             $championship = $this->championship->withCount('teams', 'competitors')->find(2);
-        }else{
+        } else {
             $championship = $this->championship->withCount('teams', 'competitors')->first();
         }
 

Braces +10 added lines, -4 removed lines

@@ -70,7 +70,7 @@ 
     {
         if ($this->championship->category->isTeam){
             $championship = $this->championship->withCount('teams', 'competitors')->find(2);
-        }else{
+        } else{
             $championship = $this->championship->withCount('teams', 'competitors')->first();
         }
 
@@ -90,7 +90,9 @@ 
     {
         foreach ($fightsByRound as $fight) {
             $parentGroup = $fight->group->parent;
-            if ($parentGroup == null) break;
+            if ($parentGroup == null) {
+                break;
+            }
             $parentFight = $parentGroup->fights->get(0); //TODO This Might change when extending to Preliminary
 
             // IN this $fight, is c1 or c2 has the info?
@@ -164,10 +166,14 @@ 
      */
     public function hasDeterminedParent()
     {
-        if ($this->group->has2Fighters()) return true;
+        if ($this->group->has2Fighters()) {
+            return true;
+        }
         foreach ($this->group->children as $child) {
             $fight = $child->fights->get(0);
-            if ($fight->has2Fighters()) return false;
+            if ($fight->has2Fighters()) {
+                return false;
+            }
         }
         return true;
     }

src/models/ChampionshipSettings.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
     public static function createOrUpdate(Request $request, Championship $championship): ChampionshipSettings
     {
         $request->request->add(['championship_id' => $championship->id]);
-        $arrSettings = $request->except('_token', 'numFighters','isTeam');
+        $arrSettings = $request->except('_token', 'numFighters', 'isTeam');
         $settings = static::where(['championship_id' => $championship->id])->first();
         if ($settings == null) {
             $settings = new self();

database/factories/TeamFactory.php

Spacing +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\Team;
 
-$factory->define(Team::class, function (Faker\Generator $faker) {
+$factory->define(Team::class, function(Faker\Generator $faker) {
     return [
         'name' => $faker->name,
         'championship_id' => Championship::find(2),

resources/views/tree/index.blade.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 $fightingAreas = $setting->fightingAreas;
 $fights = $championship->fights;
 $numFighters = $numFighters ??  5;
-$isTeam = $isTeam ??  0;;
+$isTeam = $isTeam ??  0; ;
 ?>
 @include('kendo-tournaments::partials.errors')