xoco70 / laravel-tournaments

src/models/Championship.php

Doc Comments +2 added lines, -1 removed lines

@@ -208,7 +208,7 @@ 
 
     /**
      * Return Groups that belongs to a round
-     * @param $round
+     * @param integer $round
      * @return HasMany
      */
     public function groupsByRound($round)
@@ -219,6 +219,7 @@ 
     /**
      * Return Fights that belongs to a round
      *
+     * @param integer $round
      * @return \Illuminate\Database\Eloquent\Relations\HasManyThrough
      */
     public function fightsByRound($round)

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Illuminate\Database\Eloquent\Relations\HasMany;
 use Illuminate\Database\Eloquent\SoftDeletes;
 use Illuminate\Foundation\Auth\User;
-use Illuminate\Support\Collection;
 
 class Championship extends Model
 {

Spacing +4 added lines, -4 removed lines

@@ -24,11 +24,11 @@ 
     {
         parent::boot();
 
-        static::deleting(function ($championship) {
+        static::deleting(function($championship) {
             $championship->competitors()->delete();
             $championship->settings()->delete();
         });
-        static::restoring(function ($championship) {
+        static::restoring(function($championship) {
             $championship->competitors()->restore();
             $championship->settings()->restore();
         });
@@ -213,7 +213,7 @@ 
      */
     public function groupsByRound($round)
     {
-        return $this->fightersGroups()->where('round',$round);
+        return $this->fightersGroups()->where('round', $round);
     }
 
     /**
@@ -223,6 +223,6 @@ 
      */
     public function fightsByRound($round)
     {
-        return $this->hasManyThrough(Fight::class, FightersGroup::class)->where('round',$round);
+        return $this->hasManyThrough(Fight::class, FightersGroup::class)->where('round', $round);
     }
 }

src/TreeGen/TreeGen.php

Doc Comments +11 added lines, -6 removed lines

@@ -226,8 +226,10 @@ 
     }
 
     /**
-     * @param $usersByArea
-     * @param $area
+     * @param Collection $usersByArea
+     * @param integer $area
+     * @param integer $round
+     * @param integer $shuffle
      *
      */
     public function generateGroupsForRound($usersByArea, $area, $round, $shuffle)
@@ -247,7 +249,7 @@ 
     /**
      * @param $fighters
      * @param $area
-     * @param $order
+     * @param integer $order
      * @param $round
      * @return FightersGroup
      */
@@ -312,6 +314,9 @@ 
             : new Competitor();
     }
 
+    /**
+     * @param integer $groupSize
+     */
     public function createByeGroup($groupSize): Collection
     {
         $byeFighter = $this->createByeFighter();
@@ -324,7 +329,7 @@ 
 
     /**
      * @param $fighters
-     * @param $fighterGroups
+     * @param Collection $fighterGroups
      * @return Collection
      */
     public function adjustFightersGroupWithByes($fighters, $fighterGroups): Collection
@@ -359,7 +364,7 @@ 
     /**
      * Get the next group on the right ( parent ), final round being the ancestor
      * @param $matchNumber
-     * @param $previousRound
+     * @param Collection $previousRound
      * @return mixed
      */
     private function getParentGroup($matchNumber, $previousRound)
@@ -371,7 +376,7 @@ 
 
     /**
      * Save Groups with their parent info
-     * @param $numRounds
+     * @param integer $numRounds
      * @param $numFightersEliminatory
      */
     private function pushGroups($numRounds, $numFightersEliminatory, $shuffle = true)

Spacing +2 added lines, -2 removed lines

@@ -130,7 +130,7 @@ 
     private function getTreeSize($fighterCount, $groupSize)
     {
         $square = collect([1, 2, 4, 8, 16, 32, 64]);
-        $squareMultiplied = $square->map(function ($item, $key) use ($groupSize) {
+        $squareMultiplied = $square->map(function($item, $key) use ($groupSize) {
             return $item * $groupSize;
         });
 
@@ -352,7 +352,7 @@ 
     private function getPreviousRound($currentRound)
     {
         $previousRound = $this->championship->groupsByRound($currentRound + 1)->get();
-        dump("previous". $previousRound->pluck('id'));
+        dump("previous" . $previousRound->pluck('id'));
         return $previousRound;
     }
 

Braces +9 added lines, -3 removed lines

@@ -255,7 +255,9 @@ 
     {
 
         $fighters = $fighters->pluck('id');
-        if ($shuffle) $fighters->shuffle();
+        if ($shuffle) {
+            $fighters->shuffle();
+        }
         $group = $this->saveGroup($area, $order, $round, $parent);
 
         // Add all competitors to Pivot Table
@@ -417,10 +419,14 @@ 
     {
         if ($this->championship->hasPreliminary()) {
             $fightersGroup = $fightersByEntity->chunk($this->settings->preliminaryGroupSize);
-            if ($shuffle) $fightersGroup->shuffle();
+            if ($shuffle) {
+                $fightersGroup->shuffle();
+            }
         } elseif ($this->championship->isDirectEliminationType() || $round > 1) {
             $fightersGroup = $fightersByEntity->chunk(2);
-            if ($shuffle) $fightersGroup->shuffle();
+            if ($shuffle) {
+                $fightersGroup->shuffle();
+            }
         } else { // Round Robin
             $fightersGroup = $fightersByEntity->chunk($fightersByEntity->count());
         }

database/factories/CompetitorFactory.php

Spacing +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\Competitor;
 
-$factory->define(Competitor::class, function (Faker\Generator $faker) {
+$factory->define(Competitor::class, function(Faker\Generator $faker) {
     $tcs = Championship::all()->pluck('id')->toArray();
     $users = User::all()->pluck('id')->toArray();
     $championshipId = $faker->randomElement($tcs);

src/TreeController.php

Spacing +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
         DB::table('fighters_group_competitor')->delete();
         DB::table('fighters_group_team')->delete();
         DB::table('competitor')->delete();
-        DB::table('users')->where('id','<>',1)->delete();
+        DB::table('users')->where('id', '<>', 1)->delete();
 
         $championship = Championship::with('teams', 'users', 'category', 'settings')->find($championship->id);
         $numFighters = $request->numFighters;

src/models/Fight.php

Braces +9 added lines, -3 removed lines

@@ -289,9 +289,15 @@
      */
     public function getValueToUpdate()
     {
-        if ($this->c1 != null && $this->c2 != null) return null;
-        if ($this->c1 != null) return "c1";
-        if ($this->c2 != null) return "c2";
+        if ($this->c1 != null && $this->c2 != null) {
+            return null;
+        }
+        if ($this->c1 != null) {
+            return "c1";
+        }
+        if ($this->c2 != null) {
+            return "c2";
+        }
         return null;
     }
 }
\ No newline at end of file

src/models/FightersGroup.php

Spacing +1 added lines, -1 removed lines

@@ -206,7 +206,7 @@
             foreach ($fightsByRound as $numFight => $fight) {
 
                 $parentGroup = $fight->group->parent;
-                if ($parentGroup == null ) break;
+                if ($parentGroup == null) break;
                 $parentFight = $parentGroup->fights->get(0);
 
                 // IN this $fight, if it is the first child or the second child --> c1 or c2 in parent

Braces +3 added lines, -1 removed lines

@@ -206,7 +206,9 @@
             foreach ($fightsByRound as $numFight => $fight) {
 
                 $parentGroup = $fight->group->parent;
-                if ($parentGroup == null ) break;
+                if ($parentGroup == null ) {
+                    break;
+                }
                 $parentFight = $parentGroup->fights->get(0);
 
                 // IN this $fight, if it is the first child or the second child --> c1 or c2 in parent

src/TreeGen/DirectEliminationTreeGen.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
         $this->championship = $championship;
         $this->names = $names;
 
-        $this->firstRoundName = $names->first()->map(function ($item) use ($championship) {
+        $this->firstRoundName = $names->first()->map(function($item) use ($championship) {
             $fighters = $item->getFighters();
             $fighter1 = $fighters->get(0);
             $fighter2 = $fighters->get(1);

Braces +3 added lines, -1 removed lines

@@ -53,7 +53,9 @@
         $matches = array_chunk($fighters, 2);
 
         //If there's already a match in the match array, then that means the next round is round 2, so increase the round number
-        if (count($this->brackets)) $roundNumber++;
+        if (count($this->brackets)) {
+            $roundNumber++;
+        }
 
         $countMatches = count($matches);
         //Create the first full round of fighters, some may be blank if waiting on the results of a previous round