xoco70 / laravel-tournaments

database/migrations/2016_10_24_223706_create_FightersGroup_table.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
      */
     public function up()
     {
-        Schema::create('fighters_groups', function (Blueprint $table) {
+        Schema::create('fighters_groups', function(Blueprint $table) {
             $table->increments('id');
             $table->tinyInteger('short_id')->unsigned()->nullable();
             $table->integer('championship_id')->unsigned()->index();

database/seeds/CompetitorSeeder.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 
-use Faker\Factory as Faker;
 use Illuminate\Database\Seeder;
 use Illuminate\Foundation\Auth\User;
 use Xoco70\KendoTournaments\Models\Championship;

src/models/Championship.php

Braces +3 added lines, -2 removed lines

@@ -169,8 +169,9 @@
 
     public function buildName()
     {
-        if ($this->settings != null && $this->settings->alias != null)
-            return $this->settings->alias;
+        if ($this->settings != null && $this->settings->alias != null) {
+                    return $this->settings->alias;
+        }
 
         if ($this->hasNoCustomSettings()) {
             return $this->category->name;

Spacing +3 added lines, -3 removed lines

@@ -29,11 +29,11 @@ 
     {
         parent::boot();
 
-        static::deleting(function ($championship) {
+        static::deleting(function($championship) {
             $championship->competitors()->delete();
             $championship->settings()->delete();
         });
-        static::restoring(function ($championship) {
+        static::restoring(function($championship) {
             $championship->competitors()->restore();
             $championship->settings()->restore();
         });
@@ -218,7 +218,7 @@ 
      */
     public function groupsFromRound($round)
     {
-        return $this->fightersGroups()->where('round','>=', $round);
+        return $this->fightersGroups()->where('round', '>=', $round);
     }
 
     /**

src/Models/DirectEliminationFight.php

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 
 namespace Xoco70\KendoTournaments\Models;
 
-use Illuminate\Database\Eloquent\Model;
-use Illuminate\Support\Collection;
-
 class DirectEliminationFight extends Fight
 {
 

src/TreeGen/TreeGen.php

Spacing +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
     private function getMaxFightersByEntity($userGroups): int
     {
         return $userGroups
-            ->sortByDesc(function ($group) {
+            ->sortByDesc(function($group) {
                 return $group->count();
             })
             ->first()
@@ -93,7 +93,7 @@ 
     protected function getTreeSize($fighterCount, $groupSize)
     {
         $square = collect([1, 2, 4, 8, 16, 32, 64]);
-        $squareMultiplied = $square->map(function ($item) use ($groupSize) {
+        $squareMultiplied = $square->map(function($item) use ($groupSize) {
             return $item * $groupSize;
         });
 

Doc Comments +9 added lines, -10 removed lines

@@ -52,7 +52,7 @@ 
 
     /**
      * Get the biggest entity group
-     * @param $userGroups
+     * @param Collection $userGroups
      *
      * @return int
      */
@@ -111,7 +111,7 @@ 
 
     /**
      * Repart BYE in the tree,
-     * @param $fighterGroups
+     * @param Collection $fighterGroups
      * @param int $max
      *
      * @return Collection
@@ -179,9 +179,9 @@ 
     }
 
     /**
-     * @param $area
-     * @param $order
-     * @param $round
+     * @param integer $area
+     * @param integer $order
+     * @param integer $round
      * @param $parent
      * @return FightersGroup
      */
@@ -326,8 +326,8 @@ 
 
     /**
      * @param Collection $fighters
-     * @param $frequency
-     * @param $sizeGroupBy
+     * @param integer $frequency
+     * @param integer $sizeGroupBy
      * @param $bye
      * @return Collection
      */
@@ -350,8 +350,8 @@ 
     /**
      * @param $frequency
      * @param $sizeGroupBy
-     * @param $count
-     * @param $byeCount
+     * @param integer $count
+     * @param integer $byeCount
      * @return bool
      */
     private function shouldInsertBye($frequency, $sizeGroupBy, $count, $byeCount): bool
@@ -361,7 +361,6 @@ 
 
 
     /**
-     * @param Championship $championship
      */
     protected function destroyPreviousFights()
     {

src/TreeGen/DirectEliminationTreeGen.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Illuminate\Support\Facades\App;
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\DirectEliminationFight;
-use Xoco70\KendoTournaments\Models\Fight;
 
 class DirectEliminationTreeGen extends TreeGen
 {

Braces +9 added lines, -3 removed lines

@@ -86,7 +86,9 @@ 
     {
         foreach ($fightsByRound as $fight) {
             $parentGroup = $fight->group->parent;
-            if ($parentGroup == null) break;
+            if ($parentGroup == null) {
+                break;
+            }
             $parentFight = $parentGroup->fights->get(0); //TODO This Might change when extending to Preliminary
 
             // IN this $fight, is c1 or c2 has the info?
@@ -160,10 +162,14 @@ 
      */
     public function hasDeterminedParent()
     {
-        if ($this->group->has2Fighters()) return true;
+        if ($this->group->has2Fighters()) {
+            return true;
+        }
         foreach ($this->group->children as $child) {
             $fight = $child->fights->get(0);
-            if ($fight->has2Fighters()) return false;
+            if ($fight->has2Fighters()) {
+                return false;
+            }
         }
         return true;
     }

Spacing +1 added lines, -1 removed lines

@@ -190,7 +190,7 @@
      * @param $numFighters
      * @return int
      */
-    public function getNumRounds($numFighters){
+    public function getNumRounds($numFighters) {
         return intval(log($numFighters, 2));
     }
 }

src/models/Fight.php

Braces +18 added lines, -6 removed lines

@@ -46,7 +46,9 @@ 
      */
     protected static function getFightersWithByes(FightersGroup $group)
     {
-        if ($group == null) return null;
+        if ($group == null) {
+            return null;
+        }
         $fighters = $group->getFighters();
         $fighterType = $group->getFighterType();
         if (sizeof($fighters) == 0) {
@@ -167,18 +169,26 @@ 
      */
     public function hasDeterminedParent()
     {
-        if ($this->has2Fighters()) return true;
+        if ($this->has2Fighters()) {
+            return true;
+        }
         foreach ($this->group->children as $child) {
             $fight = $child->fights->get(0);
-            if ($fight->has2Fighters()) return false;
+            if ($fight->has2Fighters()) {
+                return false;
+            }
         }
         return true;
     }
 
     public function shouldBeInFightList()
     {
-        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) return false;
-        if ($this->has2Fighters()) return true;
+        if ($this->belongsToFirstRound() && $this->dontHave2Fighters()) {
+            return false;
+        }
+        if ($this->has2Fighters()) {
+            return true;
+        }
         // We aint in the first round, and there is 1 or 0 competitor
         // We check children, and see :
         // if there is 2  - 2 fighters -> undetermine, we cannot add it to fight list
@@ -204,7 +214,9 @@ 
     private function belongsToFirstRound()
     {
         $firstRoundFights = $this->group->championship->firstRoundFights->pluck('id')->toArray();
-        if (in_array($this->id, $firstRoundFights)) return true;
+        if (in_array($this->id, $firstRoundFights)) {
+            return true;
+        }
         return false;
     }
 

src/TreeController.php

Unused Use Statements -2 removed lines

@@ -10,8 +10,6 @@
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\ChampionshipSettings;
 use Xoco70\KendoTournaments\Models\Competitor;
-use Xoco70\KendoTournaments\Models\Fight;
-use Xoco70\KendoTournaments\Models\FightersGroup;
 use Xoco70\KendoTournaments\Models\Team;
 use Xoco70\KendoTournaments\Models\Tournament;
 

src/TreeGen/CreateDirectEliminationTree.php

Doc Comments +2 added lines, -2 removed lines

@@ -233,7 +233,7 @@ 
     }
 
     /**
-     * @param $roundNumber
+     * @param integer $roundNumber
      */
     private function assignFightersToBracket($roundNumber)
     {
@@ -258,7 +258,7 @@ 
     /**
      * @param $selected
      * @param $fighter
-     * @param $html
+     * @param string $html
      * @return string
      */
     private function addOptionToSelect($selected, $fighter, $html): string

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
         $this->championship = $championship;
         $this->names = $names;
 
-        $this->firstRoundName = $names->first()->map(function ($item) use ($championship) {
+        $this->firstRoundName = $names->first()->map(function($item) use ($championship) {
             $fighters = $item->getFighters();
             $fighter1 = $fighters->get(0);
             $fighter2 = $fighters->get(1);