xoco70 / laravel-tournaments

src/TreeGen/PlayOffTreeGen.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Illuminate\Support\Facades\App;
 use Xoco70\KendoTournaments\Models\Championship;
 use Xoco70\KendoTournaments\Models\DirectEliminationFight;
-use Xoco70\KendoTournaments\Models\Fight;
 use Xoco70\KendoTournaments\Models\PreliminaryFight;
 
 class PlayOffTreeGen extends TreeGen

Spacing +4 added lines, -4 removed lines

@@ -37,7 +37,7 @@ 
     protected function pushGroups($numRounds, $numFightersElim)
     {
         // TODO Here is where you should change when enable several winners for preliminary
-        for ($roundNumber = 2; $roundNumber <= $numRounds +1; $roundNumber++) {
+        for ($roundNumber = 2; $roundNumber <= $numRounds + 1; $roundNumber++) {
             // From last match to first match
             $maxMatches = ($numFightersElim / pow(2, $roundNumber));
 
@@ -56,7 +56,7 @@ 
     {
         $numFightersElim = $numFighters / $this->championship->getSettings()->preliminaryGroupSize * 2;
         // We calculate how much rounds we will have
-        $numRounds = intval(log($numFightersElim, 2)) ; // 3 rounds, but begining from round 2 ( ie => 4)
+        $numRounds = intval(log($numFightersElim, 2)); // 3 rounds, but begining from round 2 ( ie => 4)
         $this->pushGroups($numRounds, $numFightersElim);
     }
 
@@ -104,7 +104,7 @@ 
     public function generateNextRoundsFights()
     {
         $fight = new DirectEliminationFight;
-        $fight->saveFights($this->championship,2);
+        $fight->saveFights($this->championship, 2);
     }
 
     /**
@@ -112,7 +112,7 @@ 
      * @param $numFighters
      * @return int
      */
-    public function getNumRounds($numFighters){
+    public function getNumRounds($numFighters) {
         return intval(log($numFighters / $this->championship->getSettings()->preliminaryGroupSize * 2, 2));
     }
 }

src/TreeGen/TreeGen.php

Doc Comments +9 added lines, -10 removed lines

@@ -52,7 +52,7 @@ 
 
     /**
      * Get the biggest entity group
-     * @param $userGroups
+     * @param Collection $userGroups
      *
      * @return int
      */
@@ -111,7 +111,7 @@ 
 
     /**
      * Repart BYE in the tree,
-     * @param $fighterGroups
+     * @param Collection $fighterGroups
      * @param int $max
      *
      * @return Collection
@@ -179,9 +179,9 @@ 
     }
 
     /**
-     * @param $area
-     * @param $order
-     * @param $round
+     * @param integer $area
+     * @param integer $order
+     * @param integer $round
      * @param $parent
      * @return FightersGroup
      */
@@ -326,8 +326,8 @@ 
 
     /**
      * @param Collection $fighters
-     * @param $frequency
-     * @param $sizeGroupBy
+     * @param integer $frequency
+     * @param integer $sizeGroupBy
      * @param $bye
      * @return Collection
      */
@@ -350,8 +350,8 @@ 
     /**
      * @param $frequency
      * @param $sizeGroupBy
-     * @param $count
-     * @param $byeCount
+     * @param integer $count
+     * @param integer $byeCount
      * @return bool
      */
     private function shouldInsertBye($frequency, $sizeGroupBy, $count, $byeCount): bool
@@ -361,7 +361,6 @@ 
 
 
     /**
-     * @param Championship $championship
      */
     protected function destroyPreviousFights()
     {

src/TreeGen/DirectEliminationTreeGen.php

Spacing +1 added lines, -1 removed lines

@@ -190,7 +190,7 @@
      * @param $numFighters
      * @return int
      */
-    public function getNumRounds($numFighters){
+    public function getNumRounds($numFighters) {
         return intval(log($numFighters, 2));
     }
 }

src/models/Championship.php

Spacing +3 added lines, -3 removed lines

@@ -29,11 +29,11 @@ 
     {
         parent::boot();
 
-        static::deleting(function ($championship) {
+        static::deleting(function($championship) {
             $championship->competitors()->delete();
             $championship->settings()->delete();
         });
-        static::restoring(function ($championship) {
+        static::restoring(function($championship) {
             $championship->competitors()->restore();
             $championship->settings()->restore();
         });
@@ -218,7 +218,7 @@ 
      */
     public function groupsFromRound($round)
     {
-        return $this->fightersGroups()->where('round','>=', $round);
+        return $this->fightersGroups()->where('round', '>=', $round);
     }
 
     /**