Competitor::getShortId() - Code Metrics - Inspection of "Bump lodash from 4.17.10 to 4.17.21" - xoco70/kendozone - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#53)

unknown

created 2021-05-06 17:35 UTC

Competitor::getShortId() A

↳ Parent: Competitor

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	2
dl	0
loc	9
ccs	6
cts	6
cp	1
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace App;

use Illuminate\Support\Facades\Auth;

class Competitor extends \Xoco70\LaravelTournaments\Models\Competitor
{
    public static function getShortId($categories, Tournament $tournament)
    {
        $competitor = static::where('user_id', Auth::user()->id)
            ->whereIn('championship_id', $categories)->first();

        if ($competitor != null) {
            return $competitor->short_id;

        }
        return $tournament->competitors()->max('short_id') + 1;
    }

    /**
     * @param $attributes
     * @return mixed $user
     */
    public static function createUser($attributes)
    {
        $user = User::where(['email' => $attributes['email']])->withTrashed()->first();

        if ($user == null) {
            $password = str_random(8);
            $user = User::create([
                'firstname' => $attributes['firstname'],
                'lastname' => $attributes['lastname'],
                'name' => $attributes['name'],
                'email' => $attributes['email']
            ]);
            $user->clearPassword = $password;
        }
        // If user is deleted, this is restoring the user only, but not his asset ( tournaments, categories, etc.)
        if ($user->isDeleted()) {
            $user->deleted_at = null;
            $user->save();
        }
        return $user;
    }
}


1		<?php
2
3		namespace App;
4
5		use Illuminate\Support\Facades\Auth;
6
7		class Competitor extends \Xoco70\LaravelTournaments\Models\Competitor
8		{
9	3	public static function getShortId($categories, Tournament $tournament)
10		{
11	3	$competitor = static::where('user_id', Auth::user()->id)
12	3	->whereIn('championship_id', $categories)->first();
13
14	3	if ($competitor != null) {
15	1	return $competitor->short_id;
		0 ignored issues – show Bug Best Practice introduced 2018-10-24 09:33 UTC by Report Bug Copy Issue Report The property `short_id` does not exist on `App\Competitor`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
16		}
17	3	return $tournament->competitors()->max('short_id') + 1;
18		}
19
20		/**
21		* @param $attributes
22		* @return mixed $user
23		*/
24	2	public static function createUser($attributes)
25		{
26	2	$user = User::where(['email' => $attributes['email']])->withTrashed()->first();
27
28	2	if ($user == null) {
29		$password = str_random(8);
30		$user = User::create([
31		'firstname' => $attributes['firstname'],
32		'lastname' => $attributes['lastname'],
33		'name' => $attributes['name'],
34		'email' => $attributes['email']
35		]);
36		$user->clearPassword = $password;
37		}
38		// If user is deleted, this is restoring the user only, but not his asset ( tournaments, categories, etc.)
39	2	if ($user->isDeleted()) {
40	1	$user->deleted_at = null;
41	1	$user->save();
42		}
43	2	return $user;
44		}
45		}
46

xoco70 / kendozone

Pull Request — master (#53)

Competitor::getShortId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like