App\Competitor

Complexity

Total Complexity

5

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Test Coverage

Coverage

65%

Importance

Changes	2
Bugs	2	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getShortId()	0	9	2
A	createUser()	0	20	3

<?php

namespace App;

use Illuminate\Support\Facades\Auth;

class Competitor extends \Xoco70\LaravelTournaments\Models\Competitor
{
    public static function getShortId($categories, Tournament $tournament)
    {
        $competitor = static::where('user_id', Auth::user()->id)
            ->whereIn('championship_id', $categories)->first();

        if ($competitor != null) {
            return $competitor->short_id;

The property short_id does not exist on App\Competitor. Since you implemented __get, consider adding a @property annotation.

        }
        return $tournament->competitors()->max('short_id') + 1;
    }

    /**
     * @param $attributes
     * @return mixed $user
     */
    public static function createUser($attributes)
    {
        $user = User::where(['email' => $attributes['email']])->withTrashed()->first();

        if ($user == null) {
            $password = str_random(8);
            $user = User::create([
                'firstname' => $attributes['firstname'],
                'lastname' => $attributes['lastname'],
                'name' => $attributes['name'],
                'email' => $attributes['email']
            ]);
            $user->clearPassword = $password;
        }
        // If user is deleted, this is restoring the user only, but not his asset ( tournaments, categories, etc.)
        if ($user->isDeleted()) {
            $user->deleted_at = null;
            $user->save();
        }
        return $user;
    }
}