App\Http\Controllers\UserAvatarController::store()

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1.512

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function store()
    {
        request()->validate([
            'file' => ['required', 'image']
        ]);
        $file = request()
            ->file('file')
            ->store(config('constants.RELATIVE_AVATAR_PATH'), 'public');

        Image::make(storage_path('app/public/' . $file))

Are you sure $file of type false|string can be used in concatenation?

            ->resize(200, 200, function ($constraint) {
                $constraint->aspectRatio();
                $constraint->upsize();
            })
            ->save();

        auth()->user()->update([
            'avatar' => basename($file)

It seems like $file can also be of type false; however, parameter $path of basename() does only seem to accept string, maybe add an additional type check?

        ]);
        return response([], 204);
    }