App\Http\Controllers\UserAvatarController

Complexity

Total Complexity

1

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Test Coverage

Coverage

20%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	store()	0	20	1

<?php

namespace App\Http\Controllers;


use Intervention\Image\Facades\Image;

class UserAvatarController extends Controller
{
    /**
     * Store a newly created resource in storage.
     *
     */
    public function store()
    {
        request()->validate([
            'file' => ['required', 'image']
        ]);
        $file = request()
            ->file('file')
            ->store(config('constants.RELATIVE_AVATAR_PATH'), 'public');

        Image::make(storage_path('app/public/' . $file))

Are you sure $file of type false|string can be used in concatenation?

            ->resize(200, 200, function ($constraint) {
                $constraint->aspectRatio();
                $constraint->upsize();
            })
            ->save();

        auth()->user()->update([
            'avatar' => basename($file)

It seems like $file can also be of type false; however, parameter $path of basename() does only seem to accept string, maybe add an additional type check?

        ]);
        return response([], 204);
    }
}