xchopin / LAWA-UL

public/index.php

Spacing +2 added lines, -2 removed lines

@@ -5,7 +5,7 @@ 
 use Symfony\Component\Dotenv\Dotenv;
 use Symfony\Component\HttpFoundation\Request;
 
-require __DIR__.'/../vendor/autoload.php';
+require __DIR__ . '/../vendor/autoload.php';
 
 session_start();
 
@@ -14,7 +14,7 @@ 
     if (!class_exists(Dotenv::class)) {
         throw new \RuntimeException('APP_ENV environment variable is not defined. You need to define environment variables for configuration or add "symfony/dotenv" as a Composer dependency to load variables from a .env file.');
     }
-    (new Dotenv())->load(__DIR__.'/../.env');
+    (new Dotenv())->load(__DIR__ . '/../.env');
 }
 
 if ($_SERVER['APP_DEBUG'] ?? ('prod' !== ($_SERVER['APP_ENV'] ?? 'dev'))) {

src/Kernel.php

Spacing +15 added lines, -15 removed lines

@@ -16,17 +16,17 @@ 
 
     public function getCacheDir()
     {
-        return $this->getProjectDir().'/var/cache/'.$this->environment;
+        return $this->getProjectDir() . '/var/cache/' . $this->environment;
     }
 
     public function getLogDir()
     {
-        return $this->getProjectDir().'/var/log';
+        return $this->getProjectDir() . '/var/log';
     }
 
     public function registerBundles()
     {
-        $contents = require $this->getProjectDir().'/config/bundles.php';
+        $contents = require $this->getProjectDir() . '/config/bundles.php';
         foreach ($contents as $class => $envs) {
             if (isset($envs['all']) || isset($envs[$this->environment])) {
                 yield new $class();
@@ -38,24 +38,24 @@ 
     {
         $container->setParameter('container.autowiring.strict_mode', true);
         $container->setParameter('container.dumper.inline_class_loader', true);
-        $confDir = $this->getProjectDir().'/config';
-        $loader->load($confDir.'/packages/*'.self::CONFIG_EXTS, 'glob');
-        if (is_dir($confDir.'/packages/'.$this->environment)) {
-            $loader->load($confDir.'/packages/'.$this->environment.'/**/*'.self::CONFIG_EXTS, 'glob');
+        $confDir = $this->getProjectDir() . '/config';
+        $loader->load($confDir . '/packages/*' . self::CONFIG_EXTS, 'glob');
+        if (is_dir($confDir . '/packages/' . $this->environment)) {
+            $loader->load($confDir . '/packages/' . $this->environment . '/**/*' . self::CONFIG_EXTS, 'glob');
         }
-        $loader->load($confDir.'/services'.self::CONFIG_EXTS, 'glob');
-        $loader->load($confDir.'/services_'.$this->environment.self::CONFIG_EXTS, 'glob');
+        $loader->load($confDir . '/services' . self::CONFIG_EXTS, 'glob');
+        $loader->load($confDir . '/services_' . $this->environment . self::CONFIG_EXTS, 'glob');
     }
 
     protected function configureRoutes(RouteCollectionBuilder $routes)
     {
-        $confDir = $this->getProjectDir().'/config';
-        if (is_dir($confDir.'/routes/')) {
-            $routes->import($confDir.'/routes/*'.self::CONFIG_EXTS, '/', 'glob');
+        $confDir = $this->getProjectDir() . '/config';
+        if (is_dir($confDir . '/routes/')) {
+            $routes->import($confDir . '/routes/*' . self::CONFIG_EXTS, '/', 'glob');
         }
-        if (is_dir($confDir.'/routes/'.$this->environment)) {
-            $routes->import($confDir.'/routes/'.$this->environment.'/**/*'.self::CONFIG_EXTS, '/', 'glob');
+        if (is_dir($confDir . '/routes/' . $this->environment)) {
+            $routes->import($confDir . '/routes/' . $this->environment . '/**/*' . self::CONFIG_EXTS, '/', 'glob');
         }
-        $routes->import($confDir.'/routes'.self::CONFIG_EXTS, '/', 'glob');
+        $routes->import($confDir . '/routes' . self::CONFIG_EXTS, '/', 'glob');
     }
 }

src/TwigExtension/TranslatorExtension.php

Indentation +4 added lines, -4 removed lines

@@ -83,10 +83,10 @@
      */
     public function languagesAvailable()
     {
-       $languages = [];
-       foreach ($this->container->getParameter('dictionaries') as $languageId => $dictionary) {
-           $languages += [ $dictionary['self_name'] => $languageId ];
-       }
+        $languages = [];
+        foreach ($this->container->getParameter('dictionaries') as $languageId => $dictionary) {
+            $languages += [ $dictionary['self_name'] => $languageId ];
+        }
         return $languages;
     }
 }

Spacing +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
     {
        $languages = [];
        foreach ($this->container->getParameter('dictionaries') as $languageId => $dictionary) {
-           $languages += [ $dictionary['self_name'] => $languageId ];
+           $languages += [$dictionary['self_name'] => $languageId];
        }
         return $languages;
     }

src/Event/AdminSubscriber.php

Spacing +1 added lines, -1 removed lines

@@ -43,6 +43,6 @@
 
     public static function getSubscribedEvents()
     {
-        return [ KernelEvents::CONTROLLER => 'onKernelController' ];
+        return [KernelEvents::CONTROLLER => 'onKernelController'];
     }
 }
\ No newline at end of file

Braces +9 added lines, -5 removed lines

@@ -36,17 +36,21 @@
         if ($controller[0] instanceof AdminAuthenticatedInterface) {
             $isAdmin = false;
             if (isset($_SESSION['phpCAS']['user'])) {
-                if (in_array($_SESSION['phpCAS']['user'], $this->administrators))
-                    $isAdmin = true;
+                if (in_array($_SESSION['phpCAS']['user'], $this->administrators)) {
+                                    $isAdmin = true;
+                }
+            }
+            if (!$isAdmin) {
+                throw new AccessDeniedHttpException('Access forbidden.');
             }
-            if (!$isAdmin) throw new AccessDeniedHttpException('Access forbidden.');
         }
     }
 
     public function onKernelRequest(GetResponseEvent $event)
     {
-        if (HttpKernel::MASTER_REQUEST != $event->getRequestType())
-            return;
+        if (HttpKernel::MASTER_REQUEST != $event->getRequestType()) {
+                    return;
+        }
     }
 
 

src/Event/LocaleListener.php

Spacing +1 added lines, -1 removed lines

@@ -58,6 +58,6 @@
 
     public static function getSubscribedEvents()
     {
-        return [ KernelEvents::REQUEST => [['onKernelRequest', 200]] ];
+        return [KernelEvents::REQUEST => [['onKernelRequest', 200]]];
     }
 }
\ No newline at end of file

Braces +3 added lines, -2 removed lines

@@ -33,8 +33,9 @@
      */
     public function onKernelRequest(GetResponseEvent $event)
     {
-        if (HttpKernel::MASTER_REQUEST != $event->getRequestType())
-            return;
+        if (HttpKernel::MASTER_REQUEST != $event->getRequestType()) {
+                    return;
+        }
 
         $this->registerLDAP();
         $this->registerCapsule();

src/Controller/AbstractController.php

Spacing +2 added lines, -2 removed lines

@@ -41,8 +41,8 @@
       */
     public static function generateJwt()
     {
-        $_SESSION['JWT'] = json_decode( self::$http->request('POST', 'api/auth/login', [
-            'headers' => [ 'X-Requested-With' => 'XMLHttpRequest' ],
+        $_SESSION['JWT'] = json_decode(self::$http->request('POST', 'api/auth/login', [
+            'headers' => ['X-Requested-With' => 'XMLHttpRequest'],
             'json' => [
                 'username' => env('API_USERNAME'),
                 'password' => env('API_PASSWORD')

Indentation +28 added lines, -28 removed lines

@@ -13,7 +13,7 @@ 
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
- abstract class AbstractController extends Controller
+    abstract class AbstractController extends Controller
 {
 
     /**
@@ -33,12 +33,12 @@ 
         $container->set('http', self::$http);
     }
 
-     /**
-      * Creates and return a JSON Web Token through the OpenLRW API by using credentials filled in .env
-      *
-      * @return mixed|\Psr\Http\Message\ResponseInterface
-      * @throws \GuzzleHttp\Exception\GuzzleException
-      */
+        /**
+         * Creates and return a JSON Web Token through the OpenLRW API by using credentials filled in .env
+         *
+         * @return mixed|\Psr\Http\Message\ResponseInterface
+         * @throws \GuzzleHttp\Exception\GuzzleException
+         */
     public static function generateJwt()
     {
         $_SESSION['JWT'] = json_decode( self::$http->request('POST', 'api/auth/login', [
@@ -48,7 +48,7 @@ 
                 'password' => env('API_PASSWORD')
             ]
         ])->getBody()
-          ->getContents())->token;
+            ->getContents())->token;
 
         return $_SESSION['JWT'];
 
@@ -124,26 +124,26 @@ 
         return ldap_get_entries($this->__get('ldap'), $this->searchLDAP($filter, $arg))[0];
     }
 
-     /**
-      * Function to check if OpenLRW is up
-      *
-      * @return boolean
-      * @throws \GuzzleHttp\Exception\GuzzleException
-      */
-     public static function isUp()
-     {
-         return self::$http->request('GET', '/info.json')->getStatusCode() == 200;
-     }
-
-     /**
-      * Get the logged username
-      *
-      * @return mixed
-      */
-     public static function loggedUser()
-     {
-         return $_SESSION['phpCAS']['user'];
-     }
+        /**
+         * Function to check if OpenLRW is up
+         *
+         * @return boolean
+         * @throws \GuzzleHttp\Exception\GuzzleException
+         */
+        public static function isUp()
+        {
+            return self::$http->request('GET', '/info.json')->getStatusCode() == 200;
+        }
+
+        /**
+         * Get the logged username
+         *
+         * @return mixed
+         */
+        public static function loggedUser()
+        {
+            return $_SESSION['phpCAS']['user'];
+        }
 
 
 }
\ No newline at end of file

src/Model/API/ApiModel.php

Spacing +2 added lines, -2 removed lines

@@ -60,8 +60,8 @@
      */
     public function post(String $route, array $args) // ToDo : add JWT
     {
-       return json_decode( self::$http->request('POST', $route, [
-           'headers' => [ 'X-Requested-With' => 'XMLHttpRequest' ],
+       return json_decode(self::$http->request('POST', $route, [
+           'headers' => ['X-Requested-With' => 'XMLHttpRequest'],
            'json' => $args
        ])->getBody()->getContents());
     }

Indentation +4 added lines, -4 removed lines

@@ -68,10 +68,10 @@
      */
     public function post(String $route, array $args) // ToDo : add JWT
     {
-       return json_decode( self::$http->request('POST', $route, [
-           'headers' => [ 'X-Requested-With' => 'XMLHttpRequest' ],
-           'json' => $args
-       ])->getBody()->getContents());
+        return json_decode( self::$http->request('POST', $route, [
+            'headers' => [ 'X-Requested-With' => 'XMLHttpRequest' ],
+            'json' => $args
+        ])->getBody()->getContents());
     }
 
 

src/Event/StudentSubscriber.php

Spacing +1 added lines, -1 removed lines

@@ -43,6 +43,6 @@
 
     public static function getSubscribedEvents()
     {
-        return [ KernelEvents::CONTROLLER => 'onKernelController' ];
+        return [KernelEvents::CONTROLLER => 'onKernelController'];
     }
 }
\ No newline at end of file

Braces +3 added lines, -2 removed lines

@@ -42,8 +42,9 @@
 
     public function onKernelRequest(GetResponseEvent $event)
     {
-        if (HttpKernel::MASTER_REQUEST != $event->getRequestType())
-            return;
+        if (HttpKernel::MASTER_REQUEST != $event->getRequestType()) {
+                    return;
+        }
     }
 
 

src/Controller/UserController.php

Spacing +3 added lines, -3 removed lines

@@ -43,7 +43,7 @@ 
         $events['moodle'] = null;
 
         if ($events['all'] != null) {
-            usort($events['all'], function ($a, $b) {
+            usort($events['all'], function($a, $b) {
                 return $a->eventTime < $b->eventTime;
             });
 
@@ -130,7 +130,7 @@ 
         $events = Klass::eventsForUser($id, self::loggedUser());
 
         if ($events != null)
-            usort($events, function($a, $b) {return $a->eventTime < $b->eventTime;});
+            usort($events, function($a, $b) {return $a->eventTime < $b->eventTime; });
 
         return $this->render('User/class.twig', [
             'class' => $class,
@@ -163,7 +163,7 @@ 
             }
 
             return $this->json($res);
-        }catch (Exception $e) {
+        } catch (Exception $e) {
             return new Response($e->getMessage(), 404);
         }
 

Braces +14 added lines, -9 removed lines

@@ -55,11 +55,13 @@ 
             foreach ($events['all'] as $event) {
                 $date = date('Y-m-d', strtotime($event->eventTime));
                 if ($event->object->{'@type'} == 'SoftwareApplication') {
-                    if (array_key_exists($date, $cas_events))
-                        array_push($cas_events[$date], $event);
+                    if (array_key_exists($date, $cas_events)) {
+                                            array_push($cas_events[$date], $event);
+                    }
                 } else {
-                    if (array_key_exists($date, $moodle_events))
-                        array_push($moodle_events[$date], $event);
+                    if (array_key_exists($date, $moodle_events)) {
+                                            array_push($moodle_events[$date], $event);
+                    }
                 }
             }
 
@@ -129,8 +131,10 @@ 
 
         $events = Klass::eventsForUser($id, self::loggedUser());
 
-        if ($events != null)
-            usort($events, function($a, $b) {return $a->eventTime < $b->eventTime;});
+        if ($events != null) {
+                    usort($events, function($a, $b) {return $a->eventTime < $b->eventTime;
+        }
+        });
 
         return $this->render('User/class.twig', [
             'class' => $class,
@@ -157,13 +161,14 @@ 
                 $res[$i]['date'] = $result->date;
                 $res[$i]['score'] = $result->score;
                 foreach ($lineItems as $lineItem) {
-                    if ($lineItem->sourcedId == $result->lineitem->sourcedId)
-                        $res[$i]['title'] = $lineItem->title;
+                    if ($lineItem->sourcedId == $result->lineitem->sourcedId) {
+                                            $res[$i]['title'] = $lineItem->title;
+                    }
                 } $i++;
             }
 
             return $this->json($res);
-        }catch (Exception $e) {
+        } catch (Exception $e) {
             return new Response($e->getMessage(), 404);
         }