x-tools / xtools

web/app_dev.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 // Feel free to remove this, extend it, or make something more sophisticated.
 if (isset($_SERVER['HTTP_CLIENT_IP'])
     || isset($_SERVER['HTTP_X_FORWARDED_FOR'])
-    || !( in_array(@$_SERVER['REMOTE_ADDR'], [ '127.0.0.1', 'fe80::1', '::1' ]) || php_sapi_name() === 'cli-server' )
+    || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1']) || php_sapi_name() === 'cli-server')
 ) {
     header('HTTP/1.0 403 Forbidden');
     exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');

src/AppBundle/Helper/PageviewsHelper.php

Spacing +3 added lines, -3 removed lines

@@ -12,8 +12,8 @@ 
         $title = str_replace(' ', '_', $title);
         $client = new GuzzleHttp\Client();
 
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
-            "$project/all-access/user/" . rawurlencode($title) . '/daily/' . $start . '/' . $end;
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
+            "$project/all-access/user/".rawurlencode($title).'/daily/'.$start.'/'.$end;
 
         $res = $client->request('GET', $url);
         return json_decode($res->getBody()->getContents());
@@ -32,7 +32,7 @@ 
         $data = $this->getLastDays($project, $title, $days);
 
         // FIXME: needs to handle gotchas
-        return array_sum(array_map(function ($item) {
+        return array_sum(array_map(function($item) {
             return $item->views;
         }, $data->items));
     }

src/AppBundle/Twig/Extension.php

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
         }
 
         // Find the path, and complain if English doesn't exist.
-        $path = $this->container->getParameter("kernel.root_dir") . '/../i18n';
+        $path = $this->container->getParameter("kernel.root_dir").'/../i18n';
         if (!file_exists("$path/en.json")) {
             throw new Exception("Language directory doesn't exist: $path");
         }

src/AppBundle/Controller/AdminStatsController.php

Spacing +1 added lines, -1 removed lines

@@ -176,7 +176,7 @@
 
         // Iterate over query results, loading each user id into the array
         while ($row = $res->fetch()) {
-            $adminIdArr[] = $row["user_id"] ;
+            $adminIdArr[] = $row["user_id"];
         }
 
         // Set the query results to be useful in a sql statement.

src/AppBundle/Controller/QuoteController.php

Spacing +2 added lines, -2 removed lines

@@ -111,7 +111,7 @@ 
             'quote/all.html.twig',
             [
                 'base_dir' => realpath(
-                    $this->getParameter('kernel.root_dir') . '/..'
+                    $this->getParameter('kernel.root_dir').'/..'
                 ),
                 'xtPage' => 'bash',
                 'quotes' => $quotes,
@@ -160,7 +160,7 @@ 
             'quote/view.html.twig',
             [
                 'base_dir' => realpath(
-                    $this->getParameter('kernel.root_dir') . '/..'
+                    $this->getParameter('kernel.root_dir').'/..'
                 ),
                 "xtPage" => "bash",
                 "text" => $text,

src/AppBundle/Controller/TopEditsController.php

Doc Comments +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
      * List top edits by this user for all pages in a particular namespace.
      * @param User $user The User.
      * @param Project $project The project.
-     * @param integer|string $namespaceId The namespace ID or 'all'
+     * @param integer $namespaceId The namespace ID or 'all'
      * @return \Symfony\Component\HttpFoundation\Response
      */
     protected function namespaceTopEdits(User $user, Project $project, $namespaceId)

Spacing +6 added lines, -6 removed lines

@@ -168,11 +168,11 @@ 
         }
 
         // Get page info about these 100 pages, so we can use their display title.
-        $titles = array_map(function ($e) use ($namespaces) {
+        $titles = array_map(function($e) use ($namespaces) {
             // If non-mainspace, prepend namespace to the titles.
             $ns = $e['page_namespace'];
-            $nsTitle = $ns > 0 ? $namespaces[$e['page_namespace']] . ':' : '';
-            return $nsTitle . $e['page_title'];
+            $nsTitle = $ns > 0 ? $namespaces[$e['page_namespace']].':' : '';
+            return $nsTitle.$e['page_title'];
         }, $editData);
 
         /** @var ApiHelper $apiHelper */
@@ -188,8 +188,8 @@ 
         foreach ($editData as $editDatum) {
             // If non-mainspace, prepend namespace to the titles.
             $ns = $editDatum['page_namespace'];
-            $nsTitle = $ns > 0 ? $namespaces[$editDatum['page_namespace']] . ':' : '';
-            $pageTitle = $nsTitle . $editDatum['page_title'];
+            $nsTitle = $ns > 0 ? $namespaces[$editDatum['page_namespace']].':' : '';
+            $pageTitle = $nsTitle.$editDatum['page_title'];
             $editDatum['displaytitle'] = $displayTitles[$pageTitle];
             // $editDatum['page_title'] is retained without the namespace
             //  so we can link to TopEdits for that page
@@ -249,7 +249,7 @@ 
         // Send all to the template.
         return $this->render('topedits/result_article.html.twig', [
             'xtPage' => 'topedits',
-            'xtTitle' => $user->getUsername() . ' - ' . $page->getTitle(),
+            'xtTitle' => $user->getUsername().' - '.$page->getTitle(),
             'project' => $project,
             'user' => $user,
             'page' => $page,

src/Xtools/ProjectRepository.php

Indentation +3 added lines, -3 removed lines

@@ -251,9 +251,9 @@
         $conn = $this->getProjectsConnection();
         $pageTable = $this->getTableName($project->getDatabaseName(), 'page');
         $query = "SELECT page_id "
-             . " FROM $pageTable "
-             . " WHERE page_namespace = :ns AND page_title = :title AND page_len > 0 "
-             . " LIMIT 1";
+                . " FROM $pageTable "
+                . " WHERE page_namespace = :ns AND page_title = :title AND page_len > 0 "
+                . " LIMIT 1";
         $params = [
             'ns' => $namespaceId,
             'title' => $pageTitle,

Spacing +3 added lines, -3 removed lines

@@ -146,7 +146,7 @@ 
                 if ($projMetadata['dbName'] == "$project"
                     || $projMetadata['url'] == "$project"
                     || $projMetadata['url'] == "https://$project") {
-                    $this->log->debug(__METHOD__ . " Using cached data for $project");
+                    $this->log->debug(__METHOD__." Using cached data for $project");
                     return $projMetadata;
                 }
             }
@@ -200,7 +200,7 @@ 
         }
 
         // Redis cache
-        $cacheKey = "projectMetadata." . preg_replace("/[^A-Za-z0-9]/", '', $projectUrl);
+        $cacheKey = "projectMetadata.".preg_replace("/[^A-Za-z0-9]/", '', $projectUrl);
         if ($this->cache->hasItem($cacheKey)) {
             $this->metadata = $this->cache->getItem($cacheKey)->get();
             return $this->metadata;
@@ -280,7 +280,7 @@ 
         $optedIn = $this->container->getParameter('opted_in');
         // In case there's just one given.
         if (!is_array($optedIn)) {
-            $optedIn = [ $optedIn ];
+            $optedIn = [$optedIn];
         }
         return $optedIn;
     }

src/AppBundle/Controller/AdminScoreController.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use DateTime;
 use Xtools\ProjectRepository;
 use Xtools\UserRepository;

Spacing +16 added lines, -16 removed lines

@@ -47,9 +47,9 @@ 
         $username = $request->query->get('username', $request->query->get('user'));
 
         if ($projectQuery != '' && $username != '') {
-            return $this->redirectToRoute('AdminScoreResult', [ 'project' => $projectQuery, 'username' => $username ]);
+            return $this->redirectToRoute('AdminScoreResult', ['project' => $projectQuery, 'username' => $username]);
         } elseif ($projectQuery != '' && $project === null) {
-            return $this->redirectToRoute('AdminScoreProject', [ 'project' => $projectQuery ]);
+            return $this->redirectToRoute('AdminScoreProject', ['project' => $projectQuery]);
         }
 
         // Set default project so we can populate the namespace selector.
@@ -95,20 +95,20 @@ 
         $archiveTable = $projectRepo->getTableName($dbName, 'archive');
 
         // MULTIPLIERS (to review)
-        $ACCT_AGE_MULT = 1.25;   # 0 if = 365 jours
-        $EDIT_COUNT_MULT = 1.25;     # 0 if = 10 000
-        $USER_PAGE_MULT = 0.1;     # 0 if =
+        $ACCT_AGE_MULT = 1.25; # 0 if = 365 jours
+        $EDIT_COUNT_MULT = 1.25; # 0 if = 10 000
+        $USER_PAGE_MULT = 0.1; # 0 if =
         $PATROLS_MULT = 1; # 0 if =
-        $BLOCKS_MULT = 1.4;     # 0 if = 10
+        $BLOCKS_MULT = 1.4; # 0 if = 10
         $AFD_MULT = 1.15;
-        $RECENT_ACTIVITY_MULT = 0.9;     # 0 if =
+        $RECENT_ACTIVITY_MULT = 0.9; # 0 if =
         $AIV_MULT = 1.15;
-        $EDIT_SUMMARIES_MULT = 0.8;   # 0 if =
-        $NAMESPACES_MULT = 1.0;     # 0 if =
+        $EDIT_SUMMARIES_MULT = 0.8; # 0 if =
+        $NAMESPACES_MULT = 1.0; # 0 if =
         $PAGES_CREATED_LIVE_MULT = 1.4; # 0 if =
         $PAGES_CREATED_ARCHIVE_MULT = 1.4; # 0 if =
-        $RPP_MULT = 1.15;     # 0 if =
-        $USERRIGHTS_MULT = 0.75;   # 0 if =
+        $RPP_MULT = 1.15; # 0 if =
+        $USERRIGHTS_MULT = 0.75; # 0 if =
 
         // Grab the connection to the replica database (which is separate from the above)
         $conn = $this->get('doctrine')->getManager("replicas")->getConnection();
@@ -186,15 +186,15 @@ 
                 $now = new DateTime();
                 $date = new DateTime($value);
                 $diff = $date->diff($now);
-                $formula = 365*$diff->format("%y")+30*$diff->format("%m")+$diff->format("%d");
+                $formula = 365 * $diff->format("%y")+30 * $diff->format("%m")+$diff->format("%d");
                 $value = $formula-365;
             }
 
             if ($key == "id") {
                 $id = $value;
             } else {
-                $multiplierKey = strtoupper($row["source"] . "_MULT");
-                $multiplier = ( isset($$multiplierKey) ? $$multiplierKey : 1 );
+                $multiplierKey = strtoupper($row["source"]."_MULT");
+                $multiplier = (isset($$multiplierKey) ? $$multiplierKey : 1);
                 $score = max(min($value * $multiplier, 100), -100);
                 $master[$key]["mult"] = $multiplier;
                 $master[$key]["value"] = $value;
@@ -204,8 +204,8 @@ 
         }
 
         if ($id == 0) {
-            $this->addFlash("notice", [ "no-result", $username ]);
-            return $this->redirectToRoute("AdminScore", [ "project"=>$project ]);
+            $this->addFlash("notice", ["no-result", $username]);
+            return $this->redirectToRoute("AdminScore", ["project"=>$project]);
         }
 
         return $this->render('adminscore/result.html.twig', [

src/AppBundle/Controller/DefaultController.php

Spacing +2 added lines, -2 removed lines

@@ -90,7 +90,7 @@ 
     public function loginAction()
     {
         try {
-            list( $next, $token ) = $this->getOauthClient()->initiate();
+            list($next, $token) = $this->getOauthClient()->initiate();
         } catch (Exception $oauthException) {
             throw $oauthException;
             // @TODO Make this work.
@@ -155,7 +155,7 @@ 
                     . '/index.php?title=Special:OAuth';
         $conf = new ClientConfig($endpoint);
         $consumerKey = $this->getParameter('oauth_key');
-        $consumerSecret =  $this->getParameter('oauth_secret');
+        $consumerSecret = $this->getParameter('oauth_secret');
         $conf->setConsumer(new Consumer($consumerKey, $consumerSecret));
         $this->oauthClient = new Client($conf);
         // Callback URL is hardcoded in the consumer registration.