Completed
Push — master ( f9a368...59d319 )
by
unknown
02:44
created

Page::getCheckWikiErrors()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 4
rs 10
c 0
b 0
f 0
cc 1
eloc 2
nc 1
nop 0
1
<?php
2
/**
3
 * This file contains only the Page class.
4
 */
5
6
namespace Xtools;
7
8
/**
9
 * A Page is a single wiki page in one project.
10
 */
11
class Page extends Model
12
{
13
14
    /** @var Project The project that this page belongs to. */
15
    protected $project;
16
17
    /** @var string The page name as provided at instantiation. */
18
    protected $unnormalizedPageName;
19
20
    /** @var string[] Metadata about this page. */
21
    protected $pageInfo;
22
23
    /** @var string[] Revision history of this page */
24
    protected $revisions;
25
26
    /**
27
     * Page constructor.
28
     * @param Project $project
29
     * @param string $pageName
30
     */
31
    public function __construct(Project $project, $pageName)
32
    {
33
        $this->project = $project;
34
        $this->unnormalizedPageName = $pageName;
35
    }
36
37
    /**
38
     * Get basic information about this page from the repository.
39
     * @return \string[]
40
     */
41
    protected function getPageInfo()
42
    {
43
        if (!$this->pageInfo) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->pageInfo of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
44
            $this->pageInfo = $this->getRepository()
1 ignored issue
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class Xtools\Repository as the method getPageInfo() does only exist in the following sub-classes of Xtools\Repository: Xtools\PagesRepository. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
45
                    ->getPageInfo($this->project, $this->unnormalizedPageName);
46
        }
47
        return $this->pageInfo;
48
    }
49
50
    /**
51
     * Get the page's title.
52
     * @return string
53
     */
54
    public function getTitle()
55
    {
56
        $info = $this->getPageInfo();
57
        return isset($info['title']) ? $info['title'] : $this->unnormalizedPageName;
58
    }
59
60
    /**
61
     * Get this page's database ID.
62
     * @return int
63
     */
64
    public function getId()
65
    {
66
        $info = $this->getPageInfo();
67
        return isset($info['pageid']) ? $info['pageid'] : null;
68
    }
69
70
    /**
71
     * Get this page's length in bytes.
72
     * @return int
73
     */
74
    public function getLength()
75
    {
76
        $info = $this->getPageInfo();
77
        return isset($info['length']) ? $info['length'] : null;
78
    }
79
80
    /**
81
     * Get HTML for the stylized display of the title.
82
     * The text will be the same as Page::getTitle().
83
     * @return string
84
     */
85
    public function getDisplayTitle()
86
    {
87
        $info = $this->getPageInfo();
88
        if (isset($info['displaytitle'])) {
89
            return $info['displaytitle'];
90
        }
91
        return $this->getTitle();
92
    }
93
94
    /**
95
     * Get the full URL of this page.
96
     * @return string
97
     */
98
    public function getUrl()
99
    {
100
        $info = $this->getPageInfo();
101
        return isset($info['fullurl']) ? $info['fullurl'] : null;
102
    }
103
104
    /**
105
     * Get the numerical ID of the namespace of this page.
106
     * @return int
107
     */
108
    public function getNamespace()
109
    {
110
        $info = $this->getPageInfo();
111
        return isset($info['ns']) ? $info['ns'] : null;
112
    }
113
114
    /**
115
     * Get the number of page watchers.
116
     * @return int
117
     */
118
    public function getWatchers()
119
    {
120
        $info = $this->getPageInfo();
121
        return isset($info['ns']) ? $info['ns'] : null;
122
    }
123
124
    /**
125
     * Whether or not this page exists.
126
     * @return bool
127
     */
128
    public function exists()
129
    {
130
        $info = $this->getPageInfo();
131
        return !isset($info['missing']);
132
    }
133
134
    /**
135
     * Get the Project to which this page belongs.
136
     * @return Project
137
     */
138
    public function getProject()
139
    {
140
        return $this->project;
141
    }
142
143
    /**
144
     * Get the language code for this page.
145
     * If not set, the language code for the project is returned.
146
     * @return string
147
     */
148
    public function getLang()
149
    {
150
        $info = $this->getPageInfo();
151
        if (isset($info['pagelanguage'])) {
152
            return $info['pagelanguage'];
153
        } else {
154
            return $this->getProject()->getLang();
155
        }
156
    }
157
158
    /**
159
     * Get the Wikidata ID of this page.
160
     * @return string
161
     */
162
    public function getWikidataId()
163
    {
164
        $info = $this->getPageInfo();
165
        if (isset($info['pageprops']['wikibase_item'])) {
166
            return $info['pageprops']['wikibase_item'];
167
        } else {
168
            return null;
169
        }
170
    }
171
172
    /**
173
     * Get the number of revisions the page has.
174
     * @param User $user Optionally limit to those of this user.
175
     * @return int
176
     */
177
    public function getNumRevisions(User $user = null)
178
    {
179
        // Return the count of revisions if already present
180
        if ($this->revisions) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->revisions of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
181
            return count($this->revisions);
182
        }
183
184
        // Otherwise do a COUNT in the event fetching
185
        // all revisions is not desired
186
        return $this->getRepository()->getNumRevisions($this, $user);
1 ignored issue
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class Xtools\Repository as the method getNumRevisions() does only exist in the following sub-classes of Xtools\Repository: Xtools\PagesRepository. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
187
    }
188
189
    /**
190
     * Get all edits made to this page.
191
     * @param User|null $user Specify to get only revisions by the given user.
192
     * @return array
193
     */
194
    public function getRevisions(User $user = null)
195
    {
196
        if ($this->revisions) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->revisions of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
197
            return $this->revisions;
198
        }
199
200
        $data = $this->getRepository()->getRevisions($this, $user);
1 ignored issue
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class Xtools\Repository as the method getRevisions() does only exist in the following sub-classes of Xtools\Repository: Xtools\EditCounterRepository, Xtools\PagesRepository. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
201
        $totalAdded = 0;
202
        $totalRemoved = 0;
203
        $revisions = [];
204 View Code Duplication
        foreach ($data as $revision) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
205
            if ($revision['length_change'] > 0) {
206
                $totalAdded += $revision['length_change'];
207
            } else {
208
                $totalRemoved += $revision['length_change'];
209
            }
210
            $revisions[] = $revision;
211
        }
212
        $this->revisions = $revisions;
213
214
        return $revisions;
215
    }
216
217
    /**
218
     * Get assessments of this page
219
     * @return string[]|false `false` if unsupported, or array in the format of:
220
     *         [
221
     *             'assessment' => 'C', // overall assessment
222
     *             'wikiprojects' => [
223
     *                 'Biography' => [
224
     *                     'assessment' => 'C',
225
     *                     'badge' => 'url',
226
     *                 ],
227
     *                 ...
228
     *             ],
229
     *             'wikiproject_prefix' => 'Wikipedia:WikiProject_',
230
     *         ]
231
     */
232
    public function getAssessments()
233
    {
234
        if (!$this->project->hasPageAssessments() || $this->getNamespace() !== 0) {
235
            return false;
236
        }
237
238
        $projectDomain = $this->project->getDomain();
239
        $config = $this->project->getRepository()->getAssessmentsConfig($projectDomain);
1 ignored issue
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class Xtools\Repository as the method getAssessmentsConfig() does only exist in the following sub-classes of Xtools\Repository: Xtools\ProjectRepository. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
240
        $data = $this->getRepository()->getAssessments($this->project, [$this->getId()]);
1 ignored issue
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class Xtools\Repository as the method getAssessments() does only exist in the following sub-classes of Xtools\Repository: Xtools\PagesRepository. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
241
242
        // Set the default decorations for the overall quality assessment
243
        // This will be replaced with the first valid class defined for any WikiProject
244
        $overallQuality = $config['class']['Unknown'];
245
        $overallQuality['value'] = '???';
246
247
        $decoratedAssessments = [];
248
249
        foreach ($data as $assessment) {
250
            $classValue = $assessment['class'];
251
252
            // Use ??? as the presented value when the class is unknown or is not defined in the config
253
            if ($classValue === 'Unknown' || $classValue === '' || !isset($config['class'][$classValue])) {
254
                $classAttrs = $config['class']['Unknown'];
255
                $assessment['class']['value'] = '???';
256
                $assessment['class']['category'] = $classAttrs['category'];
257
                $assessment['class']['color'] = $classAttrs['color'];
258
                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/"
259
                    . $classAttrs['badge'];
260
            } else {
261
                $classAttrs = $config['class'][$classValue];
262
                $assessment['class'] = [
263
                    'value' => $classValue,
264
                    'color' => $classAttrs['color'],
265
                    'category' => $classAttrs['category'],
266
                ];
267
268
                // add full URL to badge icon
269
                if ($classAttrs['badge'] !== '') {
270
                    $assessment['class']['badge'] = $this->project->getAssessmentBadgeURL($classValue);
271
                }
272
            }
273
274
            if ($overallQuality['value'] === '???') {
275
                $overallQuality = $assessment['class'];
276
                $overallQuality['category'] = $classAttrs['category'];
277
            }
278
279
            $importanceValue = $assessment['importance'];
280
            $importanceUnknown = $importanceValue === 'Unknown' || $importanceValue === '';
281
282
            if ($importanceUnknown || !isset($config['importance'][$importanceValue])) {
283
                $importanceAttrs = $config['importance']['Unknown'];
284
                $assessment['importance'] = $importanceAttrs;
285
                $assessment['importance']['value'] = '???';
286
                $assessment['importance']['category'] = $importanceAttrs['category'];
287
            } else {
288
                $importanceAttrs = $config['importance'][$importanceValue];
289
                $assessment['importance'] = [
290
                    'value' => $importanceValue,
291
                    'color' => $importanceAttrs['color'],
292
                    'weight' => $importanceAttrs['weight'], // numerical weight for sorting purposes
293
                    'category' => $importanceAttrs['category'],
294
                ];
295
            }
296
297
            $decoratedAssessments[$assessment['wikiproject']] = $assessment;
298
        }
299
300
        return [
301
            'assessment' => $overallQuality,
302
            'wikiprojects' => $decoratedAssessments,
303
            'wikiproject_prefix' => $config['wikiproject_prefix']
304
        ];
305
    }
306
307
    /**
308
     * Get CheckWiki errors for this page
309
     * @return string[] See getErrors() for format
310
     */
311
    public function getCheckWikiErrors()
312
    {
313
        return $this->getRepository()->getCheckWikiErrors($this);
1 ignored issue
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class Xtools\Repository as the method getCheckWikiErrors() does only exist in the following sub-classes of Xtools\Repository: Xtools\PagesRepository. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
314
    }
315
316
    /**
317
     * Get Wikidata errors for this page
318
     * @return string[] See getErrors() for format
319
     */
320
    public function getWikidataErrors()
321
    {
322
        $errors = [];
323
324
        if (empty($this->getWikidataId())) {
325
            return [];
326
        }
327
328
        $wikidataInfo = $this->getRepository()->getWikidataInfo($this);
1 ignored issue
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class Xtools\Repository as the method getWikidataInfo() does only exist in the following sub-classes of Xtools\Repository: Xtools\PagesRepository. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
329
330
        $terms = array_map(function ($entry) {
331
            return $entry['term'];
332
        }, $wikidataInfo);
333
334
        $lang = $this->getLang();
335
336 View Code Duplication
        if (!in_array('label', $terms)) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
337
            $errors[] = [
338
                'prio' => 2,
339
                'name' => 'Wikidata',
340
                'notice' => "Label for language <em>$lang</em> is missing", // FIXME: i18n
341
                'explanation' => "See: <a target='_blank' " .
342
                    "href='//www.wikidata.org/wiki/Help:Label'>Help:Label</a>",
343
            ];
344
        }
345
346 View Code Duplication
        if (!in_array('description', $terms)) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
347
            $errors[] = [
348
                'prio' => 3,
349
                'name' => 'Wikidata',
350
                'notice' => "Description for language <em>$lang</em> is missing", // FIXME: i18n
351
                'explanation' => "See: <a target='_blank' " .
352
                    "href='//www.wikidata.org/wiki/Help:Description'>Help:Description</a>",
353
            ];
354
        }
355
356
        return $errors;
357
    }
358
359
    /**
360
     * Get Wikidata and CheckWiki errors, if present
361
     * @return string[] List of errors in the format:
362
     *    [[
363
     *         'prio' => int,
364
     *         'name' => string,
365
     *         'notice' => string (HTML),
366
     *         'explanation' => string (HTML)
367
     *     ], ... ]
368
     */
369
    public function getErrors()
370
    {
371
        // Includes label and description
372
        $wikidataErrors = $this->getWikidataErrors();
373
374
        $checkWikiErrors = $this->getCheckWikiErrors();
375
376
        return array_merge($wikidataErrors, $checkWikiErrors);
377
    }
378
379
    /**
380
     * Get all wikidata items for the page, not just languages of sister projects
381
     * @param Page $page
0 ignored issues
show
Bug introduced by
There is no parameter named $page. Was it maybe removed?

This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.

Consider the following example. The parameter $italy is not defined by the method finale(...).

/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}

The most likely cause is that the parameter was removed, but the annotation was not.

Loading history...
382
     * @return int Number of records.
383
     */
384
    public function getWikidataItems()
385
    {
386
        return $this->getRepository()->getWikidataItems($this);
1 ignored issue
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class Xtools\Repository as the method getWikidataItems() does only exist in the following sub-classes of Xtools\Repository: Xtools\PagesRepository. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
387
    }
388
389
    /**
390
     * Count wikidata items for the page, not just languages of sister projects
391
     * @param Page $page
0 ignored issues
show
Bug introduced by
There is no parameter named $page. Was it maybe removed?

This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.

Consider the following example. The parameter $italy is not defined by the method finale(...).

/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}

The most likely cause is that the parameter was removed, but the annotation was not.

Loading history...
392
     * @return int Number of records.
393
     */
394
    public function countWikidataItems()
395
    {
396
        return $this->getRepository()->countWikidataItems($this);
1 ignored issue
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class Xtools\Repository as the method countWikidataItems() does only exist in the following sub-classes of Xtools\Repository: Xtools\PagesRepository. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
397
    }
398
}
399