Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Page often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Page, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 11 | class Page extends Model |
||
| 12 | { |
||
| 13 | |||
| 14 | /** @var Project The project that this page belongs to. */ |
||
| 15 | protected $project; |
||
| 16 | |||
| 17 | /** @var string The page name as provided at instantiation. */ |
||
| 18 | protected $unnormalizedPageName; |
||
| 19 | |||
| 20 | /** @var string[] Metadata about this page. */ |
||
| 21 | protected $pageInfo; |
||
| 22 | |||
| 23 | /** @var string[] Revision history of this page */ |
||
| 24 | protected $revisions; |
||
| 25 | |||
| 26 | /** |
||
| 27 | * Page constructor. |
||
| 28 | * @param Project $project |
||
| 29 | * @param string $pageName |
||
| 30 | */ |
||
| 31 | public function __construct(Project $project, $pageName) |
||
| 36 | |||
| 37 | /** |
||
| 38 | * Get basic information about this page from the repository. |
||
| 39 | * @return \string[] |
||
| 40 | */ |
||
| 41 | protected function getPageInfo() |
||
| 49 | |||
| 50 | /** |
||
| 51 | * Get the page's title. |
||
| 52 | * @return string |
||
| 53 | */ |
||
| 54 | public function getTitle() |
||
| 59 | |||
| 60 | /** |
||
| 61 | * Get this page's database ID. |
||
| 62 | * @return int |
||
| 63 | */ |
||
| 64 | public function getId() |
||
| 69 | |||
| 70 | /** |
||
| 71 | * Get this page's length in bytes. |
||
| 72 | * @return int |
||
| 73 | */ |
||
| 74 | public function getLength() |
||
| 79 | |||
| 80 | /** |
||
| 81 | * Get HTML for the stylized display of the title. |
||
| 82 | * The text will be the same as Page::getTitle(). |
||
| 83 | * @return string |
||
| 84 | */ |
||
| 85 | public function getDisplayTitle() |
||
| 93 | |||
| 94 | /** |
||
| 95 | * Get the full URL of this page. |
||
| 96 | * @return string |
||
| 97 | */ |
||
| 98 | public function getUrl() |
||
| 103 | |||
| 104 | /** |
||
| 105 | * Get the numerical ID of the namespace of this page. |
||
| 106 | * @return int |
||
| 107 | */ |
||
| 108 | public function getNamespace() |
||
| 113 | |||
| 114 | /** |
||
| 115 | * Get the number of page watchers. |
||
| 116 | * @return int |
||
| 117 | */ |
||
| 118 | public function getWatchers() |
||
| 123 | |||
| 124 | /** |
||
| 125 | * Whether or not this page exists. |
||
| 126 | * @return bool |
||
| 127 | */ |
||
| 128 | public function exists() |
||
| 133 | |||
| 134 | /** |
||
| 135 | * Get the Project to which this page belongs. |
||
| 136 | * @return Project |
||
| 137 | */ |
||
| 138 | public function getProject() |
||
| 142 | |||
| 143 | /** |
||
| 144 | * Get the language code for this page. |
||
| 145 | * If not set, the language code for the project is returned. |
||
| 146 | * @return string |
||
| 147 | */ |
||
| 148 | public function getLang() |
||
| 157 | |||
| 158 | /** |
||
| 159 | * Get the Wikidata ID of this page. |
||
| 160 | * @return string |
||
| 161 | */ |
||
| 162 | public function getWikidataId() |
||
| 171 | |||
| 172 | /** |
||
| 173 | * Get the number of revisions the page has. |
||
| 174 | * @param User $user Optionally limit to those of this user. |
||
| 175 | * @return int |
||
| 176 | */ |
||
| 177 | public function getNumRevisions(User $user = null) |
||
| 188 | |||
| 189 | /** |
||
| 190 | * Get all edits made to this page. |
||
| 191 | * @param User|null $user Specify to get only revisions by the given user. |
||
| 192 | * @return array |
||
| 193 | */ |
||
| 194 | public function getRevisions(User $user = null) |
||
| 216 | |||
| 217 | /** |
||
| 218 | * Get assessments of this page |
||
| 219 | * @return string[]|false `false` if unsupported, or array in the format of: |
||
| 220 | * [ |
||
| 221 | * 'assessment' => 'C', // overall assessment |
||
| 222 | * 'wikiprojects' => [ |
||
| 223 | * 'Biography' => [ |
||
| 224 | * 'assessment' => 'C', |
||
| 225 | * 'badge' => 'url', |
||
| 226 | * ], |
||
| 227 | * ... |
||
| 228 | * ], |
||
| 229 | * 'wikiproject_prefix' => 'Wikipedia:WikiProject_', |
||
| 230 | * ] |
||
| 231 | */ |
||
| 232 | public function getAssessments() |
||
| 306 | |||
| 307 | /** |
||
| 308 | * Get CheckWiki errors for this page |
||
| 309 | * @return string[] See getErrors() for format |
||
| 310 | */ |
||
| 311 | public function getCheckWikiErrors() |
||
| 315 | |||
| 316 | /** |
||
| 317 | * Get Wikidata errors for this page |
||
| 318 | * @return string[] See getErrors() for format |
||
| 319 | */ |
||
| 320 | public function getWikidataErrors() |
||
| 358 | |||
| 359 | /** |
||
| 360 | * Get Wikidata and CheckWiki errors, if present |
||
| 361 | * @return string[] List of errors in the format: |
||
| 362 | * [[ |
||
| 363 | * 'prio' => int, |
||
| 364 | * 'name' => string, |
||
| 365 | * 'notice' => string (HTML), |
||
| 366 | * 'explanation' => string (HTML) |
||
| 367 | * ], ... ] |
||
| 368 | */ |
||
| 369 | public function getErrors() |
||
| 378 | |||
| 379 | /** |
||
| 380 | * Get all wikidata items for the page, not just languages of sister projects |
||
| 381 | * @param Page $page |
||
| 382 | * @return int Number of records. |
||
| 383 | */ |
||
| 384 | public function getWikidataItems() |
||
| 388 | |||
| 389 | /** |
||
| 390 | * Count wikidata items for the page, not just languages of sister projects |
||
| 391 | * @param Page $page |
||
| 392 | * @return int Number of records. |
||
| 393 | */ |
||
| 394 | public function countWikidataItems() |
||
| 398 | } |
||
| 399 |
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.