x-tools / xtools

src/AppBundle/Controller/ApiController.php

Unused Use Statements -6 removed lines

@@ -5,21 +5,15 @@
 
 namespace AppBundle\Controller;
 
-use Exception;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Debug\Exception\FatalErrorException;
 use FOS\RestBundle\Controller\Annotations as Rest;
 use FOS\RestBundle\Controller\FOSRestController;
 use FOS\RestBundle\View\View;
 use Xtools\ProjectRepository;
 use Xtools\UserRepository;
-use Xtools\Page;
-use Xtools\PagesRepository;
 use Xtools\Edit;
-use DateTime;
 
 /**
  * Serves the external API of XTools.

Spacing +4 added lines, -4 removed lines

@@ -131,7 +131,7 @@ 
             $res['automated_editcount'] = $user->countAutomatedEdits($project, $namespace, $start, $end);
         }
 
-        $res['nonautomated_editcount'] = $res['total_editcount'] - $res['automated_editcount'];
+        $res['nonautomated_editcount'] = $res['total_editcount']-$res['automated_editcount'];
 
         $view = View::create()->setStatusCode(Response::HTTP_OK);
         $view->setData($res);
@@ -176,8 +176,8 @@ 
             if ($request->query->get('format') !== 'html') {
                 return new View(
                     [
-                        'error' => 'Unable to show any data. User has made over ' .
-                            $user->maxEdits() . ' edits.',
+                        'error' => 'Unable to show any data. User has made over '.
+                            $user->maxEdits().' edits.',
                     ],
                     Response::HTTP_FORBIDDEN
                 );
@@ -192,7 +192,7 @@ 
 
         if ($request->query->get('format') === 'html') {
             if ($edits) {
-                $edits = array_map(function ($attrs) use ($project, $username) {
+                $edits = array_map(function($attrs) use ($project, $username) {
                     $page = $project->getRepository()
                         ->getPage($project, $attrs['full_page_title']);
                     $pageTitles[] = $attrs['full_page_title'];

src/AppBundle/Controller/ArticleInfoController.php

Doc Comments +1 added lines, -1 removed lines

@@ -187,7 +187,7 @@
      * @param Request $request The HTTP request.
      * @param string $project
      * @param string $article
-     * @return View
+     * @return Response
      */
     public function articleInfo(Request $request, $project, $article)
     {

Spacing +13 added lines, -13 removed lines

@@ -85,10 +85,10 @@ 
             $rendered = str_replace('"', '\"', trim($rendered));
 
             // Uglify temporary file.
-            $tmpFile = sys_get_temp_dir() . '/xtools_articleinfo_gadget.js';
+            $tmpFile = sys_get_temp_dir().'/xtools_articleinfo_gadget.js';
             $script = "echo \"$rendered\" | tee $tmpFile >/dev/null && ";
-            $script .= $this->get('kernel')->getRootDir() .
-                "/Resources/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle " .
+            $script .= $this->get('kernel')->getRootDir().
+                "/Resources/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle ".
                 "&& rm $tmpFile >/dev/null";
             $process = new Process($script);
             $process->run();
@@ -107,10 +107,10 @@ 
             $rendered = str_replace('\"', '"', trim($rendered));
 
             // Add comment after uglifying since it removes comments.
-            $rendered = "/**\n * This code was automatically generated and should not " .
-                "be manually edited.\n * For updates, please copy and paste from " .
-                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL) .
-                "\n * Released under GPL v3 license.\n */\n" . $rendered;
+            $rendered = "/**\n * This code was automatically generated and should not ".
+                "be manually edited.\n * For updates, please copy and paste from ".
+                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL).
+                "\n * Released under GPL v3 license.\n */\n".$rendered;
         }
 
         $response = new \Symfony\Component\HttpFoundation\Response($rendered);
@@ -213,19 +213,19 @@ 
         $info = $page->getBasicEditingInfo();
         $creationDateTime = DateTime::createFromFormat('YmdHis', $info['created_at']);
         $modifiedDateTime = DateTime::createFromFormat('YmdHis', $info['modified_at']);
-        $secsSinceLastEdit = (new DateTime)->getTimestamp() - $modifiedDateTime->getTimestamp();
+        $secsSinceLastEdit = (new DateTime)->getTimestamp()-$modifiedDateTime->getTimestamp();
 
         $data = [
-            'revisions' => (int) $info['num_edits'],
-            'editors' => (int) $info['num_editors'],
+            'revisions' => (int)$info['num_edits'],
+            'editors' => (int)$info['num_editors'],
             'author' => $info['author'],
-            'author_editcount' => (int) $info['author_editcount'],
+            'author_editcount' => (int)$info['author_editcount'],
             'created_at' => $creationDateTime->format('Y-m-d'),
             'created_rev_id' => $info['created_rev_id'],
             'modified_at' => $modifiedDateTime->format('Y-m-d H:i'),
             'secs_since_last_edit' => $secsSinceLastEdit,
-            'last_edit_id' => (int) $info['modified_rev_id'],
-            'watchers' => (int) $page->getWatchers(),
+            'last_edit_id' => (int)$info['modified_rev_id'],
+            'watchers' => (int)$page->getWatchers(),
             'pageviews' => $page->getLastPageviews($pageviewsOffset),
             'pageviews_offset' => $pageviewsOffset,
         ];

Unused Use Statements -3 removed lines

@@ -8,15 +8,12 @@
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\Process\Process;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 use Xtools\ProjectRepository;
-use Xtools\Page;
-use Xtools\PagesRepository;
 use Xtools\ArticleInfo;
 use DateTime;
 

src/Xtools/PagesRepository.php

Spacing +6 added lines, -6 removed lines

@@ -148,7 +148,7 @@ 
         // supply as the OFFSET.
         $limitClause = '';
         if (intval($limit) > 0 && isset($numRevisions)) {
-            $offset = $numRevisions - $limit;
+            $offset = $numRevisions-$limit;
             $limitClause = "LIMIT $offset, $limit";
         }
 
@@ -264,7 +264,7 @@ 
         $time2 = time();
 
         // If it took over 5 seconds, cache the result for 20 minutes.
-        if ($time2 - $time1 > 5) {
+        if ($time2-$time1 > 5) {
             $cacheItem = $this->cache->getItem($cacheKey)
                 ->set($result)
                 ->expiresAfter(new DateInterval('PT20M'));
@@ -399,7 +399,7 @@ 
 
         $wikidataId = ltrim($page->getWikidataId(), 'Q');
 
-        $sql = "SELECT " . ($count ? 'COUNT(*) AS count' : '*') . "
+        $sql = "SELECT ".($count ? 'COUNT(*) AS count' : '*')."
                 FROM wikidatawiki_p.wb_items_per_site
                 WHERE ips_item_id = :wikidataId";
 
@@ -409,7 +409,7 @@ 
 
         $result = $resultQuery->fetchAll();
 
-        return $count ? (int) $result[0]['count'] : $result;
+        return $count ? (int)$result[0]['count'] : $result;
     }
 
     /**
@@ -449,7 +449,7 @@ 
 
         // Transform to associative array by 'type'
         foreach ($res as $row) {
-            $data[$row['type'] . '_count'] = $row['value'];
+            $data[$row['type'].'_count'] = $row['value'];
         }
 
         return $data;
@@ -487,7 +487,7 @@ 
 
         $project = $page->getProject()->getDomain();
 
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
             "$project/all-access/user/$title/daily/$start/$end";
 
         $res = $client->request('GET', $url);