Completed
Pull Request — master (#65)
by Sam
03:31
created
web/app_dev.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 // Feel free to remove this, extend it, or make something more sophisticated.
13 13
 if (isset($_SERVER['HTTP_CLIENT_IP'])
14 14
     || isset($_SERVER['HTTP_X_FORWARDED_FOR'])
15
-    || !( in_array(@$_SERVER['REMOTE_ADDR'], [ '127.0.0.1', 'fe80::1', '::1' ]) || php_sapi_name() === 'cli-server' )
15
+    || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1']) || php_sapi_name() === 'cli-server')
16 16
 ) {
17 17
     header('HTTP/1.0 403 Forbidden');
18 18
     exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
Please login to merge, or discard this patch.
src/AppBundle/Helper/PageviewsHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,8 +12,8 @@  discard block
 block discarded – undo
12 12
         $title = str_replace(' ', '_', $title);
13 13
         $client = new GuzzleHttp\Client();
14 14
 
15
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
16
-            "$project/all-access/user/" . rawurlencode($title) . '/daily/' . $start . '/' . $end;
15
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
16
+            "$project/all-access/user/".rawurlencode($title).'/daily/'.$start.'/'.$end;
17 17
 
18 18
         $res = $client->request('GET', $url);
19 19
         return json_decode($res->getBody()->getContents());
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
         $data = $this->getLastDays($project, $title, $days);
33 33
 
34 34
         // FIXME: needs to handle gotchas
35
-        return array_sum(array_map(function ($item) {
35
+        return array_sum(array_map(function($item) {
36 36
             return $item->views;
37 37
         }, $data->items));
38 38
     }
Please login to merge, or discard this patch.
src/AppBundle/Twig/Extension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         }
46 46
 
47 47
         // Find the path, and complain if English doesn't exist.
48
-        $path = $this->container->getParameter("kernel.root_dir") . '/../i18n';
48
+        $path = $this->container->getParameter("kernel.root_dir").'/../i18n';
49 49
         if (!file_exists("$path/en.json")) {
50 50
             throw new Exception("Language directory doesn't exist: $path");
51 51
         }
Please login to merge, or discard this patch.
src/AppBundle/Controller/AdminStatsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
 
177 177
         // Iterate over query results, loading each user id into the array
178 178
         while ($row = $res->fetch()) {
179
-            $adminIdArr[] = $row["user_id"] ;
179
+            $adminIdArr[] = $row["user_id"];
180 180
         }
181 181
 
182 182
         // Set the query results to be useful in a sql statement.
Please login to merge, or discard this patch.
src/AppBundle/Controller/QuoteController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
             'quote/all.html.twig',
112 112
             [
113 113
                 'base_dir' => realpath(
114
-                    $this->getParameter('kernel.root_dir') . '/..'
114
+                    $this->getParameter('kernel.root_dir').'/..'
115 115
                 ),
116 116
                 'xtPage' => 'bash',
117 117
                 'quotes' => $quotes,
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
             'quote/view.html.twig',
161 161
             [
162 162
                 'base_dir' => realpath(
163
-                    $this->getParameter('kernel.root_dir') . '/..'
163
+                    $this->getParameter('kernel.root_dir').'/..'
164 164
                 ),
165 165
                 "xtPage" => "bash",
166 166
                 "text" => $text,
Please login to merge, or discard this patch.
src/AppBundle/Controller/TopEditsController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@
 block discarded – undo
96 96
      * List top edits by this user for all pages in a particular namespace.
97 97
      * @param User $user The User.
98 98
      * @param Project $project The project.
99
-     * @param integer|string $namespaceId The namespace ID or 'all'
99
+     * @param integer $namespaceId The namespace ID or 'all'
100 100
      * @return \Symfony\Component\HttpFoundation\Response
101 101
      */
102 102
     protected function namespaceTopEdits(User $user, Project $project, $namespaceId)
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -168,11 +168,11 @@  discard block
 block discarded – undo
168 168
         }
169 169
 
170 170
         // Get page info about these 100 pages, so we can use their display title.
171
-        $titles = array_map(function ($e) use ($namespaces) {
171
+        $titles = array_map(function($e) use ($namespaces) {
172 172
             // If non-mainspace, prepend namespace to the titles.
173 173
             $ns = $e['page_namespace'];
174
-            $nsTitle = $ns > 0 ? $namespaces[$e['page_namespace']] . ':' : '';
175
-            return $nsTitle . $e['page_title'];
174
+            $nsTitle = $ns > 0 ? $namespaces[$e['page_namespace']].':' : '';
175
+            return $nsTitle.$e['page_title'];
176 176
         }, $editData);
177 177
 
178 178
         /** @var ApiHelper $apiHelper */
@@ -188,8 +188,8 @@  discard block
 block discarded – undo
188 188
         foreach ($editData as $editDatum) {
189 189
             // If non-mainspace, prepend namespace to the titles.
190 190
             $ns = $editDatum['page_namespace'];
191
-            $nsTitle = $ns > 0 ? $namespaces[$editDatum['page_namespace']] . ':' : '';
192
-            $pageTitle = $nsTitle . $editDatum['page_title'];
191
+            $nsTitle = $ns > 0 ? $namespaces[$editDatum['page_namespace']].':' : '';
192
+            $pageTitle = $nsTitle.$editDatum['page_title'];
193 193
             $editDatum['displaytitle'] = $displayTitles[$pageTitle];
194 194
             // $editDatum['page_title'] is retained without the namespace
195 195
             //  so we can link to TopEdits for that page
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
         // Send all to the template.
250 250
         return $this->render('topedits/result_article.html.twig', [
251 251
             'xtPage' => 'topedits',
252
-            'xtTitle' => $user->getUsername() . ' - ' . $page->getTitle(),
252
+            'xtTitle' => $user->getUsername().' - '.$page->getTitle(),
253 253
             'project' => $project,
254 254
             'user' => $user,
255 255
             'page' => $page,
Please login to merge, or discard this patch.
app/autoload.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,6 +8,6 @@
 block discarded – undo
8 8
  */
9 9
 $loader = require __DIR__.'/../vendor/autoload.php';
10 10
 
11
-AnnotationRegistry::registerLoader([ $loader, 'loadClass' ]);
11
+AnnotationRegistry::registerLoader([$loader, 'loadClass']);
12 12
 
13 13
 return $loader;
Please login to merge, or discard this patch.
app/AppKernel.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
             new AppBundle\AppBundle(),
28 28
         ];
29 29
 
30
-        if (in_array($this->getEnvironment(), [ 'dev', 'test' ], true)) {
30
+        if (in_array($this->getEnvironment(), ['dev', 'test'], true)) {
31 31
             $bundles[] = new Symfony\Bundle\DebugBundle\DebugBundle();
32 32
             $bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle();
33 33
             $bundles[] = new Sensio\Bundle\DistributionBundle\SensioDistributionBundle();
Please login to merge, or discard this patch.
src/Xtools/ProjectRepository.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -251,9 +251,9 @@
 block discarded – undo
251 251
         $conn = $this->getProjectsConnection();
252 252
         $pageTable = $this->getTableName($project->getDatabaseName(), 'page');
253 253
         $query = "SELECT page_id "
254
-             . " FROM $pageTable "
255
-             . " WHERE page_namespace = :ns AND page_title = :title AND page_len > 0 "
256
-             . " LIMIT 1";
254
+                . " FROM $pageTable "
255
+                . " WHERE page_namespace = :ns AND page_title = :title AND page_len > 0 "
256
+                . " LIMIT 1";
257 257
         $params = [
258 258
             'ns' => $namespaceId,
259 259
             'title' => $pageTitle,
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
                 if ($projMetadata['dbName'] == "$project"
147 147
                     || $projMetadata['url'] == "$project"
148 148
                     || $projMetadata['url'] == "https://$project") {
149
-                    $this->log->debug(__METHOD__ . " Using cached data for $project");
149
+                    $this->log->debug(__METHOD__." Using cached data for $project");
150 150
                     return $projMetadata;
151 151
                 }
152 152
             }
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
         }
201 201
 
202 202
         // Redis cache
203
-        $cacheKey = "projectMetadata." . preg_replace("/[^A-Za-z0-9]/", '', $projectUrl);
203
+        $cacheKey = "projectMetadata.".preg_replace("/[^A-Za-z0-9]/", '', $projectUrl);
204 204
         if ($this->cache->hasItem($cacheKey)) {
205 205
             $this->metadata = $this->cache->getItem($cacheKey)->get();
206 206
             return $this->metadata;
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
         $optedIn = $this->container->getParameter('opted_in');
281 281
         // In case there's just one given.
282 282
         if (!is_array($optedIn)) {
283
-            $optedIn = [ $optedIn ];
283
+            $optedIn = [$optedIn];
284 284
         }
285 285
         return $optedIn;
286 286
     }
Please login to merge, or discard this patch.