x-tools / xtools

src/AppBundle/Controller/EditCounterController.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Xtools\EditCounter;
 use Xtools\EditCounterRepository;
-use Xtools\Page;
 use Xtools\Project;
 use Xtools\ProjectRepository;
 use Xtools\User;

Spacing +3 added lines, -3 removed lines

@@ -98,10 +98,10 @@ 
         $username = $request->query->get('username', $request->query->get('user'));
 
         if (($project || $queryProject) && $username) {
-            $routeParams = [ 'project'=>($project ?: $queryProject), 'username' => $username ];
+            $routeParams = ['project'=>($project ?: $queryProject), 'username' => $username];
             return $this->redirectToRoute("EditCounterResult", $routeParams);
         } elseif (!$project && $queryProject) {
-            return $this->redirectToRoute("EditCounterProject", [ 'project'=>$queryProject ]);
+            return $this->redirectToRoute("EditCounterProject", ['project'=>$queryProject]);
         }
 
         $project = ProjectRepository::getProject($queryProject, $this->container);
@@ -141,7 +141,7 @@ 
         $isSubRequest = $this->container->get('request_stack')->getParentRequest() !== null;
 
         return $this->render('editCounter/result.html.twig', [
-            'xtTitle' => $this->user->getUsername() . ' - ' . $this->project->getTitle(),
+            'xtTitle' => $this->user->getUsername().' - '.$this->project->getTitle(),
             'xtPage' => 'ec',
             'base_dir' => realpath($this->getParameter('kernel.root_dir').'/..'),
             'is_sub_request' => $isSubRequest,

src/Xtools/EditCounter.php

Doc Comments +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
     /**
      * This method asynchronously fetches all the expensive data, waits
      * for each request to finish, and copies the values to the class instance.
-     * @param ContainerInterface $container Symfony's container.
+     * @param \Symfony\Component\DependencyInjection\ContainerInterface $container Symfony's container.
      * @return null
      */
     public function prepareData($container)
@@ -544,7 +544,7 @@ 
 
     /**
      * Get the date and time of the user's first edit.
-     * @return DateTime|bool The time of the first revision, or false.
+     * @return DateInterval The time of the first revision, or false.
      */
     public function datetimeFirstRevision()
     {
@@ -554,7 +554,7 @@ 
 
     /**
      * Get the date and time of the user's first edit.
-     * @return DateTime|bool The time of the last revision, or false.
+     * @return DateInterval The time of the last revision, or false.
      */
     public function datetimeLastRevision()
     {

Spacing +23 added lines, -23 removed lines

@@ -117,12 +117,12 @@ 
 
         foreach ($endpoints as $key => $endpoint) {
             // $promise = $this->getRepository()->queryXTools($endpoint, true);
-            $promise = $client->getAsync('https://xtools-dev.wmflabs.org/' . $endpoint);
+            $promise = $client->getAsync('https://xtools-dev.wmflabs.org/'.$endpoint);
             $promises[] = $promise;
 
             // Handle response of $promise asynchronously.
-            $promise->then(function ($response) use ($key, $endpoint) {
-                $result = (array) json_decode($response->getBody()->getContents());
+            $promise->then(function($response) use ($key, $endpoint) {
+                $result = (array)json_decode($response->getBody()->getContents());
 
                 if (isset($result)) {
                     // Copy result to the class class instance. From here any subsequent
@@ -135,7 +135,7 @@ 
                     // We'll log this to see how often it happens.
                     $this->getRepository()
                         ->log
-                        ->err("Failed to fetch data for $endpoint via async, " .
+                        ->err("Failed to fetch data for $endpoint via async, ".
                             "re-attempting synchoronously.");
                 }
             });
@@ -216,7 +216,7 @@ 
      */
     public function countAllRevisions()
     {
-        return $this->countLiveRevisions() + $this->countDeletedRevisions();
+        return $this->countLiveRevisions()+$this->countDeletedRevisions();
     }
 
     /**
@@ -235,7 +235,7 @@ 
      */
     public function countRevisionsWithoutComments()
     {
-        return $this->countLiveRevisions() - $this->countRevisionsWithComments();
+        return $this->countLiveRevisions()-$this->countRevisionsWithComments();
     }
 
     /**
@@ -274,7 +274,7 @@ 
      */
     public function countAllPagesEdited()
     {
-        return $this->countLivePagesEdited() + $this->countDeletedPagesEdited();
+        return $this->countLivePagesEdited()+$this->countDeletedPagesEdited();
     }
 
     /**
@@ -284,7 +284,7 @@ 
      */
     public function countPagesCreated()
     {
-        return $this->countCreatedPagesLive() + $this->countPagesCreatedDeleted();
+        return $this->countCreatedPagesLive()+$this->countPagesCreatedDeleted();
     }
 
     /**
@@ -412,7 +412,7 @@ 
             // Try block just in case there are older, unpredictable formats
             try {
                 $expiry = strtotime($durationStr, $timestamp);
-                $duration = ($expiry - $timestamp) / (60 * 60 * 24);
+                $duration = ($expiry-$timestamp) / (60 * 60 * 24);
 
                 if (!$duration || $duration > $this->longestBlockDays) {
                     $this->longestBlockDays = $duration;
@@ -496,7 +496,7 @@ 
         $import = isset($logCounts['import-import']) ? (int)$logCounts['import-import'] : 0;
         $interwiki = isset($logCounts['import-interwiki']) ? (int)$logCounts['import-interwiki'] : 0;
         $upload = isset($logCounts['import-upload']) ? (int)$logCounts['import-upload'] : 0;
-        return $import + $interwiki + $upload;
+        return $import+$interwiki+$upload;
     }
 
     /**
@@ -620,9 +620,9 @@ 
     public function approvals()
     {
         $logCounts = $this->getLogCounts();
-        $total = $logCounts['review-approve'] +
-        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0) +
-        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0) +
+        $total = $logCounts['review-approve']+
+        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0)+
+        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0)+
         (!empty($logCounts['review-approve-ia']) ? $logCounts['review-approve-ia'] : 0);
         return $total;
     }
@@ -646,7 +646,7 @@ 
         $logCounts = $this->getLogCounts();
         $create2 = $logCounts['newusers-create2'] ?: 0;
         $byemail = $logCounts['newusers-byemail'] ?: 0;
-        return $create2 + $byemail;
+        return $create2+$byemail;
     }
 
     /**
@@ -698,7 +698,7 @@ 
 
         $totals = $this->getRepository()->getMonthCounts($this->project, $this->user);
         $out = [
-            'yearLabels' => [],  // labels for years
+            'yearLabels' => [], // labels for years
             'monthLabels' => [], // labels for months
             'totals' => [], // actual totals, grouped by namespace, year and then month
         ];
@@ -726,7 +726,7 @@ 
                 $out['totals'][$ns][$total['year']] = [];
             }
 
-            $out['totals'][$ns][$total['year']][$total['month']] = (int) $total['count'];
+            $out['totals'][$ns][$total['year']][$total['month']] = (int)$total['count'];
         }
 
         $dateRange = new DatePeriod(
@@ -736,8 +736,8 @@ 
         );
 
         foreach ($dateRange as $monthObj) {
-            $year = (int) $monthObj->format('Y');
-            $month = (int) $monthObj->format('n');
+            $year = (int)$monthObj->format('Y');
+            $month = (int)$monthObj->format('n');
 
             // Fill in labels
             $out['monthLabels'][] = $monthObj->format('Y-m');
@@ -853,8 +853,8 @@ 
 
         if ($sorted) {
             // Sort.
-            uasort($this->globalEditCounts, function ($a, $b) {
-                return $b['total'] - $a['total'];
+            uasort($this->globalEditCounts, function($a, $b) {
+                return $b['total']-$a['total'];
             });
         }
 
@@ -890,7 +890,7 @@ 
                 $nsName = $project->getNamespaces()[$revision['page_namespace']];
             }
             $page = $project->getRepository()
-                ->getPage($project, $nsName . ':' . $revision['page_title']);
+                ->getPage($project, $nsName.':'.$revision['page_title']);
             $edit = new Edit($page, $revision);
             $globalEdits[$edit->getTimestamp()->getTimestamp().'-'.$edit->getId()] = $edit;
         }
@@ -931,7 +931,7 @@ 
     public function countSmallEdits()
     {
         $editSizeData = $this->getEditSizeData();
-        return isset($editSizeData['small_edits']) ? (int) $editSizeData['small_edits'] : 0;
+        return isset($editSizeData['small_edits']) ? (int)$editSizeData['small_edits'] : 0;
     }
 
     /**
@@ -941,7 +941,7 @@ 
     public function countLargeEdits()
     {
         $editSizeData = $this->getEditSizeData();
-        return isset($editSizeData['large_edits']) ? (int) $editSizeData['large_edits'] : 0;
+        return isset($editSizeData['large_edits']) ? (int)$editSizeData['large_edits'] : 0;
     }
 
     /**

src/Xtools/Repository.php

Spacing +2 added lines, -2 removed lines

@@ -151,7 +151,7 @@ 
 
         // Ensure there's a trailing slash.
         $apiRoot = trim($this->container->getParameter('app.multithread.api_url'), '/');
-        $endpoint = $apiRoot . '/' . $endpoint;
+        $endpoint = $apiRoot.'/'.$endpoint;
 
         if ($async) {
             return $this->apiConnection->getAsync($endpoint);
@@ -177,7 +177,7 @@ 
         // $tableExtension in order to generate the new table name
         if ($this->isLabs() && $tableExtension !== null) {
             $mapped = true;
-            $tableName = $tableName . '_' . $tableExtension;
+            $tableName = $tableName.'_'.$tableExtension;
         } elseif ($this->container->hasParameter("app.table.$tableName")) {
             // Use the table specified in the table mapping configuration, if present.
             $mapped = true;