x-tools / xtools

src/AppBundle/Controller/RfXVoteCalculatorController.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace AppBundle\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\CssSelector\Exception\InternalErrorException;
-use Symfony\Component\Debug\Exception\ContextErrorException;
 use Symfony\Component\HttpFoundation\Request;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Xtools\ProjectRepository;

Doc Comments +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
      * @Route("/rfxvote", name="rfxvote")
      * @Route("/rfxvote", name="RfXVoteCalculator")
      *
-     * @return Response
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function indexAction()
     {
@@ -86,7 +86,7 @@ 
      *
      * @Route("/rfxvote/{project}/{username}", name="rfxvoteResult")
      *
-     * @return Response
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function resultAction($project, $username)
     {

Spacing +3 added lines, -3 removed lines

@@ -48,7 +48,7 @@ 
         $username = $request->query->get('username');
 
         if ($projectQuery != '' && $username != '') {
-            $routeParams = [ 'project' => $projectQuery, 'username' => $username ];
+            $routeParams = ['project' => $projectQuery, 'username' => $username];
             return $this->redirectToRoute(
                 'rfxvoteResult',
                 $routeParams
@@ -167,8 +167,8 @@ 
             $titles = [];
 
             while ($row = $sth->fetch()) {
-                $titles[] = $namespaces[$row['page_namespace']] .
-                    ':' .$row['page_title'];
+                $titles[] = $namespaces[$row['page_namespace']].
+                    ':'.$row['page_title'];
             }
 
             // Chunking... it's possible to make a URI too long

src/AppBundle/Controller/RfXAnalysisController.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Xtools\ProjectRepository;
 use Xtools\Page;
 use Xtools\PagesRepository;

Doc Comments +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
      * @Route("/rfx/{project}",        name="rfxAnalysisProject")
      * @Route("/rfx/{project}/{type}", name="rfxAnalysisProjectType")
      *
-     * @return Response|RedirectResponse
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function indexAction(Request $request, $project = null, $type = null)
     {
@@ -110,7 +110,7 @@ 
      *
      * @Route("/rfx/{project}/{type}/{username}", name="rfxAnalysisResult")
      *
-     * @return Response|RedirectResponse
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function resultAction($project, $type, $username)
     {

Spacing +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
         $neutral = $rfx->getSection('neutral');
         $dup = $rfx->getDuplicates();
 
-        $total = count($support) + count($oppose) + count($neutral);
+        $total = count($support)+count($oppose)+count($neutral);
 
         if ($total === 0) {
             $this->addFlash('notice', ['no-result', $pagename]);

src/Xtools/Page.php

Spacing +8 added lines, -8 removed lines

@@ -66,7 +66,7 @@ 
         $info = $this->getPageInfo();
         $title = isset($info['title']) ? $info['title'] : $this->unnormalizedPageName;
         $nsName = $this->getNamespaceName();
-        return str_replace($nsName . ':', '', $title);
+        return str_replace($nsName.':', '', $title);
     }
 
     /**
@@ -207,7 +207,7 @@ 
 
         // Otherwise do a COUNT in the event fetching
         // all revisions is not desired
-        return (int) $this->getRepository()->getNumRevisions($this, $user);
+        return (int)$this->getRepository()->getNumRevisions($this, $user);
     }
 
     /**
@@ -234,7 +234,7 @@ 
     {
         $content = $this->getRepository()->getPagesWikitext(
             $this->getProject(),
-            [ $this->getTitle() ]
+            [$this->getTitle()]
         );
 
         return isset($content[$this->getTitle()])
@@ -381,7 +381,7 @@ 
 
         $wikidataInfo = $this->getRepository()->getWikidataInfo($this);
 
-        $terms = array_map(function ($entry) {
+        $terms = array_map(function($entry) {
             return $entry['term'];
         }, $wikidataInfo);
 
@@ -392,7 +392,7 @@ 
                 'prio' => 2,
                 'name' => 'Wikidata',
                 'notice' => "Label for language <em>$lang</em> is missing", // FIXME: i18n
-                'explanation' => "See: <a target='_blank' " .
+                'explanation' => "See: <a target='_blank' ".
                     "href='//www.wikidata.org/wiki/Help:Label'>Help:Label</a>",
             ];
         }
@@ -402,7 +402,7 @@ 
                 'prio' => 3,
                 'name' => 'Wikidata',
                 'notice' => "Description for language <em>$lang</em> is missing", // FIXME: i18n
-                'explanation' => "See: <a target='_blank' " .
+                'explanation' => "See: <a target='_blank' ".
                     "href='//www.wikidata.org/wiki/Help:Description'>Help:Description</a>",
             ];
         }
@@ -473,8 +473,8 @@ 
             return 0;
         }
 
-        return array_sum(array_map(function ($item) {
-            return (int) $item['views'];
+        return array_sum(array_map(function($item) {
+            return (int)$item['views'];
         }, $pageviews['items']));
     }
 

src/Xtools/RFX.php

Doc Comments +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
      * Returns matches.
      *
      * @param string $input   The line we're looking for
-     * @param array  $matches Pointer to an array where we stash results
+     * @param string[]  $matches Pointer to an array where we stash results
      *
      * @TODO: Make this cleaner
      *

Spacing +2 added lines, -2 removed lines

@@ -119,7 +119,7 @@ 
             }
         }
 
-        $final = [];    // initialize the final array
+        $final = []; // initialize the final array
         $finalRaw = []; // Initialize the raw data array
 
         foreach ($this->data as $key => $value) {
@@ -132,7 +132,7 @@ 
 
         $final = array_count_values($final); // find repetition and its count
 
-        $final = array_diff($final, [1]);    // remove single occurrences
+        $final = array_diff($final, [1]); // remove single occurrences
 
         $this->duplicates = array_keys($final);
     }