x-tools / xtools

src/AppBundle/Controller/TopEditsController.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use Xtools\Page;
 use Xtools\PagesRepository;
 use Xtools\Project;
-use Xtools\ProjectRepository;
 use Xtools\User;
 
 class TopEditsController extends ControllerBase

src/AppBundle/Helper/AutomatedEditsHelper.php

Unused Use Statements -5 removed lines

@@ -2,12 +2,7 @@
 
 namespace AppBundle\Helper;
 
-use Doctrine\DBAL\Connection;
-use Psr\Cache\CacheItemPoolInterface;
-use Symfony\Component\Config\Definition\Exception\Exception;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Symfony\Component\DependencyInjection\ContainerInterface;
-use Symfony\Component\VarDumper\VarDumper;
 
 class AutomatedEditsHelper extends HelperBase
 {

src/Xtools/EditCounterRepository.php

Spacing +46 added lines, -46 removed lines

@@ -41,7 +41,7 @@ 
     public function getRevisionCounts(Project $project, User $user)
     {
         // Set up cache.
-        $cacheKey = 'revisioncounts.' . $user->getId($project);
+        $cacheKey = 'revisioncounts.'.$user->getId($project);
         if ($this->cache->hasItem($cacheKey)) {
             return $this->cache->getItem($cacheKey)->get();
         }
@@ -132,7 +132,7 @@ 
     public function getTopProjectsEditCounts($projectUrl, $username, $numProjects = 10)
     {
         $this->debug("Getting top project edit counts for $username");
-        $cacheKey = 'topprojectseditcounts.' . $username;
+        $cacheKey = 'topprojectseditcounts.'.$username;
         if ($this->cacheHas($cacheKey)) {
             return $this->cacheGet($cacheKey);
         }
@@ -144,7 +144,7 @@ 
         if (false === $topEditCounts) {
             // If no CentralAuth, fall back to querying each database in turn.
             foreach ($this->labsHelper->getProjectsInfo() as $project) {
-                $this->container->get('logger')->debug('Getting edit count for ' . $project['url']);
+                $this->container->get('logger')->debug('Getting edit count for '.$project['url']);
                 $revisionTableName = $this->labsHelper->getTable('revision', $project['dbName']);
                 $sql = "SELECT COUNT(rev_id) FROM $revisionTableName WHERE rev_user_text=:username";
                 $stmt = $this->replicas->prepare($sql);
@@ -154,8 +154,8 @@ 
                 $topEditCounts[$project['dbName']] = array_merge($project, ['total' => $total]);
             }
         }
-        uasort($topEditCounts, function ($a, $b) {
-            return $b['total'] - $a['total'];
+        uasort($topEditCounts, function($a, $b) {
+            return $b['total']-$a['total'];
         });
         $out = array_slice($topEditCounts, 0, $numProjects);
 
@@ -197,10 +197,10 @@ 
         $results = $resultQuery->fetchAll();
 
         $pageCounts = array_combine(
-            array_map(function ($e) {
+            array_map(function($e) {
                     return $e['source'];
             }, $results),
-            array_map(function ($e) {
+            array_map(function($e) {
                     return $e['value'];
             }, $results)
         );
@@ -216,16 +216,16 @@ 
     public function getLogCounts($userId)
     {
         $sql = "SELECT CONCAT(log_type, '-', log_action) AS source, COUNT(log_id) AS value
-            FROM " . $this->labsHelper->getTable('logging') . "
+            FROM " . $this->labsHelper->getTable('logging')."
             WHERE log_user = :userId
             GROUP BY log_type, log_action";
         $resultQuery = $this->replicas->prepare($sql);
         $resultQuery->bindParam('userId', $userId);
         $resultQuery->execute();
         $results = $resultQuery->fetchAll();
-        $logCounts = array_combine(array_map(function ($e) {
+        $logCounts = array_combine(array_map(function($e) {
             return $e['source'];
-        }, $results), array_map(function ($e) {
+        }, $results), array_map(function($e) {
                 return $e['value'];
         }, $results));
 
@@ -253,9 +253,9 @@ 
 
         // Merge approvals together.
         $logCounts['review-approve'] =
-            $logCounts['review-approve'] +
-            (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0) +
-            (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0) +
+            $logCounts['review-approve']+
+            (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0)+
+            (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0)+
             (!empty($logCounts['review-approve-ia']) ? $logCounts['review-approve-ia'] : 0);
 
         // Add Commons upload count, if applicable.
@@ -281,16 +281,16 @@ 
     {
         $userId = $this->getUserId($username);
         $sql = "SELECT page_namespace, count(rev_id) AS total
-            FROM " . $this->labsHelper->getTable('revision') . " r
-                JOIN " . $this->labsHelper->getTable('page') . " p on r.rev_page = p.page_id
+            FROM " . $this->labsHelper->getTable('revision')." r
+                JOIN " . $this->labsHelper->getTable('page')." p on r.rev_page = p.page_id
             WHERE r.rev_user = :id GROUP BY page_namespace";
         $resultQuery = $this->replicas->prepare($sql);
         $resultQuery->bindParam(":id", $userId);
         $resultQuery->execute();
         $results = $resultQuery->fetchAll();
-        $namespaceTotals = array_combine(array_map(function ($e) {
+        $namespaceTotals = array_combine(array_map(function($e) {
             return $e['page_namespace'];
-        }, $results), array_map(function ($e) {
+        }, $results), array_map(function($e) {
                 return $e['total'];
         }, $results));
 
@@ -313,14 +313,14 @@ 
                 $revisions = $this->cacheGet($cacheKey);
             } else {
                 $sql =
-                    "SELECT rev_id, rev_timestamp, UNIX_TIMESTAMP(rev_timestamp) AS unix_timestamp, " .
-                    " rev_minor_edit, rev_deleted, rev_len, rev_parent_id, rev_comment, " .
-                    " page_title, page_namespace " . " FROM " .
-                    $this->labsHelper->getTable('revision', $project['dbName']) . "    JOIN " .
-                    $this->labsHelper->getTable('page', $project['dbName']) .
-                    "    ON (rev_page = page_id)" .
-                    " WHERE rev_timestamp > NOW() - INTERVAL $days DAY AND rev_user_text LIKE :username" .
-                    " ORDER BY rev_timestamp DESC" . " LIMIT 10";
+                    "SELECT rev_id, rev_timestamp, UNIX_TIMESTAMP(rev_timestamp) AS unix_timestamp, ".
+                    " rev_minor_edit, rev_deleted, rev_len, rev_parent_id, rev_comment, ".
+                    " page_title, page_namespace "." FROM ".
+                    $this->labsHelper->getTable('revision', $project['dbName'])."    JOIN ".
+                    $this->labsHelper->getTable('page', $project['dbName']).
+                    "    ON (rev_page = page_id)".
+                    " WHERE rev_timestamp > NOW() - INTERVAL $days DAY AND rev_user_text LIKE :username".
+                    " ORDER BY rev_timestamp DESC"." LIMIT 10";
                 $resultQuery = $this->replicas->prepare($sql);
                 $resultQuery->bindParam(":username", $username);
                 $resultQuery->execute();
@@ -330,7 +330,7 @@ 
             if (count($revisions) === 0) {
                 continue;
             }
-            $revsWithProject = array_map(function (&$item) use ($project) {
+            $revsWithProject = array_map(function(&$item) use ($project) {
                 $item['project_name'] = $project['wikiName'];
                 $item['project_url'] = $project['url'];
                 $item['project_db_name'] = $project['dbName'];
@@ -340,8 +340,8 @@ 
             }, $revisions);
             $allRevisions = array_merge($allRevisions, $revsWithProject);
         }
-        usort($allRevisions, function ($a, $b) {
-            return $b['rev_timestamp'] - $a['rev_timestamp'];
+        usort($allRevisions, function($a, $b) {
+            return $b['rev_timestamp']-$a['rev_timestamp'];
         });
 
         return array_slice($allRevisions, 0, $topN);
@@ -360,12 +360,12 @@ 
         }
 
         $sql =
-            "SELECT " . "     YEAR(rev_timestamp) AS `year`," .
-            "     MONTH(rev_timestamp) AS `month`," . "     page_namespace," .
-            "     COUNT(rev_id) AS `count` " . " FROM " . $this->labsHelper->getTable('revision') .
-            "    JOIN " . $this->labsHelper->getTable('page') . " ON (rev_page = page_id)" .
-            " WHERE rev_user_text = :username" .
-            " GROUP BY YEAR(rev_timestamp), MONTH(rev_timestamp), page_namespace " .
+            "SELECT "."     YEAR(rev_timestamp) AS `year`,".
+            "     MONTH(rev_timestamp) AS `month`,"."     page_namespace,".
+            "     COUNT(rev_id) AS `count` "." FROM ".$this->labsHelper->getTable('revision').
+            "    JOIN ".$this->labsHelper->getTable('page')." ON (rev_page = page_id)".
+            " WHERE rev_user_text = :username".
+            " GROUP BY YEAR(rev_timestamp), MONTH(rev_timestamp), page_namespace ".
             " ORDER BY rev_timestamp DESC";
         $resultQuery = $this->replicas->prepare($sql);
         $resultQuery->bindParam(":username", $username);
@@ -387,14 +387,14 @@ 
             if (!isset($out['totals'][$ns])) {
                 $out['totals'][$ns] = [];
             }
-            $out['totals'][$ns][$total['year'] . $total['month']] = $total['count'];
+            $out['totals'][$ns][$total['year'].$total['month']] = $total['count'];
         }
         // Fill in the blanks (where no edits were made in a given month for a namespace).
         for ($y = $out['min_year']; $y <= $out['max_year']; $y++) {
             for ($m = 1; $m <= 12; $m++) {
                 foreach ($out['totals'] as $nsId => &$total) {
-                    if (!isset($total[$y . $m])) {
-                        $total[$y . $m] = 0;
+                    if (!isset($total[$y.$m])) {
+                        $total[$y.$m] = 0;
                     }
                 }
             }
@@ -417,12 +417,12 @@ 
         }
 
         $sql =
-            "SELECT " . "     SUBSTR(CAST(rev_timestamp AS CHAR(4)), 1, 4) AS `year`," .
-            "     page_namespace," . "     COUNT(rev_id) AS `count` " . " FROM " .
-            $this->labsHelper->getTable('revision') . "    JOIN " .
-            $this->labsHelper->getTable('page') . " ON (rev_page = page_id)" .
-            " WHERE rev_user_text = :username" .
-            " GROUP BY SUBSTR(CAST(rev_timestamp AS CHAR(4)), 1, 4), page_namespace " .
+            "SELECT "."     SUBSTR(CAST(rev_timestamp AS CHAR(4)), 1, 4) AS `year`,".
+            "     page_namespace,"."     COUNT(rev_id) AS `count` "." FROM ".
+            $this->labsHelper->getTable('revision')."    JOIN ".
+            $this->labsHelper->getTable('page')." ON (rev_page = page_id)".
+            " WHERE rev_user_text = :username".
+            " GROUP BY SUBSTR(CAST(rev_timestamp AS CHAR(4)), 1, 4), page_namespace ".
             " ORDER BY rev_timestamp DESC ";
         $resultQuery = $this->replicas->prepare($sql);
         $resultQuery->bindParam(":username", $username);
@@ -461,9 +461,9 @@ 
         $hourInterval = 2;
         $xCalc = "ROUND(HOUR(rev_timestamp)/$hourInterval)*$hourInterval";
         $sql =
-            "SELECT " . "     DAYOFWEEK(rev_timestamp) AS `y`, " . "     $xCalc AS `x`, " .
-            "     COUNT(rev_id) AS `r` " . " FROM " . $this->labsHelper->getTable('revision') .
-            " WHERE rev_user_text = :username" . " GROUP BY DAYOFWEEK(rev_timestamp), $xCalc " .
+            "SELECT "."     DAYOFWEEK(rev_timestamp) AS `y`, "."     $xCalc AS `x`, ".
+            "     COUNT(rev_id) AS `r` "." FROM ".$this->labsHelper->getTable('revision').
+            " WHERE rev_user_text = :username"." GROUP BY DAYOFWEEK(rev_timestamp), $xCalc ".
             " ";
         $resultQuery = $this->replicas->prepare($sql);
         $resultQuery->bindParam(":username", $username);

src/Xtools/User.php

Indentation +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
     public function userRightsUrl(Project $project)
     {
         return $project->getUrl() . $project->getScriptPath() . "?title=Special:UserRights&user=" .
-               $this->getUsername();
+                $this->getUsername();
     }
 
     /**

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
      */
     public function userRightsUrl(Project $project)
     {
-        return $project->getUrl() . $project->getScriptPath() . "?title=Special:UserRights&user=" .
+        return $project->getUrl().$project->getScriptPath()."?title=Special:UserRights&user=".
                $this->getUsername();
     }
 

src/Xtools/UserRepository.php

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
     public function getGroups(Project $project, $username)
     {
         $api = $this->getMediawikiApi($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
         $res = $api->getRequest($query);
@@ -57,7 +57,7 @@ 
 
         // Create the API query.
         $api = $this->getMediawikiApi($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
 
         // Get the result.

src/Xtools/EditCounter.php

Spacing +6 added lines, -6 removed lines

@@ -37,7 +37,7 @@ 
      */
     protected function getRevisionCounts()
     {
-        if (! is_array($this->revisionCounts)) {
+        if (!is_array($this->revisionCounts)) {
             $this->revisionCounts = $this->getRepository()
                 ->getRevisionCounts($this->project, $this->user);
         }
@@ -50,7 +50,7 @@ 
      */
     protected function getPageCounts()
     {
-        if (! is_array($this->pageCounts)) {
+        if (!is_array($this->pageCounts)) {
             $this->pageCounts = $this->getRepository()
                 ->getPageCounts($this->project, $this->user);
         }
@@ -63,7 +63,7 @@ 
      */
     protected function getRevisionDates()
     {
-        if (! is_array($this->revisionDates)) {
+        if (!is_array($this->revisionDates)) {
             $this->revisionDates = $this->getRepository()
                 ->getRevisionDates($this->project, $this->user);
         }
@@ -88,7 +88,7 @@ 
      */
     public function getTotalEditCount()
     {
-        return $this->getLiveEditCount() + $this->getDeletedEditCount();
+        return $this->getLiveEditCount()+$this->getDeletedEditCount();
     }
 
     /**
@@ -113,7 +113,7 @@ 
      */
     public function getTotalPagesEdited()
     {
-        return $this->getTotalLivePagesEdited() + $this->getTotalDeletedPagesEdited();
+        return $this->getTotalLivePagesEdited()+$this->getTotalDeletedPagesEdited();
     }
 
     /**
@@ -132,7 +132,7 @@ 
      */
     public function getCreatedPagesTotal()
     {
-        return $this->getCreatedPagesLive() + $this->getCreatedPagesDeleted();
+        return $this->getCreatedPagesLive()+$this->getCreatedPagesDeleted();
     }
 
     /**

src/AppBundle/Controller/EditCounterController.php

Spacing +2 added lines, -2 removed lines

@@ -53,10 +53,10 @@
         $username = $request->query->get('username');
 
         if (($project || $queryProject) && $username) {
-            $routeParams = [ 'project'=>($project ?: $queryProject), 'username' => $username ];
+            $routeParams = ['project'=>($project ?: $queryProject), 'username' => $username];
             return $this->redirectToRoute("EditCounterResult", $routeParams);
         } elseif (!$project && $queryProject) {
-            return $this->redirectToRoute("EditCounterProject", [ 'project'=>$queryProject ]);
+            return $this->redirectToRoute("EditCounterProject", ['project'=>$queryProject]);
         }
 
         $this->init($project);