x-tools / xtools

src/AppBundle/Controller/TopEditsController.php

Doc Comments +1 added lines, -1 removed lines

@@ -155,7 +155,7 @@
      * @param Request $request The HTTP request.
      * @param User $user The User.
      * @param Project $project The project.
-     * @param integer|string $namespace The namespace ID or 'all'
+     * @param integer $namespace The namespace ID or 'all'
      * @return \Symfony\Component\HttpFoundation\Response
      */
     public function namespaceTopEdits(Request $request, User $user, Project $project, $namespace)

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 
 namespace AppBundle\Controller;
 
-use AppBundle\Helper\ApiHelper;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\RedirectResponse;

Spacing +2 added lines, -2 removed lines

@@ -96,7 +96,7 @@ 
             'xtSubtitle' => 'tool-topedits-desc',
             'xtPage' => 'topedits',
             'project' => $project,
-            'namespace' => (int) $namespace,
+            'namespace' => (int)$namespace,
             'article' => $article,
         ]);
     }
@@ -248,7 +248,7 @@ 
         // Send all to the template.
         return $this->render('topedits/result_article.html.twig', [
             'xtPage' => 'topedits',
-            'xtTitle' => $user->getUsername() . ' - ' . $page->getTitle(),
+            'xtTitle' => $user->getUsername().' - '.$page->getTitle(),
             'project' => $project,
             'user' => $user,
             'page' => $page,

src/Xtools/TopEdits.php

Doc Comments -1 removed lines

@@ -105,7 +105,6 @@
     /**
      * Get the top edits by a user in the given namespace.
      * @param int $namespace Namespace ID.
-     * @param int $limit Number of edits to fetch.
      * @return string[] page_namespace, page_title, page_is_redirect,
      *   count (number of edits), assessment (page assessment).
      */

Unused Use Statements -3 removed lines

@@ -5,9 +5,6 @@
 
 namespace Xtools;
 
-use Symfony\Component\DependencyInjection\Container;
-use DateTime;
-
 /**
  * TopEdits returns the top-edited pages by a user. There is not a separate
  * repository because there is only one query :)

Spacing +6 added lines, -6 removed lines

@@ -124,9 +124,9 @@ 
         $pages = [];
         foreach ($topPages as $page) {
             // If non-mainspace, prepend namespace to the titles.
-            $ns = (int) $page['page_namespace'];
-            $nsTitle = $ns > 0 ? $this->project->getNamespaces()[$page['page_namespace']] . ':' : '';
-            $pageTitle = $nsTitle . $page['page_title'];
+            $ns = (int)$page['page_namespace'];
+            $nsTitle = $ns > 0 ? $this->project->getNamespaces()[$page['page_namespace']].':' : '';
+            $pageTitle = $nsTitle.$page['page_title'];
             $page['displaytitle'] = $displayTitles[$pageTitle];
             // $page['page_title'] is retained without the namespace
             //  so we can link to TopEdits for that page.
@@ -147,11 +147,11 @@ 
         $namespaces = $this->project->getNamespaces();
 
         // First extract page titles including namespace.
-        $pageTitles = array_map(function ($page) use ($namespaces) {
+        $pageTitles = array_map(function($page) use ($namespaces) {
             // If non-mainspace, prepend namespace to the titles.
             $ns = $page['page_namespace'];
-            $nsTitle = $ns > 0 ? $namespaces[$page['page_namespace']] . ':' : '';
-            return $nsTitle . $page['page_title'];
+            $nsTitle = $ns > 0 ? $namespaces[$page['page_namespace']].':' : '';
+            return $nsTitle.$page['page_title'];
         }, $topPages);
 
         return $this->getRepository()->getDisplayTitles($this->project, $pageTitles);