x-tools / xtools

src/AppBundle/Controller/AdminScoreController.php

Doc Comments -1 removed lines

@@ -28,7 +28,6 @@
      * @Route("/scottywong tools/adminscore.php", name="AdminScoreLegacy")
      * @Route("/adminscore/{project}", name="AdminScoreProject")
      * @param Request $request The HTTP request.
-     * @param string $project The project name.
      * @return Response
      */
     public function indexAction(Request $request)

Unused Use Statements -3 removed lines

@@ -10,10 +10,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use DateTime;
-use Xtools\ProjectRepository;
-use Xtools\UserRepository;
 
 /**
  * The AdminScoreController serves the search form and results page of the AdminScore tool

Spacing +15 added lines, -15 removed lines

@@ -92,20 +92,20 @@ 
 
         // MULTIPLIERS (to review)
         $multipliers = [
-            'account-age-mult' => 1.25,             # 0 if = 365 jours
-            'edit-count-mult' => 1.25,              # 0 if = 10 000
-            'user-page-mult' => 0.1,                # 0 if =
-            'patrols-mult' => 1,                    # 0 if =
-            'blocks-mult' => 1.4,                   # 0 if = 10
+            'account-age-mult' => 1.25, # 0 if = 365 jours
+            'edit-count-mult' => 1.25, # 0 if = 10 000
+            'user-page-mult' => 0.1, # 0 if =
+            'patrols-mult' => 1, # 0 if =
+            'blocks-mult' => 1.4, # 0 if = 10
             'afd-mult' => 1.15,
-            'recent-activity-mult' => 0.9,          # 0 if =
+            'recent-activity-mult' => 0.9, # 0 if =
             'aiv-mult' => 1.15,
-            'edit-summaries-mult' => 0.8,           # 0 if =
-            'namespaces-mult' => 1.0,               # 0 if =
-            'pages-created-live-mult' => 1.4,       # 0 if =
-            'pages-created-deleted-mult' => 1.4,    # 0 if =
-            'rpp-mult' => 1.15,                     # 0 if =
-            'user-rights-mult' => 0.75,             # 0 if =
+            'edit-summaries-mult' => 0.8, # 0 if =
+            'namespaces-mult' => 1.0, # 0 if =
+            'pages-created-live-mult' => 1.4, # 0 if =
+            'pages-created-deleted-mult' => 1.4, # 0 if =
+            'rpp-mult' => 1.15, # 0 if =
+            'user-rights-mult' => 0.75, # 0 if =
         ];
 
         // Grab the connection to the replica database (which is separate from the above)
@@ -188,14 +188,14 @@ 
                 $now = new DateTime();
                 $date = new DateTime($value);
                 $diff = $date->diff($now);
-                $formula = 365 * $diff->format('%y') + 30 * $diff->format('%m') + $diff->format('%d');
-                $value = $formula - 365;
+                $formula = 365 * $diff->format('%y')+30 * $diff->format('%m')+$diff->format('%d');
+                $value = $formula-365;
             }
 
             if ($key === 'id') {
                 $id = $value;
             } else {
-                $multiplierKey = $row['source'] . '-mult';
+                $multiplierKey = $row['source'].'-mult';
                 $multiplier = isset($multipliers[$multiplierKey]) ? $multipliers[$multiplierKey] : 1;
                 $score = max(min($value * $multiplier, 100), -100);
                 $master[$key]['mult'] = $multiplier;

src/AppBundle/Controller/EditSummaryController.php

Spacing +4 added lines, -6 removed lines

@@ -143,8 +143,8 @@ 
     {
         $dbName = $project->getDatabaseName();
 
-        $cacheKey = 'editsummaryusage.' . $dbName . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'editsummaryusage.'.$dbName.'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $cache = $this->container->get('cache.app');
         if ($cache->hasItem($cacheKey)) {
@@ -231,8 +231,7 @@ 
             if ($row['rev_minor_edit'] == 0) {
                 if ($row['rev_comment'] !== '') {
                     isset($monthEditsummaryTotals[$monthkey]) ?
-                        $monthEditsummaryTotals[$monthkey]++ :
-                        $monthEditsummaryTotals[$monthkey] = 1;
+                        $monthEditsummaryTotals[$monthkey]++ : $monthEditsummaryTotals[$monthkey] = 1;
                     $totalSummariesMajor++;
                 }
 
@@ -249,8 +248,7 @@ 
                 // If there is a comment, count it
                 if ($row['rev_comment'] !== '') {
                     isset($monthEditsummaryTotals[$monthkey]) ?
-                        $monthEditsummaryTotals[$monthkey]++ :
-                        $monthEditsummaryTotals[$monthkey] = 1;
+                        $monthEditsummaryTotals[$monthkey]++ : $monthEditsummaryTotals[$monthkey] = 1;
                     $totalSummariesMinor++;
                     $totalEditsMinor++;
                 } else {

Unused Use Statements -2 removed lines

@@ -11,9 +11,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Psr\Cache\CacheItemPoolInterface;
 use Xtools\Project;
-use Xtools\ProjectRepository;
 use Xtools\User;
 use DateTime;
 use DateInterval;

Doc Comments +1 added lines, -4 removed lines

@@ -38,7 +38,6 @@ 
      * The Edit Summary search form.
      *
      * @param Request $request The HTTP request.
-     * @param string  $project The project database name or domain.
      *
      * @Route("/editsummary",           name="es")
      * @Route("/editsummary",           name="EditSummary")
@@ -75,9 +74,7 @@ 
      * Display the Edit Summary results
      *
      * @param Request $request The HTTP request.
-     * @param string $project  The project domain name.
-     * @param string $username The username.
-     * @param string $namespace Namespace ID or 'all' for all namespaces.
+     * @param integer $namespace Namespace ID or 'all' for all namespaces.
      *
      * @Route("/editsummary/{project}/{username}/{namespace}", name="EditSummaryResult")
      *

src/AppBundle/Controller/AutomatedEditsController.php

Spacing +2 added lines, -2 removed lines

@@ -151,8 +151,8 @@
         // Get individual counts of how many times each tool was used.
         // This also includes a wikilink to the tool.
         $toolCounts = $user->getAutomatedCounts($projectData, $namespace, $start, $end);
-        $toolsTotal = array_reduce($toolCounts, function ($a, $b) {
-            return $a + $b['count'];
+        $toolsTotal = array_reduce($toolCounts, function($a, $b) {
+            return $a+$b['count'];
         });
 
         // Query to get combined (semi)automated using for all edits

Unused Use Statements -2 removed lines

@@ -11,9 +11,7 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Xtools\ProjectRepository;
 use Xtools\User;
-use Xtools\UserRepository;
 
 /**
  * This controller serves the AutomatedEdits tool.

Doc Comments +1 added lines, -2 removed lines

@@ -41,7 +41,6 @@ 
      * @Route("/automatededits/index.php", name="autoeditsLongIndexPhp")
      * @Route("/autoedits/{project}", name="autoeditsProject")
      * @param Request $request The HTTP request.
-     * @param string $project The project name.
      * @return Response
      */
     public function indexAction(Request $request)
@@ -79,7 +78,7 @@ 
      *     }
      * )
      * @param Request $request The HTTP request.
-     * @param int|string $namespace
+     * @param integer $namespace
      * @param null|string $start
      * @param null|string $end
      * @return RedirectResponse|Response

src/AppBundle/Controller/TopEditsController.php

Unused Use Statements -4 removed lines

@@ -11,12 +11,8 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Xtools\Page;
-use Xtools\PagesRepository;
 use Xtools\Project;
-use Xtools\ProjectRepository;
 use Xtools\User;
-use Xtools\UserRepository;
 use Xtools\TopEdits;
 use Xtools\TopEditsRepository;
 use Xtools\Edit;

Spacing +1 added lines, -1 removed lines

@@ -191,7 +191,7 @@
         // Send all to the template.
         return $this->render('topedits/result_article.html.twig', [
             'xtPage' => 'topedits',
-            'xtTitle' => $user->getUsername() . ' - ' . $page->getTitle(),
+            'xtTitle' => $user->getUsername().' - '.$page->getTitle(),
             'project' => $project,
             'user' => $user,
             'page' => $page,

Doc Comments +1 added lines, -4 removed lines

@@ -45,7 +45,6 @@ 
      * @Route("/topedits/index.php", name="TopEditsIndex")
      * @Route("/topedits/{project}", name="TopEditsProject")
      * @param Request $request
-     * @param string $project The project name.
      * @return Response
      */
     public function indexAction(Request $request)
@@ -76,8 +75,6 @@ 
      * @Route("/topedits/{project}/{username}/{namespace}/{article}", name="TopEditsResults",
      *     requirements={"article"=".+"})
      * @param Request $request The HTTP request.
-     * @param string $project
-     * @param string $username
      * @param int $namespace
      * @param string $article
      * @return RedirectResponse|Response
@@ -105,7 +102,7 @@ 
      * @param Request $request The HTTP request.
      * @param User $user The User.
      * @param Project $project The project.
-     * @param integer|string $namespace The namespace ID or 'all'
+     * @param integer $namespace The namespace ID or 'all'
      * @return \Symfony\Component\HttpFoundation\Response
      * @codeCoverageIgnore
      */

src/AppBundle/Controller/XtoolsController.php

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
         $params = $this->parseLegacyParams($request, $params);
 
         // Remove blank values.
-        return array_filter($params, function ($param) {
+        return array_filter($params, function($param) {
             // 'namespace' or 'username' could be '0'.
             return $param !== null && $param !== '';
         });
@@ -182,7 +182,7 @@ 
         ];
 
         // Remove blank values.
-        return array_filter($params, function ($param) {
+        return array_filter($params, function($param) {
             // 'namespace' or 'username' could be '0'.
             return $param !== null && $param !== '';
         });

Doc Comments +1 added lines, -1 removed lines

@@ -171,7 +171,7 @@
      * @param  bool   $optionalStartDate If set, no start date will be provided
      *   if only an end date is given. If false, start date will be set to one
      *   month before the end date.
-     * @return int[] Start and end date as UTC timestamps.
+     * @return integer[] Start and end date as UTC timestamps.
      */
     public function getUTCFromDateParams($start, $end, $optionalStartDate = false)
     {

src/AppBundle/Controller/ArticleInfoController.php

Unused Use Statements -4 removed lines

@@ -9,13 +9,9 @@
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Process\Process;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
-use Xtools\ProjectRepository;
-use Xtools\Page;
-use Xtools\PagesRepository;
 use Xtools\ArticleInfo;
 
 /**

Spacing +7 added lines, -7 removed lines

@@ -84,10 +84,10 @@ 
             $rendered = str_replace('"', '\"', trim($rendered));
 
             // Uglify temporary file.
-            $tmpFile = sys_get_temp_dir() . '/xtools_articleinfo_gadget.js';
+            $tmpFile = sys_get_temp_dir().'/xtools_articleinfo_gadget.js';
             $script = "echo \"$rendered\" | tee $tmpFile >/dev/null && ";
-            $script .= $this->get('kernel')->getRootDir() .
-                "/Resources/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle " .
+            $script .= $this->get('kernel')->getRootDir().
+                "/Resources/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle ".
                 "&& rm $tmpFile >/dev/null";
             $process = new Process($script);
             $process->run();
@@ -106,10 +106,10 @@ 
             $rendered = str_replace('\"', '"', trim($rendered));
 
             // Add comment after uglifying since it removes comments.
-            $rendered = "/**\n * This code was automatically generated and should not " .
-                "be manually edited.\n * For updates, please copy and paste from " .
-                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL) .
-                "\n * Released under GPL v3 license.\n */\n" . $rendered;
+            $rendered = "/**\n * This code was automatically generated and should not ".
+                "be manually edited.\n * For updates, please copy and paste from ".
+                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL).
+                "\n * Released under GPL v3 license.\n */\n".$rendered;
         }
 
         $response = new \Symfony\Component\HttpFoundation\Response($rendered);

src/AppBundle/Controller/PagesController.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Xtools\ProjectRepository;
-use Xtools\UserRepository;
 
 /**
  * This controller serves the Pages tool.

Doc Comments -3 removed lines

@@ -39,7 +39,6 @@ 
      * @Route("/pages/index.php", name="PagesIndexPhp")
      * @Route("/pages/{project}", name="PagesProject")
      * @param Request $request
-     * @param string $project The project domain name.
      * @return Response
      */
     public function indexAction(Request $request)
@@ -70,8 +69,6 @@ 
      * Display the results.
      * @Route("/pages/{project}/{username}/{namespace}/{redirects}", name="PagesResult")
      * @param Request $request
-     * @param string $project The project domain name.
-     * @param string $username The username.
      * @param string $namespace The ID of the namespace.
      * @param string $redirects Whether to follow redirects or not.
      * @return RedirectResponse|Response

src/AppBundle/Controller/SimpleEditCounterController.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Xtools\Project;
-use Xtools\ProjectRepository;
-use Xtools\User;
 
 /**
  * This controller handles the Simple Edit Counter tool.

Doc Comments -1 removed lines

@@ -39,7 +39,6 @@
      * @Route("/sc/index.php", name="SimpleEditCounterIndexPhp")
      * @Route("/sc/{project}", name="SimpleEditCounterProject")
      * @param Request $request The HTTP request.
-     * @param string $project The project database name or domain.
      * @return Response
      */
     public function indexAction(Request $request)

Spacing +4 added lines, -4 removed lines

@@ -132,16 +132,16 @@ 
                 $rev = $row['value'];
             }
             if ($row['source'] == 'groups') {
-                $groups .= $row['value']. ', ';
+                $groups .= $row['value'].', ';
             }
         }
 
         // Unknown user - If the user is created the $results variable will have 3 entries.
         // This is a workaround to detect non-existent IPs.
         if (count($results) < 3 && $arch == 0 && $rev == 0) {
-            $this->addFlash('notice', [ 'no-result', $username]);
+            $this->addFlash('notice', ['no-result', $username]);
 
-            return $this->redirectToRoute('SimpleEditCounterProject', [ 'project' => $project->getDomain() ]);
+            return $this->redirectToRoute('SimpleEditCounterProject', ['project' => $project->getDomain()]);
         }
 
         // Remove the last comma and space
@@ -170,7 +170,7 @@ 
             'project' => $project,
             'id' => $id,
             'arch' => $arch,
-            'rev' => $rev + $arch,
+            'rev' => $rev+$arch,
             'live' => $rev,
             'groups' => $groups,
             'globalGroups' => $globalGroups,

src/AppBundle/Controller/AdminStatsController.php

Spacing +2 added lines, -2 removed lines

@@ -103,7 +103,7 @@ 
         }
 
         // Generate a diff for the dates - this is the number of days we're spanning.
-        $days = ($end - $start) / 60 / 60 / 24;
+        $days = ($end-$start) / 60 / 60 / 24;
 
         // Get admin ID's, used to account for inactive admins
         $userGroupsTable = $projectData->getTableName('user_groups');
@@ -123,7 +123,7 @@ 
 
         // Iterate over query results, loading each user id into the array
         while ($row = $res->fetch()) {
-            $adminIdArr[] = $row['user_id'] ;
+            $adminIdArr[] = $row['user_id'];
         }
 
         // Set the query results to be useful in a sql statement.