x-tools / xtools

src/AppBundle/Controller/TopEditsController.php

Unused Use Statements -4 removed lines

@@ -11,12 +11,8 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Xtools\Page;
-use Xtools\PagesRepository;
 use Xtools\Project;
-use Xtools\ProjectRepository;
 use Xtools\User;
-use Xtools\UserRepository;
 use Xtools\TopEdits;
 use Xtools\TopEditsRepository;
 use Xtools\Edit;

Spacing +1 added lines, -1 removed lines

@@ -191,7 +191,7 @@
         // Send all to the template.
         return $this->render('topedits/result_article.html.twig', [
             'xtPage' => 'topedits',
-            'xtTitle' => $user->getUsername() . ' - ' . $page->getTitle(),
+            'xtTitle' => $user->getUsername().' - '.$page->getTitle(),
             'project' => $project,
             'user' => $user,
             'page' => $page,

src/AppBundle/Controller/AdminScoreController.php

Doc Comments -2 removed lines

@@ -65,8 +65,6 @@
     /**
      * Display the AdminScore results.
      * @Route("/adminscore/{project}/{username}", name="AdminScoreResult")
-     * @param string $project The project name.
-     * @param string $username The username.
      * @return Response
      * @todo Move SQL to a model.
      * @codeCoverageIgnore

Unused Use Statements -3 removed lines

@@ -10,10 +10,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use DateTime;
-use Xtools\ProjectRepository;
-use Xtools\UserRepository;
 
 /**
  * The AdminScoreController serves the search form and results page of the AdminScore tool

Spacing +15 added lines, -15 removed lines

@@ -92,20 +92,20 @@ 
 
         // MULTIPLIERS (to review)
         $multipliers = [
-            'account-age-mult' => 1.25,             # 0 if = 365 jours
-            'edit-count-mult' => 1.25,              # 0 if = 10 000
-            'user-page-mult' => 0.1,                # 0 if =
-            'patrols-mult' => 1,                    # 0 if =
-            'blocks-mult' => 1.4,                   # 0 if = 10
+            'account-age-mult' => 1.25, # 0 if = 365 jours
+            'edit-count-mult' => 1.25, # 0 if = 10 000
+            'user-page-mult' => 0.1, # 0 if =
+            'patrols-mult' => 1, # 0 if =
+            'blocks-mult' => 1.4, # 0 if = 10
             'afd-mult' => 1.15,
-            'recent-activity-mult' => 0.9,          # 0 if =
+            'recent-activity-mult' => 0.9, # 0 if =
             'aiv-mult' => 1.15,
-            'edit-summaries-mult' => 0.8,           # 0 if =
-            'namespaces-mult' => 1.0,               # 0 if =
-            'pages-created-live-mult' => 1.4,       # 0 if =
-            'pages-created-deleted-mult' => 1.4,    # 0 if =
-            'rpp-mult' => 1.15,                     # 0 if =
-            'user-rights-mult' => 0.75,             # 0 if =
+            'edit-summaries-mult' => 0.8, # 0 if =
+            'namespaces-mult' => 1.0, # 0 if =
+            'pages-created-live-mult' => 1.4, # 0 if =
+            'pages-created-deleted-mult' => 1.4, # 0 if =
+            'rpp-mult' => 1.15, # 0 if =
+            'user-rights-mult' => 0.75, # 0 if =
         ];
 
         // Grab the connection to the replica database (which is separate from the above)
@@ -188,14 +188,14 @@ 
                 $now = new DateTime();
                 $date = new DateTime($value);
                 $diff = $date->diff($now);
-                $formula = 365 * $diff->format('%y') + 30 * $diff->format('%m') + $diff->format('%d');
-                $value = $formula - 365;
+                $formula = 365 * $diff->format('%y')+30 * $diff->format('%m')+$diff->format('%d');
+                $value = $formula-365;
             }
 
             if ($key === 'id') {
                 $id = $value;
             } else {
-                $multiplierKey = $row['source'] . '-mult';
+                $multiplierKey = $row['source'].'-mult';
                 $multiplier = isset($multipliers[$multiplierKey]) ? $multipliers[$multiplierKey] : 1;
                 $score = max(min($value * $multiplier, 100), -100);
                 $master[$key]['mult'] = $multiplier;

src/AppBundle/Controller/XtoolsController.php

Doc Comments +3 added lines, -3 removed lines

@@ -24,7 +24,6 @@ 
      * counterparts (e.g. 'lang' and 'wiki').
      *
      * @param  Request $request
-     * @param  string $project
      * @return string[] Normalized parameters (no legacy params).
      */
     public function parseQueryParams(Request $request)
@@ -80,7 +79,7 @@ 
      * given project string is invalid.
      *
      * @param  string[] $params Query params.
-     * @return Project
+     * @return \Xtools\Project
      */
     public function getProjectFromQuery($params)
     {
@@ -108,6 +107,7 @@ 
     /**
      * If the given project and user are valid, Project and User instances are returned.
      * Otherwise a redirect is returned that goes back to the index page.
+     * @param string $tooHighEditCountAction
      * @return RedirectResponse|Project|User
      */
     public function validateProjectAndUser(Request $request, $tooHighEditCountAction = null)
@@ -147,7 +147,7 @@ 
 
     /**
      * Get a Page instance from the given page title, and validate that it exists.
-     * @param  Project $project
+     * @param  \Xtools\Project $project
      * @param  string $pageTitle
      * @return Page|RedirectResponse Page or redirect back to index if page doesn't exist.
      */

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
         $params = $this->parseLegacyParams($request, $params);
 
         // Remove blank values.
-        return array_filter($params, function ($param) {
+        return array_filter($params, function($param) {
             // 'namespace' or 'username' could be '0'.
             return $param !== null && $param !== '';
         });
@@ -182,7 +182,7 @@ 
         ];
 
         // Remove blank values.
-        return array_filter($params, function ($param) {
+        return array_filter($params, function($param) {
             // 'namespace' or 'username' could be '0'.
             return $param !== null && $param !== '';
         });