x-tools / xtools

src/Xtools/PagesRepository.php

Doc Comments +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
      * Get metadata about a single page from the API.
      * @param Project $project The project to which the page belongs.
      * @param string $pageTitle Page title.
-     * @return string[] Array with some of the following keys: pageid, title, missing, displaytitle,
+     * @return string|null Array with some of the following keys: pageid, title, missing, displaytitle,
      * url.
      */
     public function getPageInfo(Project $project, $pageTitle)
@@ -96,7 +96,7 @@ 
      * Get the statement for a single revision, so that you can iterate row by row.
      * @param Page $page The page.
      * @param User|null $user Specify to get only revisions by the given user.
-     * @return Doctrine\DBAL\Driver\PDOStatement
+     * @return \Doctrine\DBAL\Driver\Statement
      */
     public function getRevisionsStmt(Page $page, User $user = null)
     {

Spacing +4 added lines, -4 removed lines

@@ -322,7 +322,7 @@ 
 
         $wikidataId = ltrim($page->getWikidataId(), 'Q');
 
-        $sql = "SELECT " . ($count ? 'COUNT(*) AS count' : '*') . "
+        $sql = "SELECT ".($count ? 'COUNT(*) AS count' : '*')."
                 FROM wikidatawiki_p.wb_items_per_site
                 WHERE ips_item_id = :wikidataId";
 
@@ -332,7 +332,7 @@ 
 
         $result = $resultQuery->fetchAll();
 
-        return $count ? (int) $result[0]['count'] : $result;
+        return $count ? (int)$result[0]['count'] : $result;
     }
 
     /**
@@ -372,7 +372,7 @@ 
 
         // Transform to associative array by 'type'
         foreach ($res as $row) {
-            $data[$row['type'] . '_count'] = $row['value'];
+            $data[$row['type'].'_count'] = $row['value'];
         }
 
         return $data;
@@ -409,7 +409,7 @@ 
 
         $project = $page->getProject()->getDomain();
 
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
             "$project/all-access/user/$title/daily/$start/$end";
 
         $res = $client->request('GET', $url);

src/AppBundle/Controller/ApiController.php

Unused Use Statements -4 removed lines

@@ -5,12 +5,8 @@
 
 namespace AppBundle\Controller;
 
-use Exception;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Debug\Exception\FatalErrorException;
 use FOS\RestBundle\Controller\Annotations as Rest;
 use FOS\RestBundle\Controller\FOSRestController;
 use FOS\RestBundle\View\View;

Spacing +8 added lines, -8 removed lines

@@ -106,13 +106,13 @@ 
         $data = $user->getNonautomatedEdits($project, $namespace, $start, $end, $offset);
 
         if ($format === 'html') {
-            $edits = array_map(function ($attrs) use ($project, $username) {
+            $edits = array_map(function($attrs) use ($project, $username) {
                 $nsName = '';
                 if ($attrs['page_namespace']) {
                     $nsName = $project->getNamespaces()[$attrs['page_namespace']];
                 }
                 $page = $project->getRepository()
-                    ->getPage($project, $nsName . ':' . $attrs['page_title']);
+                    ->getPage($project, $nsName.':'.$attrs['page_title']);
                 $attrs['id'] = $attrs['rev_id'];
                 $attrs['username'] = $username;
                 return new Edit($page, $attrs);
@@ -159,17 +159,17 @@ 
         $info = $page->getBasicEditingInfo();
         $creationDateTime = DateTime::createFromFormat('YmdHis', $info['created_at']);
         $modifiedDateTime = DateTime::createFromFormat('YmdHis', $info['modified_at']);
-        $secsSinceLastEdit = $modifiedDateTime->getTimestamp() - $creationDateTime->getTimestamp();
+        $secsSinceLastEdit = $modifiedDateTime->getTimestamp()-$creationDateTime->getTimestamp();
 
         $data = [
-            'revisions' => (int) $info['num_edits'],
-            'editors' => (int) $info['num_editors'],
+            'revisions' => (int)$info['num_edits'],
+            'editors' => (int)$info['num_editors'],
             'author' => $info['author'],
-            'author_editcount' => (int) $info['author_editcount'],
+            'author_editcount' => (int)$info['author_editcount'],
             'created_at' => $creationDateTime->format('Y-m-d H:i'),
             'modified_at' => $modifiedDateTime->format('Y-m-d H:i'),
             'secs_since_last_edit' => $secsSinceLastEdit,
-            'watchers' => (int) $page->getWatchers(),
+            'watchers' => (int)$page->getWatchers(),
             'pageviews' => $page->getLastPageviews($pageviewsOffset),
             'pageviews_offset' => $pageviewsOffset,
         ];
@@ -220,7 +220,7 @@ 
         }
 
         $conn = $this->getDoctrine()->getManager('default')->getConnection();
-        $date =  date('Y-m-d');
+        $date = date('Y-m-d');
 
         // Increment count in timeline
         $existsSql = "SELECT 1 FROM usage_timeline

src/Xtools/Page.php

Spacing +6 added lines, -6 removed lines

@@ -183,7 +183,7 @@ 
 
         // Otherwise do a COUNT in the event fetching
         // all revisions is not desired
-        return (int) $this->getRepository()->getNumRevisions($this, $user);
+        return (int)$this->getRepository()->getNumRevisions($this, $user);
     }
 
     /**
@@ -341,7 +341,7 @@ 
 
         $wikidataInfo = $this->getRepository()->getWikidataInfo($this);
 
-        $terms = array_map(function ($entry) {
+        $terms = array_map(function($entry) {
             return $entry['term'];
         }, $wikidataInfo);
 
@@ -352,7 +352,7 @@ 
                 'prio' => 2,
                 'name' => 'Wikidata',
                 'notice' => "Label for language <em>$lang</em> is missing", // FIXME: i18n
-                'explanation' => "See: <a target='_blank' " .
+                'explanation' => "See: <a target='_blank' ".
                     "href='//www.wikidata.org/wiki/Help:Label'>Help:Label</a>",
             ];
         }
@@ -362,7 +362,7 @@ 
                 'prio' => 3,
                 'name' => 'Wikidata',
                 'notice' => "Description for language <em>$lang</em> is missing", // FIXME: i18n
-                'explanation' => "See: <a target='_blank' " .
+                'explanation' => "See: <a target='_blank' ".
                     "href='//www.wikidata.org/wiki/Help:Description'>Help:Description</a>",
             ];
         }
@@ -439,8 +439,8 @@ 
 
         $pageviews = $this->getPageviews($start, $end);
 
-        return array_sum(array_map(function ($item) {
-            return (int) $item['views'];
+        return array_sum(array_map(function($item) {
+            return (int)$item['views'];
         }, $pageviews['items']));
     }
 }

Doc Comments +7 added lines, -7 removed lines

@@ -59,7 +59,7 @@ 
 
     /**
      * Get this page's database ID.
-     * @return int
+     * @return \string|null
      */
     public function getId()
     {
@@ -69,7 +69,7 @@ 
 
     /**
      * Get this page's length in bytes.
-     * @return int
+     * @return \string|null
      */
     public function getLength()
     {
@@ -93,7 +93,7 @@ 
 
     /**
      * Get the full URL of this page.
-     * @return string
+     * @return \string|null
      */
     public function getUrl()
     {
@@ -103,7 +103,7 @@ 
 
     /**
      * Get the numerical ID of the namespace of this page.
-     * @return int
+     * @return \string|null
      */
     public function getNamespace()
     {
@@ -113,7 +113,7 @@ 
 
     /**
      * Get the number of page watchers.
-     * @return int
+     * @return \string|null
      */
     public function getWatchers()
     {
@@ -420,8 +420,8 @@ 
 
     /**
      * Get page views for the given page and timeframe.
-     * @param string|DateTime $start In the format YYYYMMDD
-     * @param string|DateTime $end In the format YYYYMMDD
+     * @param string $start In the format YYYYMMDD
+     * @param string $end In the format YYYYMMDD
      * @return string[]
      */
     public function getPageviews($start, $end)

src/AppBundle/Twig/AppExtension.php

Spacing +40 added lines, -40 removed lines

@@ -32,32 +32,32 @@ 
     {
         $options = ['is_safe' => ['html']];
         return [
-            new \Twig_SimpleFunction('request_time', [ $this, 'requestTime' ], $options),
-            new \Twig_SimpleFunction('memory_usage', [ $this, 'requestMemory' ], $options),
-            new \Twig_SimpleFunction('year', [ $this, 'generateYear' ], $options),
-            new \Twig_SimpleFunction('msgPrintExists', [ $this, 'intuitionMessagePrintExists' ], $options),
-            new \Twig_SimpleFunction('msgExists', [ $this, 'intuitionMessageExists' ], $options),
-            new \Twig_SimpleFunction('msg', [ $this, 'intuitionMessage' ], $options),
-            new \Twig_SimpleFunction('lang', [ $this, 'getLang' ], $options),
-            new \Twig_SimpleFunction('langName', [ $this, 'getLangName' ], $options),
-            new \Twig_SimpleFunction('allLangs', [ $this, 'getAllLangs' ]),
-            new \Twig_SimpleFunction('isRTL', [ $this, 'intuitionIsRTL' ]),
-            new \Twig_SimpleFunction('isRTLLang', [ $this, 'intuitionIsRTLLang' ]),
-            new \Twig_SimpleFunction('shortHash', [ $this, 'gitShortHash' ]),
-            new \Twig_SimpleFunction('hash', [ $this, 'gitHash' ]),
-            new \Twig_SimpleFunction('enabled', [ $this, 'tabEnabled' ]),
-            new \Twig_SimpleFunction('tools', [ $this, 'allTools' ]),
-            new \Twig_SimpleFunction('color', [ $this, 'getColorList' ]),
-            new \Twig_SimpleFunction('chartColor', [ $this, 'chartColor' ]),
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
-            new \Twig_SimpleFunction('isSingleWiki', [ $this, 'isSingleWiki' ]),
-            new \Twig_SimpleFunction('getReplagThreshold', [ $this, 'getReplagThreshold' ]),
-            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [ $this, 'loadStylesheetsFromCDN' ]),
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
-            new \Twig_SimpleFunction('replag', [ $this, 'replag' ]),
-            new \Twig_SimpleFunction('link', [ $this, 'link' ]),
-            new \Twig_SimpleFunction('quote', [ $this, 'quote' ]),
-            new \Twig_SimpleFunction('bugReportURL', [ $this, 'bugReportURL' ]),
+            new \Twig_SimpleFunction('request_time', [$this, 'requestTime'], $options),
+            new \Twig_SimpleFunction('memory_usage', [$this, 'requestMemory'], $options),
+            new \Twig_SimpleFunction('year', [$this, 'generateYear'], $options),
+            new \Twig_SimpleFunction('msgPrintExists', [$this, 'intuitionMessagePrintExists'], $options),
+            new \Twig_SimpleFunction('msgExists', [$this, 'intuitionMessageExists'], $options),
+            new \Twig_SimpleFunction('msg', [$this, 'intuitionMessage'], $options),
+            new \Twig_SimpleFunction('lang', [$this, 'getLang'], $options),
+            new \Twig_SimpleFunction('langName', [$this, 'getLangName'], $options),
+            new \Twig_SimpleFunction('allLangs', [$this, 'getAllLangs']),
+            new \Twig_SimpleFunction('isRTL', [$this, 'intuitionIsRTL']),
+            new \Twig_SimpleFunction('isRTLLang', [$this, 'intuitionIsRTLLang']),
+            new \Twig_SimpleFunction('shortHash', [$this, 'gitShortHash']),
+            new \Twig_SimpleFunction('hash', [$this, 'gitHash']),
+            new \Twig_SimpleFunction('enabled', [$this, 'tabEnabled']),
+            new \Twig_SimpleFunction('tools', [$this, 'allTools']),
+            new \Twig_SimpleFunction('color', [$this, 'getColorList']),
+            new \Twig_SimpleFunction('chartColor', [$this, 'chartColor']),
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
+            new \Twig_SimpleFunction('isSingleWiki', [$this, 'isSingleWiki']),
+            new \Twig_SimpleFunction('getReplagThreshold', [$this, 'getReplagThreshold']),
+            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [$this, 'loadStylesheetsFromCDN']),
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
+            new \Twig_SimpleFunction('replag', [$this, 'replag']),
+            new \Twig_SimpleFunction('link', [$this, 'link']),
+            new \Twig_SimpleFunction('quote', [$this, 'quote']),
+            new \Twig_SimpleFunction('bugReportURL', [$this, 'bugReportURL']),
             new \Twig_SimpleFunction('logged_in_user', [$this, 'functionLoggedInUser']),
             new \Twig_SimpleFunction('isUserAnon', [$this, 'isUserAnon']),
             new \Twig_SimpleFunction('nsName', [$this, 'nsName']),
@@ -72,7 +72,7 @@ 
      */
     public function requestTime($decimals = 3)
     {
-        return number_format(microtime(true) - $_SERVER['REQUEST_TIME_FLOAT'], $decimals);
+        return number_format(microtime(true)-$_SERVER['REQUEST_TIME_FLOAT'], $decimals);
     }
 
     /**
@@ -105,7 +105,7 @@ 
      */
     public function intuitionMessageExists($message = "")
     {
-        return $this->getIntuition()->msgExists($message, [ "domain" => "xtools" ]);
+        return $this->getIntuition()->msgExists($message, ["domain" => "xtools"]);
     }
 
     /**
@@ -136,7 +136,7 @@ 
      */
     public function intuitionMessage($message = "", $vars = [])
     {
-        return $this->getIntuition()->msg($message, [ "domain" => "xtools", "variables" => $vars ]);
+        return $this->getIntuition()->msg($message, ["domain" => "xtools", "variables" => $vars]);
     }
 
     /**
@@ -165,10 +165,10 @@ 
      */
     public function getAllLangs()
     {
-        $messageFiles = glob($this->container->getParameter("kernel.root_dir") . '/../i18n/*.json');
+        $messageFiles = glob($this->container->getParameter("kernel.root_dir").'/../i18n/*.json');
 
         $languages = array_values(array_unique(array_map(
-            function ($filename) {
+            function($filename) {
                 return basename($filename, '.json');
             },
             $messageFiles
@@ -516,9 +516,9 @@ 
     public function getFilters()
     {
         return [
-            new \Twig_SimpleFilter('capitalize_first', [ $this, 'capitalizeFirst' ]),
-            new \Twig_SimpleFilter('percent_format', [ $this, 'percentFormat' ]),
-            new \Twig_SimpleFilter('diff_format', [ $this, 'diffFormat' ], [ 'is_safe' => [ 'html' ] ]),
+            new \Twig_SimpleFilter('capitalize_first', [$this, 'capitalizeFirst']),
+            new \Twig_SimpleFilter('percent_format', [$this, 'percentFormat']),
+            new \Twig_SimpleFilter('diff_format', [$this, 'diffFormat'], ['is_safe' => ['html']]),
         ];
     }
 
@@ -545,10 +545,10 @@ 
         if (!$denominator) {
             $quotient = $numerator;
         } else {
-            $quotient = ( $numerator / $denominator ) * 100;
+            $quotient = ($numerator / $denominator) * 100;
         }
 
-        return round($quotient, $precision) . '%';
+        return round($quotient, $precision).'%';
     }
 
     /**
@@ -623,20 +623,20 @@ 
 
         if ($seconds >= 86400) {
             // Over a day
-            $val = (int) floor($seconds / 86400);
+            $val = (int)floor($seconds / 86400);
             $key = 'days';
         } elseif ($seconds >= 3600) {
             // Over an hour, less than a day
-            $val = (int) floor($seconds / 3600);
+            $val = (int)floor($seconds / 3600);
             $key = 'hours';
         } elseif ($seconds >= 60) {
             // Over a minute, less than an hour
-            $val = (int) floor($seconds / 60);
+            $val = (int)floor($seconds / 60);
             $key = 'minutes';
         }
 
         if ($translate) {
-            return number_format($val) . ' ' . $this->intuitionMessage("num-$key", [$val]);
+            return number_format($val).' '.$this->intuitionMessage("num-$key", [$val]);
         } else {
             return [number_format($val), "num-$key"];
         }