x-tools / xtools

src/AppBundle/Controller/RfXAnalysisController.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Xtools\ProjectRepository;
 use Xtools\RFA;
 

Spacing +2 added lines, -2 removed lines

@@ -170,7 +170,7 @@ 
         $neutral = $rfa->getSection("neutral");
         $dup = $rfa->getDuplicates();
 
-        if ((sizeof($support) + sizeof($oppose) + sizeof($neutral)) == 0) {
+        if ((sizeof($support)+sizeof($oppose)+sizeof($neutral)) == 0) {
             $this->addFlash("notice", ["no-result", $pagename]);
             return $this->redirectToRoute(
                 "rfxAnalysisProject",
@@ -183,7 +183,7 @@ 
         $end = $rfa->getEndDate();
 
         $percent = (sizeof($support) /
-            (sizeof($support) + sizeof($oppose) + sizeof($neutral)));
+            (sizeof($support)+sizeof($oppose)+sizeof($neutral)));
 
         $percent = $percent * 100;
 

src/AppBundle/Controller/RfXVoteCalculatorController.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace AppBundle\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\CssSelector\Exception\InternalErrorException;
-use Symfony\Component\Debug\Exception\ContextErrorException;
 use Symfony\Component\HttpFoundation\Request;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Xtools\ProjectRepository;

Spacing +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
         $username = $request->query->get('username');
 
         if ($projectQuery != "" && $username != "") {
-            $routeParams = [ 'project'=>$projectQuery, 'username' => $username ];
+            $routeParams = ['project'=>$projectQuery, 'username' => $username];
             return $this->redirectToRoute(
                 "rfapResult",
                 $routeParams
@@ -135,8 +135,8 @@ 
             $titles = [];
 
             while ($row = $sth->fetch()) {
-                $titles[] = $namespaces[$row["page_namespace"]] .
-                    ":" .$row["page_title"];
+                $titles[] = $namespaces[$row["page_namespace"]].
+                    ":".$row["page_title"];
             }
 
             // Chunking... it's possible to make a URI too long

src/Xtools/RFA.php

Doc Comments +4 added lines, -1 removed lines

@@ -20,7 +20,7 @@ 
      * Returns matches.
      *
      * @param $input
-     * @param $matches
+     * @param string[] $matches
      *
      * @return int
      */
@@ -85,6 +85,9 @@ 
         return $this->userSectionFound;
     }
 
+    /**
+     * @param string $sectionName
+     */
     public function getSection($sectionName) {
         $sectionName = strtolower($sectionName);
         if (!isset($this->data[$sectionName])) {

Braces +1 added lines, -2 removed lines

@@ -89,8 +89,7 @@
         $sectionName = strtolower($sectionName);
         if (!isset($this->data[$sectionName])) {
             return [];
-        }
-        else {
+        } else {
             return $this->data[$sectionName];
         }
     }

Spacing +3 added lines, -3 removed lines

@@ -25,7 +25,7 @@ 
      *
      * @return int
      */
-    protected function findSig( $input, &$matches ) {
+    protected function findSig($input, &$matches) {
         //Supports User: and User talk: wikilinks, {{fullurl}}, unsubsted {{unsigned}}, unsubsted {{unsigned2}}, anything that looks like a custom sig template
         // TODO: Cross-wiki this sucker
         return preg_match_all(
@@ -80,7 +80,7 @@ 
             }
         }
 
-        $final = [];    // initialize the final array
+        $final = []; // initialize the final array
         $finalRaw = []; // Initialize the raw data array
 
         foreach ($this->data as $key => $value) {
@@ -93,7 +93,7 @@ 
 
         $final = array_count_values($final); // find repetition and its count
 
-        $final = array_diff($final, [1]);    // remove single occurrences
+        $final = array_diff($final, [1]); // remove single occurrences
 
         $this->duplicates = array_keys($final);
 

src/AppBundle/Twig/AppExtension.php

Braces +3 added lines, -1 removed lines

@@ -489,7 +489,9 @@
      */
     public function quote()
     {
-        if (!$this->container->getParameter("enable.bash")) return "";
+        if (!$this->container->getParameter("enable.bash")) {
+            return "";
+        }
         $quotes = $this->container->getParameter('quotes');
         $id = array_rand($quotes);
         return $quotes[$id];

src/AppBundle/Helper/ApiHelper.php

Spacing +9 added lines, -9 removed lines

@@ -60,7 +60,7 @@ 
     public function groups($project, $username)
     {
         $this->setUp($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
 
@@ -88,7 +88,7 @@ 
     public function globalGroups($project, $username)
     {
         $this->setUp($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
 
@@ -138,7 +138,7 @@ 
                 $groups[] = "B";
             }
             if (in_array("steward", $admin["groups"])) {
-                $groups[] = "S" ;
+                $groups[] = "S";
             }
             if (in_array("checkuser", $admin["groups"])) {
                 $groups[] = "CU";
@@ -149,7 +149,7 @@ 
             if (in_array("bot", $admin["groups"])) {
                 $groups[] = "Bot";
             }
-            $result[ $admin["name"] ] = [
+            $result[$admin["name"]] = [
                 "groups" => implode('/', $groups)
             ];
         }
@@ -182,7 +182,7 @@ 
             $normalized = [];
             if (isset($result['query']['normalized'])) {
                 array_map(
-                    function ($e) use (&$normalized) {
+                    function($e) use (&$normalized) {
                         $normalized[$e['to']] = $e['from'];
                     },
                     $result['query']['normalized']
@@ -267,7 +267,7 @@ 
         $query = FluentRequest::factory()->setAction('query')->setParams($requestData);
         $innerPromise = $this->api->getRequestAsync($query);
 
-        $innerPromise->then(function ($result) use (&$data) {
+        $innerPromise->then(function($result) use (&$data) {
             // some failures come back as 200s, so we still resolve and let the outer function handle it
             if (isset($result['error']) || !isset($result['query'])) {
                 return $data['promise']->resolve($data);
@@ -347,7 +347,7 @@ 
 
         $titleText = join("|", $titles);
 
-        $params= [
+        $params = [
             "titles" => $titleText,
             "prop" => "revisions",
             "rvprop" =>"content"
@@ -360,8 +360,8 @@ 
             if (!isset($res["query"]["pages"])) {
                 return [];
             }
-            foreach($res["query"]["pages"] as $key => $value) {
-                if(isset($value["revisions"][0]["*"])) {
+            foreach ($res["query"]["pages"] as $key => $value) {
+                if (isset($value["revisions"][0]["*"])) {
                     $result[$value["title"]] = $value["revisions"][0]["*"];
                 }
                 else {

Braces +1 added lines, -2 removed lines

@@ -363,8 +363,7 @@
             foreach($res["query"]["pages"] as $key => $value) {
                 if(isset($value["revisions"][0]["*"])) {
                     $result[$value["title"]] = $value["revisions"][0]["*"];
-                }
-                else {
+                } else {
                     $result[$value["title"]] = "";
                 }
             }

src/Xtools/ProjectRepository.php

Braces +1 added lines, -2 removed lines

@@ -208,8 +208,7 @@
 
         try {
             $api = MediawikiApi::newFromPage($projectUrl);
-        }
-        catch (\Exception $e) {
+        } catch (\Exception $e) {
             return null;
         }