Completed
Pull Request — master (#184)
by Matthew
05:19
created
web/app_dev.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 // Feel free to remove this, extend it, or make something more sophisticated.
13 13
 if (isset($_SERVER['HTTP_CLIENT_IP'])
14 14
     || isset($_SERVER['HTTP_X_FORWARDED_FOR'])
15
-    || !( in_array(@$_SERVER['REMOTE_ADDR'], [ '127.0.0.1', 'fe80::1', '::1' ]) || php_sapi_name() === 'cli-server' )
15
+    || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1']) || php_sapi_name() === 'cli-server')
16 16
 ) {
17 17
     header('HTTP/1.0 403 Forbidden');
18 18
     exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
Please login to merge, or discard this patch.
src/AppBundle/Controller/QuoteController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
             'quote/all.html.twig',
112 112
             [
113 113
                 'base_dir' => realpath(
114
-                    $this->getParameter('kernel.root_dir') . '/..'
114
+                    $this->getParameter('kernel.root_dir').'/..'
115 115
                 ),
116 116
                 'xtPage' => 'bash',
117 117
                 'quotes' => $quotes,
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
             'quote/view.html.twig',
161 161
             [
162 162
                 'base_dir' => realpath(
163
-                    $this->getParameter('kernel.root_dir') . '/..'
163
+                    $this->getParameter('kernel.root_dir').'/..'
164 164
                 ),
165 165
                 "xtPage" => "bash",
166 166
                 "text" => $text,
Please login to merge, or discard this patch.
src/Xtools/RFX.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
             }
120 120
         }
121 121
 
122
-        $final = [];    // initialize the final array
122
+        $final = []; // initialize the final array
123 123
         $finalRaw = []; // Initialize the raw data array
124 124
 
125 125
         foreach ($this->data as $key => $value) {
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 
133 133
         $final = array_count_values($final); // find repetition and its count
134 134
 
135
-        $final = array_diff($final, [1]);    // remove single occurrences
135
+        $final = array_diff($final, [1]); // remove single occurrences
136 136
 
137 137
         $this->duplicates = array_keys($final);
138 138
     }
Please login to merge, or discard this patch.
src/AppBundle/Controller/RfXVoteCalculatorController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
         $username = $request->query->get('username');
49 49
 
50 50
         if ($projectQuery != '' && $username != '') {
51
-            $routeParams = [ 'project' => $projectQuery, 'username' => $username ];
51
+            $routeParams = ['project' => $projectQuery, 'username' => $username];
52 52
             return $this->redirectToRoute(
53 53
                 'rfxvoteResult',
54 54
                 $routeParams
@@ -167,8 +167,8 @@  discard block
 block discarded – undo
167 167
             $titles = [];
168 168
 
169 169
             while ($row = $sth->fetch()) {
170
-                $titles[] = $namespaces[$row['page_namespace']] .
171
-                    ':' .$row['page_title'];
170
+                $titles[] = $namespaces[$row['page_namespace']].
171
+                    ':'.$row['page_title'];
172 172
             }
173 173
 
174 174
             // Chunking... it's possible to make a URI too long
Please login to merge, or discard this patch.
src/AppBundle/Controller/RfXAnalysisController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -166,7 +166,7 @@
 block discarded – undo
166 166
         $neutral = $rfx->getSection('neutral');
167 167
         $dup = $rfx->getDuplicates();
168 168
 
169
-        $total = count($support) + count($oppose) + count($neutral);
169
+        $total = count($support)+count($oppose)+count($neutral);
170 170
 
171 171
         if ($total === 0) {
172 172
             $this->addFlash('notice', ['no-result', $pagename]);
Please login to merge, or discard this patch.
src/AppBundle/Controller/TopEditsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@
 block discarded – undo
191 191
         // Send all to the template.
192 192
         return $this->render('topedits/result_article.html.twig', [
193 193
             'xtPage' => 'topedits',
194
-            'xtTitle' => $user->getUsername() . ' - ' . $page->getTitle(),
194
+            'xtTitle' => $user->getUsername().' - '.$page->getTitle(),
195 195
             'project' => $project,
196 196
             'user' => $user,
197 197
             'page' => $page,
Please login to merge, or discard this patch.
src/Xtools/AdminStatsRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
         $userGroupsTable = $project->getTableName('user_groups');
53 53
         $ufgTable = $project->getTableName('user_former_groups');
54 54
 
55
-        $adminGroups = join(array_map(function ($group) {
55
+        $adminGroups = join(array_map(function($group) {
56 56
             return "'$group'";
57 57
         }, $this->getAdminGroups($project)), ',');
58 58
 
Please login to merge, or discard this patch.
src/Xtools/ProjectRepository.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
                     || $projMetadata['url'] == "https://$project"
150 150
                     || $projMetadata['url'] == "https://$project.org"
151 151
                     || $projMetadata['url'] == "https://www.$project") {
152
-                    $this->log->debug(__METHOD__ . " Using cached data for $project");
152
+                    $this->log->debug(__METHOD__." Using cached data for $project");
153 153
                     return $projMetadata;
154 154
                 }
155 155
             }
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
         $optedIn = $this->container->getParameter('opted_in');
293 293
         // In case there's just one given.
294 294
         if (!is_array($optedIn)) {
295
-            $optedIn = [ $optedIn ];
295
+            $optedIn = [$optedIn];
296 296
         }
297 297
         return $optedIn;
298 298
     }
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -330,9 +330,9 @@
 block discarded – undo
330 330
     {
331 331
         $pageTable = $this->getTableName($project->getDatabaseName(), 'page');
332 332
         $query = "SELECT page_id "
333
-             . " FROM $pageTable "
334
-             . " WHERE page_namespace = :ns AND page_title = :title AND page_len > 0 "
335
-             . " LIMIT 1";
333
+                . " FROM $pageTable "
334
+                . " WHERE page_namespace = :ns AND page_title = :title AND page_len > 0 "
335
+                . " LIMIT 1";
336 336
         $params = [
337 337
             'ns' => $namespaceId,
338 338
             'title' => str_replace(' ', '_', $pageTitle),
Please login to merge, or discard this patch.
src/Xtools/AdminStats.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
      */
126 126
     public function numDays()
127 127
     {
128
-        return ($this->end - $this->start) / 60 / 60 / 24;
128
+        return ($this->end-$this->start) / 60 / 60 / 24;
129 129
     }
130 130
 
131 131
     /**
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
         $stats = $this->groupAdminStatsByUsername($stats, $abbreviateGroups);
155 155
 
156 156
         // Resort, as for some reason the SQL isn't doing this properly.
157
-        uasort($stats, function ($a, $b) {
157
+        uasort($stats, function($a, $b) {
158 158
             if ($a['total'] === $b['total']) {
159 159
                 return 0;
160 160
             }
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
      */
297 297
     public function getNumAdminsWithActions()
298 298
     {
299
-        return $this->numAdmins() - $this->adminsWithoutActions;
299
+        return $this->numAdmins()-$this->adminsWithoutActions;
300 300
     }
301 301
 
302 302
     /**
Please login to merge, or discard this patch.