x-systems / epesi-filestorage

src/FileStorageCore.php

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
 	
 	public static function boot()
 	{
-		Route::group(['namespace' => 'Epesi\FileStorage'], function(){
+		Route::group(['namespace' => 'Epesi\FileStorage'], function() {
 			Route::get('file', 'FileStorageController@get')->middleware('web', FileStorageAccess::class);
 		});
 		

src/FileStorageController.php

Indentation +39 added lines, -39 removed lines

@@ -7,49 +7,49 @@
 
 class FileStorageController extends Controller
 {
-    public function get(Request $request)
-    {
-    	try {
-    		$meta = Database\Models\Meta::get($request->get('id'));
-    	} catch (\Exception $e) {
-    		abort(404);
-    	}
+	public function get(Request $request)
+	{
+		try {
+			$meta = Database\Models\Meta::get($request->get('id'));
+		} catch (\Exception $e) {
+			abort(404);
+		}
     	
-    	$useThumbnail = false;
-    	$disposition = 'attachment';
-    	switch ($request->get('action')) {	
-    		case 'preview':
-    			$useThumbnail = true;
-    		case 'inline':
-    			$disposition = 'inline';
-    			break;
+		$useThumbnail = false;
+		$disposition = 'attachment';
+		switch ($request->get('action')) {	
+			case 'preview':
+				$useThumbnail = true;
+			case 'inline':
+				$disposition = 'inline';
+				break;
     			
-    		default:
-    			break;
-    	}
+			default:
+				break;
+		}
 
-    	if ($useThumbnail && $request->get('thumbnail', 1) && ($thumbnail = $meta->thumbnail)) {
-    		$mime = $thumbnail['mime'];
-    		$filename = $thumbnail['name'];
-    		$contents = $thumbnail['contents'];
-    	}
-    	else {
-    		$mime = $meta->file->type;
-    		$filename = $meta->name;
-    		$contents = $meta->file->contents;
-    	}
+		if ($useThumbnail && $request->get('thumbnail', 1) && ($thumbnail = $meta->thumbnail)) {
+			$mime = $thumbnail['mime'];
+			$filename = $thumbnail['name'];
+			$contents = $thumbnail['contents'];
+		}
+		else {
+			$mime = $meta->file->type;
+			$filename = $meta->name;
+			$contents = $meta->file->contents;
+		}
 
-    	$headers = [
-    			'Content-Type' => $mime,
-    			'Content-Length' => strlen($contents),
-    			'Content-Disposition' => "$disposition; filename=\"$filename\"",
-    	];
+		$headers = [
+				'Content-Type' => $mime,
+				'Content-Length' => strlen($contents),
+				'Content-Disposition' => "$disposition; filename=\"$filename\"",
+		];
 
-    	if ($request->get('nocache')) {
-    		$headers['Pragma'] = 'no-cache';
-    		$headers['Expires'] = '0';
-    	}
+		if ($request->get('nocache')) {
+			$headers['Pragma'] = 'no-cache';
+			$headers['Expires'] = '0';
+		}
     	
-    	return response($contents, 200, $headers);
-    }
+		return response($contents, 200, $headers);
+	}
 }

Braces +1 added lines, -2 removed lines

@@ -32,8 +32,7 @@
     		$mime = $thumbnail['mime'];
     		$filename = $thumbnail['name'];
     		$contents = $thumbnail['contents'];
-    	}
-    	else {
+    	} else {
     		$mime = $meta->file->type;
     		$filename = $meta->name;
     		$contents = $meta->file->contents;

src/FileStorageAccess.php

Indentation +22 added lines, -22 removed lines

@@ -6,30 +6,30 @@
 
 class FileStorageAccess
 {
-    public function handle($request, \Closure $next)
-    {
-    	foreach (Integration\Joints\FileStorageAccessJoint::collect() as $joint) {
-    		if ($joint->accessGranted($request)) {    			
-    			$this->logFileAccess($request->get('id'), $request->get('action', 'download'));
+	public function handle($request, \Closure $next)
+	{
+		foreach (Integration\Joints\FileStorageAccessJoint::collect() as $joint) {
+			if ($joint->accessGranted($request)) {    			
+				$this->logFileAccess($request->get('id'), $request->get('action', 'download'));
     			
-    			return $next($request);
-    		}
-    	}
+				return $next($request);
+			}
+		}
     	
-    	return response('No access to file', 401);
-    }
+		return response('No access to file', 401);
+	}
         
-    protected function logFileAccess($metaId, $action, $time = null)
-    {
-    	$ip_address = request()->ip();
+	protected function logFileAccess($metaId, $action, $time = null)
+	{
+		$ip_address = request()->ip();
 
-    	Database\Models\AccessLog::create([
-    			'meta_id' => $metaId,
-    			'accessed_at' => date('Y-m-d H:i:s', $time ?: time()),
-    			'accessed_by' => Auth::id() ?: 0,
-    			'action' => $action,
-    			'ip_address' => $ip_address,
-    			'host_name' => gethostbyaddr($ip_address)
-    	]);
-    }
+		Database\Models\AccessLog::create([
+				'meta_id' => $metaId,
+				'accessed_at' => date('Y-m-d H:i:s', $time ?: time()),
+				'accessed_by' => Auth::id() ?: 0,
+				'action' => $action,
+				'ip_address' => $ip_address,
+				'host_name' => gethostbyaddr($ip_address)
+		]);
+	}
 }

src/Database/Models/File.php

Indentation +94 added lines, -94 removed lines

@@ -13,111 +13,111 @@
 	
 	public $timestamps = false;
 	
-    protected $table = 'filestorage_files';
-    protected static $unguarded = true;    
+	protected $table = 'filestorage_files';
+	protected static $unguarded = true;    
     
-    protected $appends = ['path'];
+	protected $appends = ['path'];
     
-    /**
-     * One file can have many meta datas
-     * The actual content is stored only once based on the content hash
-     * 
-     * @return \Illuminate\Database\Eloquent\Relations\HasMany
-     */
-    public function meta()
-    {
-    	return $this->hasMany(Meta::class, 'file_id');
-    }
+	/**
+	 * One file can have many meta datas
+	 * The actual content is stored only once based on the content hash
+	 * 
+	 * @return \Illuminate\Database\Eloquent\Relations\HasMany
+	 */
+	public function meta()
+	{
+		return $this->hasMany(Meta::class, 'file_id');
+	}
     
-    /**
-     * Accessor method for retrieving of file content path when using the model
-     * Having the $appends property in the File model listing the 'path' makes sure the value is also exported to arrays
-     * 
-     * @return string
-     */
-    public function getPathAttribute()
-    {
-    	return self::storage()->path($this->getStoragePath($this->hash));
-    }
+	/**
+	 * Accessor method for retrieving of file content path when using the model
+	 * Having the $appends property in the File model listing the 'path' makes sure the value is also exported to arrays
+	 * 
+	 * @return string
+	 */
+	public function getPathAttribute()
+	{
+		return self::storage()->path($this->getStoragePath($this->hash));
+	}
     
-    /**
-     * Accessor method for retrieving of file contents
-     * 
-     * @return string
-     */
-    public function getContentsAttribute()
-    {
-    	return self::storage()->get($this->storage_path);
-    }
+	/**
+	 * Accessor method for retrieving of file contents
+	 * 
+	 * @return string
+	 */
+	public function getContentsAttribute()
+	{
+		return self::storage()->get($this->storage_path);
+	}
     
-    /**
-     * Accessor method for file relative storage path
-     * 
-     * @return string
-     */
-    public function getStoragePathAttribute()
-    {
-    	return $this->getStoragePath($this->hash);
-    }
+	/**
+	 * Accessor method for file relative storage path
+	 * 
+	 * @return string
+	 */
+	public function getStoragePathAttribute()
+	{
+		return $this->getStoragePath($this->hash);
+	}
     
-    protected static function getStoragePath($hash)
-    {
-    	return implode(DIRECTORY_SEPARATOR, array_merge(str_split(substr($hash, 0, 5)), [substr($hash, 5)]));
-    }
+	protected static function getStoragePath($hash)
+	{
+		return implode(DIRECTORY_SEPARATOR, array_merge(str_split(substr($hash, 0, 5)), [substr($hash, 5)]));
+	}
     
-    /**
-     * Returns the storage where file contents are saved based on config settings
-     * 
-     * @return \Illuminate\Contracts\Filesystem\Filesystem
-     */
-    public static function storage()
-    {
-    	return Storage::disk(config('epesi.filestorage', 'local'));
-    }
+	/**
+	 * Returns the storage where file contents are saved based on config settings
+	 * 
+	 * @return \Illuminate\Contracts\Filesystem\Filesystem
+	 */
+	public static function storage()
+	{
+		return Storage::disk(config('epesi.filestorage', 'local'));
+	}
         
-    /**
-     * Add file to the filestorage
-     *
-     * @param string $file File path to save
-     *
-     * @return int File id in the database
-     */
-    public static function putDataFromFile($file)
-    {
-    	return self::putData(file_get_contents($file));
-    }
+	/**
+	 * Add file to the filestorage
+	 *
+	 * @param string $file File path to save
+	 *
+	 * @return int File id in the database
+	 */
+	public static function putDataFromFile($file)
+	{
+		return self::putData(file_get_contents($file));
+	}
     
-    /**
-     * Add content to the filestorage
-     *
-     * @param string $content Content to save
-     *
-     * @return int File id in the database
-     */
-    public static function putData($content)
-    {
-    	$hash = self::hashContent($content);
+	/**
+	 * Add content to the filestorage
+	 *
+	 * @param string $content Content to save
+	 *
+	 * @return int File id in the database
+	 */
+	public static function putData($content)
+	{
+		$hash = self::hashContent($content);
     	
-    	$path = self::getStoragePath($hash);
+		$path = self::getStoragePath($hash);
     	
-    	if (! self::storage()->exists($path)) {
-    		self::storage()->put($path, $content);
-    	}
+		if (! self::storage()->exists($path)) {
+			self::storage()->put($path, $content);
+		}
     	
-    	return self::firstOrCreate(compact('hash'), [
-    			'size' => self::storage()->size($path),
-    			'type' => self::storage()->mimeType($path)
-    	])->id;
-    }
+		return self::firstOrCreate(compact('hash'), [
+				'size' => self::storage()->size($path),
+				'type' => self::storage()->mimeType($path)
+		])->id;
+	}
     
-    /**
-     * Get the hash of the content using hash method defined as constant to the class
-     * 
-     * @param string $content
-     * @return string
-     */
-    public static function hashContent($content)
-    {
-    	return hash(self::HASH_METHOD, $content);
-    }
+	/**
+	 * Get the hash of the content using hash method defined as constant to the class
+	 * 
+	 * @param string $content
+	 * @return string
+	 */
+	public static function hashContent($content)
+	{
+		return hash(self::HASH_METHOD, $content);
+	}
 }
\ No newline at end of file

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
     	
     	$path = self::getStoragePath($hash);
     	
-    	if (! self::storage()->exists($path)) {
+    	if (!self::storage()->exists($path)) {
     		self::storage()->put($path, $content);
     	}
     	

src/Database/Models/Meta.php

Indentation +159 added lines, -159 removed lines

@@ -15,205 +15,205 @@
 {
 	use SoftDeletes;
 	
-    protected $table = 'filestorage_meta';
-    protected static $unguarded = true;
+	protected $table = 'filestorage_meta';
+	protected static $unguarded = true;
     
-    public function file()
-    {
-    	return $this->belongsTo(File::class, 'file_id');
-    }
+	public function file()
+	{
+		return $this->belongsTo(File::class, 'file_id');
+	}
     
-    /**
-     * Retrieve meta info about the file
-     *
-     * @param int|string $idOrLink Filestorage ID or unique link string
-     * @param bool $useCache Use cache or not
-     *
-     * @return array Metadata about the file.
-     *               Keys in array: hash, file, filename, link, backref,
-     *               created_at, created_by, deleted, file_id
-     * @throws FileNotFound
-     * @throws StorageNotFound
-     */
-    public static function get($idOrLink, $useCache = true)
-    {
-    	static $cache = [];
+	/**
+	 * Retrieve meta info about the file
+	 *
+	 * @param int|string $idOrLink Filestorage ID or unique link string
+	 * @param bool $useCache Use cache or not
+	 *
+	 * @return array Metadata about the file.
+	 *               Keys in array: hash, file, filename, link, backref,
+	 *               created_at, created_by, deleted, file_id
+	 * @throws FileNotFound
+	 * @throws StorageNotFound
+	 */
+	public static function get($idOrLink, $useCache = true)
+	{
+		static $cache = [];
 
-    	$id = self::getIdByLink($idOrLink, true, true);
+		$id = self::getIdByLink($idOrLink, true, true);
 
-    	if ($useCache && isset($cache[$id])) {
-    		return $cache[$id];
-    	}
+		if ($useCache && isset($cache[$id])) {
+			return $cache[$id];
+		}
 
-    	if (! $meta = self::with('file')->find($id)) {
-    		throw new StorageNotFound('Exception - DB storage object not found: ' . $id);
-    	}
+		if (! $meta = self::with('file')->find($id)) {
+			throw new StorageNotFound('Exception - DB storage object not found: ' . $id);
+		}
 
-    	if (empty($meta->file['hash'])) {
-    		throw new FileNotFound('File object does not have corresponding file hash');
-    	}
+		if (empty($meta->file['hash'])) {
+			throw new FileNotFound('File object does not have corresponding file hash');
+		}
 
-    	return $cache[$id] = $meta;
-    }
+		return $cache[$id] = $meta;
+	}
     
-    /**
-     * Get Filestorage ID by link
-     *
-     * @param string $link            Unique link
-     * @param bool   $useCache       Use cache or not
-     * @param bool   $throwException Throw exception if link is not found
-     *
-     * @return int Filestorage ID
-     * @throws LinkNotFound
-     */
-    public static function getIdByLink($link, $useCache = true, $throwException = false)
-    {
-    	static $cache = [];
+	/**
+	 * Get Filestorage ID by link
+	 *
+	 * @param string $link            Unique link
+	 * @param bool   $useCache       Use cache or not
+	 * @param bool   $throwException Throw exception if link is not found
+	 *
+	 * @return int Filestorage ID
+	 * @throws LinkNotFound
+	 */
+	public static function getIdByLink($link, $useCache = true, $throwException = false)
+	{
+		static $cache = [];
     	
-    	if (is_numeric($link)) return $link;
+		if (is_numeric($link)) return $link;
     	
-    	if (!$useCache || !isset($cache[$link])) {
-    		$cache[$link] = self::where('link', $link)->value('id');
+		if (!$useCache || !isset($cache[$link])) {
+			$cache[$link] = self::where('link', $link)->value('id');
     		
-    		if (!$cache[$link] && $throwException) {
-    			throw new LinkNotFound($link);
-    		}
-    	}
+			if (!$cache[$link] && $throwException) {
+				throw new LinkNotFound($link);
+			}
+		}
     	
-    	return $cache[$link];
-    }
+		return $cache[$link];
+	}
 
-    /**
-     * Mark file as deleted. Does not remove any content!
-     *
-     * @param int|string $idOrLink Filestorage ID or unique link
-     */
-    public static function deleteFile($idOrLink)
-    {
+	/**
+	 * Mark file as deleted. Does not remove any content!
+	 *
+	 * @param int|string $idOrLink Filestorage ID or unique link
+	 */
+	public static function deleteFile($idOrLink)
+	{
    		if ($id = self::getIdByLink($idOrLink, false)) {
    			self::find($id)->delete();
-    	}
-    }
+		}
+	}
     
-    /**
-     * Check if file exists
-     *
-     * @param int|static $idOrMeta              Filestorage ID or meta object
-     * @param bool      $throwException Throw exception on missing file or return false
-     *
-     * @return bool True if file exists, false otherwise
-     * @throws FileNotFound May be thrown if $throwException set to true
-     */
-    public static function fileExists($idOrMeta, $throwException = false)
-    {
-    	try {
-    		$meta = is_numeric($idOrMeta) ? self::get($idOrMeta) : $idOrMeta;
+	/**
+	 * Check if file exists
+	 *
+	 * @param int|static $idOrMeta              Filestorage ID or meta object
+	 * @param bool      $throwException Throw exception on missing file or return false
+	 *
+	 * @return bool True if file exists, false otherwise
+	 * @throws FileNotFound May be thrown if $throwException set to true
+	 */
+	public static function fileExists($idOrMeta, $throwException = false)
+	{
+		try {
+			$meta = is_numeric($idOrMeta) ? self::get($idOrMeta) : $idOrMeta;
     		
-    		if (! file_exists($meta->file->path)) {
-    			throw new FileNotFound('Exception - file not found: ' . $meta->file->path);
-    		}
-    	} catch (\Exception $exception) {
-    		if ($throwException)
-    			throw $exception;
-    		else
-    			return false;
-    	}
+			if (! file_exists($meta->file->path)) {
+				throw new FileNotFound('Exception - file not found: ' . $meta->file->path);
+			}
+		} catch (\Exception $exception) {
+			if ($throwException)
+				throw $exception;
+			else
+				return false;
+		}
     	
-    	return true;
-    }
+		return true;
+	}
     
-    /**
-     * Add multiple files, clone file if file id is provided.
-     * May be used to update backref for all files.
-     *
-     * @param array $files array of existing filestorage ids or array with values for the new file
-     * @param string|null $backref Backref for all files
-     * @return array Newly created Meta Ids sorted in ascending order
-     */
-    public static function putMany($files, $backref = null)
-    {
-    	$ids = [];
-    	foreach ((array) $files as $file) {
-    		if (! is_numeric($file)) {
-    			$ids[] = self::put($file);
+	/**
+	 * Add multiple files, clone file if file id is provided.
+	 * May be used to update backref for all files.
+	 *
+	 * @param array $files array of existing filestorage ids or array with values for the new file
+	 * @param string|null $backref Backref for all files
+	 * @return array Newly created Meta Ids sorted in ascending order
+	 */
+	public static function putMany($files, $backref = null)
+	{
+		$ids = [];
+		foreach ((array) $files as $file) {
+			if (! is_numeric($file)) {
+				$ids[] = self::put($file);
     			
-    			continue;
-    		}
+				continue;
+			}
     		
-    		$meta = self::get($file, false)->toArray();
+			$meta = self::get($file, false)->toArray();
     			
-    		if ($backref && $meta['backref'] != $backref) {
-    			$meta['backref'] = $backref;
-    			unset($meta['link']);
+			if ($backref && $meta['backref'] != $backref) {
+				$meta['backref'] = $backref;
+				unset($meta['link']);
     			
-    			self::put($meta);
-    		}
+				self::put($meta);
+			}
     			
-    		$ids[] = $file;
-    	}
+			$ids[] = $file;
+		}
     	
-    	sort($ids);
+		sort($ids);
     	
-    	return $ids;
-    }
+		return $ids;
+	}
         
-    /**
-     * @param string|array     $metaOrFile
-     * @param string     $content    Content of the file
-     * 
-     * @return int Filestorage ID
-     * @throws LinkDuplicate
-     */
-    public static function put($metaOrFile, $content = null) 
-    {
-    	$meta = $metaOrFile;
-    	if (! $content && is_string($metaOrFile)) {
-    		$content = file_get_contents($metaOrFile);
+	/**
+	 * @param string|array     $metaOrFile
+	 * @param string     $content    Content of the file
+	 * 
+	 * @return int Filestorage ID
+	 * @throws LinkDuplicate
+	 */
+	public static function put($metaOrFile, $content = null) 
+	{
+		$meta = $metaOrFile;
+		if (! $content && is_string($metaOrFile)) {
+			$content = file_get_contents($metaOrFile);
     		
-    		$meta = [
-    				'name' => basename($metaOrFile)
-    		];
-    	}
+			$meta = [
+					'name' => basename($metaOrFile)
+			];
+		}
     	
-    	if (!empty($meta['link']) && self::getIdByLink($meta['link'], false)) {
-    		throw new LinkDuplicate($meta['link']);
-    	}
+		if (!empty($meta['link']) && self::getIdByLink($meta['link'], false)) {
+			throw new LinkDuplicate($meta['link']);
+		}
     	
-    	if ($file = $meta['file']?? null) {
-    		$path = is_array($file)? $file['path']: $file;
+		if ($file = $meta['file']?? null) {
+			$path = is_array($file)? $file['path']: $file;
     		
-    		$meta['name'] = $meta['name']?? basename($path);
+			$meta['name'] = $meta['name']?? basename($path);
     		
-    		$content = $content?: file_get_contents($path);
+			$content = $content?: file_get_contents($path);
     		
-    		unset($meta['file']);
-    	}
+			unset($meta['file']);
+		}
 	
-    	return self::updateOrCreate(['id' => $meta['id']?? null], array_merge([
-    			'created_at' => time(),
-    			'created_by' => Auth::id(),
-    			'file_id' => File::putData($meta['content']?? $content)
-    	], $meta))->id;
-    }
+		return self::updateOrCreate(['id' => $meta['id']?? null], array_merge([
+				'created_at' => time(),
+				'created_by' => Auth::id(),
+				'file_id' => File::putData($meta['content']?? $content)
+		], $meta))->id;
+	}
     
-    public function getThumbnailAttribute()
-    {
-    	if (! $this->thumbnailPossible()) return false;
+	public function getThumbnailAttribute()
+	{
+		if (! $this->thumbnailPossible()) return false;
     	
-    	$image = new \Imagick($this->meta->file->path . '[0]');
+		$image = new \Imagick($this->meta->file->path . '[0]');
     	
-    	$image->setImageFormat('jpg');
+		$image->setImageFormat('jpg');
     	
-    	$mime = 'image/jpeg';
+		$mime = 'image/jpeg';
     	
-    	$name = 'preview.jpeg';
+		$name = 'preview.jpeg';
     	
-    	$contents = $image . '';
+		$contents = $image . '';
     	
-    	return collect(compact('mime', 'name', 'contents'));
-    }
+		return collect(compact('mime', 'name', 'contents'));
+	}
     
-    protected function thumbnailPossible() {
-    	return $this->file->type == 'application/pdf' && class_exists('Imagick');
-    }
+	protected function thumbnailPossible() {
+		return $this->file->type == 'application/pdf' && class_exists('Imagick');
+	}
 }
\ No newline at end of file

Spacing +7 added lines, -7 removed lines

@@ -45,7 +45,7 @@ 
     		return $cache[$id];
     	}
 
-    	if (! $meta = self::with('file')->find($id)) {
+    	if (!$meta = self::with('file')->find($id)) {
     		throw new StorageNotFound('Exception - DB storage object not found: ' . $id);
     	}
 
@@ -109,7 +109,7 @@ 
     	try {
     		$meta = is_numeric($idOrMeta) ? self::get($idOrMeta) : $idOrMeta;
     		
-    		if (! file_exists($meta->file->path)) {
+    		if (!file_exists($meta->file->path)) {
     			throw new FileNotFound('Exception - file not found: ' . $meta->file->path);
     		}
     	} catch (\Exception $exception) {
@@ -134,7 +134,7 @@ 
     {
     	$ids = [];
     	foreach ((array) $files as $file) {
-    		if (! is_numeric($file)) {
+    		if (!is_numeric($file)) {
     			$ids[] = self::put($file);
     			
     			continue;
@@ -167,7 +167,7 @@ 
     public static function put($metaOrFile, $content = null) 
     {
     	$meta = $metaOrFile;
-    	if (! $content && is_string($metaOrFile)) {
+    	if (!$content && is_string($metaOrFile)) {
     		$content = file_get_contents($metaOrFile);
     		
     		$meta = [
@@ -180,11 +180,11 @@ 
     	}
     	
     	if ($file = $meta['file']?? null) {
-    		$path = is_array($file)? $file['path']: $file;
+    		$path = is_array($file) ? $file['path'] : $file;
     		
     		$meta['name'] = $meta['name']?? basename($path);
     		
-    		$content = $content?: file_get_contents($path);
+    		$content = $content ?: file_get_contents($path);
     		
     		unset($meta['file']);
     	}
@@ -198,7 +198,7 @@ 
     
     public function getThumbnailAttribute()
     {
-    	if (! $this->thumbnailPossible()) return false;
+    	if (!$this->thumbnailPossible()) return false;
     	
     	$image = new \Imagick($this->meta->file->path . '[0]');
     	

Braces +11 added lines, -6 removed lines

@@ -70,7 +70,9 @@ 
     {
     	static $cache = [];
     	
-    	if (is_numeric($link)) return $link;
+    	if (is_numeric($link)) {
+    		return $link;
+    	}
     	
     	if (!$useCache || !isset($cache[$link])) {
     		$cache[$link] = self::where('link', $link)->value('id');
@@ -113,10 +115,11 @@ 
     			throw new FileNotFound('Exception - file not found: ' . $meta->file->path);
     		}
     	} catch (\Exception $exception) {
-    		if ($throwException)
-    			throw $exception;
-    		else
-    			return false;
+    		if ($throwException) {
+    		    			throw $exception;
+    		} else {
+    		    			return false;
+    		}
     	}
     	
     	return true;
@@ -198,7 +201,9 @@ 
     
     public function getThumbnailAttribute()
     {
-    	if (! $this->thumbnailPossible()) return false;
+    	if (! $this->thumbnailPossible()) {
+    		return false;
+    	}
     	
     	$image = new \Imagick($this->meta->file->path . '[0]');
     	

src/Database/Models/AccessLog.php

Indentation +2 added lines, -2 removed lines

@@ -8,7 +8,7 @@
     
 	public $timestamps = false;
 	
-    protected $table = 'filestorage_access_log';
-    protected static $unguarded = true;    
+	protected $table = 'filestorage_access_log';
+	protected static $unguarded = true;    
 
 }
\ No newline at end of file

src/Database/Models/Remote.php

Indentation +10 added lines, -10 removed lines

@@ -6,23 +6,23 @@
 use Illuminate\Support\Facades\Auth;
 
 class Remote extends Model {
-    const DEFAULT_PERIOD = '1 week';
+	const DEFAULT_PERIOD = '1 week';
     
-    protected $table = 'filestorage_remote';
-    protected static $unguarded = true;    
+	protected $table = 'filestorage_remote';
+	protected static $unguarded = true;    
 
-    public static function access($metaId, $token)
-    {
-    	return (bool) self::where('meta_id', $metaId)->where('token', $token)->where('expires_at', '>', date('Y-m-d H:i:s'))->count();
-    }
+	public static function access($metaId, $token)
+	{
+		return (bool) self::where('meta_id', $metaId)->where('token', $token)->where('expires_at', '>', date('Y-m-d H:i:s'))->count();
+	}
     
-    public static function grant($metaId, $expires = self::DEFAULT_PERIOD)
-    {
+	public static function grant($metaId, $expires = self::DEFAULT_PERIOD)
+	{
 		return self::create([
 				'meta_id' => $metaId,
 				'token' => md5(uniqid(rand(), true)),
 				'created_by' => Auth::id()?: 0,
 				'expires_at' => date('Y-m-d H:i:s', strtotime($expires)),
 		]);
-    }
+	}
 }
\ No newline at end of file

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 		return self::create([
 				'meta_id' => $metaId,
 				'token' => md5(uniqid(rand(), true)),
-				'created_by' => Auth::id()?: 0,
+				'created_by' => Auth::id() ?: 0,
 				'expires_at' => date('Y-m-d H:i:s', strtotime($expires)),
 		]);
     }

src/Database/Migrations/2019_11_16_091615_create_filestorage_tables.php

Indentation +60 added lines, -60 removed lines

@@ -6,74 +6,74 @@
 
 class CreateFilestorageTables extends Migration
 {
-    /**
-     * Run the migrations.
-     *
-     * @return void
-     */
-    public function up()
-    {
-    	$this->down();
+	/**
+	 * Run the migrations.
+	 *
+	 * @return void
+	 */
+	public function up()
+	{
+		$this->down();
     	
-        Schema::create('filestorage_files', function (Blueprint $table) {
-            $table->bigIncrements('id');
-            $table->string('hash', 128);
-            $table->integer('size');
-            $table->string('type', 256);
+		Schema::create('filestorage_files', function (Blueprint $table) {
+			$table->bigIncrements('id');
+			$table->string('hash', 128);
+			$table->integer('size');
+			$table->string('type', 256);
             
-            $table->softDeletes();
-        });
+			$table->softDeletes();
+		});
         
-        Schema::create('filestorage_meta', function (Blueprint $table) {
-            $table->bigIncrements('id');
-            $table->string('name', 256);
-            $table->string('link', 128)->nullable();
-            $table->string('backref', 128)->nullable();
-            $table->unsignedBigInteger('file_id');
-            $table->unsignedBigInteger('created_by')->nullable();
-            $table->timestamps();
+		Schema::create('filestorage_meta', function (Blueprint $table) {
+			$table->bigIncrements('id');
+			$table->string('name', 256);
+			$table->string('link', 128)->nullable();
+			$table->string('backref', 128)->nullable();
+			$table->unsignedBigInteger('file_id');
+			$table->unsignedBigInteger('created_by')->nullable();
+			$table->timestamps();
             
-            $table->softDeletes();
+			$table->softDeletes();
             
-            $table->foreign('file_id')->references('id')->on('filestorage_files');
-            $table->foreign('created_by')->references('id')->on('users');
-        });
+			$table->foreign('file_id')->references('id')->on('filestorage_files');
+			$table->foreign('created_by')->references('id')->on('users');
+		});
         
-        Schema::create('filestorage_remote', function (Blueprint $table) {
-            $table->bigIncrements('id');
-            $table->unsignedBigInteger('meta_id');            
-            $table->string('token', 128);
-            $table->unsignedBigInteger('created_by');
-            $table->timestamp('expires_at');
-            $table->timestamps();
+		Schema::create('filestorage_remote', function (Blueprint $table) {
+			$table->bigIncrements('id');
+			$table->unsignedBigInteger('meta_id');            
+			$table->string('token', 128);
+			$table->unsignedBigInteger('created_by');
+			$table->timestamp('expires_at');
+			$table->timestamps();
             
-            $table->foreign('meta_id')->references('id')->on('filestorage_meta');
-            $table->foreign('created_by')->references('id')->on('users');
-        });
+			$table->foreign('meta_id')->references('id')->on('filestorage_meta');
+			$table->foreign('created_by')->references('id')->on('users');
+		});
         
-        Schema::create('filestorage_access_log', function (Blueprint $table) {
-            $table->bigIncrements('id');
-            $table->unsignedBigInteger('meta_id');            
-            $table->timestamp('accessed_at');
-            $table->unsignedBigInteger('accessed_by');
-            $table->string('type', 32);
-            $table->string('ip_address', 32);
-            $table->string('host_name', 64);
+		Schema::create('filestorage_access_log', function (Blueprint $table) {
+			$table->bigIncrements('id');
+			$table->unsignedBigInteger('meta_id');            
+			$table->timestamp('accessed_at');
+			$table->unsignedBigInteger('accessed_by');
+			$table->string('type', 32);
+			$table->string('ip_address', 32);
+			$table->string('host_name', 64);
                         
-            $table->foreign('meta_id')->references('id')->on('filestorage_meta');
-        });
-    }
+			$table->foreign('meta_id')->references('id')->on('filestorage_meta');
+		});
+	}
 
-    /**
-     * Reverse the migrations.
-     *
-     * @return void
-     */
-    public function down()
-    {
-    	Schema::dropIfExists('filestorage_remote');
-    	Schema::dropIfExists('filestorage_access_log');
-    	Schema::dropIfExists('filestorage_meta');
-        Schema::dropIfExists('filestorage_files');
-    }
+	/**
+	 * Reverse the migrations.
+	 *
+	 * @return void
+	 */
+	public function down()
+	{
+		Schema::dropIfExists('filestorage_remote');
+		Schema::dropIfExists('filestorage_access_log');
+		Schema::dropIfExists('filestorage_meta');
+		Schema::dropIfExists('filestorage_files');
+	}
 }

Spacing +4 added lines, -4 removed lines

@@ -15,7 +15,7 @@ 
     {
     	$this->down();
     	
-        Schema::create('filestorage_files', function (Blueprint $table) {
+        Schema::create('filestorage_files', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('hash', 128);
             $table->integer('size');
@@ -24,7 +24,7 @@ 
             $table->softDeletes();
         });
         
-        Schema::create('filestorage_meta', function (Blueprint $table) {
+        Schema::create('filestorage_meta', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('name', 256);
             $table->string('link', 128)->nullable();
@@ -39,7 +39,7 @@ 
             $table->foreign('created_by')->references('id')->on('users');
         });
         
-        Schema::create('filestorage_remote', function (Blueprint $table) {
+        Schema::create('filestorage_remote', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->unsignedBigInteger('meta_id');            
             $table->string('token', 128);
@@ -51,7 +51,7 @@ 
             $table->foreign('created_by')->references('id')->on('users');
         });
         
-        Schema::create('filestorage_access_log', function (Blueprint $table) {
+        Schema::create('filestorage_access_log', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->unsignedBigInteger('meta_id');            
             $table->timestamp('accessed_at');

src/FileStorageList.php

Spacing +13 added lines, -13 removed lines

@@ -47,14 +47,14 @@ 
 
 		$this->grid->setModel($model = $this->getModel());
 		
-		if ($model->action('count')->getOne() ) {
+		if ($model->action('count')->getOne()) {
 			$this->grid->on('click', 'td', new jsExpression(
 					'document.location=\'?parentId=\'+[]',
 					[(new jQuery())->closest('tr')->data('id')]
 			));
 		}
 		
-		$this->grid->addDragHandler()->onReorder(function ($order) {
+		$this->grid->addDragHandler()->onReorder(function($order) {
 			$result = true;
 			foreach ($this->nodes()->get() as $node) {
 				$node->position = array_search($node->id, $order);
@@ -62,14 +62,14 @@ 
 				$result &= $node->save();
 			}
 			
-			$notifier = $result? $this->notify(__('Items reordered!')): $this->notifyError(__('Error saving order!'));
+			$notifier = $result ? $this->notify(__('Items reordered!')) : $this->notifyError(__('Error saving order!'));
 			
 			return $this->grid->jsSave($notifier);
 		});
 		
 		$this->addContolButton('update', $this->getUpdateModal(), 'edit');
 			
-		$this->addContolButton('delete', function ($jschain, $id) {
+		$this->addContolButton('delete', function($jschain, $id) {
 			CommonData::find($id)->delete();
 				
 			return $jschain->closest('tr')->transition('fade left');
@@ -91,7 +91,7 @@ 
 			$ret .= $button->getHtml();
 		}
 		
-		return $ret;;
+		return $ret; ;
 	}
 	
 	public function getUpdateModal()
@@ -100,9 +100,9 @@ 
 		
 		$grid->pageUpdate = $grid->add($grid->pageUpdate ?: $grid->pageDefault, ['short_name'=>'edit']);
 		
-		$modal = new jsModal(__('Edit'), $grid->pageUpdate, [$grid->name => $grid->jsRow()->data('id'), $grid->name.'_sort' => $grid->getSortBy()]);
+		$modal = new jsModal(__('Edit'), $grid->pageUpdate, [$grid->name => $grid->jsRow()->data('id'), $grid->name . '_sort' => $grid->getSortBy()]);
 		
-		$grid->pageUpdate->set(function () {
+		$grid->pageUpdate->set(function() {
 			$grid = $this->grid;
 			
 			$grid->model->load($grid->app->stickyGet($grid->name));
@@ -121,7 +121,7 @@ 
 			// set save handler with reload trigger
 			// adds default submit hook if it is not already set for this form
 			if (!$grid->formUpdate->hookHasCallbacks('submit')) {
-				$grid->formUpdate->onSubmit(function ($form) {
+				$grid->formUpdate->onSubmit(function($form) {
 					$form->model->save();
 					
 					return $this->grid->jsSaveUpdate();
@@ -138,7 +138,7 @@ 
 		
 		$this->grid->on('click', ".$class", $callback, [$this->grid->table->jsRow()->data('id')]);
 		
-		$this->buttons[$name] = new \atk4\ui\Button($icon? compact('icon'): $name);
+		$this->buttons[$name] = new \atk4\ui\Button($icon ? compact('icon') : $name);
 		
 		$this->buttons[$name]->app = $this->app;
 		
@@ -165,7 +165,7 @@ 
 		
 		$rowsEmpty = [];
 		
-		$model = new \atk4\data\Model($rows? new \atk4\data\Persistence_Static($rows): new \atk4\data\Persistence_Array($rowsEmpty));
+		$model = new \atk4\data\Model($rows ? new \atk4\data\Persistence_Static($rows) : new \atk4\data\Persistence_Array($rowsEmpty));
 		
 		$captions = [
 				'position' => __('Position'),
@@ -175,7 +175,7 @@ 
 		];
 		
 		foreach ($captions as $key => $caption) {
-			$field = $rows? $model->hasField($key): $model->addField($key);
+			$field = $rows ? $model->hasField($key) : $model->addField($key);
 			
 			if ($key === 'readonly') {
 				$field->setDefaults(['ui' => ['visible' => false]]);
@@ -191,7 +191,7 @@ 
 	
 	public function getNodeForm()
 	{
-		if (! $this->form) {
+		if (!$this->form) {
 			$this->form = new Form(['buttonSave' => ['Button', __('Save'), 'primary']]);
 			
 			$this->form->addHook('submit', function($form) {
@@ -205,7 +205,7 @@ 
 				
 				CommonData::create(array_merge($values, [
 						'position' => $this->nodes()->max('position') + 1
-				]), $this->parentId? CommonData::find($this->parentId): null);
+				]), $this->parentId ? CommonData::find($this->parentId) : null);
 				
 				return $this->grid->jsSaveCreate();
 			});

Braces +3 added lines, -1 removed lines

@@ -84,7 +84,9 @@
 	
 	public function getControlButtonsHtml($row)
 	{
-		if ($row['readonly']) return '';
+		if ($row['readonly']) {
+			return '';
+		}
 		
 		$ret = '';
 		foreach ($this->buttons as $button) {