Passed
Push — master ( 4d438a...3290e5 )
by Georgi
02:54
created
src/User/Settings/Database/Models/UserSetting.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 	}
24 24
 	
25 25
 	private static function cacheUserVariables() {
26
-		if(isset(self::$userVariables)) return;
26
+		if (isset(self::$userVariables)) return;
27 27
 
28 28
 		$userId = Auth::id();
29 29
 		
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	}
34 34
 	
35 35
 	private static function cacheAdminVariables() {
36
-		if(isset(self::$adminVariables)) return;
36
+		if (isset(self::$adminVariables)) return;
37 37
 
38 38
 		foreach (self::where('user_id', 0) as $row) {
39 39
 			self::$adminVariables[$row['group']][$row['name']] = $row['value'];
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 	}
42 42
 	
43 43
 	public static function get($group, $name, $user = null) {
44
-		$user = $user?: Auth::id();
44
+		$user = $user ?: Auth::id();
45 45
 		
46 46
 		if (!$user || !is_numeric($user)) return;
47 47
 		
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	}
52 52
 	
53 53
 	public static function getGroup($group, $user = null) {
54
-		$user = $user?: Auth::id();
54
+		$user = $user ?: Auth::id();
55 55
 		
56 56
 		if (!$user || !is_numeric($user)) return;
57 57
 		
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	}
74 74
 	
75 75
 	public static function put($group, $name, $value, $user = null) {
76
-		$user_id = $user?: Auth::id();
76
+		$user_id = $user ?: Auth::id();
77 77
 		
78 78
 		if (!$user_id || !is_numeric($user_id)) return;
79 79
 		
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 	}
102 102
 	
103 103
 	public static function forget($group, $name, $user = null) {
104
-		$user_id = $user?: Auth::id();
104
+		$user_id = $user ?: Auth::id();
105 105
 		
106 106
 		if (!$user_id || !is_numeric($user_id)) return;
107 107
 		
Please login to merge, or discard this patch.
Braces   +18 added lines, -6 removed lines patch added patch discarded remove patch
@@ -23,7 +23,9 @@  discard block
 block discarded – undo
23 23
 	}
24 24
 	
25 25
 	private static function cacheUserVariables() {
26
-		if(isset(self::$userVariables)) return;
26
+		if(isset(self::$userVariables)) {
27
+			return;
28
+		}
27 29
 
28 30
 		$userId = Auth::id();
29 31
 		
@@ -33,7 +35,9 @@  discard block
 block discarded – undo
33 35
 	}
34 36
 	
35 37
 	private static function cacheAdminVariables() {
36
-		if(isset(self::$adminVariables)) return;
38
+		if(isset(self::$adminVariables)) {
39
+			return;
40
+		}
37 41
 
38 42
 		foreach (self::where('user_id', 0) as $row) {
39 43
 			self::$adminVariables[$row['group']][$row['name']] = $row['value'];
@@ -43,7 +47,9 @@  discard block
 block discarded – undo
43 47
 	public static function get($group, $name, $user = null) {
44 48
 		$user = $user?: Auth::id();
45 49
 		
46
-		if (!$user || !is_numeric($user)) return;
50
+		if (!$user || !is_numeric($user)) {
51
+			return;
52
+		}
47 53
 		
48 54
 		self::cache();
49 55
 		
@@ -53,7 +59,9 @@  discard block
 block discarded – undo
53 59
 	public static function getGroup($group, $user = null) {
54 60
 		$user = $user?: Auth::id();
55 61
 		
56
-		if (!$user || !is_numeric($user)) return;
62
+		if (!$user || !is_numeric($user)) {
63
+			return;
64
+		}
57 65
 		
58 66
 		self::cache();
59 67
 
@@ -75,7 +83,9 @@  discard block
 block discarded – undo
75 83
 	public static function put($group, $name, $value, $user = null) {
76 84
 		$user_id = $user?: Auth::id();
77 85
 		
78
-		if (!$user_id || !is_numeric($user_id)) return;
86
+		if (!$user_id || !is_numeric($user_id)) {
87
+			return;
88
+		}
79 89
 		
80 90
 		self::cache();
81 91
 
@@ -103,7 +113,9 @@  discard block
 block discarded – undo
103 113
 	public static function forget($group, $name, $user = null) {
104 114
 		$user_id = $user?: Auth::id();
105 115
 		
106
-		if (!$user_id || !is_numeric($user_id)) return;
116
+		if (!$user_id || !is_numeric($user_id)) {
117
+			return;
118
+		}
107 119
 		
108 120
 		self::cache();
109 121
 		
Please login to merge, or discard this patch.
src/Dashboard/DashboardView.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 	
25 25
 	public function body()
26 26
 	{
27
-		if (! $this->isSingleDashboard()) {
27
+		if (!$this->isSingleDashboard()) {
28 28
 			$this->location($this->dashboard()->name);
29 29
 		}
30 30
 		
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 		
43 43
 		$applets = $dashboard->applets()->orderBy('column')->orderBy('row')->get();
44 44
 
45
-		$columns = $this->add(['Columns', 'id' => 'dashboard', 'ui' => 'three stackable grid'  . ($this->isLocked()? ' locked': '')]);
45
+		$columns = $this->add(['Columns', 'id' => 'dashboard', 'ui' => 'three stackable grid' . ($this->isLocked() ? ' locked' : '')]);
46 46
 		
47 47
 		foreach ([1, 2, 3] as $columnId) {
48 48
 			/** @scrutinizer ignore-call */
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 					]
56 56
 			]);
57 57
 			
58
-			foreach ($applets->where('column', $columnId) as $applet ) {
58
+			foreach ($applets->where('column', $columnId) as $applet) {
59 59
 				$col->add([
60 60
 						new Applet(),
61 61
 						'appletId' => $applet->id,
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 			}
67 67
 		}
68 68
 		
69
-		if (! $this->isLocked()) {
69
+		if (!$this->isLocked()) {
70 70
 			$columns->js(true)->find('.sortable')->sortable([
71 71
 					'cursor' => 'move',
72 72
 					'handle' => '.panel-sortable-handle',
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 					])
85 85
 			]));
86 86
 			
87
-			$columns->js(true)->find('.applet-close')->click(new jsFunction(['e'], [new jsExpression('if (confirm("' .  __('Delete this applet?') . '")) {$(e.target).closest(".applet").fadeOut(400, function(){var col = $(this).closest(".column.sortable");this.remove();col.trigger("sortupdate");})}')]));
87
+			$columns->js(true)->find('.applet-close')->click(new jsFunction(['e'], [new jsExpression('if (confirm("' . __('Delete this applet?') . '")) {$(e.target).closest(".applet").fadeOut(400, function(){var col = $(this).closest(".column.sortable");this.remove();col.trigger("sortupdate");})}')]));
88 88
 		}
89 89
 		
90 90
 		$this->columns = $columns;
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
 				]
132 132
 		]);
133 133
 
134
-		foreach ( AppletJoint::collect() as $applet ) {
134
+		foreach (AppletJoint::collect() as $applet) {
135 135
 			$col->add([
136 136
 					new Applet(),
137 137
 					'appletId' => 'new_' . str_ireplace('\\', '-', get_class($applet)),
@@ -260,10 +260,10 @@  discard block
 block discarded – undo
260 260
 	{
261 261
 		$dashboard = Dashboard::find($dashboardId);
262 262
 
263
-		return $dashboard->delete()? [
263
+		return $dashboard->delete() ? [
264 264
 				$this->notify(__('Dashboard ":name" deleted, redirecting ...', ['name' => $dashboard->name])),
265 265
 				new jsExpression('window.setTimeout(function() {window.location.replace([])}, 1200)', [self::selfLink()])
266
-		]: $this->notifyError(__('Error deleting dashboard'));
266
+		] : $this->notifyError(__('Error deleting dashboard'));
267 267
 	}
268 268
 	
269 269
 	public function reorderDashboards($view)
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
 		$grid = $view->add(['Grid', 'paginator' => false, 'menu' => false]);
283 283
 		$grid->setModel(new \atk4\data\Model(new \atk4\data\Persistence_Static($rows)));
284 284
 		
285
-		$grid->addDragHandler()->onReorder(function ($order) use ($dashboards) {
285
+		$grid->addDragHandler()->onReorder(function($order) use ($dashboards) {
286 286
 			$result = true;
287 287
 			foreach ($dashboards as $dashboard) {
288 288
 				$dashboard->position = array_search($dashboard->id, $order);
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
 				$result &= $dashboard->save();
291 291
 			}
292 292
 			
293
-			return $result? $this->notify(__('Dashboards reordered!')): $this->notifyError(__('Error saving order!'));
293
+			return $result ? $this->notify(__('Dashboards reordered!')) : $this->notifyError(__('Error saving order!'));
294 294
 		});
295 295
 			
296 296
 		$view->add(['View', 'ui' => 'buttons'])->add(['Button', __('Done'), 'primary'])->on('click', new jsExpression('location.reload()'));
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
 	
368 368
 	public function isLocked()
369 369
 	{
370
-		return $this->locked || ! Auth::user()->can('edit dashboard');
370
+		return $this->locked || !Auth::user()->can('edit dashboard');
371 371
 	}
372 372
 	
373 373
 	protected function isSingleDashboard()
@@ -383,18 +383,18 @@  discard block
 block discarded – undo
383 383
 	 */
384 384
 	protected function dashboard()
385 385
 	{
386
-		if (! is_object($this->dashboard)) {
387
-			$this->dashboard = $this->dashboard? Dashboard::find($this->dashboard): $this->defaultUserDashboard();
386
+		if (!is_object($this->dashboard)) {
387
+			$this->dashboard = $this->dashboard ? Dashboard::find($this->dashboard) : $this->defaultUserDashboard();
388 388
 		}
389 389
 
390
-		return $this->dashboard?: abort(404);
390
+		return $this->dashboard ?: abort(404);
391 391
 	}
392 392
 	
393 393
 	protected function defaultUserDashboard()
394 394
 	{
395 395
 		$userDashboard = $this->userDashboards()->orderBy('position')->first();
396 396
 		
397
-		if (! $userDashboard) {
397
+		if (!$userDashboard) {
398 398
 			$this->lock();
399 399
 			
400 400
 			$userDashboard = $this->defaultSystemDashboard();
@@ -418,6 +418,6 @@  discard block
 block discarded – undo
418 418
 	 */
419 419
 	protected function userId()
420 420
 	{
421
-		return $this->admin? 0: Auth::id();
421
+		return $this->admin ? 0 : Auth::id();
422 422
 	}
423 423
 }
Please login to merge, or discard this patch.