Inspection of "Use ArrayHelper to retrieve config value" - writesdown/app-cms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3b924e...fb7a26 )

by Agiel Kurniawan

created 2016-04-14 06:12 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -2,16 +2,16 @@
 block discarded – undo
 defined('YII_DEBUG') or define('YII_DEBUG', false);
 defined('YII_ENV') or define('YII_ENV', 'prod');
 
-require(__DIR__ . '/../vendor/autoload.php');
-require(__DIR__ . '/../vendor/yiisoft/yii2/Yii.php');
-require(__DIR__ . '/../common/config/bootstrap.php');
-require(__DIR__ . '/../frontend/config/bootstrap.php');
+require(__DIR__.'/../vendor/autoload.php');
+require(__DIR__.'/../vendor/yiisoft/yii2/Yii.php');
+require(__DIR__.'/../common/config/bootstrap.php');
+require(__DIR__.'/../frontend/config/bootstrap.php');
 
 $config = yii\helpers\ArrayHelper::merge(
-    require(__DIR__ . '/../common/config/main.php'),
-    require(__DIR__ . '/../common/config/main-local.php'),
-    require(__DIR__ . '/../frontend/config/main.php'),
-    require(__DIR__ . '/../frontend/config/main-local.php')
+    require(__DIR__.'/../common/config/main.php'),
+    require(__DIR__.'/../common/config/main-local.php'),
+    require(__DIR__.'/../frontend/config/main.php'),
+    require(__DIR__.'/../frontend/config/main-local.php')
 );
 
 $application = new yii\web\Application($config);

Please login to merge, or discard this patch.

environments/dev/public/admin/index.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -2,16 +2,16 @@
 block discarded – undo
 defined('YII_DEBUG') or define('YII_DEBUG', true);
 defined('YII_ENV') or define('YII_ENV', 'dev');
 
-require(__DIR__ . '/../../vendor/autoload.php');
-require(__DIR__ . '/../../vendor/yiisoft/yii2/Yii.php');
-require(__DIR__ . '/../../common/config/bootstrap.php');
-require(__DIR__ . '/../../backend/config/bootstrap.php');
+require(__DIR__.'/../../vendor/autoload.php');
+require(__DIR__.'/../../vendor/yiisoft/yii2/Yii.php');
+require(__DIR__.'/../../common/config/bootstrap.php');
+require(__DIR__.'/../../backend/config/bootstrap.php');
 
 $config = yii\helpers\ArrayHelper::merge(
-    require(__DIR__ . '/../../common/config/main.php'),
-    require(__DIR__ . '/../../common/config/main-local.php'),
-    require(__DIR__ . '/../../backend/config/main.php'),
-    require(__DIR__ . '/../../backend/config/main-local.php')
+    require(__DIR__.'/../../common/config/main.php'),
+    require(__DIR__.'/../../common/config/main-local.php'),
+    require(__DIR__.'/../../backend/config/main.php'),
+    require(__DIR__.'/../../backend/config/main-local.php')
 );
 
 $application = new yii\web\Application($config);

Please login to merge, or discard this patch.

environments/dev/public/admin/index-test.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -8,12 +8,12 @@
 block discarded – undo
 defined('YII_DEBUG') or define('YII_DEBUG', true);
 defined('YII_ENV') or define('YII_ENV', 'test');
 
-require(__DIR__ . '/../../vendor/autoload.php');
-require(__DIR__ . '/../../vendor/yiisoft/yii2/Yii.php');
-require(__DIR__ . '/../../common/config/bootstrap.php');
-require(__DIR__ . '/../../backend/config/bootstrap.php');
+require(__DIR__.'/../../vendor/autoload.php');
+require(__DIR__.'/../../vendor/yiisoft/yii2/Yii.php');
+require(__DIR__.'/../../common/config/bootstrap.php');
+require(__DIR__.'/../../backend/config/bootstrap.php');
 
 
-$config = require(__DIR__ . '/../../tests/codeception/config/backend/acceptance.php');
+$config = require(__DIR__.'/../../tests/codeception/config/backend/acceptance.php');
 
 (new yii\web\Application($config))->run();

Please login to merge, or discard this patch.

environments/dev/public/index.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -2,16 +2,16 @@
 block discarded – undo
 defined('YII_DEBUG') or define('YII_DEBUG', true);
 defined('YII_ENV') or define('YII_ENV', 'dev');
 
-require(__DIR__ . '/../vendor/autoload.php');
-require(__DIR__ . '/../vendor/yiisoft/yii2/Yii.php');
-require(__DIR__ . '/../common/config/bootstrap.php');
-require(__DIR__ . '/../frontend/config/bootstrap.php');
+require(__DIR__.'/../vendor/autoload.php');
+require(__DIR__.'/../vendor/yiisoft/yii2/Yii.php');
+require(__DIR__.'/../common/config/bootstrap.php');
+require(__DIR__.'/../frontend/config/bootstrap.php');
 
 $config = yii\helpers\ArrayHelper::merge(
-    require(__DIR__ . '/../common/config/main.php'),
-    require(__DIR__ . '/../common/config/main-local.php'),
-    require(__DIR__ . '/../frontend/config/main.php'),
-    require(__DIR__ . '/../frontend/config/main-local.php')
+    require(__DIR__.'/../common/config/main.php'),
+    require(__DIR__.'/../common/config/main-local.php'),
+    require(__DIR__.'/../frontend/config/main.php'),
+    require(__DIR__.'/../frontend/config/main-local.php')
 );
 
 $application = new yii\web\Application($config);

Please login to merge, or discard this patch.

environments/dev/public/index-test.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -8,11 +8,11 @@
 block discarded – undo
 defined('YII_DEBUG') or define('YII_DEBUG', true);
 defined('YII_ENV') or define('YII_ENV', 'test');
 
-require(__DIR__ . '/../vendor/autoload.php');
-require(__DIR__ . '/../vendor/yiisoft/yii2/Yii.php');
-require(__DIR__ . '/../common/config/bootstrap.php');
-require(__DIR__ . '/../frontend/config/bootstrap.php');
+require(__DIR__.'/../vendor/autoload.php');
+require(__DIR__.'/../vendor/yiisoft/yii2/Yii.php');
+require(__DIR__.'/../common/config/bootstrap.php');
+require(__DIR__.'/../frontend/config/bootstrap.php');
 
-$config = require(__DIR__ . '/../tests/codeception/config/frontend/acceptance.php');
+$config = require(__DIR__.'/../tests/codeception/config/frontend/acceptance.php');
 
 (new yii\web\Application($config))->run();

Please login to merge, or discard this patch.

frontend/controllers/SiteController.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -90,8 +90,8 @@
 block discarded – undo
             $comment = new PostComment();
             $query = $query->andWhere(['id' => $frontPage]);
             if ($post = $query->one()) {
-                if (is_file($this->view->theme->basePath . '/post/view-' . $post->postType->slug . '.php')) {
-                    $render = '/post/view-' . $post->postType->slug;
+                if (is_file($this->view->theme->basePath.'/post/view-'.$post->postType->slug.'.php')) {
+                    $render = '/post/view-'.$post->postType->slug;
                 }
 
                 return $this->render($render, [

Please login to merge, or discard this patch.

frontend/views/post/protected.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -16,14 +16,14 @@
 block discarded – undo
 /* @var $comment common\models\PostComment */
 /* @var $category common\models\Term */
 
-$this->title = Html::encode($post->title . ' - ' . Option::get('sitetitle'));
+$this->title = Html::encode($post->title.' - '.Option::get('sitetitle'));
 $this->params['breadcrumbs'][] = [
     'label' => Html::encode($post->postType->singular_name),
     'url' => ['/post/index', 'id' => $post->postType->id],
 ];
 $category = $post->getTerms()
     ->innerJoinWith([
-        'taxonomy' => function ($query) {
+        'taxonomy' => function($query) {
             /* @var $query \yii\db\ActiveQuery */
             $query->from(['taxonomy' => Taxonomy::tableName()]);
         },

Please login to merge, or discard this patch.

frontend/views/post/view.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,14 +17,14 @@  discard block
 block discarded – undo
 /* @var $category common\models\Term */
 /* @var $tags common\models\Term[] */
 
-$this->title = Html::encode($post->title . ' - ' . Option::get('sitetitle'));
+$this->title = Html::encode($post->title.' - '.Option::get('sitetitle'));
 $this->params['breadcrumbs'][] = [
     'label' => Html::encode($post->postType->singular_name),
     'url' => ['/post/index', 'id' => $post->postType->id],
 ];
 $category = $post->getTerms()
     ->innerJoinWith([
-        'taxonomy' => function ($query) {
+        'taxonomy' => function($query) {
             /* @var $query \yii\db\ActiveQuery */
             $query->from(['taxonomy' => Taxonomy::tableName()]);
         },
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
         <footer class="footer-meta">
             <?php $tags = $post->getTerms()
                 ->innerJoinWith([
-                    'taxonomy' => function ($query) {
+                    'taxonomy' => function($query) {
                         /** @var $query \yii\db\ActiveQuery */
                         return $query->from(['taxonomy' => Taxonomy::tableName()]);
                     },
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
             <?php if ($tags): ?>
                 <h3>
                     <?php foreach ($tags as $tag): ?>
-                        <?= Html::a($tag->name, $tag->url, ['class' => 'btn btn-xs btn-success']) . "\n" ?>
+                        <?= Html::a($tag->name, $tag->url, ['class' => 'btn btn-xs btn-success'])."\n" ?>
                     <?php endforeach ?>
                 </h3>
             <?php endif ?>

Please login to merge, or discard this patch.

frontend/views/post/index.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 /* @var $tags common\models\Term[] */
 /* @var $pages yii\data\Pagination */
 
-$this->title = Html::encode($postType->plural_name . ' - ' . Option::get('sitetitle'));
+$this->title = Html::encode($postType->plural_name.' - '.Option::get('sitetitle'));
 $this->params['breadcrumbs'][] = Html::encode($postType->plural_name);
 ?>
 <div class="archive post-index">
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
                 <footer class="footer-meta">
                     <?php $tags = $post->getTerms()
                         ->innerJoinWith([
-                            'taxonomy' => function ($query) {
+                            'taxonomy' => function($query) {
                                 /** @var $query \yii\db\ActiveQuery */
                                 return $query->from(['taxonomy' => Taxonomy::tableName()]);
                             },
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
                     <?php if ($tags): ?>
                         <h3>
                             <?php foreach ($tags as $tag): ?>
-                                <?= Html::a($tag->name, $tag->url, ['class' => 'btn btn-xs btn-success']) . "\n" ?>
+                                <?= Html::a($tag->name, $tag->url, ['class' => 'btn btn-xs btn-success'])."\n" ?>
                             <?php endforeach ?>
                         </h3>
                     <?php endif; ?>

Please login to merge, or discard this patch.

		@@ -2,16 +2,16 @@
		block discarded – undo
2	2	defined('YII_DEBUG') or define('YII_DEBUG', false);
3	3	defined('YII_ENV') or define('YII_ENV', 'prod');
4	4
5		-require(__DIR__ . '/../vendor/autoload.php');
6		-require(__DIR__ . '/../vendor/yiisoft/yii2/Yii.php');
7		-require(__DIR__ . '/../common/config/bootstrap.php');
8		-require(__DIR__ . '/../frontend/config/bootstrap.php');
	5	+require(__DIR__.'/../vendor/autoload.php');
	6	+require(__DIR__.'/../vendor/yiisoft/yii2/Yii.php');
	7	+require(__DIR__.'/../common/config/bootstrap.php');
	8	+require(__DIR__.'/../frontend/config/bootstrap.php');
9	9
10	10	$config = yii\helpers\ArrayHelper::merge(
11		- require(__DIR__ . '/../common/config/main.php'),
12		- require(__DIR__ . '/../common/config/main-local.php'),
13		- require(__DIR__ . '/../frontend/config/main.php'),
14		- require(__DIR__ . '/../frontend/config/main-local.php')
	11	+ require(__DIR__.'/../common/config/main.php'),
	12	+ require(__DIR__.'/../common/config/main-local.php'),
	13	+ require(__DIR__.'/../frontend/config/main.php'),
	14	+ require(__DIR__.'/../frontend/config/main-local.php')
15	15	);
16	16
17	17	$application = new yii\web\Application($config);

		@@ -8,12 +8,12 @@
		block discarded – undo
8	8	defined('YII_DEBUG') or define('YII_DEBUG', true);
9	9	defined('YII_ENV') or define('YII_ENV', 'test');
10	10
11		-require(__DIR__ . '/../../vendor/autoload.php');
12		-require(__DIR__ . '/../../vendor/yiisoft/yii2/Yii.php');
13		-require(__DIR__ . '/../../common/config/bootstrap.php');
14		-require(__DIR__ . '/../../backend/config/bootstrap.php');
	11	+require(__DIR__.'/../../vendor/autoload.php');
	12	+require(__DIR__.'/../../vendor/yiisoft/yii2/Yii.php');
	13	+require(__DIR__.'/../../common/config/bootstrap.php');
	14	+require(__DIR__.'/../../backend/config/bootstrap.php');
15	15
16	16
17		-$config = require(__DIR__ . '/../../tests/codeception/config/backend/acceptance.php');
	17	+$config = require(__DIR__.'/../../tests/codeception/config/backend/acceptance.php');
18	18
19	19	(new yii\web\Application($config))->run();

		@@ -8,11 +8,11 @@
		block discarded – undo
8	8	defined('YII_DEBUG') or define('YII_DEBUG', true);
9	9	defined('YII_ENV') or define('YII_ENV', 'test');
10	10
11		-require(__DIR__ . '/../vendor/autoload.php');
12		-require(__DIR__ . '/../vendor/yiisoft/yii2/Yii.php');
13		-require(__DIR__ . '/../common/config/bootstrap.php');
14		-require(__DIR__ . '/../frontend/config/bootstrap.php');
	11	+require(__DIR__.'/../vendor/autoload.php');
	12	+require(__DIR__.'/../vendor/yiisoft/yii2/Yii.php');
	13	+require(__DIR__.'/../common/config/bootstrap.php');
	14	+require(__DIR__.'/../frontend/config/bootstrap.php');
15	15
16		-$config = require(__DIR__ . '/../tests/codeception/config/frontend/acceptance.php');
	16	+$config = require(__DIR__.'/../tests/codeception/config/frontend/acceptance.php');
17	17
18	18	(new yii\web\Application($config))->run();

		@@ -90,8 +90,8 @@
		block discarded – undo
90	90	$comment = new PostComment();
91	91	$query = $query->andWhere(['id' => $frontPage]);
92	92	if ($post = $query->one()) {
93		- if (is_file($this->view->theme->basePath . '/post/view-' . $post->postType->slug . '.php')) {
94		- $render = '/post/view-' . $post->postType->slug;
	93	+ if (is_file($this->view->theme->basePath.'/post/view-'.$post->postType->slug.'.php')) {
	94	+ $render = '/post/view-'.$post->postType->slug;
95	95	}
96	96
97	97	return $this->render($render, [

		@@ -16,14 +16,14 @@
		block discarded – undo
16	16	/* @var $comment common\models\PostComment */
17	17	/* @var $category common\models\Term */
18	18
19		-$this->title = Html::encode($post->title . ' - ' . Option::get('sitetitle'));
	19	+$this->title = Html::encode($post->title.' - '.Option::get('sitetitle'));
20	20	$this->params['breadcrumbs'][] = [
21	21	'label' => Html::encode($post->postType->singular_name),
22	22	'url' => ['/post/index', 'id' => $post->postType->id],
23	23	];
24	24	$category = $post->getTerms()
25	25	->innerJoinWith([
26		- 'taxonomy' => function ($query) {
	26	+ 'taxonomy' => function($query) {
27	27	/* @var $query \yii\db\ActiveQuery */
28	28	$query->from(['taxonomy' => Taxonomy::tableName()]);
29	29	},

		@@ -17,14 +17,14 @@ discard block
		block discarded – undo
17	17	/* @var $category common\models\Term */
18	18	/* @var $tags common\models\Term[] */
19	19
20		-$this->title = Html::encode($post->title . ' - ' . Option::get('sitetitle'));
	20	+$this->title = Html::encode($post->title.' - '.Option::get('sitetitle'));
21	21	$this->params['breadcrumbs'][] = [
22	22	'label' => Html::encode($post->postType->singular_name),
23	23	'url' => ['/post/index', 'id' => $post->postType->id],
24	24	];
25	25	$category = $post->getTerms()
26	26	->innerJoinWith([
27		- 'taxonomy' => function ($query) {
	27	+ 'taxonomy' => function($query) {
28	28	/* @var $query \yii\db\ActiveQuery */
29	29	$query->from(['taxonomy' => Taxonomy::tableName()]);
30	30	},
		@@ -81,7 +81,7 @@ discard block
		block discarded – undo
81	81	<footer class="footer-meta">
82	82	<?php $tags = $post->getTerms()
83	83	->innerJoinWith([
84		- 'taxonomy' => function ($query) {
	84	+ 'taxonomy' => function($query) {
85	85	/** @var $query \yii\db\ActiveQuery */
86	86	return $query->from(['taxonomy' => Taxonomy::tableName()]);
87	87	},
		@@ -92,7 +92,7 @@ discard block
		block discarded – undo
92	92	<?php if ($tags): ?>
93	93	<h3>
94	94	<?php foreach ($tags as $tag): ?>
95		- <?= Html::a($tag->name, $tag->url, ['class' => 'btn btn-xs btn-success']) . "\n" ?>
	95	+ <?= Html::a($tag->name, $tag->url, ['class' => 'btn btn-xs btn-success'])."\n" ?>
96	96	<?php endforeach ?>
97	97	</h3>
98	98	<?php endif ?>

		@@ -17,7 +17,7 @@ discard block
		block discarded – undo
17	17	/* @var $tags common\models\Term[] */
18	18	/* @var $pages yii\data\Pagination */
19	19
20		-$this->title = Html::encode($postType->plural_name . ' - ' . Option::get('sitetitle'));
	20	+$this->title = Html::encode($postType->plural_name.' - '.Option::get('sitetitle'));
21	21	$this->params['breadcrumbs'][] = Html::encode($postType->plural_name);
22	22	?>
23	23	<div class="archive post-index">
		@@ -69,7 +69,7 @@ discard block
		block discarded – undo
69	69	<footer class="footer-meta">
70	70	<?php $tags = $post->getTerms()
71	71	->innerJoinWith([
72		- 'taxonomy' => function ($query) {
	72	+ 'taxonomy' => function($query) {
73	73	/** @var $query \yii\db\ActiveQuery */
74	74	return $query->from(['taxonomy' => Taxonomy::tableName()]);
75	75	},
		@@ -80,7 +80,7 @@ discard block
		block discarded – undo
80	80	<?php if ($tags): ?>
81	81	<h3>
82	82	<?php foreach ($tags as $tag): ?>
83		- <?= Html::a($tag->name, $tag->url, ['class' => 'btn btn-xs btn-success']) . "\n" ?>
	83	+ <?= Html::a($tag->name, $tag->url, ['class' => 'btn btn-xs btn-success'])."\n" ?>
84	84	<?php endforeach ?>
85	85	</h3>
86	86	<?php endif; ?>

writesdown / app-cms

Push — master ( 3b924e...fb7a26 )

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch