Inspection of "Use ArrayHelper to retrieve config value" - writesdown/app-cms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3b924e...fb7a26 )

by Agiel Kurniawan

created 2016-04-14 06:12 UTC

Status

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -58,7 +58,7 @@  discard block
 block discarded – undo
     /**
      * Lists all User models.
      *
-     * @return mixed
+     * @return string
      */
     public function actionIndex()
     {
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
      * Displays a single User model.
      *
      * @param integer $id
-     * @return mixed
+     * @return string
      */
     public function actionView($id)
     {
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
      * @throws \Exception
      * @throws \yii\web\ForbiddenHttpException
      * @throws \yii\web\NotFoundHttpException
-     * @return mixed
+     * @return \yii\web\Response
      */
     public function actionDelete($id)
     {

Please login to merge, or discard this patch.

console/migrations/m000000_000020_module.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -23,16 +23,16 @@
 block discarded – undo
 
         $this->createTable('{{%module}}', [
             'id' => Schema::TYPE_PK,
-            'name' => Schema::TYPE_STRING . '(64) NOT NULL',
-            'title' => Schema::TYPE_TEXT . ' NOT NULL',
+            'name' => Schema::TYPE_STRING.'(64) NOT NULL',
+            'title' => Schema::TYPE_TEXT.' NOT NULL',
             'description' => Schema::TYPE_TEXT,
-            'config' => Schema::TYPE_TEXT . ' NOT NULL',
-            'status' => Schema::TYPE_SMALLINT . '(1) NOT NULL DEFAULT 0',
-            'directory' => Schema::TYPE_STRING . '(128) NOT NULL',
-            'backend_bootstrap' => Schema::TYPE_SMALLINT . '(1) NOT NULL DEFAULT 0',
-            'frontend_bootstrap' => Schema::TYPE_SMALLINT . '(1) NOT NULL DEFAULT 0',
-            'date' => Schema::TYPE_DATETIME . ' NOT NULL',
-            'modified' => Schema::TYPE_DATETIME . ' NOT NULL',
+            'config' => Schema::TYPE_TEXT.' NOT NULL',
+            'status' => Schema::TYPE_SMALLINT.'(1) NOT NULL DEFAULT 0',
+            'directory' => Schema::TYPE_STRING.'(128) NOT NULL',
+            'backend_bootstrap' => Schema::TYPE_SMALLINT.'(1) NOT NULL DEFAULT 0',
+            'frontend_bootstrap' => Schema::TYPE_SMALLINT.'(1) NOT NULL DEFAULT 0',
+            'date' => Schema::TYPE_DATETIME.' NOT NULL',
+            'modified' => Schema::TYPE_DATETIME.' NOT NULL',
         ], $tableOptions);
 
         /**

Please login to merge, or discard this patch.

backend/views/site/index.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -92,7 +92,7 @@  discard block
 block discarded – undo
                         <?php foreach ($posts as $post): ?>
                             <tr>
                                 <td><?= $post->postAuthor->display_name ?></td>
-                                <td><?= substr(strip_tags($post->excerpt), 0, 180) . '...' ?></td>
+                                <td><?= substr(strip_tags($post->excerpt), 0, 180).'...' ?></td>
                                 <td><?= date('M d, Y H:i:s', strtotime($post->date)) ?></td>
                                 <td><?= $post->comment_count ?></td>
                                 <td>
@@ -182,11 +182,11 @@  discard block
 block discarded – undo
                         <?php foreach ($comments as $comment): ?>
                             <tr>
                                 <td><?= $comment->author ?></td>
-                                <td><?= substr(strip_tags($comment->content), 0, 180) . '...' ?></td>
+                                <td><?= substr(strip_tags($comment->content), 0, 180).'...' ?></td>
                                 <td>
                                     <?= Html::a(
                                         '<span class="glyphicon glyphicon-eye-open"></span>',
-                                        $comment->commentPost->url . '#comment-' . $comment->id,
+                                        $comment->commentPost->url.'#comment-'.$comment->id,
                                         ['title' => Yii::t('writesdown', 'View Comment')]
                                     ) ?>
 

Please login to merge, or discard this patch.

backend/views/media-comment/reply.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@
 block discarded – undo
                     'attribute' => 'ip',
                     'value' => Html::a(
                         $commentParent->ip,
-                        'http://whois.arin.net/rest/ip/' . $commentParent->ip,
+                        'http://whois.arin.net/rest/ip/'.$commentParent->ip,
                         ['target' => '_blank']
                     ),
                     'format' => 'raw',

Please login to merge, or discard this patch.

backend/views/media-comment/update.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -54,7 +54,7 @@  discard block
 block discarded – undo
                     'attribute' => 'ip',
                     'value' => Html::a(
                         $model->ip,
-                        'http://whois.arin.net/rest/ip/' . $model->ip,
+                        'http://whois.arin.net/rest/ip/'.$model->ip,
                         ['target' => '_blank']
                     ),
                     'format' => 'raw',
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
                 [
                     'attribute' => 'date',
                     'value' => Html::a(
-                        date('M d, Y H:i:s', strtotime($model->date)) . ' <i class="fa fa-pencil"></i>',
+                        date('M d, Y H:i:s', strtotime($model->date)).' <i class="fa fa-pencil"></i>',
                         '#', [
                             'data-toggle' => 'modal',
                             'id' => 'date-link',
@@ -84,13 +84,13 @@  discard block
 block discarded – undo
         ]) ?>
 
         <?= Html::a(
-            '<span class="glyphicon glyphicon-share-alt"></span> ' . Yii::t('writesdown', 'Reply'),
+            '<span class="glyphicon glyphicon-share-alt"></span> '.Yii::t('writesdown', 'Reply'),
             ['reply', 'id' => $model->id],
             ['class' => 'btn btn-sm btn-flat btn-success']
         ) ?>
 
         <?= Html::a(
-            '<span class="glyphicon glyphicon-trash"></span> ' . Yii::t('writesdown', 'Delete'),
+            '<span class="glyphicon glyphicon-trash"></span> '.Yii::t('writesdown', 'Delete'),
             ['delete', 'id' => $model->id],
             [
                 'class' => 'btn btn-wd-post btn-sm btn-flat btn-danger pull-right',
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
     </div>
 </div>
 <?php Modal::begin([
-    'header' => '<i class="glyphicon glyphicon-time"></i> ' . Yii::t('writesdown', 'Change Comment Date'),
+    'header' => '<i class="glyphicon glyphicon-time"></i> '.Yii::t('writesdown', 'Change Comment Date'),
     'id' => 'modal-for-date',
 ]) ?>
 

Please login to merge, or discard this patch.

backend/views/post-comment/reply.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -68,7 +68,7 @@
 block discarded – undo
                     'attribute' => 'ip',
                     'value' => Html::a(
                         $commentParent->ip,
-                        'http://whois.arin.net/rest/ip/' . $commentParent->ip,
+                        'http://whois.arin.net/rest/ip/'.$commentParent->ip,
                         ['target' => '_blank']
                     ),
                     'format' => 'raw',

Please login to merge, or discard this patch.

backend/views/post-comment/update.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -60,7 +60,7 @@  discard block
 block discarded – undo
                     'attribute' => 'ip',
                     'value' => Html::a(
                         $model->ip,
-                        'http://whois.arin.net/rest/ip/' . $model->ip,
+                        'http://whois.arin.net/rest/ip/'.$model->ip,
                         ['target' => '_blank']
                     ),
                     'format' => 'raw',
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
                 [
                     'attribute' => 'date',
                     'value' => Html::a(
-                        date('M d, Y H:i:s', strtotime($model->date)) . ' <i class="fa fa-pencil"></i>',
+                        date('M d, Y H:i:s', strtotime($model->date)).' <i class="fa fa-pencil"></i>',
                         '#', [
                             'data-toggle' => 'modal',
                             'id' => 'date-link',
@@ -90,13 +90,13 @@  discard block
 block discarded – undo
         ]) ?>
 
         <?= Html::a(
-            '<span class="glyphicon glyphicon-share-alt"></span> ' . Yii::t('writesdown', 'Reply'),
+            '<span class="glyphicon glyphicon-share-alt"></span> '.Yii::t('writesdown', 'Reply'),
             ['reply', 'id' => $model->id],
             ['class' => 'btn btn-sm btn-flat btn-success']
         ) ?>
 
         <?= Html::a(
-            '<span class="glyphicon glyphicon-trash"></span> ' . Yii::t('writesdown', 'Delete'),
+            '<span class="glyphicon glyphicon-trash"></span> '.Yii::t('writesdown', 'Delete'),
             ['delete', 'id' => $model->id],
             [
                 'class' => 'btn btn-wd-post btn-sm btn-flat btn-danger pull-right',
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
     </div>
 </div>
 <?php Modal::begin([
-    'header' => '<i class="glyphicon glyphicon-time"></i> ' . Yii::t('writesdown', 'Change Comment Date') . '',
+    'header' => '<i class="glyphicon glyphicon-time"></i> '.Yii::t('writesdown', 'Change Comment Date').'',
     'id' => 'modal-for-date',
 ]) ?>
 

Please login to merge, or discard this patch.

backend/views/media/update.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -84,7 +84,7 @@
 block discarded – undo
     </div>
 </div>
 <?php Modal::begin([
-    'header' => '<i class="glyphicon glyphicon-time"></i> ' . Yii::t('writesdown', 'Change Media Date') . '',
+    'header' => '<i class="glyphicon glyphicon-time"></i> '.Yii::t('writesdown', 'Change Media Date').'',
     'id' => 'modal-for-date',
 ]) ?>
 

Please login to merge, or discard this patch.

common/models/Module.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -182,7 +182,7 @@  discard block
 block discarded – undo
      */
     public function getParamPath()
     {
-        return Yii::getAlias('@modules/' . $this->directory . '/config/params.php');
+        return Yii::getAlias('@modules/'.$this->directory.'/config/params.php');
     }
 
     /**
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
      */
     public function getConfigPath()
     {
-        return Yii::getAlias('@modules/' . $this->directory . '/config/config.php');
+        return Yii::getAlias('@modules/'.$this->directory.'/config/config.php');
     }
 
     /**

Please login to merge, or discard this patch.

		@@ -182,7 +182,7 @@ discard block
		block discarded – undo
182	182	*/
183	183	public function getParamPath()
184	184	{
185		- return Yii::getAlias('@modules/' . $this->directory . '/config/params.php');
	185	+ return Yii::getAlias('@modules/'.$this->directory.'/config/params.php');
186	186	}
187	187
188	188	/**
		@@ -192,7 +192,7 @@ discard block
		block discarded – undo
192	192	*/
193	193	public function getConfigPath()
194	194	{
195		- return Yii::getAlias('@modules/' . $this->directory . '/config/config.php');
	195	+ return Yii::getAlias('@modules/'.$this->directory.'/config/config.php');
196	196	}
197	197
198	198	/**

		@@ -58,7 +58,7 @@ discard block
		block discarded – undo
58	58	/**
59	59	* Lists all User models.
60	60	*
61		- * @return mixed
	61	+ * @return string
62	62	*/
63	63	public function actionIndex()
64	64	{
		@@ -75,7 +75,7 @@ discard block
		block discarded – undo
75	75	* Displays a single User model.
76	76	*
77	77	* @param integer $id
78		- * @return mixed
	78	+ * @return string
79	79	*/
80	80	public function actionView($id)
81	81	{
		@@ -144,7 +144,7 @@ discard block
		block discarded – undo
144	144	* @throws \Exception
145	145	* @throws \yii\web\ForbiddenHttpException
146	146	* @throws \yii\web\NotFoundHttpException
147		- * @return mixed
	147	+ * @return \yii\web\Response
148	148	*/
149	149	public function actionDelete($id)
150	150	{

		@@ -23,16 +23,16 @@
		block discarded – undo
23	23
24	24	$this->createTable('{{%module}}', [
25	25	'id' => Schema::TYPE_PK,
26		- 'name' => Schema::TYPE_STRING . '(64) NOT NULL',
27		- 'title' => Schema::TYPE_TEXT . ' NOT NULL',
	26	+ 'name' => Schema::TYPE_STRING.'(64) NOT NULL',
	27	+ 'title' => Schema::TYPE_TEXT.' NOT NULL',
28	28	'description' => Schema::TYPE_TEXT,
29		- 'config' => Schema::TYPE_TEXT . ' NOT NULL',
30		- 'status' => Schema::TYPE_SMALLINT . '(1) NOT NULL DEFAULT 0',
31		- 'directory' => Schema::TYPE_STRING . '(128) NOT NULL',
32		- 'backend_bootstrap' => Schema::TYPE_SMALLINT . '(1) NOT NULL DEFAULT 0',
33		- 'frontend_bootstrap' => Schema::TYPE_SMALLINT . '(1) NOT NULL DEFAULT 0',
34		- 'date' => Schema::TYPE_DATETIME . ' NOT NULL',
35		- 'modified' => Schema::TYPE_DATETIME . ' NOT NULL',
	29	+ 'config' => Schema::TYPE_TEXT.' NOT NULL',
	30	+ 'status' => Schema::TYPE_SMALLINT.'(1) NOT NULL DEFAULT 0',
	31	+ 'directory' => Schema::TYPE_STRING.'(128) NOT NULL',
	32	+ 'backend_bootstrap' => Schema::TYPE_SMALLINT.'(1) NOT NULL DEFAULT 0',
	33	+ 'frontend_bootstrap' => Schema::TYPE_SMALLINT.'(1) NOT NULL DEFAULT 0',
	34	+ 'date' => Schema::TYPE_DATETIME.' NOT NULL',
	35	+ 'modified' => Schema::TYPE_DATETIME.' NOT NULL',
36	36	], $tableOptions);
37	37
38	38	/**

		@@ -92,7 +92,7 @@ discard block
		block discarded – undo
92	92	<?php foreach ($posts as $post): ?>
93	93	<tr>
94	94	<td><?= $post->postAuthor->display_name ?></td>
95		- <td><?= substr(strip_tags($post->excerpt), 0, 180) . '...' ?></td>
	95	+ <td><?= substr(strip_tags($post->excerpt), 0, 180).'...' ?></td>
96	96	<td><?= date('M d, Y H:i:s', strtotime($post->date)) ?></td>
97	97	<td><?= $post->comment_count ?></td>
98	98	<td>
		@@ -182,11 +182,11 @@ discard block
		block discarded – undo
182	182	<?php foreach ($comments as $comment): ?>
183	183	<tr>
184	184	<td><?= $comment->author ?></td>
185		- <td><?= substr(strip_tags($comment->content), 0, 180) . '...' ?></td>
	185	+ <td><?= substr(strip_tags($comment->content), 0, 180).'...' ?></td>
186	186	<td>
187	187	<?= Html::a(
188	188	'<span class="glyphicon glyphicon-eye-open"></span>',
189		- $comment->commentPost->url . '#comment-' . $comment->id,
	189	+ $comment->commentPost->url.'#comment-'.$comment->id,
190	190	['title' => Yii::t('writesdown', 'View Comment')]
191	191	) ?>
192	192

		@@ -63,7 +63,7 @@
		block discarded – undo
63	63	'attribute' => 'ip',
64	64	'value' => Html::a(
65	65	$commentParent->ip,
66		- 'http://whois.arin.net/rest/ip/' . $commentParent->ip,
	66	+ 'http://whois.arin.net/rest/ip/'.$commentParent->ip,
67	67	['target' => '_blank']
68	68	),
69	69	'format' => 'raw',

		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54	'attribute' => 'ip',
55	55	'value' => Html::a(
56	56	$model->ip,
57		- 'http://whois.arin.net/rest/ip/' . $model->ip,
	57	+ 'http://whois.arin.net/rest/ip/'.$model->ip,
58	58	['target' => '_blank']
59	59	),
60	60	'format' => 'raw',
		@@ -62,7 +62,7 @@ discard block
		block discarded – undo
62	62	[
63	63	'attribute' => 'date',
64	64	'value' => Html::a(
65		- date('M d, Y H:i:s', strtotime($model->date)) . ' <i class="fa fa-pencil"></i>',
	65	+ date('M d, Y H:i:s', strtotime($model->date)).' <i class="fa fa-pencil"></i>',
66	66	'#', [
67	67	'data-toggle' => 'modal',
68	68	'id' => 'date-link',
		@@ -84,13 +84,13 @@ discard block
		block discarded – undo
84	84	]) ?>
85	85
86	86	<?= Html::a(
87		- '<span class="glyphicon glyphicon-share-alt"></span> ' . Yii::t('writesdown', 'Reply'),
	87	+ '<span class="glyphicon glyphicon-share-alt"></span> '.Yii::t('writesdown', 'Reply'),
88	88	['reply', 'id' => $model->id],
89	89	['class' => 'btn btn-sm btn-flat btn-success']
90	90	) ?>
91	91
92	92	<?= Html::a(
93		- '<span class="glyphicon glyphicon-trash"></span> ' . Yii::t('writesdown', 'Delete'),
	93	+ '<span class="glyphicon glyphicon-trash"></span> '.Yii::t('writesdown', 'Delete'),
94	94	['delete', 'id' => $model->id],
95	95	[
96	96	'class' => 'btn btn-wd-post btn-sm btn-flat btn-danger pull-right',
		@@ -101,7 +101,7 @@ discard block
		block discarded – undo
101	101	</div>
102	102	</div>
103	103	<?php Modal::begin([
104		- 'header' => '<i class="glyphicon glyphicon-time"></i> ' . Yii::t('writesdown', 'Change Comment Date'),
	104	+ 'header' => '<i class="glyphicon glyphicon-time"></i> '.Yii::t('writesdown', 'Change Comment Date'),
105	105	'id' => 'modal-for-date',
106	106	]) ?>
107	107

		@@ -68,7 +68,7 @@
		block discarded – undo
68	68	'attribute' => 'ip',
69	69	'value' => Html::a(
70	70	$commentParent->ip,
71		- 'http://whois.arin.net/rest/ip/' . $commentParent->ip,
	71	+ 'http://whois.arin.net/rest/ip/'.$commentParent->ip,
72	72	['target' => '_blank']
73	73	),
74	74	'format' => 'raw',

		@@ -60,7 +60,7 @@ discard block
		block discarded – undo
60	60	'attribute' => 'ip',
61	61	'value' => Html::a(
62	62	$model->ip,
63		- 'http://whois.arin.net/rest/ip/' . $model->ip,
	63	+ 'http://whois.arin.net/rest/ip/'.$model->ip,
64	64	['target' => '_blank']
65	65	),
66	66	'format' => 'raw',
		@@ -68,7 +68,7 @@ discard block
		block discarded – undo
68	68	[
69	69	'attribute' => 'date',
70	70	'value' => Html::a(
71		- date('M d, Y H:i:s', strtotime($model->date)) . ' <i class="fa fa-pencil"></i>',
	71	+ date('M d, Y H:i:s', strtotime($model->date)).' <i class="fa fa-pencil"></i>',
72	72	'#', [
73	73	'data-toggle' => 'modal',
74	74	'id' => 'date-link',
		@@ -90,13 +90,13 @@ discard block
		block discarded – undo
90	90	]) ?>
91	91
92	92	<?= Html::a(
93		- '<span class="glyphicon glyphicon-share-alt"></span> ' . Yii::t('writesdown', 'Reply'),
	93	+ '<span class="glyphicon glyphicon-share-alt"></span> '.Yii::t('writesdown', 'Reply'),
94	94	['reply', 'id' => $model->id],
95	95	['class' => 'btn btn-sm btn-flat btn-success']
96	96	) ?>
97	97
98	98	<?= Html::a(
99		- '<span class="glyphicon glyphicon-trash"></span> ' . Yii::t('writesdown', 'Delete'),
	99	+ '<span class="glyphicon glyphicon-trash"></span> '.Yii::t('writesdown', 'Delete'),
100	100	['delete', 'id' => $model->id],
101	101	[
102	102	'class' => 'btn btn-wd-post btn-sm btn-flat btn-danger pull-right',
		@@ -107,7 +107,7 @@ discard block
		block discarded – undo
107	107	</div>
108	108	</div>
109	109	<?php Modal::begin([
110		- 'header' => '<i class="glyphicon glyphicon-time"></i> ' . Yii::t('writesdown', 'Change Comment Date') . '',
	110	+ 'header' => '<i class="glyphicon glyphicon-time"></i> '.Yii::t('writesdown', 'Change Comment Date').'',
111	111	'id' => 'modal-for-date',
112	112	]) ?>
113	113

		@@ -84,7 +84,7 @@
		block discarded – undo
84	84	</div>
85	85	</div>
86	86	<?php Modal::begin([
87		- 'header' => '<i class="glyphicon glyphicon-time"></i> ' . Yii::t('writesdown', 'Change Media Date') . '',
	87	+ 'header' => '<i class="glyphicon glyphicon-time"></i> '.Yii::t('writesdown', 'Change Media Date').'',
88	88	'id' => 'modal-for-date',
89	89	]) ?>
90	90

writesdown / app-cms

Push — master ( 3b924e...fb7a26 )

Status

Category

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch