Completed
Pull Request — master (#1365)
by
unknown
01:49
created
includes/class-wc-stripe-apple-pay-registration.php 1 patch
Spacing   +59 added lines, -59 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@  discard block
 block discarded – undo
5 5
  * @since 4.0.6
6 6
  */
7 7
 
8
-if ( ! defined( 'ABSPATH' ) ) {
8
+if ( ! defined('ABSPATH')) {
9 9
 	exit;
10 10
 }
11 11
 
@@ -32,17 +32,17 @@  discard block
 block discarded – undo
32 32
 	public $apple_pay_verify_notice;
33 33
 
34 34
 	public function __construct() {
35
-		add_action( 'init', array( $this, 'add_domain_association_rewrite_rule' ) );
36
-		add_filter( 'query_vars', array( $this, 'whitelist_domain_association_query_param' ), 10, 1 );
37
-		add_action( 'parse_request', array( $this, 'parse_domain_association_request' ), 10, 1 );
35
+		add_action('init', array($this, 'add_domain_association_rewrite_rule'));
36
+		add_filter('query_vars', array($this, 'whitelist_domain_association_query_param'), 10, 1);
37
+		add_action('parse_request', array($this, 'parse_domain_association_request'), 10, 1);
38 38
 
39
-		add_action( 'woocommerce_stripe_updated', array( $this, 'verify_domain_if_configured' ) );
40
-		add_action( 'add_option_woocommerce_stripe_settings', array( $this, 'verify_domain_on_new_settings' ), 10, 2 );
41
-		add_action( 'update_option_woocommerce_stripe_settings', array( $this, 'verify_domain_on_updated_settings' ), 10, 2 );
42
-		add_action( 'admin_notices', array( $this, 'admin_notices' ) );
39
+		add_action('woocommerce_stripe_updated', array($this, 'verify_domain_if_configured'));
40
+		add_action('add_option_woocommerce_stripe_settings', array($this, 'verify_domain_on_new_settings'), 10, 2);
41
+		add_action('update_option_woocommerce_stripe_settings', array($this, 'verify_domain_on_updated_settings'), 10, 2);
42
+		add_action('admin_notices', array($this, 'admin_notices'));
43 43
 
44
-		$this->stripe_settings         = get_option( 'woocommerce_stripe_settings', array() );
45
-		$this->apple_pay_domain_set    = 'yes' === $this->get_option( 'apple_pay_domain_set', 'no' );
44
+		$this->stripe_settings         = get_option('woocommerce_stripe_settings', array());
45
+		$this->apple_pay_domain_set    = 'yes' === $this->get_option('apple_pay_domain_set', 'no');
46 46
 		$this->apple_pay_verify_notice = '';
47 47
 	}
48 48
 
@@ -54,13 +54,13 @@  discard block
 block discarded – undo
54 54
 	 * @param string default
55 55
 	 * @return string $setting_value
56 56
 	 */
57
-	public function get_option( $setting = '', $default = '' ) {
58
-		if ( empty( $this->stripe_settings ) ) {
57
+	public function get_option($setting = '', $default = '') {
58
+		if (empty($this->stripe_settings)) {
59 59
 			return $default;
60 60
 		}
61 61
 
62
-		if ( ! empty( $this->stripe_settings[ $setting ] ) ) {
63
-			return $this->stripe_settings[ $setting ];
62
+		if ( ! empty($this->stripe_settings[$setting])) {
63
+			return $this->stripe_settings[$setting];
64 64
 		}
65 65
 
66 66
 		return $default;
@@ -73,8 +73,8 @@  discard block
 block discarded – undo
73 73
 	 * @return string Whether Apple Pay required settings are enabled.
74 74
 	 */
75 75
 	private function is_enabled() {
76
-		$stripe_enabled                 = 'yes' === $this->get_option( 'enabled', 'no' );
77
-		$payment_request_button_enabled = 'yes' === $this->get_option( 'payment_request', 'yes' );
76
+		$stripe_enabled                 = 'yes' === $this->get_option('enabled', 'no');
77
+		$payment_request_button_enabled = 'yes' === $this->get_option('payment_request', 'yes');
78 78
 
79 79
 		return $stripe_enabled && $payment_request_button_enabled;
80 80
 	}
@@ -86,8 +86,8 @@  discard block
 block discarded – undo
86 86
 	 * @return string Secret key.
87 87
 	 */
88 88
 	private function get_secret_key() {
89
-		$testmode = 'yes' === $this->get_option( 'testmode', 'no' );
90
-		return $testmode ? $this->get_option( 'test_secret_key' ) : $this->get_option( 'secret_key' );
89
+		$testmode = 'yes' === $this->get_option('testmode', 'no');
90
+		return $testmode ? $this->get_option('test_secret_key') : $this->get_option('secret_key');
91 91
 	}
92 92
 
93 93
 	/**
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 		$regex    = '^\.well-known\/apple-developer-merchantid-domain-association$';
98 98
 		$redirect = 'index.php?apple-developer-merchantid-domain-association=1';
99 99
 
100
-		add_rewrite_rule( $regex, $redirect, 'top' );
100
+		add_rewrite_rule($regex, $redirect, 'top');
101 101
 	}
102 102
 
103 103
 	/**
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 	 * @param  array $query_vars - provided public query vars.
107 107
 	 * @return array Updated public query vars.
108 108
 	 */
109
-	public function whitelist_domain_association_query_param( $query_vars ) {
109
+	public function whitelist_domain_association_query_param($query_vars) {
110 110
 		$query_vars[] = 'apple-developer-merchantid-domain-association';
111 111
 		return $query_vars;
112 112
 	}
@@ -116,17 +116,17 @@  discard block
 block discarded – undo
116 116
 	 *
117 117
 	 * @param WP WordPress environment object.
118 118
 	 */
119
-	public function parse_domain_association_request( $wp ) {
119
+	public function parse_domain_association_request($wp) {
120 120
 		if (
121
-			! isset( $wp->query_vars['apple-developer-merchantid-domain-association'] ) ||
121
+			! isset($wp->query_vars['apple-developer-merchantid-domain-association']) ||
122 122
 			'1' !== $wp->query_vars['apple-developer-merchantid-domain-association']
123 123
 		) {
124 124
 			return;
125 125
 		}
126 126
 
127 127
 		$path = WC_STRIPE_PLUGIN_PATH . '/apple-developer-merchantid-domain-association';
128
-		header( 'Content-Type: application/octet-stream' );
129
-		echo esc_html( file_get_contents( $path ) );
128
+		header('Content-Type: application/octet-stream');
129
+		echo esc_html(file_get_contents($path));
130 130
 		exit;
131 131
 	}
132 132
 
@@ -137,9 +137,9 @@  discard block
 block discarded – undo
137 137
 	 * @version 4.5.4
138 138
 	 * @param string $secret_key
139 139
 	 */
140
-	private function make_domain_registration_request( $secret_key ) {
141
-		if ( empty( $secret_key ) ) {
142
-			throw new Exception( __( 'Unable to verify domain - missing secret key.', 'woocommerce-gateway-stripe' ) );
140
+	private function make_domain_registration_request($secret_key) {
141
+		if (empty($secret_key)) {
142
+			throw new Exception(__('Unable to verify domain - missing secret key.', 'woocommerce-gateway-stripe'));
143 143
 		}
144 144
 
145 145
 		$endpoint = 'https://api.stripe.com/v1/apple_pay/domains';
@@ -157,22 +157,22 @@  discard block
 block discarded – undo
157 157
 			$endpoint,
158 158
 			array(
159 159
 				'headers' => $headers,
160
-				'body'    => http_build_query( $data ),
160
+				'body'    => http_build_query($data),
161 161
 			)
162 162
 		);
163 163
 
164
-		if ( is_wp_error( $response ) ) {
164
+		if (is_wp_error($response)) {
165 165
 			/* translators: error message */
166
-			throw new Exception( sprintf( __( 'Unable to verify domain - %s', 'woocommerce-gateway-stripe' ), $response->get_error_message() ) );
166
+			throw new Exception(sprintf(__('Unable to verify domain - %s', 'woocommerce-gateway-stripe'), $response->get_error_message()));
167 167
 		}
168 168
 
169
-		if ( 200 !== $response['response']['code'] ) {
170
-			$parsed_response = json_decode( $response['body'] );
169
+		if (200 !== $response['response']['code']) {
170
+			$parsed_response = json_decode($response['body']);
171 171
 
172 172
 			$this->apple_pay_verify_notice = $parsed_response->error->message;
173 173
 
174 174
 			/* translators: error message */
175
-			throw new Exception( sprintf( __( 'Unable to verify domain - %s', 'woocommerce-gateway-stripe' ), $parsed_response->error->message ) );
175
+			throw new Exception(sprintf(__('Unable to verify domain - %s', 'woocommerce-gateway-stripe'), $parsed_response->error->message));
176 176
 		}
177 177
 	}
178 178
 
@@ -184,25 +184,25 @@  discard block
 block discarded – undo
184 184
 	 *
185 185
 	 * @param string $secret_key
186 186
 	 */
187
-	public function register_domain_with_apple( $secret_key ) {
187
+	public function register_domain_with_apple($secret_key) {
188 188
 		try {
189
-			$this->make_domain_registration_request( $secret_key );
189
+			$this->make_domain_registration_request($secret_key);
190 190
 
191 191
 			// No errors to this point, verification success!
192 192
 			$this->stripe_settings['apple_pay_domain_set'] = 'yes';
193 193
 			$this->apple_pay_domain_set                    = true;
194 194
 
195
-			update_option( 'woocommerce_stripe_settings', $this->stripe_settings );
195
+			update_option('woocommerce_stripe_settings', $this->stripe_settings);
196 196
 
197
-			WC_Stripe_Logger::log( 'Your domain has been verified with Apple Pay!' );
197
+			WC_Stripe_Logger::log('Your domain has been verified with Apple Pay!');
198 198
 
199
-		} catch ( Exception $e ) {
199
+		} catch (Exception $e) {
200 200
 			$this->stripe_settings['apple_pay_domain_set'] = 'no';
201 201
 			$this->apple_pay_domain_set                    = false;
202 202
 
203
-			update_option( 'woocommerce_stripe_settings', $this->stripe_settings );
203
+			update_option('woocommerce_stripe_settings', $this->stripe_settings);
204 204
 
205
-			WC_Stripe_Logger::log( 'Error: ' . $e->getMessage() );
205
+			WC_Stripe_Logger::log('Error: ' . $e->getMessage());
206 206
 		}
207 207
 	}
208 208
 
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 	public function verify_domain_if_configured() {
217 217
 		$secret_key = $this->get_secret_key();
218 218
 
219
-		if ( ! $this->is_enabled() || empty( $secret_key ) ) {
219
+		if ( ! $this->is_enabled() || empty($secret_key)) {
220 220
 			return;
221 221
 		}
222 222
 
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 		flush_rewrite_rules();
225 225
 
226 226
 		// Register the domain with Apple Pay.
227
-		$this->register_domain_with_apple( $secret_key );
227
+		$this->register_domain_with_apple($secret_key);
228 228
 
229 229
 		// Show/hide notes if necessary.
230 230
 		WC_Stripe_Inbox_Notes::notify_on_apple_pay_domain_verification();
@@ -236,8 +236,8 @@  discard block
 block discarded – undo
236 236
 	 * @since 4.5.4
237 237
 	 * @version 4.5.4
238 238
 	 */
239
-	public function verify_domain_on_new_settings( $option, $settings ) {
240
-		$this->verify_domain_on_updated_settings( array(), $settings );
239
+	public function verify_domain_on_new_settings($option, $settings) {
240
+		$this->verify_domain_on_updated_settings(array(), $settings);
241 241
 	}
242 242
 
243 243
 	/**
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 	 * @since 4.5.3
247 247
 	 * @version 4.5.4
248 248
 	 */
249
-	public function verify_domain_on_updated_settings( $prev_settings, $settings ) {
249
+	public function verify_domain_on_updated_settings($prev_settings, $settings) {
250 250
 		// Grab previous state and then update cached settings.
251 251
 		$this->stripe_settings = $prev_settings;
252 252
 		$prev_secret_key       = $this->get_secret_key();
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 		$this->stripe_settings = $settings;
255 255
 
256 256
 		// If Stripe or Payment Request Button wasn't enabled (or secret key was different) then might need to verify now.
257
-		if ( ! $prev_is_enabled || ( $this->get_secret_key() !== $prev_secret_key ) ) {
257
+		if ( ! $prev_is_enabled || ($this->get_secret_key() !== $prev_secret_key)) {
258 258
 			$this->verify_domain_if_configured();
259 259
 		}
260 260
 	}
@@ -265,16 +265,16 @@  discard block
 block discarded – undo
265 265
 	 * @since 4.0.6
266 266
 	 */
267 267
 	public function admin_notices() {
268
-		if ( ! $this->is_enabled() ) {
268
+		if ( ! $this->is_enabled()) {
269 269
 			return;
270 270
 		}
271 271
 
272
-		if ( ! current_user_can( 'manage_woocommerce' ) ) {
272
+		if ( ! current_user_can('manage_woocommerce')) {
273 273
 			return;
274 274
 		}
275 275
 
276
-		$empty_notice = empty( $this->apple_pay_verify_notice );
277
-		if ( $empty_notice && ( $this->apple_pay_domain_set || empty( $this->secret_key ) ) ) {
276
+		$empty_notice = empty($this->apple_pay_verify_notice);
277
+		if ($empty_notice && ($this->apple_pay_domain_set || empty($this->secret_key))) {
278 278
 			return;
279 279
 		}
280 280
 
@@ -283,28 +283,28 @@  discard block
 block discarded – undo
283 283
 		 * when setting screen is displayed. So if domain verification is not set,
284 284
 		 * something went wrong so lets notify user.
285 285
 		 */
286
-		$allowed_html                      = array(
286
+		$allowed_html = array(
287 287
 			'a' => array(
288 288
 				'href'  => array(),
289 289
 				'title' => array(),
290 290
 			),
291 291
 		);
292
-		$verification_failed_without_error = __( 'Apple Pay domain verification failed.', 'woocommerce-gateway-stripe' );
293
-		$verification_failed_with_error    = __( 'Apple Pay domain verification failed with the following error:', 'woocommerce-gateway-stripe' );
292
+		$verification_failed_without_error = __('Apple Pay domain verification failed.', 'woocommerce-gateway-stripe');
293
+		$verification_failed_with_error    = __('Apple Pay domain verification failed with the following error:', 'woocommerce-gateway-stripe');
294 294
 		$check_log_text                    = sprintf(
295 295
 			/* translators: 1) HTML anchor open tag 2) HTML anchor closing tag */
296
-			esc_html__( 'Please check the %1$slogs%2$s for more details on this issue. Logging must be enabled to see recorded logs.', 'woocommerce-gateway-stripe' ),
297
-			'<a href="' . admin_url( 'admin.php?page=wc-status&tab=logs' ) . '">',
296
+			esc_html__('Please check the %1$slogs%2$s for more details on this issue. Logging must be enabled to see recorded logs.', 'woocommerce-gateway-stripe'),
297
+			'<a href="' . admin_url('admin.php?page=wc-status&tab=logs') . '">',
298 298
 			'</a>'
299 299
 		);
300 300
 
301 301
 		?>
302 302
 		<div class="error stripe-apple-pay-message">
303
-			<?php if ( $empty_notice ) : ?>
304
-				<p><?php echo esc_html( $verification_failed_without_error ); ?></p>
303
+			<?php if ($empty_notice) : ?>
304
+				<p><?php echo esc_html($verification_failed_without_error); ?></p>
305 305
 			<?php else : ?>
306
-				<p><?php echo esc_html( $verification_failed_with_error ); ?></p>
307
-				<p><i><?php echo wp_kses( make_clickable( esc_html( $this->apple_pay_verify_notice ) ), $allowed_html ); ?></i></p>
306
+				<p><?php echo esc_html($verification_failed_with_error); ?></p>
307
+				<p><i><?php echo wp_kses(make_clickable(esc_html($this->apple_pay_verify_notice)), $allowed_html); ?></i></p>
308 308
 			<?php endif; ?>
309 309
 			<p><?php echo $check_log_text; ?></p>
310 310
 		</div>
Please login to merge, or discard this patch.
includes/admin/class-wc-stripe-inbox-notes.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if ( ! defined( 'ABSPATH' ) ) {
2
+if ( ! defined('ABSPATH')) {
3 3
 	exit;
4 4
 }
5 5
 
@@ -16,47 +16,47 @@  discard block
 block discarded – undo
16 16
 	const FAILURE_NOTE_NAME = 'stripe-apple-pay-domain-verification-needed';
17 17
 
18 18
 	public static function notify_on_apple_pay_domain_verification() {
19
-		if ( ! class_exists( 'Automattic\WooCommerce\Admin\Notes\WC_Admin_Notes' ) ) {
19
+		if ( ! class_exists('Automattic\WooCommerce\Admin\Notes\WC_Admin_Notes')) {
20 20
 			return;
21 21
 		}
22 22
 
23
-		if ( ! class_exists( 'WC_Data_Store' ) ) {
23
+		if ( ! class_exists('WC_Data_Store')) {
24 24
 			return;
25 25
 		}
26 26
 
27
-		$stripe_settings       = get_option( 'woocommerce_stripe_settings', array() );
27
+		$stripe_settings       = get_option('woocommerce_stripe_settings', array());
28 28
 		$domain_flag_key       = 'apple_pay_domain_set';
29
-		$verification_complete = isset( $stripe_settings[ $domain_flag_key ] ) && 'yes' === $stripe_settings[ $domain_flag_key ];
29
+		$verification_complete = isset($stripe_settings[$domain_flag_key]) && 'yes' === $stripe_settings[$domain_flag_key];
30 30
 
31
-		$data_store = WC_Data_Store::load( 'admin-note' );
31
+		$data_store = WC_Data_Store::load('admin-note');
32 32
 
33
-		$success_note_ids = $data_store->get_notes_with_name( self::SUCCESS_NOTE_NAME );
34
-		$failure_note_ids = $data_store->get_notes_with_name( self::FAILURE_NOTE_NAME );
33
+		$success_note_ids = $data_store->get_notes_with_name(self::SUCCESS_NOTE_NAME);
34
+		$failure_note_ids = $data_store->get_notes_with_name(self::FAILURE_NOTE_NAME);
35 35
 
36
-		if ( $verification_complete ) {
36
+		if ($verification_complete) {
37 37
 			// Display success note to US merchants only.
38 38
 			$base_location = wc_get_base_location();
39
-			if ( is_array( $base_location ) && 'US' === $base_location['country'] ) {
40
-				if ( empty( $success_note_ids ) ) {
39
+			if (is_array($base_location) && 'US' === $base_location['country']) {
40
+				if (empty($success_note_ids)) {
41 41
 					self::create_success_note();
42 42
 				}
43 43
 			}
44 44
 
45
-			if ( ! empty( $failure_note_ids ) ) {
46
-				$note_id = array_pop( $failure_note_ids );
47
-				$note    = WC_Admin_Notes::get_note( $note_id );
48
-				if ( false === $note ) {
45
+			if ( ! empty($failure_note_ids)) {
46
+				$note_id = array_pop($failure_note_ids);
47
+				$note    = WC_Admin_Notes::get_note($note_id);
48
+				if (false === $note) {
49 49
 					return;
50 50
 				}
51 51
 
52 52
 				// If the domain verification completed after failure note was created, make sure it's marked as actioned.
53
-				if ( WC_Admin_Note::E_WC_ADMIN_NOTE_ACTIONED !== $note->get_status() ) {
54
-					$note->set_status( WC_Admin_Note::E_WC_ADMIN_NOTE_ACTIONED );
53
+				if (WC_Admin_Note::E_WC_ADMIN_NOTE_ACTIONED !== $note->get_status()) {
54
+					$note->set_status(WC_Admin_Note::E_WC_ADMIN_NOTE_ACTIONED);
55 55
 					$note->save();
56 56
 				}
57 57
 			}
58 58
 		} else {
59
-			if ( empty( $failure_note_ids ) ) {
59
+			if (empty($failure_note_ids)) {
60 60
 				self::create_failure_note();
61 61
 			}
62 62
 		}
@@ -64,14 +64,14 @@  discard block
 block discarded – undo
64 64
 
65 65
 	public static function create_success_note() {
66 66
 		$note = new WC_Admin_Note();
67
-		$note->set_title( __( 'Boost sales this holiday season with Apple Pay!', 'woocommerce-gateway-stripe' ) );
68
-		$note->set_content( __( 'Now that you accept Apple Pay® with Stripe, you can increase conversion rates by letting your customers know that Apple Pay is available. Here’s a marketing guide to help you get started.', 'woocommerce-gateway-stripe' ) );
69
-		$note->set_type( WC_Admin_Note::E_WC_ADMIN_NOTE_MARKETING );
70
-		$note->set_name( self::SUCCESS_NOTE_NAME );
71
-		$note->set_source( 'woocommerce-gateway-stripe' );
67
+		$note->set_title(__('Boost sales this holiday season with Apple Pay!', 'woocommerce-gateway-stripe'));
68
+		$note->set_content(__('Now that you accept Apple Pay® with Stripe, you can increase conversion rates by letting your customers know that Apple Pay is available. Here’s a marketing guide to help you get started.', 'woocommerce-gateway-stripe'));
69
+		$note->set_type(WC_Admin_Note::E_WC_ADMIN_NOTE_MARKETING);
70
+		$note->set_name(self::SUCCESS_NOTE_NAME);
71
+		$note->set_source('woocommerce-gateway-stripe');
72 72
 		$note->add_action(
73 73
 			'marketing-guide',
74
-			__( 'See marketing guide', 'woocommerce-gateway-stripe' ),
74
+			__('See marketing guide', 'woocommerce-gateway-stripe'),
75 75
 			'https://developer.apple.com/apple-pay/marketing/'
76 76
 		);
77 77
 		$note->save();
@@ -79,14 +79,14 @@  discard block
 block discarded – undo
79 79
 
80 80
 	public static function create_failure_note() {
81 81
 		$note = new WC_Admin_Note();
82
-		$note->set_title( __( 'Apple Pay domain verification needed', 'woocommerce-gateway-stripe' ) );
83
-		$note->set_content( __( 'The WooCommerce Stripe Gateway extension attempted to perform domain verification on behalf of your store, but was unable to do so. This must be resolved before Apple Pay can be offered to your customers.', 'woocommerce-gateway-stripe' ) );
84
-		$note->set_type( WC_Admin_Note::E_WC_ADMIN_NOTE_INFORMATIONAL );
85
-		$note->set_name( self::FAILURE_NOTE_NAME );
86
-		$note->set_source( 'woocommerce-gateway-stripe' );
82
+		$note->set_title(__('Apple Pay domain verification needed', 'woocommerce-gateway-stripe'));
83
+		$note->set_content(__('The WooCommerce Stripe Gateway extension attempted to perform domain verification on behalf of your store, but was unable to do so. This must be resolved before Apple Pay can be offered to your customers.', 'woocommerce-gateway-stripe'));
84
+		$note->set_type(WC_Admin_Note::E_WC_ADMIN_NOTE_INFORMATIONAL);
85
+		$note->set_name(self::FAILURE_NOTE_NAME);
86
+		$note->set_source('woocommerce-gateway-stripe');
87 87
 		$note->add_action(
88 88
 			'learn-more',
89
-			__( 'Learn more', 'woocommerce-gateway-stripe' ),
89
+			__('Learn more', 'woocommerce-gateway-stripe'),
90 90
 			'https://docs.woocommerce.com/document/stripe/#apple-pay'
91 91
 		);
92 92
 		$note->save();
Please login to merge, or discard this patch.