Inspection of "Add tests" - woocommerce/woocommerce-gateway-stripe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8d4fd8...e2f88d )

by Roy

created 2018-02-03 06:35 UTC

Status

Spacing +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -2,12 +2,12 @@  discard block
 block discarded – undo
 
 class WC_Stripe_Test extends WP_UnitTestCase {
 	public function test_constants_defined() {
-		$this->assertTrue( defined( 'WC_STRIPE_VERSION' ) );
-		$this->assertTrue( defined( 'WC_STRIPE_MIN_PHP_VER' ) );
-		$this->assertTrue( defined( 'WC_STRIPE_MIN_WC_VER' ) );
-		$this->assertTrue( defined( 'WC_STRIPE_MAIN_FILE' ) );
-		$this->assertTrue( defined( 'WC_STRIPE_PLUGIN_URL' ) );
-		$this->assertTrue( defined( 'WC_STRIPE_PLUGIN_PATH' ) );
+		$this->assertTrue(defined('WC_STRIPE_VERSION'));
+		$this->assertTrue(defined('WC_STRIPE_MIN_PHP_VER'));
+		$this->assertTrue(defined('WC_STRIPE_MIN_WC_VER'));
+		$this->assertTrue(defined('WC_STRIPE_MAIN_FILE'));
+		$this->assertTrue(defined('WC_STRIPE_PLUGIN_URL'));
+		$this->assertTrue(defined('WC_STRIPE_PLUGIN_PATH'));
 	}
 
 	/**
@@ -15,11 +15,11 @@  discard block
 block discarded – undo
 	 * This test will see if we're indeed converting the price correctly.
 	 */
 	public function test_price_conversion_before_send_to_stripe() {
-		$this->assertEquals( 10050, WC_Stripe_Helper::get_stripe_amount( 100.50, 'USD' ) );
-		$this->assertEquals( 10050, WC_Stripe_Helper::get_stripe_amount( 10050, 'JPY' ) );
-		$this->assertEquals( 100, WC_Stripe_Helper::get_stripe_amount( 100.50, 'JPY' ) );
-		$this->assertEquals( 10050, WC_Stripe_Helper::get_stripe_amount( 100.50 ) );
-		$this->assertInternalType( 'int', WC_Stripe_Helper::get_stripe_amount( 100.50, 'USD' ) );
+		$this->assertEquals(10050, WC_Stripe_Helper::get_stripe_amount(100.50, 'USD'));
+		$this->assertEquals(10050, WC_Stripe_Helper::get_stripe_amount(10050, 'JPY'));
+		$this->assertEquals(100, WC_Stripe_Helper::get_stripe_amount(100.50, 'JPY'));
+		$this->assertEquals(10050, WC_Stripe_Helper::get_stripe_amount(100.50));
+		$this->assertInternalType('int', WC_Stripe_Helper::get_stripe_amount(100.50, 'USD'));
 	}
 
 	/**
@@ -33,37 +33,37 @@  discard block
 block discarded – undo
 		$balance_fee1->net = 10000;
 		$balance_fee1->currency = 'USD';
 
-		$this->assertEquals( 105.00, WC_Stripe_Helper::format_balance_fee( $balance_fee1, 'fee' ) );
+		$this->assertEquals(105.00, WC_Stripe_Helper::format_balance_fee($balance_fee1, 'fee'));
 
 		$balance_fee2 = new stdClass();
 		$balance_fee2->fee = 10500;
 		$balance_fee2->net = 10000;
 		$balance_fee2->currency = 'JPY';
 
-		$this->assertEquals( 10500, WC_Stripe_Helper::format_balance_fee( $balance_fee2, 'fee' ) );
+		$this->assertEquals(10500, WC_Stripe_Helper::format_balance_fee($balance_fee2, 'fee'));
 
 		$balance_fee3 = new stdClass();
 		$balance_fee3->fee = 10500;
 		$balance_fee3->net = 10000;
 		$balance_fee3->currency = 'USD';
 
-		$this->assertEquals( 100.00, WC_Stripe_Helper::format_balance_fee( $balance_fee3, 'net' ) );
+		$this->assertEquals(100.00, WC_Stripe_Helper::format_balance_fee($balance_fee3, 'net'));
 
 		$balance_fee4 = new stdClass();
 		$balance_fee4->fee = 10500;
 		$balance_fee4->net = 10000;
 		$balance_fee4->currency = 'JPY';
 
-		$this->assertEquals( 10000, WC_Stripe_Helper::format_balance_fee( $balance_fee4, 'net' ) );
+		$this->assertEquals(10000, WC_Stripe_Helper::format_balance_fee($balance_fee4, 'net'));
 
 		$balance_fee5 = new stdClass();
 		$balance_fee5->fee = 10500;
 		$balance_fee5->net = 10000;
 		$balance_fee5->currency = 'USD';
 
-		$this->assertEquals( 105.00, WC_Stripe_Helper::format_balance_fee( $balance_fee5 ) );
+		$this->assertEquals(105.00, WC_Stripe_Helper::format_balance_fee($balance_fee5));
 
-		$this->assertInternalType( 'string', WC_Stripe_Helper::format_balance_fee( $balance_fee5 ) );
+		$this->assertInternalType('string', WC_Stripe_Helper::format_balance_fee($balance_fee5));
 	}
 
 	/**
@@ -76,28 +76,28 @@  discard block
 block discarded – undo
 			'expected' => 'Tests Store',
 		);
 
-		$this->assertEquals( $statement_descriptor1['expected'], WC_Stripe_Helper::clean_statement_descriptor( $statement_descriptor1['actual'] ) );
+		$this->assertEquals($statement_descriptor1['expected'], WC_Stripe_Helper::clean_statement_descriptor($statement_descriptor1['actual']));
 
 		$statement_descriptor2 = array(
 			'actual'   => 'Test\'s Store > Driving Course Range',
 			'expected' => 'Tests Store  Driving C',
 		);
 
-		$this->assertEquals( $statement_descriptor2['expected'], WC_Stripe_Helper::clean_statement_descriptor( $statement_descriptor2['actual'] ) );
+		$this->assertEquals($statement_descriptor2['expected'], WC_Stripe_Helper::clean_statement_descriptor($statement_descriptor2['actual']));
 
 		$statement_descriptor3 = array(
 			'actual'   => 'Test\'s Store < Driving Course Range',
 			'expected' => 'Tests Store  Driving C',
 		);
 
-		$this->assertEquals( $statement_descriptor3['expected'], WC_Stripe_Helper::clean_statement_descriptor( $statement_descriptor3['actual'] ) );
+		$this->assertEquals($statement_descriptor3['expected'], WC_Stripe_Helper::clean_statement_descriptor($statement_descriptor3['actual']));
 
 		$statement_descriptor4 = array(
 			'actual'   => 'Test\'s Store " Driving Course Range',
 			'expected' => 'Tests Store  Driving C',
 		);
 
-		$this->assertEquals( $statement_descriptor4['expected'], WC_Stripe_Helper::clean_statement_descriptor( $statement_descriptor4['actual'] ) );
+		$this->assertEquals($statement_descriptor4['expected'], WC_Stripe_Helper::clean_statement_descriptor($statement_descriptor4['actual']));
 	}
 
 	/**
@@ -109,12 +109,12 @@  discard block
 block discarded – undo
 		$source = new stdClass();
 		$source->type = 'three_d_secure';
 
-		$this->assertEquals( true, $stripe->is_3ds_card( $source ) );
+		$this->assertEquals(true, $stripe->is_3ds_card($source));
 
 		$source = new stdClass();
 		$source->type = 'card';
 
-		$this->assertEquals( false, $stripe->is_3ds_card( $source ) );
+		$this->assertEquals(false, $stripe->is_3ds_card($source));
 	}
 
 	/**
@@ -128,20 +128,20 @@  discard block
 block discarded – undo
 		$source->card = new stdClass();
 		$source->card->three_d_secure = 'required';
 
-		$this->assertEquals( true, $stripe->is_3ds_required( $source ) );
+		$this->assertEquals(true, $stripe->is_3ds_required($source));
 
 		$source = new stdClass();
 		$source->type = 'card';
 		$source->card = new stdClass();
 		$source->card->three_d_secure = 'optional';
 
-		$this->assertEquals( false, $stripe->is_3ds_required( $source ) );
+		$this->assertEquals(false, $stripe->is_3ds_required($source));
 
 		$source = new stdClass();
 		$source->type = 'card';
 		$source->card = new stdClass();
 		$source->card->three_d_secure = 'not_supported';
 
-		$this->assertEquals( false, $stripe->is_3ds_required( $source ) );
+		$this->assertEquals(false, $stripe->is_3ds_required($source));
 	}
 }

Please login to merge, or discard this patch.

tests/phpunit/bootstrap.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -1,28 +1,28 @@
 block discarded – undo
 <?php
 
-$_tests_dir = getenv( 'WP_TESTS_DIR' );
-if ( ! $_tests_dir ) {
+$_tests_dir = getenv('WP_TESTS_DIR');
+if ( ! $_tests_dir) {
 	$_tests_dir = '/tmp/wordpress-tests-lib';
 }
 
 require_once $_tests_dir . '/includes/functions.php';
 
 function _manually_load_plugin() {
-	$plugin_dir = dirname( dirname( dirname( dirname( __FILE__ ) ) ) ) . '/';
+	$plugin_dir = dirname(dirname(dirname(dirname(__FILE__)))) . '/';
 	require $plugin_dir . 'woocommerce-gateway-stripe/woocommerce-gateway-stripe.php';
 	require $plugin_dir . 'woocommerce/woocommerce.php';
 }
 
-tests_add_filter( 'muplugins_loaded', '_manually_load_plugin' );
+tests_add_filter('muplugins_loaded', '_manually_load_plugin');
 
 require $_tests_dir . '/includes/bootstrap.php';
 
-$wc_tests_framework_base_dir = dirname( dirname( dirname( dirname( __FILE__ ) ) ) ) . '/woocommerce/tests/framework/';
-require_once( $wc_tests_framework_base_dir . 'class-wc-mock-session-handler.php' );
-require_once( $wc_tests_framework_base_dir . 'class-wc-unit-test-case.php' );
-require_once( $wc_tests_framework_base_dir . 'helpers/class-wc-helper-product.php' );
-require_once( $wc_tests_framework_base_dir . 'helpers/class-wc-helper-coupon.php' );
-require_once( $wc_tests_framework_base_dir . 'helpers/class-wc-helper-fee.php' );
-require_once( $wc_tests_framework_base_dir . 'helpers/class-wc-helper-shipping.php' );
-require_once( $wc_tests_framework_base_dir . 'helpers/class-wc-helper-customer.php' );
-require_once( $wc_tests_framework_base_dir . 'helpers/class-wc-helper-order.php' );
+$wc_tests_framework_base_dir = dirname(dirname(dirname(dirname(__FILE__)))) . '/woocommerce/tests/framework/';
+require_once($wc_tests_framework_base_dir . 'class-wc-mock-session-handler.php');
+require_once($wc_tests_framework_base_dir . 'class-wc-unit-test-case.php');
+require_once($wc_tests_framework_base_dir . 'helpers/class-wc-helper-product.php');
+require_once($wc_tests_framework_base_dir . 'helpers/class-wc-helper-coupon.php');
+require_once($wc_tests_framework_base_dir . 'helpers/class-wc-helper-fee.php');
+require_once($wc_tests_framework_base_dir . 'helpers/class-wc-helper-shipping.php');
+require_once($wc_tests_framework_base_dir . 'helpers/class-wc-helper-customer.php');
+require_once($wc_tests_framework_base_dir . 'helpers/class-wc-helper-order.php');

Please login to merge, or discard this patch.

		@@ -2,12 +2,12 @@ discard block
		block discarded – undo
2	2
3	3	class WC_Stripe_Test extends WP_UnitTestCase {
4	4	public function test_constants_defined() {
5		- $this->assertTrue( defined( 'WC_STRIPE_VERSION' ) );
6		- $this->assertTrue( defined( 'WC_STRIPE_MIN_PHP_VER' ) );
7		- $this->assertTrue( defined( 'WC_STRIPE_MIN_WC_VER' ) );
8		- $this->assertTrue( defined( 'WC_STRIPE_MAIN_FILE' ) );
9		- $this->assertTrue( defined( 'WC_STRIPE_PLUGIN_URL' ) );
10		- $this->assertTrue( defined( 'WC_STRIPE_PLUGIN_PATH' ) );
	5	+ $this->assertTrue(defined('WC_STRIPE_VERSION'));
	6	+ $this->assertTrue(defined('WC_STRIPE_MIN_PHP_VER'));
	7	+ $this->assertTrue(defined('WC_STRIPE_MIN_WC_VER'));
	8	+ $this->assertTrue(defined('WC_STRIPE_MAIN_FILE'));
	9	+ $this->assertTrue(defined('WC_STRIPE_PLUGIN_URL'));
	10	+ $this->assertTrue(defined('WC_STRIPE_PLUGIN_PATH'));
11	11	}
12	12
13	13	/**
		@@ -15,11 +15,11 @@ discard block
		block discarded – undo
15	15	* This test will see if we're indeed converting the price correctly.
16	16	*/
17	17	public function test_price_conversion_before_send_to_stripe() {
18		- $this->assertEquals( 10050, WC_Stripe_Helper::get_stripe_amount( 100.50, 'USD' ) );
19		- $this->assertEquals( 10050, WC_Stripe_Helper::get_stripe_amount( 10050, 'JPY' ) );
20		- $this->assertEquals( 100, WC_Stripe_Helper::get_stripe_amount( 100.50, 'JPY' ) );
21		- $this->assertEquals( 10050, WC_Stripe_Helper::get_stripe_amount( 100.50 ) );
22		- $this->assertInternalType( 'int', WC_Stripe_Helper::get_stripe_amount( 100.50, 'USD' ) );
	18	+ $this->assertEquals(10050, WC_Stripe_Helper::get_stripe_amount(100.50, 'USD'));
	19	+ $this->assertEquals(10050, WC_Stripe_Helper::get_stripe_amount(10050, 'JPY'));
	20	+ $this->assertEquals(100, WC_Stripe_Helper::get_stripe_amount(100.50, 'JPY'));
	21	+ $this->assertEquals(10050, WC_Stripe_Helper::get_stripe_amount(100.50));
	22	+ $this->assertInternalType('int', WC_Stripe_Helper::get_stripe_amount(100.50, 'USD'));
23	23	}
24	24
25	25	/**
		@@ -33,37 +33,37 @@ discard block
		block discarded – undo
33	33	$balance_fee1->net = 10000;
34	34	$balance_fee1->currency = 'USD';
35	35
36		- $this->assertEquals( 105.00, WC_Stripe_Helper::format_balance_fee( $balance_fee1, 'fee' ) );
	36	+ $this->assertEquals(105.00, WC_Stripe_Helper::format_balance_fee($balance_fee1, 'fee'));
37	37
38	38	$balance_fee2 = new stdClass();
39	39	$balance_fee2->fee = 10500;
40	40	$balance_fee2->net = 10000;
41	41	$balance_fee2->currency = 'JPY';
42	42
43		- $this->assertEquals( 10500, WC_Stripe_Helper::format_balance_fee( $balance_fee2, 'fee' ) );
	43	+ $this->assertEquals(10500, WC_Stripe_Helper::format_balance_fee($balance_fee2, 'fee'));
44	44
45	45	$balance_fee3 = new stdClass();
46	46	$balance_fee3->fee = 10500;
47	47	$balance_fee3->net = 10000;
48	48	$balance_fee3->currency = 'USD';
49	49
50		- $this->assertEquals( 100.00, WC_Stripe_Helper::format_balance_fee( $balance_fee3, 'net' ) );
	50	+ $this->assertEquals(100.00, WC_Stripe_Helper::format_balance_fee($balance_fee3, 'net'));
51	51
52	52	$balance_fee4 = new stdClass();
53	53	$balance_fee4->fee = 10500;
54	54	$balance_fee4->net = 10000;
55	55	$balance_fee4->currency = 'JPY';
56	56
57		- $this->assertEquals( 10000, WC_Stripe_Helper::format_balance_fee( $balance_fee4, 'net' ) );
	57	+ $this->assertEquals(10000, WC_Stripe_Helper::format_balance_fee($balance_fee4, 'net'));
58	58
59	59	$balance_fee5 = new stdClass();
60	60	$balance_fee5->fee = 10500;
61	61	$balance_fee5->net = 10000;
62	62	$balance_fee5->currency = 'USD';
63	63
64		- $this->assertEquals( 105.00, WC_Stripe_Helper::format_balance_fee( $balance_fee5 ) );
	64	+ $this->assertEquals(105.00, WC_Stripe_Helper::format_balance_fee($balance_fee5));
65	65
66		- $this->assertInternalType( 'string', WC_Stripe_Helper::format_balance_fee( $balance_fee5 ) );
	66	+ $this->assertInternalType('string', WC_Stripe_Helper::format_balance_fee($balance_fee5));
67	67	}
68	68
69	69	/**
		@@ -76,28 +76,28 @@ discard block
		block discarded – undo
76	76	'expected' => 'Tests Store',
77	77	);
78	78
79		- $this->assertEquals( $statement_descriptor1['expected'], WC_Stripe_Helper::clean_statement_descriptor( $statement_descriptor1['actual'] ) );
	79	+ $this->assertEquals($statement_descriptor1['expected'], WC_Stripe_Helper::clean_statement_descriptor($statement_descriptor1['actual']));
80	80
81	81	$statement_descriptor2 = array(
82	82	'actual' => 'Test\'s Store > Driving Course Range',
83	83	'expected' => 'Tests Store Driving C',
84	84	);
85	85
86		- $this->assertEquals( $statement_descriptor2['expected'], WC_Stripe_Helper::clean_statement_descriptor( $statement_descriptor2['actual'] ) );
	86	+ $this->assertEquals($statement_descriptor2['expected'], WC_Stripe_Helper::clean_statement_descriptor($statement_descriptor2['actual']));
87	87
88	88	$statement_descriptor3 = array(
89	89	'actual' => 'Test\'s Store < Driving Course Range',
90	90	'expected' => 'Tests Store Driving C',
91	91	);
92	92
93		- $this->assertEquals( $statement_descriptor3['expected'], WC_Stripe_Helper::clean_statement_descriptor( $statement_descriptor3['actual'] ) );
	93	+ $this->assertEquals($statement_descriptor3['expected'], WC_Stripe_Helper::clean_statement_descriptor($statement_descriptor3['actual']));
94	94
95	95	$statement_descriptor4 = array(
96	96	'actual' => 'Test\'s Store " Driving Course Range',
97	97	'expected' => 'Tests Store Driving C',
98	98	);
99	99
100		- $this->assertEquals( $statement_descriptor4['expected'], WC_Stripe_Helper::clean_statement_descriptor( $statement_descriptor4['actual'] ) );
	100	+ $this->assertEquals($statement_descriptor4['expected'], WC_Stripe_Helper::clean_statement_descriptor($statement_descriptor4['actual']));
101	101	}
102	102
103	103	/**
		@@ -109,12 +109,12 @@ discard block
		block discarded – undo
109	109	$source = new stdClass();
110	110	$source->type = 'three_d_secure';
111	111
112		- $this->assertEquals( true, $stripe->is_3ds_card( $source ) );
	112	+ $this->assertEquals(true, $stripe->is_3ds_card($source));
113	113
114	114	$source = new stdClass();
115	115	$source->type = 'card';
116	116
117		- $this->assertEquals( false, $stripe->is_3ds_card( $source ) );
	117	+ $this->assertEquals(false, $stripe->is_3ds_card($source));
118	118	}
119	119
120	120	/**
		@@ -128,20 +128,20 @@ discard block
		block discarded – undo
128	128	$source->card = new stdClass();
129	129	$source->card->three_d_secure = 'required';
130	130
131		- $this->assertEquals( true, $stripe->is_3ds_required( $source ) );
	131	+ $this->assertEquals(true, $stripe->is_3ds_required($source));
132	132
133	133	$source = new stdClass();
134	134	$source->type = 'card';
135	135	$source->card = new stdClass();
136	136	$source->card->three_d_secure = 'optional';
137	137
138		- $this->assertEquals( false, $stripe->is_3ds_required( $source ) );
	138	+ $this->assertEquals(false, $stripe->is_3ds_required($source));
139	139
140	140	$source = new stdClass();
141	141	$source->type = 'card';
142	142	$source->card = new stdClass();
143	143	$source->card->three_d_secure = 'not_supported';
144	144
145		- $this->assertEquals( false, $stripe->is_3ds_required( $source ) );
	145	+ $this->assertEquals(false, $stripe->is_3ds_required($source));
146	146	}
147	147	}

		@@ -1,28 +1,28 @@
		block discarded – undo
1	1	<?php
2	2
3		-$_tests_dir = getenv( 'WP_TESTS_DIR' );
4		-if ( ! $_tests_dir ) {
	3	+$_tests_dir = getenv('WP_TESTS_DIR');
	4	+if ( ! $_tests_dir) {
5	5	$_tests_dir = '/tmp/wordpress-tests-lib';
6	6	}
7	7
8	8	require_once $_tests_dir . '/includes/functions.php';
9	9
10	10	function _manually_load_plugin() {
11		- $plugin_dir = dirname( dirname( dirname( dirname( __FILE__ ) ) ) ) . '/';
	11	+ $plugin_dir = dirname(dirname(dirname(dirname(__FILE__)))) . '/';
12	12	require $plugin_dir . 'woocommerce-gateway-stripe/woocommerce-gateway-stripe.php';
13	13	require $plugin_dir . 'woocommerce/woocommerce.php';
14	14	}
15	15
16		-tests_add_filter( 'muplugins_loaded', '_manually_load_plugin' );
	16	+tests_add_filter('muplugins_loaded', '_manually_load_plugin');
17	17
18	18	require $_tests_dir . '/includes/bootstrap.php';
19	19
20		-$wc_tests_framework_base_dir = dirname( dirname( dirname( dirname( __FILE__ ) ) ) ) . '/woocommerce/tests/framework/';
21		-require_once( $wc_tests_framework_base_dir . 'class-wc-mock-session-handler.php' );
22		-require_once( $wc_tests_framework_base_dir . 'class-wc-unit-test-case.php' );
23		-require_once( $wc_tests_framework_base_dir . 'helpers/class-wc-helper-product.php' );
24		-require_once( $wc_tests_framework_base_dir . 'helpers/class-wc-helper-coupon.php' );
25		-require_once( $wc_tests_framework_base_dir . 'helpers/class-wc-helper-fee.php' );
26		-require_once( $wc_tests_framework_base_dir . 'helpers/class-wc-helper-shipping.php' );
27		-require_once( $wc_tests_framework_base_dir . 'helpers/class-wc-helper-customer.php' );
28		-require_once( $wc_tests_framework_base_dir . 'helpers/class-wc-helper-order.php' );
	20	+$wc_tests_framework_base_dir = dirname(dirname(dirname(dirname(__FILE__)))) . '/woocommerce/tests/framework/';
	21	+require_once($wc_tests_framework_base_dir . 'class-wc-mock-session-handler.php');
	22	+require_once($wc_tests_framework_base_dir . 'class-wc-unit-test-case.php');
	23	+require_once($wc_tests_framework_base_dir . 'helpers/class-wc-helper-product.php');
	24	+require_once($wc_tests_framework_base_dir . 'helpers/class-wc-helper-coupon.php');
	25	+require_once($wc_tests_framework_base_dir . 'helpers/class-wc-helper-fee.php');
	26	+require_once($wc_tests_framework_base_dir . 'helpers/class-wc-helper-shipping.php');
	27	+require_once($wc_tests_framework_base_dir . 'helpers/class-wc-helper-customer.php');
	28	+require_once($wc_tests_framework_base_dir . 'helpers/class-wc-helper-order.php');

woocommerce / woocommerce-gateway-stripe

Push — master ( 8d4fd8...e2f88d )

Status

Category

Spacing +26 added lines, -26 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch