View GitHub Repository banner-server

Schedule Inspection
Subscribe
Completed
Pull Request — master (#19)
by Tim
03:25
created

139 +96 Covered Lines

141 +8 Total Lines

98.6 % +66.3% Code Coverage

PHP Classes Changes

 
 ⇢
0%
SystemRandomIntegerGenerator added
 
 ⇢
100%
ImpressionThreshold added
 
 ⇢
100%
EmptyBannerSelectionData added
 
 ⇢
100%
ActiveBannerSelectionData added
0%
 ↗
100%
 BannerSelectionController improved
0%
 ↗
100%
 Visitor improved
0%
 ↗
100%
 BannerSelectionUseCase improved
88.89%
 ↗
100%
 Campaign improved
0%
 ↛
 
 TrafficImpressionThreshold removed
0%
 ↛
 
 BannerSelection removed

CRAP Changes

 
 ⇢
5
BannerSelectionUseCase::selectBanner() added
 
 ⇢
2
BannerSelectionUseCase::getCurrentCampaign() added
 
 ⇢
2
SystemRandomIntegerGenerator::getRandomInteger() added
 
 ⇢
1
BannerSelectionUseCase::isRatioLimited() added
 
 ⇢
1
EmptyBannerSelectionData::__construct() added
 
 ⇢
1
EmptyBannerSelectionData::displayBanner() added
 
 ⇢
1
EmptyBannerSelectionData::getVisitorData() added
 
 ⇢
1
EmptyBannerSelectionData::getBannerIdentifier() added
 
 ⇢
1
EmptyBannerSelectionData::getCampaignEnd() added
 
 ⇢
1
ActiveBannerSelectionData::getCampaignEnd() added
⋮ view more  
2
 ↘
1
 Visitor::getTotalImpressionCount() improved
2
 ↘
1
 Visitor::getBucketIdentifier() improved
2
 ↘
1
 Visitor::__construct() improved
2
 ↘
1
 BannerSelectionController::__construct() improved
2
 ↘
1
 BannerSelectionController::buildValuesFromRequest(... improved
2
 ↘
1
 BannerSelectionUseCase::__construct() improved
2
 ↘
1
 Visitor::hasDonated() improved
6
 ↘
3
 BannerSelectionController::selectBanner() improved
6
 ↛
 
 TrafficImpressionThreshold::getIsOverThreshold() removed
6
 ↛
 
 BannerSelectionUseCase::provideBannerRequest() removed
2
 ↛
 
 BannerSelection::getCampaignEnd() removed
2
 ↛
 
 BannerSelection::__construct() removed
2
 ↛
 
 BannerSelection::getVisitorData() removed
2
 ↛
 
 BannerSelection::displayBanner() removed
2
 ↛
 
 BannerSelection::createEmptySelection() removed
2
 ↛
 
 BannerSelection::createBannerSelection() removed
2
 ↛
 
 BannerSelection::getBannerIdentifier() removed
2
 ↛
 
 Campaign::getCampaignExpiration() removed
⋮ view more